[{"id":1761912,"web_url":"http://patchwork.ozlabs.org/comment/1761912/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA96A5@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-01T18:39:43","subject":"Re: [Intel-wired-lan] [next PATCH S79-V2 12/13] i40evf: enable\n\tsupport\tfor VF VLAN tag stripping control","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Alice Michael\n> Sent: Tuesday, August 29, 2017 2:33 AM\n> To: Michael, Alice ; intel-wired-\n> lan@lists.osuosl.org\n> Subject: [Intel-wired-lan] [next PATCH S79-V2 12/13] i40evf: enable support\n> for VF VLAN tag stripping control\n> \n> From: Jacob Keller \n> \n> A recent commit 809481484e5d (\"i40e/i40evf: support for VF VLAN tag\n> stripping control\") added support for VFs to negotiate the control of VLAN\n> tag stripping. This should have allowed VFs to disable the feature.\n> Unfortunately, the flag was set only in netdev->feature flags and not in\n> netdev->hw_features.\n> \n> This ultimately causes the stack to assume that it cannot change the flag, so it\n> was unchangeable and marked as [fixed] in the ethtool -k output.\n> \n> Fix this by setting the feature in hw_features first, just as we do for the PF\n> code. This enables ethtool -K to disable the feature correctly, and fully\n> enables user control of the VLAN tag stripping feature.\n> \n> Signed-off-by: Jacob Keller \n> ---\n> drivers/net/ethernet/intel/i40evf/i40evf_main.c | 22 ++++++++++++++-----\n> ---\n> 1 file changed, 14 insertions(+), 8 deletions(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkShk0WzMz9sPm\n\tfor ;\n\tSat, 2 Sep 2017 04:39:49 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1DCC782291;\n\tFri, 1 Sep 2017 18:39:48 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zHuDgNAV6h6u; Fri, 1 Sep 2017 18:39:46 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D2CEF821B1;\n\tFri, 1 Sep 2017 18:39:46 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E60581C40B6\n\tfor ;\n\tFri, 1 Sep 2017 18:39:45 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D78C58A2BF\n\tfor ;\n\tFri, 1 Sep 2017 18:39:45 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LsVoAs1uHeKg for ;\n\tFri, 1 Sep 2017 18:39:45 +0000 (UTC)","from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 096E28A288\n\tfor ;\n\tFri, 1 Sep 2017 18:39:45 +0000 (UTC)","from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Sep 2017 11:39:44 -0700","from orsmsx109.amr.corp.intel.com ([10.22.240.7])\n\tby orsmga004.jf.intel.com with ESMTP; 01 Sep 2017 11:39:44 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX109.amr.corp.intel.com ([169.254.11.118]) with mapi id\n\t14.03.0319.002; Fri, 1 Sep 2017 11:39:43 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,459,1498546800\"; d=\"scan'208\";a=\"124776006\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [next PATCH S79-V2 12/13] i40evf: enable\n\tsupport\tfor VF VLAN tag stripping control","Thread-Index":"AQHTIO2KQotloDZiDU65nTuzBf5fzaKgYWag","Date":"Fri, 1 Sep 2017 18:39:43 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA96A5@ORSMSX104.amr.corp.intel.com>","References":"<20170829093242.41026-1-alice.michael@intel.com>\n\t<20170829093242.41026-12-alice.michael@intel.com>","In-Reply-To":"<20170829093242.41026-12-alice.michael@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODIxY2Q0MjktZmY0ZS00MTA1LTg3ZjEtMmE2NTRmZWVlMDEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNIbGxESDV2eTJtS21kUHloSEJRd2ZsVUZNREJUcllhXC81R251Vkx5XC9MST0ifQ==","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.139]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [next PATCH S79-V2 12/13] i40evf: enable\n\tsupport\tfor VF VLAN tag stripping control","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]