[{"id":1763567,"web_url":"http://patchwork.ozlabs.org/comment/1763567/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9943@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-05T18:45:48","subject":"Re: [Intel-wired-lan] [next PATCH S79-V2 09/13] i40e: Properly\n\tmaintain\tflow director filters list","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Alice Michael\n> Sent: Tuesday, August 29, 2017 2:33 AM\n> To: Michael, Alice ; intel-wired-\n> lan@lists.osuosl.org\n> Cc: Sadowski, Filip \n> Subject: [Intel-wired-lan] [next PATCH S79-V2 09/13] i40e: Properly maintain\n> flow director filters list\n> \n> From: Filip Sadowski \n> \n> When there is no space for more flow director filters and user requested to\n> add a new one it is rejected by firmware and automatically removed from\n> the filter list maintained by driver. This behaviour is correct. Afterwards\n> existing filter can be removed making free slot for the new one. This\n> however causes the newly added filter to be accepted by firmware but\n> removed from driver filter list resulting in not showing after issuing 'ethtool -\n> n '.\n> \n> This happended due to not clearing the variable pf->fd_inv which stores filter\n> number to be removed from the list when firmware refused to add the\n> requested filter. It caused the filter with this specific ID to be constantly\n> removed once it was added to the list although it has been accepted by\n> firmware and effectively applied to the NIC.\n> It was fixed by clearing pf->fd_inv variable after removal of the filter from\n> the list when it was rejected by firmware.\n> \n> Signed-off-by: Filip Sadowski \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +\n> 1 file changed, 1 insertion(+)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmwdw1s0mz9sCZ\n\tfor ;\n\tWed, 6 Sep 2017 04:45:55 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 07A773090C;\n\tTue, 5 Sep 2017 18:45:54 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0mNzutV7XHme; Tue, 5 Sep 2017 18:45:53 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 59F2230771;\n\tTue, 5 Sep 2017 18:45:53 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0D6C81C00CC\n\tfor ;\n\tTue, 5 Sep 2017 18:45:52 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 04A1530771\n\tfor ;\n\tTue, 5 Sep 2017 18:45:52 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id O91xnQc6QF4N for ;\n\tTue, 5 Sep 2017 18:45:51 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3867D3071A\n\tfor ;\n\tTue, 5 Sep 2017 18:45:51 +0000 (UTC)","from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 05 Sep 2017 11:45:50 -0700","from orsmsx106.amr.corp.intel.com ([10.22.225.133])\n\tby orsmga001.jf.intel.com with ESMTP; 05 Sep 2017 11:45:50 -0700","from orsmsx163.amr.corp.intel.com (10.22.240.88) by\n\tORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Tue, 5 Sep 2017 11:45:50 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX163.amr.corp.intel.com ([169.254.9.96]) with mapi id\n\t14.03.0319.002; Tue, 5 Sep 2017 11:45:50 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.41,480,1498546800\"; d=\"scan'208\";\n\ta=\"1169359017\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [next PATCH S79-V2 09/13] i40e: Properly\n\tmaintain\tflow director filters list","Thread-Index":"AQHTIO2FCDHo9Xlv80OFSBdiMpy7VqKmrHBA","Date":"Tue, 5 Sep 2017 18:45:48 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9943@ORSMSX104.amr.corp.intel.com>","References":"<20170829093242.41026-1-alice.michael@intel.com>\n\t<20170829093242.41026-9-alice.michael@intel.com>","In-Reply-To":"<20170829093242.41026-9-alice.michael@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzcxMTk2ZWMtMWQ4MS00NDA3LWExN2MtZDUyYzgyZGQ0NDYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZxM0pZMldtMlZSNDRZdkhJWk9RU1NXYVQ1eEMwZ0VvOTFRUHlMaGlPOWc9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.138]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [next PATCH S79-V2 09/13] i40e: Properly\n\tmaintain\tflow director filters list","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]