[{"id":1761272,"web_url":"http://patchwork.ozlabs.org/comment/1761272/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA94F0@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-08-31T19:02:10","subject":"Re: [Intel-wired-lan] [next PATCH S79-V2 04/13] i40e:\n\tredfine\tI40E_PHY_TYPE_MAX","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Alice Michael\n> Sent: Tuesday, August 29, 2017 2:33 AM\n> To: Michael, Alice ; intel-wired-\n> lan@lists.osuosl.org\n> Cc: Williams, Mitch A \n> Subject: [Intel-wired-lan] [next PATCH S79-V2 04/13] i40e: redfine\n> I40E_PHY_TYPE_MAX\n> \n> From: Mitch Williams \n> \n> Since I40E_PHY_TYPE_MAX is used as an iterator, ususally combined with\n> some sort of bit-shifting, it should only include actual PHY types and not error\n> cases. Move it up in the enum declaration so that loops only iterate across\n> valid PHY types.\n> \n> Signed-off-by: Mitch Williams \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 2 +-\n> drivers/net/ethernet/intel/i40evf/i40e_adminq_cmd.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjsF46Nv7z9s7f\n\tfor ;\n\tFri, 1 Sep 2017 05:02:16 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3831387F06;\n\tThu, 31 Aug 2017 19:02:15 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SM4pwrr67b-B; Thu, 31 Aug 2017 19:02:13 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C87A987F02;\n\tThu, 31 Aug 2017 19:02:13 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6C89C1C20A3\n\tfor ;\n\tThu, 31 Aug 2017 19:02:12 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 64C8D87F02\n\tfor ;\n\tThu, 31 Aug 2017 19:02:12 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 58W8_M4PT95x for ;\n\tThu, 31 Aug 2017 19:02:11 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id B734487EEB\n\tfor ;\n\tThu, 31 Aug 2017 19:02:11 +0000 (UTC)","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga105.fm.intel.com with ESMTP; 31 Aug 2017 12:02:11 -0700","from orsmsx108.amr.corp.intel.com ([10.22.240.6])\n\tby fmsmga004.fm.intel.com with ESMTP; 31 Aug 2017 12:02:10 -0700","from orsmsx163.amr.corp.intel.com (10.22.240.88) by\n\tORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Thu, 31 Aug 2017 12:02:10 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX163.amr.corp.intel.com ([169.254.9.96]) with mapi id\n\t14.03.0319.002; Thu, 31 Aug 2017 12:02:10 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,454,1498546800\"; d=\"scan'208\";a=\"306673675\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [next PATCH S79-V2 04/13] i40e: redfine\n\tI40E_PHY_TYPE_MAX","Thread-Index":"AQHTIO2EquGgc+kwlEWp862sWq3UnaKe1V+Q","Date":"Thu, 31 Aug 2017 19:02:10 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA94F0@ORSMSX104.amr.corp.intel.com>","References":"<20170829093242.41026-1-alice.michael@intel.com>\n\t<20170829093242.41026-4-alice.michael@intel.com>","In-Reply-To":"<20170829093242.41026-4-alice.michael@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODBiZTc2MWItMmRlOS00YzM4LTg5MDItMDBhMTlkMDlhMThkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFTUG5yb3JPUlN4M1pQVTVIczJQZjMwV0FiQmc0UStLRFFWWlBoaERTMmc9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.140]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [next PATCH S79-V2 04/13] i40e:\n\tredfine\tI40E_PHY_TYPE_MAX","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]