[{"id":1761269,"web_url":"http://patchwork.ozlabs.org/comment/1761269/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA94D0@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-08-31T18:59:14","subject":"Re: [Intel-wired-lan] [next PATCH S79-V2 01/13] i40e: add private\n\tflag\tto control source pruning","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Alice Michael\n> Sent: Tuesday, August 29, 2017 2:33 AM\n> To: Michael, Alice ; intel-wired-\n> lan@lists.osuosl.org\n> Cc: Williams, Mitch A \n> Subject: [Intel-wired-lan] [next PATCH S79-V2 01/13] i40e: add private flag to\n> control source pruning\n> \n> From: Mitch Williams \n> \n> By default, our devices do source pruning, that is, they drop receive packets\n> that have the source MAC matching one of the receive filters.\n> Unfortunately, this breaks ARP monitoring in channel bonding, as the\n> bonding driver expects devices to receive ARPs containing their own source\n> address.\n> \n> Add an ethtool private flag to control this feature.\n> \n> Also, remove the netif_running() check when we process our private flags.\n> It's OK to reset when the device is closed and in most cases we need the\n> reset the apply these changes.\n> \n> Signed-off-by: Mitch Williams \n> ---\n> drivers/net/ethernet/intel/i40e/i40e.h | 1 +\n> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +++++--\n> drivers/net/ethernet/intel/i40e/i40e_main.c | 25\n> +++++++++++++++++++++++++\n> 3 files changed, 31 insertions(+), 2 deletions(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjs9m4BRhz9s7f\n\tfor ;\n\tFri, 1 Sep 2017 04:59:23 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9494987F06;\n\tThu, 31 Aug 2017 18:59:21 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XqatgjYQ_366; Thu, 31 Aug 2017 18:59:18 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B81BA87EF3;\n\tThu, 31 Aug 2017 18:59:18 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id ED6B41C4115\n\tfor ;\n\tThu, 31 Aug 2017 18:59:16 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E72102E871\n\tfor ;\n\tThu, 31 Aug 2017 18:59:16 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6FNLVVdOMv5W for ;\n\tThu, 31 Aug 2017 18:59:16 +0000 (UTC)","from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 15BEA2DAE0\n\tfor ;\n\tThu, 31 Aug 2017 18:59:16 +0000 (UTC)","from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Aug 2017 11:59:15 -0700","from orsmsx105.amr.corp.intel.com ([10.22.225.132])\n\tby orsmga001.jf.intel.com with ESMTP; 31 Aug 2017 11:59:15 -0700","from orsmsx158.amr.corp.intel.com (10.22.240.20) by\n\tORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Thu, 31 Aug 2017 11:59:15 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX158.amr.corp.intel.com ([169.254.10.117]) with mapi id\n\t14.03.0319.002; Thu, 31 Aug 2017 11:59:15 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.41,454,1498546800\"; d=\"scan'208\";\n\ta=\"1168021427\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [next PATCH S79-V2 01/13] i40e: add private\n\tflag\tto control source pruning","Thread-Index":"AQHTIO2Dbn+v8yOdFUqbgz4ZkAnvJaKe1IqQ","Date":"Thu, 31 Aug 2017 18:59:14 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA94D0@ORSMSX104.amr.corp.intel.com>","References":"<20170829093242.41026-1-alice.michael@intel.com>","In-Reply-To":"<20170829093242.41026-1-alice.michael@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzIwMjE0NmItMTQ2OC00NDI2LTg1ZWItMjNiYzAzYmFkYjE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1pbTBRQnNuYjVuUkJBTnNVZDZQNFRKeUhvUGtuSDFlMXh0ZXVSWDhTQ2M9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.140]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [next PATCH S79-V2 01/13] i40e: add private\n\tflag\tto control source pruning","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]