[{"id":1759540,"web_url":"http://patchwork.ozlabs.org/comment/1759540/","msgid":"<58a43572-668b-7c49-609f-f3686f2740f4@redhat.com>","list_archive_url":null,"date":"2017-08-29T16:49:27","subject":"Re: [Qemu-devel] [PATCH] io: fix check for handshake completion in\n\tTLS test","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/29/2017 11:40 AM, Daniel P. Berrange wrote:\n> The TLS I/O channel test had mistakenly used && instead\n> of || when checking for handshake completion. As a\n> result it could terminate the handshake process before\n> it had actually completed. This was harmless before but\n> changes in GNUTLS 3.6.0 exposed this bug and caused the\n> test suite to fail.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> tests/test-io-channel-tls.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n\nReviewed-by: Eric Blake \n\n> diff --git a/tests/test-io-channel-tls.c b/tests/test-io-channel-tls.c\n> index 8eaa208e1b..e7c80f46cf 100644\n> --- a/tests/test-io-channel-tls.c\n> +++ b/tests/test-io-channel-tls.c\n> @@ -218,7 +218,7 @@ static void test_io_channel_tls(const void *opaque)\n> mainloop = g_main_context_default();\n> do {\n> g_main_context_iteration(mainloop, TRUE);\n> - } while (!clientHandshake.finished &&\n> + } while (!clientHandshake.finished ||\n> !serverHandshake.finished);\n> \n> g_assert(clientHandshake.failed == data->expectClientFail);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhZQB4jBPz9t38\n\tfor ;\n\tWed, 30 Aug 2017 02:50:42 +1000 (AEST)","from localhost ([::1]:46105 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmjiq-0004NH-Gl\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 12:50:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48614)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmjhl-0003uD-OT\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 12:49:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmjhi-0000RV-Lz\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 12:49:33 -0400","from mx1.redhat.com ([209.132.183.28]:38386)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dmjhi-0000RH-Cw\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 12:49:30 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 356F185376\n\tfor ; Tue, 29 Aug 2017 16:49:29 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C9DF27FEBA;\n\tTue, 29 Aug 2017 16:49:28 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 356F185376","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170829164017.14178-1-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<58a43572-668b-7c49-609f-f3686f2740f4@redhat.com>","Date":"Tue, 29 Aug 2017 11:49:27 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170829164017.14178-1-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"q4AVG5LMBNR7P6tWTs7OEOSdHuWX8RshM\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 29 Aug 2017 16:49:29 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] io: fix check for handshake completion in\n\tTLS test","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]