[{"id":1759782,"web_url":"http://patchwork.ozlabs.org/comment/1759782/","msgid":"<1504053369.4670.8.camel@neuling.org>","list_archive_url":null,"date":"2017-08-30T00:36:09","subject":"Re: [Skiboot] [PATCH 1/1] vas: export chip-id to vas platform device","submitter":{"id":109,"url":"http://patchwork.ozlabs.org/api/people/109/","name":"Michael Neuling","email":"mikey@neuling.org"},"content":"On Tue, 2017-08-29 at 08:33 -0700, Sukadev Bhattiprolu wrote:\n> This is needed so VAS in the kernel can perform cpu to vas id mapping.\n\ncpu to vas, or chip to vas?\n\nMikey\n\n> \n> Signed-off-by: Sukadev Bhattiprolu \n> ---\n>  hw/vas.c | 3 +++\n>  1 file changed, 3 insertions(+)\n> \n> diff --git a/hw/vas.c b/hw/vas.c\n> index b744b51..7ee668d 100644\n> --- a/hw/vas.c\n> +++ b/hw/vas.c\n> @@ -389,6 +389,7 @@ static struct vas *alloc_vas(uint32_t chip_id, uint32_t\n> vas_id, uint64_t base)\n> \n>  static void create_mm_dt_node(struct proc_chip *chip)\n>  {\n> +\tint gcid;\n>  \tstruct dt_node *dn;\n>  \tstruct vas *vas;\n>  \tuint64_t hvwc_start, hvwc_len;\n> @@ -397,6 +398,7 @@ static void create_mm_dt_node(struct proc_chip *chip)\n>  \tuint64_t pbf_start, pbf_nbits;\n> \n>  \tvas = chip->vas;\n> +\tgcid = chip->id;\n>  \tget_hvwc_mmio_bar(chip->id, &hvwc_start, &hvwc_len);\n>  \tget_uwc_mmio_bar(chip->id, &uwc_start, &uwc_len);\n>  \tget_paste_bar(chip->id, &pbar_start, &pbar_len);\n> @@ -413,6 +415,7 @@ static void create_mm_dt_node(struct proc_chip *chip)\n>  \t\t\t\t\tpbf_start, pbf_nbits);\n> \n>  \tdt_add_property(dn, \"ibm,vas-id\", &vas->vas_id, sizeof(vas->vas_id));\n> +\tdt_add_property(dn, \"ibm,chip-id\", &gcid, sizeof(gcid));\n>  }\n> \n>  /*","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhmlY0WLcz9s8w\n\tfor ;\n\tWed, 30 Aug 2017 10:36:25 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xhmlX6VMbzDqGV\n\tfor ;\n\tWed, 30 Aug 2017 10:36:24 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xhmlF6s1jzDq5b\n\tfor ; Wed, 30 Aug 2017 10:36:09 +1000 (AEST)","from localhost.localdomain (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhmlF284sz9sNc;\n\tWed, 30 Aug 2017 10:36:09 +1000 (AEST)","by localhost.localdomain (Postfix, from userid 1000)\n\tid 35C35EEDE20; Wed, 30 Aug 2017 10:36:09 +1000 (AEST)"],"Message-ID":"<1504053369.4670.8.camel@neuling.org>","From":"Michael Neuling ","To":"Sukadev Bhattiprolu , \n\tstewart@linux.vnet.ibm.com","Date":"Wed, 30 Aug 2017 10:36:09 +1000","In-Reply-To":"<20170829153304.GA28625@us.ibm.com>","References":"<20170829153304.GA28625@us.ibm.com>","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Subject":"Re: [Skiboot] [PATCH 1/1] vas: export chip-id to vas platform device","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Haren Myneni , skiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1759785,"web_url":"http://patchwork.ozlabs.org/comment/1759785/","msgid":"<20170830005133.GA26152@us.ibm.com>","list_archive_url":null,"date":"2017-08-30T00:51:33","subject":"Re: [Skiboot] [PATCH 1/1] vas: export chip-id to vas platform device","submitter":{"id":984,"url":"http://patchwork.ozlabs.org/api/people/984/","name":"Sukadev Bhattiprolu","email":"sukadev@linux.vnet.ibm.com"},"content":"Michael Neuling [mikey@neuling.org] wrote:\n> On Tue, 2017-08-29 at 08:33 -0700, Sukadev Bhattiprolu wrote:\n> > This is needed so VAS in the kernel can perform cpu to vas id mapping.\n> \n> cpu to vas, or chip to vas?\n\nYes, there is cpu_to_chip() mapping in the kernel which I am thinking of\nusing to map a procees's cpu to chip to vas id. So, yes, for this patch,\nwe should say chip to vas id.\n> \n> Mikey\n> \n> > \n> > Signed-off-by: Sukadev Bhattiprolu \n> > ---\n> >  hw/vas.c | 3 +++\n> >  1 file changed, 3 insertions(+)\n> > \n> > diff --git a/hw/vas.c b/hw/vas.c\n> > index b744b51..7ee668d 100644\n> > --- a/hw/vas.c\n> > +++ b/hw/vas.c\n> > @@ -389,6 +389,7 @@ static struct vas *alloc_vas(uint32_t chip_id, uint32_t\n> > vas_id, uint64_t base)\n> > \n> >  static void create_mm_dt_node(struct proc_chip *chip)\n> >  {\n> > +\tint gcid;\n> >  \tstruct dt_node *dn;\n> >  \tstruct vas *vas;\n> >  \tuint64_t hvwc_start, hvwc_len;\n> > @@ -397,6 +398,7 @@ static void create_mm_dt_node(struct proc_chip *chip)\n> >  \tuint64_t pbf_start, pbf_nbits;\n> > \n> >  \tvas = chip->vas;\n> > +\tgcid = chip->id;\n> >  \tget_hvwc_mmio_bar(chip->id, &hvwc_start, &hvwc_len);\n> >  \tget_uwc_mmio_bar(chip->id, &uwc_start, &uwc_len);\n> >  \tget_paste_bar(chip->id, &pbar_start, &pbar_len);\n> > @@ -413,6 +415,7 @@ static void create_mm_dt_node(struct proc_chip *chip)\n> >  \t\t\t\t\tpbf_start, pbf_nbits);\n> > \n> >  \tdt_add_property(dn, \"ibm,vas-id\", &vas->vas_id, sizeof(vas->vas_id));\n> > +\tdt_add_property(dn, \"ibm,chip-id\", &gcid, sizeof(gcid));\n> >  }\n> > \n> >  /*","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhn5L0FLzz9sNc\n\tfor ;\n\tWed, 30 Aug 2017 10:51:50 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xhn5K6Dn1zDqBf\n\tfor ;\n\tWed, 30 Aug 2017 10:51:49 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xhn592r5DzDq5b\n\tfor ; Wed, 30 Aug 2017 10:51:41 +1000 (AEST)","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7U0o37N105192\n\tfor ; Tue, 29 Aug 2017 20:51:39 -0400","from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cnby3knad-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 29 Aug 2017 20:51:38 -0400","from localhost\n\tby e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 29 Aug 2017 18:51:38 -0600","from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 29 Aug 2017 18:51:35 -0600","from b03ledav005.gho.boulder.ibm.com\n\t(b03ledav005.gho.boulder.ibm.com [9.17.130.236])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7U0pYrH31916236; Tue, 29 Aug 2017 17:51:34 -0700","from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C5272BE03A;\n\tTue, 29 Aug 2017 18:51:34 -0600 (MDT)","from suka-w540.localdomain (unknown [9.70.94.25])\n\tby b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id 9A62DBE03B;\n\tTue, 29 Aug 2017 18:51:34 -0600 (MDT)","by suka-w540.localdomain (Postfix, from userid 1000)\n\tid 36D7F225DD8; Tue, 29 Aug 2017 17:51:33 -0700 (PDT)"],"Date":"Tue, 29 Aug 2017 17:51:33 -0700","From":"Sukadev Bhattiprolu ","To":"Michael Neuling ","References":"<20170829153304.GA28625@us.ibm.com>\n\t<1504053369.4670.8.camel@neuling.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504053369.4670.8.camel@neuling.org>","X-Operating-System":"Linux 2.0.32 on an i486","User-Agent":"Mutt/1.7.1 (2016-10-04)","X-TM-AS-GCONF":"00","x-cbid":"17083000-8235-0000-0000-00000C31563F","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007634; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909486; UDB=6.00456144;\n\tIPR=6.00689770; \n\tBA=6.00005560; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016924;\n\tXFM=3.00000015; UTC=2017-08-30 00:51:36","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083000-8236-0000-0000-00003D6FC0CC","Message-Id":"<20170830005133.GA26152@us.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-29_11:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708300010","Subject":"Re: [Skiboot] [PATCH 1/1] vas: export chip-id to vas platform device","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Haren Myneni , skiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1760629,"web_url":"http://patchwork.ozlabs.org/comment/1760629/","msgid":"<87lgm0jsbz.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-08-31T04:04:32","subject":"Re: [Skiboot] [PATCH 1/1] vas: export chip-id to vas platform device","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Sukadev Bhattiprolu writes:\n> This is needed so VAS in the kernel can perform cpu to vas id mapping.\n\nThanks, merged to master as of e1e962475e1e16e50a1aa192f08d20e9d66d10e4.\n\nAlthough one missing bit was updating documentation for the device tree\nentries for VAS. So, I assume that patch is coming shortly :)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjTKd0KnMz9s71\n\tfor ;\n\tThu, 31 Aug 2017 14:04:53 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjTKc6YwhzDqYG\n\tfor ;\n\tThu, 31 Aug 2017 14:04:52 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjTKT4ZnnzDq5b\n\tfor ; Thu, 31 Aug 2017 14:04:45 +1000 (AEST)","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7V44dan017433\n\tfor ; Thu, 31 Aug 2017 00:04:43 -0400","from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cp4crw3jy-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 31 Aug 2017 00:04:43 -0400","from localhost\n\tby e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 30 Aug 2017 22:04:42 -0600","from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 30 Aug 2017 22:04:39 -0600","from b03ledav002.gho.boulder.ibm.com\n\t(b03ledav002.gho.boulder.ibm.com [9.17.130.233])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7V44cSe4915556; Wed, 30 Aug 2017 21:04:38 -0700","from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 4ADC713603A;\n\tWed, 30 Aug 2017 22:04:38 -0600 (MDT)","from birb.localdomain (unknown [9.81.216.230])\n\tby b03ledav002.gho.boulder.ibm.com (Postfix) with SMTP id CC46313603C;\n\tWed, 30 Aug 2017 22:04:36 -0600 (MDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid E30A14E87E1; Thu, 31 Aug 2017 14:04:32 +1000 (AEST)"],"From":"Stewart Smith ","To":"Sukadev Bhattiprolu ","In-Reply-To":"<20170829153304.GA28625@us.ibm.com>","References":"<20170829153304.GA28625@us.ibm.com>","Date":"Thu, 31 Aug 2017 14:04:32 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17083104-0028-0000-0000-00000849E0E2","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007639; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00910031; UDB=6.00456471;\n\tIPR=6.00690311; \n\tBA=6.00005562; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016938;\n\tXFM=3.00000015; UTC=2017-08-31 04:04:40","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083104-0029-0000-0000-0000375CD2F8","Message-Id":"<87lgm0jsbz.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-30_10:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310060","Subject":"Re: [Skiboot] [PATCH 1/1] vas: export chip-id to vas platform device","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hbabu@us.ibm.com, michael.neuling@au1.ibm.com, skiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]