[{"id":1759570,"web_url":"http://patchwork.ozlabs.org/comment/1759570/","msgid":"","list_archive_url":null,"date":"2017-08-29T17:38:24","subject":"Re: [U-Boot] [PATCH v2] spi: fsl_qspi: Add controller busy check\n\tbefore new spi operation","submitter":{"id":20045,"url":"http://patchwork.ozlabs.org/api/people/20045/","name":"Jagan Teki","email":"jagannadh.teki@gmail.com"},"content":"On Tue, Aug 29, 2017 at 6:55 PM, Suresh Gupta wrote:\n> It is recommended to check either controller is free to take\n> new spi action. The IP_ACC and AHB_ACC bits indicates that\n> the controller is busy in IP or AHB mode respectively.\n> And the BUSY bit indicates that controller is currently\n> busy handling a transaction to an external flash device\n>\n> Signed-off-by: Suresh Gupta \n> ---\n> Changes in v2:\n>\n> - Add wait_for_bit instead of while\n> - move the busy check code to fsl_qspi_claim_bus form qspi_xfer\n>\n> drivers/spi/fsl_qspi.c | 28 +++++++++++++++++++++++++++-\n> drivers/spi/fsl_qspi.h | 4 ++++\n> 2 files changed, 31 insertions(+), 1 deletion(-)\n>\n> diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c\n> index 1dfa89a..ed23aac 100644\n> --- a/drivers/spi/fsl_qspi.c\n> +++ b/drivers/spi/fsl_qspi.c\n> @@ -14,6 +14,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \"fsl_qspi.h\"\n>\n> DECLARE_GLOBAL_DATA_PTR;\n> @@ -991,7 +992,7 @@ static int fsl_qspi_probe(struct udevice *bus)\n> struct fsl_qspi_platdata *plat = dev_get_platdata(bus);\n> struct fsl_qspi_priv *priv = dev_get_priv(bus);\n> struct dm_spi_bus *dm_spi_bus;\n> - int i;\n> + int i, ret;\n>\n> dm_spi_bus = bus->uclass_priv;\n>\n> @@ -1011,6 +1012,18 @@ static int fsl_qspi_probe(struct udevice *bus)\n> priv->flash_num = plat->flash_num;\n> priv->num_chipselect = plat->num_chipselect;\n>\n\nI think in previous version, this code not added in probe is it? is\nthis because probe doing mcr and other reg operations?\n\n> + /* make sure controller is not busy anywhere */\n> + ret = wait_for_bit(__func__, &priv->regs->sr,\n> + QSPI_SR_BUSY_MASK |\n> + QSPI_SR_AHB_ACC_MASK |\n> + QSPI_SR_IP_ACC_MASK,\n> + false, 1000, false);\n> +\n> + if (ret) {\n> + printf(\"ERROR : The controller is busy\\n\");\n> + return -EBUSY;\n> + }\n\nBetter to drop printf or use debug and wait_for_bit usually return\n-ETIMEDOUT or -EINTR on failure so just return ret.\n\nthanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BCgR1eoW\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhbTc48H6z9ryr\n\tfor ;\n\tWed, 30 Aug 2017 03:38:44 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2868FC21C4E; Tue, 29 Aug 2017 17:38:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id F2FE5C2211B;\n\tTue, 29 Aug 2017 17:38:26 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A6E7DC2211B; Tue, 29 Aug 2017 17:38:25 +0000 (UTC)","from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66])\n\tby lists.denx.de (Postfix) with ESMTPS id 48511C21C4E\n\tfor ; Tue, 29 Aug 2017 17:38:25 +0000 (UTC)","by mail-lf0-f66.google.com with SMTP id l140so2534330lfg.3\n\tfor ; Tue, 29 Aug 2017 10:38:25 -0700 (PDT)","by 10.25.222.200 with HTTP; Tue, 29 Aug 2017 10:38:24 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=/OgIc+7yDV6rd8ljst5gA3POQaUngU2EXH+NBP0OZOQ=;\n\tb=BCgR1eoWr9fR51Zf1Fv22tk209h+FsoItCKtBcaxogksTjveeFZufiA6puFvehq/AY\n\taiLWsvBS/j8ouw/XCtxMFjrSJDywvRJ07ACdjywtAoUz2qX2V7dOKajECRCNO/NrpeSM\n\t2iBN7Jr6ZCTATmGjM1FVoheCgbM7an0d9X4EIH3fPPaWEZhP8cCjwFvMmbyzcbbVD9Ev\n\tOxS+2yGST45xpycPRAY4EYOCrd3lbbSX4fFmF7Skt6dnFxUTN0vKYCB7ELhAEl2LqyEy\n\toI//jb3ncnE7M/uqJFA+Pz+J2NCmT148UZejzR8Ehoh+m2IjFSUg839lu069tn8gbAU2\n\tDHNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=/OgIc+7yDV6rd8ljst5gA3POQaUngU2EXH+NBP0OZOQ=;\n\tb=gMxWi2DZGkeYzpKWbf3RoYog66xawNGxPSirdPEeaKzj4bcIoSODm51K4F+D3WHejB\n\t5/hWVphnx5GMp2NgDuMIQN6bZn5dMyZXV8IZZZGeO16rSVLkv2FFsJh7Lh3bSk3EupH+\n\te36311LIvUwuJD8agPJAa79NmZK4pTWB89xgwG7jR8lZF5sz3zvl/M/ErgmToi/hG2Wo\n\tTEg8pytFKnyY5uDMK0FgkIn41XaaDwuswjXlWXSksNIC7GS/CNIs3KP08NeW9hiahnRe\n\t8Jlav2iLDsEkvZCX+3TQxjApZXQ8SYhNYSYOWQeMFpa1DX/7H3WE5f2wfJZfcnAeupLw\n\tYBbg==","X-Gm-Message-State":"AHYfb5idzvIAem8Yp17kZ3zShwyoWjlHNk0UHr2mnFtQAIaTpvmpeTQv\n\tbe+IcRa1U+mCn5A5kJdlL74qpqwIZEDk","X-Received":"by 10.25.56.22 with SMTP id f22mr323878lfa.92.1504028304716; Tue,\n\t29 Aug 2017 10:38:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504013105-11480-1-git-send-email-suresh.gupta@nxp.com>","References":"<1504013105-11480-1-git-send-email-suresh.gupta@nxp.com>","From":"Jagan Teki ","Date":"Tue, 29 Aug 2017 23:08:24 +0530","Message-ID":"","To":"Suresh Gupta ","Cc":"\"u-boot@lists.denx.de\" ","Subject":"Re: [U-Boot] [PATCH v2] spi: fsl_qspi: Add controller busy check\n\tbefore new spi operation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1759918,"web_url":"http://patchwork.ozlabs.org/comment/1759918/","msgid":"","list_archive_url":null,"date":"2017-08-30T06:53:47","subject":"Re: [U-Boot] [PATCH v2] spi: fsl_qspi: Add controller busy check\n\tbefore new spi operation","submitter":{"id":70239,"url":"http://patchwork.ozlabs.org/api/people/70239/","name":"Suresh Gupta","email":"suresh.gupta@nxp.com"},"content":"> -----Original Message-----\r\n> From: Jagan Teki [mailto:jagannadh.teki@gmail.com]\r\n> Sent: Tuesday, August 29, 2017 11:08 PM\r\n> To: Suresh Gupta \r\n> Cc: u-boot@lists.denx.de; York Sun \r\n> Subject: Re: [PATCH v2] spi: fsl_qspi: Add controller busy check before new spi\r\n> operation\r\n> \r\n> On Tue, Aug 29, 2017 at 6:55 PM, Suresh Gupta \r\n> wrote:\r\n> > It is recommended to check either controller is free to take new spi\r\n> > action. The IP_ACC and AHB_ACC bits indicates that the controller is\r\n> > busy in IP or AHB mode respectively.\r\n> > And the BUSY bit indicates that controller is currently busy handling\r\n> > a transaction to an external flash device\r\n> >\r\n> > Signed-off-by: Suresh Gupta \r\n> > ---\r\n> > Changes in v2:\r\n> >\r\n> > - Add wait_for_bit instead of while\r\n> > - move the busy check code to fsl_qspi_claim_bus form qspi_xfer\r\n> >\r\n> > drivers/spi/fsl_qspi.c | 28 +++++++++++++++++++++++++++-\r\n> > drivers/spi/fsl_qspi.h | 4 ++++\r\n> > 2 files changed, 31 insertions(+), 1 deletion(-)\r\n> >\r\n> > diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index\r\n> > 1dfa89a..ed23aac 100644\r\n> > --- a/drivers/spi/fsl_qspi.c\r\n> > +++ b/drivers/spi/fsl_qspi.c\r\n> > @@ -14,6 +14,7 @@\r\n> > #include \r\n> > #include \r\n> > #include \r\n> > +#include \r\n> > #include \"fsl_qspi.h\"\r\n> >\r\n> > DECLARE_GLOBAL_DATA_PTR;\r\n> > @@ -991,7 +992,7 @@ static int fsl_qspi_probe(struct udevice *bus)\r\n> > struct fsl_qspi_platdata *plat = dev_get_platdata(bus);\r\n> > struct fsl_qspi_priv *priv = dev_get_priv(bus);\r\n> > struct dm_spi_bus *dm_spi_bus;\r\n> > - int i;\r\n> > + int i, ret;\r\n> >\r\n> > dm_spi_bus = bus->uclass_priv;\r\n> >\r\n> > @@ -1011,6 +1012,18 @@ static int fsl_qspi_probe(struct udevice *bus)\r\n> > priv->flash_num = plat->flash_num;\r\n> > priv->num_chipselect = plat->num_chipselect;\r\n> >\r\n> \r\n> I think in previous version, this code not added in probe is it? is this because\r\n> probe doing mcr and other reg operations?\r\n\r\nThe probe function changes the LUTs, change AHB configuration and change the endianness. \r\nSo, changing above setting when the controller is busy in some AHB access will affect the running access.\r\n> \r\n> > + /* make sure controller is not busy anywhere */\r\n> > + ret = wait_for_bit(__func__, &priv->regs->sr,\r\n> > + QSPI_SR_BUSY_MASK |\r\n> > + QSPI_SR_AHB_ACC_MASK |\r\n> > + QSPI_SR_IP_ACC_MASK,\r\n> > + false, 1000, false);\r\n> > +\r\n> > + if (ret) {\r\n> > + printf(\"ERROR : The controller is busy\\n\");\r\n> > + return -EBUSY;\r\n> > + }\r\n> \r\n> Better to drop printf or use debug and\r\nThe error above is trivial and after this error, the sf commands do not work.\r\nAnd if we hide the message under debug, normal user will not understand the issue. \r\nAs per me this should be printf, what you say? \r\n\r\n> wait_for_bit usually return -ETIMEDOUT\r\n> or -EINTR on failure so just return ret.\r\nOk, I will make changes in next patch\r\n\r\n> \r\n> thanks!\r\n> --\r\n> Jagan Teki\r\n> Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream\r\n> Maintainer Hyderabad, India.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"WJvVYdCi\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=suresh.gupta@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhx7M1pj9z9s9Y\n\tfor ;\n\tWed, 30 Aug 2017 16:54:05 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CCF5EC2279E; Wed, 30 Aug 2017 06:53:54 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 4C122C2277A;\n\tWed, 30 Aug 2017 06:53:52 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8F13AC22779; Wed, 30 Aug 2017 06:53:50 +0000 (UTC)","from EUR01-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur01on0088.outbound.protection.outlook.com [104.47.0.88])\n\tby lists.denx.de (Postfix) with ESMTPS id CBF2EC22761\n\tfor ; Wed, 30 Aug 2017 06:53:49 +0000 (UTC)","from DB5PR04MB1350.eurprd04.prod.outlook.com (10.162.220.156) by\n\tDB5PR04MB1256.eurprd04.prod.outlook.com (10.162.156.146) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9; Wed, 30 Aug 2017 06:53:48 +0000","from DB5PR04MB1350.eurprd04.prod.outlook.com\n\t([fe80::7175:9fbf:f392:a88f]) by\n\tDB5PR04MB1350.eurprd04.prod.outlook.com\n\t([fe80::7175:9fbf:f392:a88f%13]) with mapi id 15.01.1385.014;\n\tWed, 30 Aug 2017 06:53:47 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=t13Kh2pX8h/Oy49ywBPLP5fs3+GTtUXE2ZhMZDGZqPw=;\n\tb=WJvVYdCi9wT9YZ+VNcTTNrRa8dQNYNKQyNWznxbQnmg7e98ATMvvGFIGz8MJjF0WKjwsPdnG42/8RvXJ/17MMbK80d4LJE5eIugj2k46jf2qm5poq19/FBGzQkdYg3Z+w4HSEm5r67Yss7ReSkEKnp+gNd3JlrMCd8SmpfzIFOc=","From":"Suresh Gupta ","To":"Jagan Teki ","Thread-Topic":"[PATCH v2] spi: fsl_qspi: Add controller busy check before new\n\tspi operation","Thread-Index":"AQHTIMokTEm3oiacr0yfpzrYdHOGyqKbmaYAgADCRrA=","Date":"Wed, 30 Aug 2017 06:53:47 +0000","Message-ID":"","References":"<1504013105-11480-1-git-send-email-suresh.gupta@nxp.com>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[192.88.169.1]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; DB5PR04MB1256;\n\t6:Lfx3HRRkYb04HmeiG92XB7RbTi7EkUze9xWDih+90DEkT/s/6YMbn1FPO478qHBPhilpN3QDNg5/u+Pvs1VkB/Asoi/xrBbK0Gd26YE3+1rxCkTrwg+pl9I9AF67AdV7KsbpgvhOJeQlHVNG5Stq5WXRbnVEDSHQwEzsHxaacksL6WJ9AItbBd+9HrHf028Hx8plT0Y5LQuGZNEf1MUz0r/HSn+XOU1rT55nMNJGidVDVI//Zay83iqI6RNfWMnjMHh2eQkExi4ghswijxpXXVJ75IE/vZ34vpkrGbt2tOULskR66/NW4OtxzyTwPyEqbWAF/96xxPP35JQuv0PYLg==;\n\t5:ZsTJGc3uNWQ7xJRnOZKT5371Hj23scAOST24lLprM/UdPcY5Kqmecb9BKRA29IDlg+moJs9SMUqAztItZyBXeBVkFnkkPeuT3XAR9r75xm/j5Lb7tlRJgDmBdPdL25Yvf8DrUtnzL6V2xH3Z9VE90w==;\n\t24:Je4f7q+qsFdO9X1a6Cw5kn9nfWxkveCzoghcDRNgFZEXVd8wgUPm0iOTG2Y7yzYAJoVK9v0IsSS79sbPN/vKAsbC9Z5dCNjm8q/MEWjqr3o=;\n\t7:i3p9WbRO2wtyBaSg1c658xrzLFzAl+fdt45jVkVOZy1RfnVh+TfWeMCoTQnW//WtvduBwjVZi/cPLdkjKvvGemc2F9KoWO/5AhMsB0cQx1iaQS9sc8uogpBZUMf5L+0z4hwP7WuEJMt/RikBdanAGw3gsqcpQv+sWlwUIe6d7lduehp+ZjLD8P4IFlY1vExgnjBv6TMtHh/VjNfKDK126JP85v2q6HLL4kd5nAfBkDM=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(199003)(24454002)(13464003)(377454003)(189002)(3280700002)(7736002)(101416001)(97736004)(15974865002)(3846002)(3660700001)(6116002)(102836003)(81156014)(8936002)(81166006)(551934003)(189998001)(66066001)(86362001)(8676002)(68736007)(74316002)(105586002)(6506006)(2906002)(305945005)(106356001)(14454004)(6916009)(229853002)(2950100002)(55016002)(4326008)(2900100001)(53936002)(53546010)(478600001)(110136004)(39060400002)(6246003)(54906002)(5660300001)(99286003)(33656002)(25786009)(9686003)(7696004)(50986999)(76176999)(54356999)(5250100002)(6436002)(2004002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB1256;\n\tH:DB5PR04MB1350.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"0ca8e1f5-351a-4152-6323-08d4ef73dd3e","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DB5PR04MB1256; ","x-ms-traffictypediagnostic":"DB5PR04MB1256:","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"WJvVYdCi\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=suresh.gupta@nxp.com; "],"x-exchange-antispam-report-test":"UriScan:(185117386973197)(16074681357397);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB5PR04MB1256; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB5PR04MB1256; ","x-forefront-prvs":"041517DFAB","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"30 Aug 2017 06:53:47.7276\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB5PR04MB1256","Cc":"\"u-boot@lists.denx.de\" ","Subject":"Re: [U-Boot] [PATCH v2] spi: fsl_qspi: Add controller busy check\n\tbefore new spi operation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1759929,"web_url":"http://patchwork.ozlabs.org/comment/1759929/","msgid":"","list_archive_url":null,"date":"2017-08-30T07:32:39","subject":"Re: [U-Boot] [PATCH v2] spi: fsl_qspi: Add controller busy check\n\tbefore new spi operation","submitter":{"id":20045,"url":"http://patchwork.ozlabs.org/api/people/20045/","name":"Jagan Teki","email":"jagannadh.teki@gmail.com"},"content":"On Wed, Aug 30, 2017 at 12:23 PM, Suresh Gupta wrote:\n>\n>\n>> -----Original Message-----\n>> From: Jagan Teki [mailto:jagannadh.teki@gmail.com]\n>> Sent: Tuesday, August 29, 2017 11:08 PM\n>> To: Suresh Gupta \n>> Cc: u-boot@lists.denx.de; York Sun \n>> Subject: Re: [PATCH v2] spi: fsl_qspi: Add controller busy check before new spi\n>> operation\n>>\n>> On Tue, Aug 29, 2017 at 6:55 PM, Suresh Gupta \n>> wrote:\n>> > It is recommended to check either controller is free to take new spi\n>> > action. The IP_ACC and AHB_ACC bits indicates that the controller is\n>> > busy in IP or AHB mode respectively.\n>> > And the BUSY bit indicates that controller is currently busy handling\n>> > a transaction to an external flash device\n>> >\n>> > Signed-off-by: Suresh Gupta \n>> > ---\n>> > Changes in v2:\n>> >\n>> > - Add wait_for_bit instead of while\n>> > - move the busy check code to fsl_qspi_claim_bus form qspi_xfer\n>> >\n>> > drivers/spi/fsl_qspi.c | 28 +++++++++++++++++++++++++++-\n>> > drivers/spi/fsl_qspi.h | 4 ++++\n>> > 2 files changed, 31 insertions(+), 1 deletion(-)\n>> >\n>> > diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index\n>> > 1dfa89a..ed23aac 100644\n>> > --- a/drivers/spi/fsl_qspi.c\n>> > +++ b/drivers/spi/fsl_qspi.c\n>> > @@ -14,6 +14,7 @@\n>> > #include \n>> > #include \n>> > #include \n>> > +#include \n>> > #include \"fsl_qspi.h\"\n>> >\n>> > DECLARE_GLOBAL_DATA_PTR;\n>> > @@ -991,7 +992,7 @@ static int fsl_qspi_probe(struct udevice *bus)\n>> > struct fsl_qspi_platdata *plat = dev_get_platdata(bus);\n>> > struct fsl_qspi_priv *priv = dev_get_priv(bus);\n>> > struct dm_spi_bus *dm_spi_bus;\n>> > - int i;\n>> > + int i, ret;\n>> >\n>> > dm_spi_bus = bus->uclass_priv;\n>> >\n>> > @@ -1011,6 +1012,18 @@ static int fsl_qspi_probe(struct udevice *bus)\n>> > priv->flash_num = plat->flash_num;\n>> > priv->num_chipselect = plat->num_chipselect;\n>> >\n>>\n>> I think in previous version, this code not added in probe is it? is this because\n>> probe doing mcr and other reg operations?\n>\n> The probe function changes the LUTs, change AHB configuration and change the endianness.\n> So, changing above setting when the controller is busy in some AHB access will affect the running access.\n>>\n>> > + /* make sure controller is not busy anywhere */\n>> > + ret = wait_for_bit(__func__, &priv->regs->sr,\n>> > + QSPI_SR_BUSY_MASK |\n>> > + QSPI_SR_AHB_ACC_MASK |\n>> > + QSPI_SR_IP_ACC_MASK,\n>> > + false, 1000, false);\n>> > +\n>> > + if (ret) {\n>> > + printf(\"ERROR : The controller is busy\\n\");\n>> > + return -EBUSY;\n>> > + }\n>>\n>> Better to drop printf or use debug and\n> The error above is trivial and after this error, the sf commands do not work.\n> And if we hide the message under debug, normal user will not understand the issue.\n> As per me this should be printf, what you say?\n\nsf return error code, can't user understand based on that? idea is to\navoid printf's in platform driver.\n\nthanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E0qTD28e\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhy0P2nYDz9sP5\n\tfor ;\n\tWed, 30 Aug 2017 17:33:08 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C557FC227B9; Wed, 30 Aug 2017 07:32:45 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id BB249C22724;\n\tWed, 30 Aug 2017 07:32:42 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0BF37C22397; Wed, 30 Aug 2017 07:32:41 +0000 (UTC)","from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67])\n\tby lists.denx.de (Postfix) with ESMTPS id 3F105C226C9\n\tfor ; Wed, 30 Aug 2017 07:32:41 +0000 (UTC)","by mail-lf0-f67.google.com with SMTP id y15so3417658lfd.0\n\tfor ; Wed, 30 Aug 2017 00:32:41 -0700 (PDT)","by 10.25.222.200 with HTTP; Wed, 30 Aug 2017 00:32:39 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Jgj4EZ6W1ODz1G2uIWqWe3nE8Xcid9Gl5oxTZo67WL8=;\n\tb=E0qTD28efvQDfIF5BNO9LxL7yoWjfjgUheynZXcVncKdobMLbSHCmeJEMyqANuVgOW\n\tnti4Z7gfAOv2NQK7cdK2azE8RnG8Qp3P+P8jxunK/wOYJK6rOGvGE0B1hH5BxbOQ2NAe\n\tilP1V7nuuY0IIDY+thb7cKkQLJkewOxexZbs996ywdG1hWBa85vxRHif96Vu8q12PL0O\n\tDOj055HLlroFk0XJIV7mF4d/e2Im0qGxcXqSJ2WbKyrrAcY9pZwKkIJwFx7RF+ClkzNm\n\t3YQ9xQaojHtEieplDP0ZBOixeebOAjRmqfQ0BeIskW6tav0mN3T1TvoyaicdJX+WRXKc\n\tmVfg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Jgj4EZ6W1ODz1G2uIWqWe3nE8Xcid9Gl5oxTZo67WL8=;\n\tb=k6yPJQYHwN5qK8tWnzfYnJIUOsaYsrK2yhFe5kjIulEbNf81DCo1WIG7eutw49E4s7\n\tbQLOtSK0qf0wGQyfL4qEkjIeca7jo6DjzZ/G0OvjGfkjbJdJdrB2Gau8CCzQ5CpCvcww\n\tNCWj0Tf+z27LqHSmuZxsWnmZlVuLUVWa6EdhkJ/WAx/vDSfK8fqC4VSERPE5ywye7jwN\n\tp+vSoGzV5QYo5YE6+qQEugczE7CHzyNyEOh48Xeh5GaBCxhp1TDa67kVNHAjsEnCS56j\n\tmAZrjnOaVkKMjO6WFAXtcETsSBvv21FYBzOXs3K38i5a4lQ+5HQx+rDgIYlc8ELFFyE2\n\tgD0g==","X-Gm-Message-State":"AHPjjUjvwYHhw01K69T9EJcFP6lKy3mkodcYLEwYtliq9oSm/khQorpv\n\tsO92WXgGENJZocwtofC1w0QsbJKyIg==","X-Received":"by 10.25.56.22 with SMTP id f22mr251649lfa.92.1504078360532; Wed,\n\t30 Aug 2017 00:32:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504013105-11480-1-git-send-email-suresh.gupta@nxp.com>\n\t\n\t","From":"Jagan Teki ","Date":"Wed, 30 Aug 2017 13:02:39 +0530","Message-ID":"","To":"Suresh Gupta ","Cc":"\"u-boot@lists.denx.de\" ","Subject":"Re: [U-Boot] [PATCH v2] spi: fsl_qspi: Add controller busy check\n\tbefore new spi operation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]