[{"id":1759431,"web_url":"http://patchwork.ozlabs.org/comment/1759431/","msgid":"<20170829180219-mutt-send-email-mst@kernel.org>","list_archive_url":null,"date":"2017-08-29T15:02:53","subject":"Re: [Qemu-devel] [PATCH 2/2] vhost-user-bridge: fix resume\n\tregression (since 2.9)","submitter":{"id":2235,"url":"http://patchwork.ozlabs.org/api/people/2235/","name":"Michael S. Tsirkin","email":"mst@redhat.com"},"content":"On Tue, Aug 29, 2017 at 04:48:05PM +0200, Marc-André Lureau wrote:\n> Commit e10e798c85c2331 switched to libvhost-user which lacked support\n> for resuming the avail_idx based on used_idx.\n> \n> Fixes:\n> https://bugzilla.redhat.com/show_bug.cgi?id=1485867\n> \n> Signed-off-by: Marc-André Lureau \n\nCan we add a test for reconnect to catch the regression?\n\n> ---\n> tests/vhost-user-bridge.c | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c\n> index 1e5b5ca3da..dca48512ba 100644\n> --- a/tests/vhost-user-bridge.c\n> +++ b/tests/vhost-user-bridge.c\n> @@ -466,11 +466,18 @@ vubr_panic(VuDev *dev, const char *msg)\n> vubr->quit = 1;\n> }\n> \n> +static bool\n> +vubr_queue_resume_to_used(VuDev *dev, int qidx)\n> +{\n> + return true;\n> +}\n> +\n> static const VuDevIface vuiface = {\n> .get_features = vubr_get_features,\n> .set_features = vubr_set_features,\n> .process_msg = vubr_process_msg,\n> .queue_set_started = vubr_queue_set_started,\n> + .queue_resume_to_used = vubr_queue_resume_to_used,\n> };\n> \n> static void\n> -- \n> 2.14.1.146.gd35faa819","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mst@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhX5g0WJWz9sRV\n\tfor ;\n\tWed, 30 Aug 2017 01:06:15 +1000 (AEST)","from localhost ([::1]:45413 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmi5k-0006J9-UW\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 11:06:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39155)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmi2m-0004Kq-RU\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:03:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmi2h-0007Px-AZ\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:03:08 -0400","from mx1.redhat.com ([209.132.183.28]:52024)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dmi2h-0007Pi-3m\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:03:03 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 15BED7E436\n\tfor ; Tue, 29 Aug 2017 15:03:02 +0000 (UTC)","from redhat.com (ovpn-120-128.rdu2.redhat.com [10.10.120.128])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0AA6580925;\n\tTue, 29 Aug 2017 15:02:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 15BED7E436","Date":"Tue, 29 Aug 2017 18:02:53 +0300","From":"\"Michael S. Tsirkin\" ","To":"=?iso-8859-1?q?Marc-Andr=E9?= Lureau ","Message-ID":"<20170829180219-mutt-send-email-mst@kernel.org>","References":"<20170829144805.28872-1-marcandre.lureau@redhat.com>\n\t<20170829144805.28872-3-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<20170829144805.28872-3-marcandre.lureau@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 29 Aug 2017 15:03:02 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/2] vhost-user-bridge: fix resume\n\tregression (since 2.9)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"victork@redhat.com, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759447,"web_url":"http://patchwork.ozlabs.org/comment/1759447/","msgid":"","list_archive_url":null,"date":"2017-08-29T15:22:28","subject":"Re: [Qemu-devel] [PATCH 2/2] vhost-user-bridge: fix resume\n\tregression (since 2.9)","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"Hi\n\nOn Tue, Aug 29, 2017 at 5:02 PM, Michael S. Tsirkin wrote:\n> On Tue, Aug 29, 2017 at 04:48:05PM +0200, Marc-André Lureau wrote:\n>> Commit e10e798c85c2331 switched to libvhost-user which lacked support\n>> for resuming the avail_idx based on used_idx.\n>>\n>> Fixes:\n>> https://bugzilla.redhat.com/show_bug.cgi?id=1485867\n>>\n>> Signed-off-by: Marc-André Lureau \n>\n> Can we add a test for reconnect to catch the regression?\n\nThere is no automated tests for vhost-user-bridge yet. We could\nprobably make one based on \"[PATCH v2 0/5] tests/pxe-test: add\ntestcase using vhost-user-bridge\" series.\n\nWe could also add seperate libvhost-user tests, that's not existent\nyet, partly because libvhost-user was born as a test itself ;).\n\n>\n>> ---\n>> tests/vhost-user-bridge.c | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c\n>> index 1e5b5ca3da..dca48512ba 100644\n>> --- a/tests/vhost-user-bridge.c\n>> +++ b/tests/vhost-user-bridge.c\n>> @@ -466,11 +466,18 @@ vubr_panic(VuDev *dev, const char *msg)\n>> vubr->quit = 1;\n>> }\n>>\n>> +static bool\n>> +vubr_queue_resume_to_used(VuDev *dev, int qidx)\n>> +{\n>> + return true;\n>> +}\n>> +\n>> static const VuDevIface vuiface = {\n>> .get_features = vubr_get_features,\n>> .set_features = vubr_set_features,\n>> .process_msg = vubr_process_msg,\n>> .queue_set_started = vubr_queue_set_started,\n>> + .queue_resume_to_used = vubr_queue_resume_to_used,\n>> };\n>>\n>> static void\n>> --\n>> 2.14.1.146.gd35faa819\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HuhEOzPl\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhXT45F9Vz9t33\n\tfor ;\n\tWed, 30 Aug 2017 01:23:04 +1000 (AEST)","from localhost ([::1]:45480 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmiM2-0005Ip-Ku\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 11:23:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44321)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmiLW-0005H2-Tq\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:22:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmiLV-0007y7-T5\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:22:30 -0400","from mail-vk0-x244.google.com ([2607:f8b0:400c:c05::244]:34603)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmiLV-0007xy-O3\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:22:29 -0400","by mail-vk0-x244.google.com with SMTP id l132so1448128vke.1\n\tfor ; Tue, 29 Aug 2017 08:22:29 -0700 (PDT)","by 10.159.51.146 with HTTP; Tue, 29 Aug 2017 08:22:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=gnsUCWyCCgDMteVA/biWU0JP6EHScybVDtj+030zRSA=;\n\tb=HuhEOzPlKT0No0fG1IvNOlRf/QgJKr1D2LkNo30AjuyMbTFhlD7eTOMgUDdvr9EhGD\n\tFMQDpK3JkCZ/qw3489875NFt7+ddXAw5GmUOJXouaqSMCv/WqP7+Kb3XHTssAjsCd8mY\n\thEIHwZCkN32H6EE1bGsshSJ3EUrYfCKusWimhnx51doyVjxDFtSncdhX36oFYrauFr+R\n\teNXw0kq2zG2+mvWnsCFwGp2dHI55JA9kk/IYXl854on9BbsoRiS6w7Di8hg8nyOwyLy5\n\teDouEluR/i/a8CHnhLnWPCsTbJb0I8c9pdknzeemZH0h2rLDsDSq2iPSyv5+WKodx+cK\n\tGEPg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=gnsUCWyCCgDMteVA/biWU0JP6EHScybVDtj+030zRSA=;\n\tb=T1Sgt9G3BEOLgOxmTDdlqmsCbDUU37Wp5k2GYm8mkDFtfDX9dOBAca7vuH5/JANuzO\n\tww95pvDOEdmIIvEQLkVGHGPfsan55G8rEjw8u3k8AjOSti6KpLdsM/nugLeoS2DF4Mv/\n\t/C4sAZhns/TN1afVNTXaS4zM84JGp6abylfAwZVP3E3iRPbkjOfk2KFrvRhH+vGBy8/g\n\tdj4WzcYKxXdS0q/B51hPO+ht1Vvfd2p5cCMb/8HZ/PlnChryuqrYij6hG3DlUmFWw0tC\n\tO78/YxCNTNMK/44MgcX5aLMvSRJfGw1UuwzrgJDoyN4+JCGD96xedsVwgW+M0xb3Muu9\n\txsyw==","X-Gm-Message-State":"AHYfb5hdSM2FC1gBIeTqbl4AzxZSWDN/gaxPge1GxWyk6I0h4xmrJBto\n\tE4m6Dc01P4LAmeO+I2ppXC2TiGidXQ==","X-Received":"by 10.31.56.145 with SMTP id f139mr430144vka.19.1504020149200;\n\tTue, 29 Aug 2017 08:22:29 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170829180219-mutt-send-email-mst@kernel.org>","References":"<20170829144805.28872-1-marcandre.lureau@redhat.com>\n\t<20170829144805.28872-3-marcandre.lureau@redhat.com>\n\t<20170829180219-mutt-send-email-mst@kernel.org>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Tue, 29 Aug 2017 17:22:28 +0200","Message-ID":"","To":"\"Michael S. Tsirkin\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400c:c05::244","Subject":"Re: [Qemu-devel] [PATCH 2/2] vhost-user-bridge: fix resume\n\tregression (since 2.9)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Victor Kaplansky , QEMU ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759454,"web_url":"http://patchwork.ozlabs.org/comment/1759454/","msgid":"<20170829182742-mutt-send-email-mst@kernel.org>","list_archive_url":null,"date":"2017-08-29T15:27:50","subject":"Re: [Qemu-devel] [PATCH 2/2] vhost-user-bridge: fix resume\n\tregression (since 2.9)","submitter":{"id":2235,"url":"http://patchwork.ozlabs.org/api/people/2235/","name":"Michael S. Tsirkin","email":"mst@redhat.com"},"content":"On Tue, Aug 29, 2017 at 05:22:28PM +0200, Marc-André Lureau wrote:\n> Hi\n> \n> On Tue, Aug 29, 2017 at 5:02 PM, Michael S. Tsirkin wrote:\n> > On Tue, Aug 29, 2017 at 04:48:05PM +0200, Marc-André Lureau wrote:\n> >> Commit e10e798c85c2331 switched to libvhost-user which lacked support\n> >> for resuming the avail_idx based on used_idx.\n> >>\n> >> Fixes:\n> >> https://bugzilla.redhat.com/show_bug.cgi?id=1485867\n> >>\n> >> Signed-off-by: Marc-André Lureau \n> >\n> > Can we add a test for reconnect to catch the regression?\n> \n> There is no automated tests for vhost-user-bridge yet. We could\n> probably make one based on \"[PATCH v2 0/5] tests/pxe-test: add\n> testcase using vhost-user-bridge\" series.\n\nExactly.\n\n> We could also add seperate libvhost-user tests, that's not existent\n> yet, partly because libvhost-user was born as a test itself ;).\n> \n> >\n> >> ---\n> >> tests/vhost-user-bridge.c | 7 +++++++\n> >> 1 file changed, 7 insertions(+)\n> >>\n> >> diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c\n> >> index 1e5b5ca3da..dca48512ba 100644\n> >> --- a/tests/vhost-user-bridge.c\n> >> +++ b/tests/vhost-user-bridge.c\n> >> @@ -466,11 +466,18 @@ vubr_panic(VuDev *dev, const char *msg)\n> >> vubr->quit = 1;\n> >> }\n> >>\n> >> +static bool\n> >> +vubr_queue_resume_to_used(VuDev *dev, int qidx)\n> >> +{\n> >> + return true;\n> >> +}\n> >> +\n> >> static const VuDevIface vuiface = {\n> >> .get_features = vubr_get_features,\n> >> .set_features = vubr_set_features,\n> >> .process_msg = vubr_process_msg,\n> >> .queue_set_started = vubr_queue_set_started,\n> >> + .queue_resume_to_used = vubr_queue_resume_to_used,\n> >> };\n> >>\n> >> static void\n> >> --\n> >> 2.14.1.146.gd35faa819\n> >\n> \n> \n> \n> -- \n> Marc-André Lureau","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mst@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhXbB5Pbkz9t33\n\tfor ;\n\tWed, 30 Aug 2017 01:28:22 +1000 (AEST)","from localhost ([::1]:45494 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmiRA-0007kE-KQ\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 11:28:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45737)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmiQn-0007jw-SB\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:27:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmiQk-0001ZE-M9\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:27:57 -0400","from mx1.redhat.com ([209.132.183.28]:38056)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dmiQk-0001Yi-EI\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:27:54 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 01A256F0;\n\tTue, 29 Aug 2017 15:27:53 +0000 (UTC)","from redhat.com (ovpn-120-128.rdu2.redhat.com [10.10.120.128])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A722368885;\n\tTue, 29 Aug 2017 15:27:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 01A256F0","Date":"Tue, 29 Aug 2017 18:27:50 +0300","From":"\"Michael S. Tsirkin\" ","To":"=?iso-8859-1?q?Marc-Andr=E9?= Lureau ","Message-ID":"<20170829182742-mutt-send-email-mst@kernel.org>","References":"<20170829144805.28872-1-marcandre.lureau@redhat.com>\n\t<20170829144805.28872-3-marcandre.lureau@redhat.com>\n\t<20170829180219-mutt-send-email-mst@kernel.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 29 Aug 2017 15:27:53 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/2] vhost-user-bridge: fix resume\n\tregression (since 2.9)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Victor Kaplansky , QEMU ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]