[{"id":1762258,"web_url":"http://patchwork.ozlabs.org/comment/1762258/","msgid":"<20170903124934.GA5972@himanshu-Vostro-3559>","list_archive_url":null,"date":"2017-09-03T12:49:34","subject":"Re: [PATCH] rtc: remove cast to void pointer","submitter":{"id":72201,"url":"http://patchwork.ozlabs.org/api/people/72201/","name":"Himanshu Jha","email":"himanshujha199640@gmail.com"},"content":"On Tue, Aug 29, 2017 at 08:09:03PM +0530, Himanshu Jha wrote:\n> casting to void pointer from any pointer type and vice-versa is done\n> implicitly and therefore casting is not needed in such a case.\n>\n\nI hope my patch is in your queue, got no reply till now.\n\nThanks\n\n\n> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>\n> ---\n>  drivers/rtc/interface.c      | 4 ++--\n>  drivers/rtc/rtc-88pm80x.c    | 2 +-\n>  drivers/rtc/rtc-88pm860x.c   | 2 +-\n>  drivers/rtc/rtc-at32ap700x.c | 2 +-\n>  drivers/rtc/rtc-hym8563.c    | 2 +-\n>  drivers/rtc/rtc-m48t59.c     | 2 +-\n>  drivers/rtc/rtc-max8925.c    | 2 +-\n>  drivers/rtc/rtc-pic32.c      | 2 +-\n>  drivers/rtc/rtc-s3c.c        | 4 ++--\n>  drivers/rtc/rtc-st-lpc.c     | 2 +-\n>  drivers/rtc/rtc-stm32.c      | 2 +-\n>  drivers/rtc/rtc-sun6i.c      | 2 +-\n>  drivers/rtc/rtc-sunxi.c      | 2 +-\n>  drivers/rtc/rtc-vr41xx.c     | 4 ++--\n>  drivers/rtc/rtc-xgene.c      | 2 +-\n>  drivers/rtc/rtc-zynqmp.c     | 2 +-\n>  16 files changed, 19 insertions(+), 19 deletions(-)\n> \n> diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c\n> index 8cec9a0..81c85d2 100644\n> --- a/drivers/rtc/interface.c\n> +++ b/drivers/rtc/interface.c\n> @@ -528,7 +528,7 @@ void rtc_handle_legacy_irq(struct rtc_device *rtc, int num, int mode)\n>   */\n>  void rtc_aie_update_irq(void *private)\n>  {\n> -\tstruct rtc_device *rtc = (struct rtc_device *)private;\n> +\tstruct rtc_device *rtc = private;\n>  \trtc_handle_legacy_irq(rtc, 1, RTC_AF);\n>  }\n>  \n> @@ -541,7 +541,7 @@ void rtc_aie_update_irq(void *private)\n>   */\n>  void rtc_uie_update_irq(void *private)\n>  {\n> -\tstruct rtc_device *rtc = (struct rtc_device *)private;\n> +\tstruct rtc_device *rtc = private;\n>  \trtc_handle_legacy_irq(rtc, 1,  RTC_UF);\n>  }\n>  \n> diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c\n> index 466bf7f..819612e 100644\n> --- a/drivers/rtc/rtc-88pm80x.c\n> +++ b/drivers/rtc/rtc-88pm80x.c\n> @@ -60,7 +60,7 @@ struct pm80x_rtc_info {\n>  \n>  static irqreturn_t rtc_update_handler(int irq, void *data)\n>  {\n> -\tstruct pm80x_rtc_info *info = (struct pm80x_rtc_info *)data;\n> +\tstruct pm80x_rtc_info *info = data;\n>  \tint mask;\n>  \n>  \tmask = PM800_ALARM | PM800_ALARM_WAKEUP;\n> diff --git a/drivers/rtc/rtc-88pm860x.c b/drivers/rtc/rtc-88pm860x.c\n> index 19e53b3..67f7fa3 100644\n> --- a/drivers/rtc/rtc-88pm860x.c\n> +++ b/drivers/rtc/rtc-88pm860x.c\n> @@ -59,7 +59,7 @@ struct pm860x_rtc_info {\n>  \n>  static irqreturn_t rtc_update_handler(int irq, void *data)\n>  {\n> -\tstruct pm860x_rtc_info *info = (struct pm860x_rtc_info *)data;\n> +\tstruct pm860x_rtc_info *info = data;\n>  \tint mask;\n>  \n>  \tmask = ALARM | ALARM_WAKEUP;\n> diff --git a/drivers/rtc/rtc-at32ap700x.c b/drivers/rtc/rtc-at32ap700x.c\n> index de8bf56..f603f99 100644\n> --- a/drivers/rtc/rtc-at32ap700x.c\n> +++ b/drivers/rtc/rtc-at32ap700x.c\n> @@ -164,7 +164,7 @@ static int at32_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)\n>  \n>  static irqreturn_t at32_rtc_interrupt(int irq, void *dev_id)\n>  {\n> -\tstruct rtc_at32ap700x *rtc = (struct rtc_at32ap700x *)dev_id;\n> +\tstruct rtc_at32ap700x *rtc = dev_id;\n>  \tunsigned long isr = rtc_readl(rtc, ISR);\n>  \tunsigned long events = 0;\n>  \tint ret = IRQ_NONE;\n> diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c\n> index e5ad527..0709968 100644\n> --- a/drivers/rtc/rtc-hym8563.c\n> +++ b/drivers/rtc/rtc-hym8563.c\n> @@ -436,7 +436,7 @@ static struct clk *hym8563_clkout_register_clk(struct hym8563 *hym8563)\n>   */\n>  static irqreturn_t hym8563_irq(int irq, void *dev_id)\n>  {\n> -\tstruct hym8563 *hym8563 = (struct hym8563 *)dev_id;\n> +\tstruct hym8563 *hym8563 = dev_id;\n>  \tstruct i2c_client *client = hym8563->client;\n>  \tstruct mutex *lock = &hym8563->rtc->ops_lock;\n>  \tint data, ret;\n> diff --git a/drivers/rtc/rtc-m48t59.c b/drivers/rtc/rtc-m48t59.c\n> index d99a705..2e35f73 100644\n> --- a/drivers/rtc/rtc-m48t59.c\n> +++ b/drivers/rtc/rtc-m48t59.c\n> @@ -302,7 +302,7 @@ static int m48t59_rtc_proc(struct device *dev, struct seq_file *seq)\n>   */\n>  static irqreturn_t m48t59_rtc_interrupt(int irq, void *dev_id)\n>  {\n> -\tstruct device *dev = (struct device *)dev_id;\n> +\tstruct device *dev = dev_id;\n>  \tstruct platform_device *pdev = to_platform_device(dev);\n>  \tstruct m48t59_plat_data *pdata = dev_get_platdata(&pdev->dev);\n>  \tstruct m48t59_private *m48t59 = platform_get_drvdata(pdev);\n> diff --git a/drivers/rtc/rtc-max8925.c b/drivers/rtc/rtc-max8925.c\n> index 67d6fc2..45d7e40 100644\n> --- a/drivers/rtc/rtc-max8925.c\n> +++ b/drivers/rtc/rtc-max8925.c\n> @@ -74,7 +74,7 @@ struct max8925_rtc_info {\n>  \n>  static irqreturn_t rtc_update_handler(int irq, void *data)\n>  {\n> -\tstruct max8925_rtc_info *info = (struct max8925_rtc_info *)data;\n> +\tstruct max8925_rtc_info *info = data;\n>  \n>  \t/* disable ALARM0 except for 1SEC alarm */\n>  \tmax8925_set_bits(info->rtc, MAX8925_ALARM0_CNTL, 0x7f, 0);\n> diff --git a/drivers/rtc/rtc-pic32.c b/drivers/rtc/rtc-pic32.c\n> index 5cfb6df..04788c3 100644\n> --- a/drivers/rtc/rtc-pic32.c\n> +++ b/drivers/rtc/rtc-pic32.c\n> @@ -92,7 +92,7 @@ static void pic32_rtc_alarm_clk_enable(struct pic32_rtc_dev *pdata,\n>  \n>  static irqreturn_t pic32_rtc_alarmirq(int irq, void *id)\n>  {\n> -\tstruct pic32_rtc_dev *pdata = (struct pic32_rtc_dev *)id;\n> +\tstruct pic32_rtc_dev *pdata = id;\n>  \n>  \tclk_enable(pdata->clk);\n>  \trtc_update_irq(pdata->rtc, 1, RTC_AF | RTC_IRQF);\n> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c\n> index a8992c2..8e8a815 100644\n> --- a/drivers/rtc/rtc-s3c.c\n> +++ b/drivers/rtc/rtc-s3c.c\n> @@ -113,7 +113,7 @@ static void s3c_rtc_disable_clk(struct s3c_rtc *info)\n>  /* IRQ Handlers */\n>  static irqreturn_t s3c_rtc_tickirq(int irq, void *id)\n>  {\n> -\tstruct s3c_rtc *info = (struct s3c_rtc *)id;\n> +\tstruct s3c_rtc *info = id;\n>  \n>  \tif (info->data->irq_handler)\n>  \t\tinfo->data->irq_handler(info, S3C2410_INTP_TIC);\n> @@ -123,7 +123,7 @@ static irqreturn_t s3c_rtc_tickirq(int irq, void *id)\n>  \n>  static irqreturn_t s3c_rtc_alarmirq(int irq, void *id)\n>  {\n> -\tstruct s3c_rtc *info = (struct s3c_rtc *)id;\n> +\tstruct s3c_rtc *info = id;\n>  \n>  \tif (info->data->irq_handler)\n>  \t\tinfo->data->irq_handler(info, S3C2410_INTP_ALM);\n> diff --git a/drivers/rtc/rtc-st-lpc.c b/drivers/rtc/rtc-st-lpc.c\n> index 82b0af1..75eb92c 100644\n> --- a/drivers/rtc/rtc-st-lpc.c\n> +++ b/drivers/rtc/rtc-st-lpc.c\n> @@ -74,7 +74,7 @@ static void st_rtc_set_hw_alarm(struct st_rtc *rtc,\n>  \n>  static irqreturn_t st_rtc_handler(int this_irq, void *data)\n>  {\n> -\tstruct st_rtc *rtc = (struct st_rtc *)data;\n> +\tstruct st_rtc *rtc = data;\n>  \n>  \trtc_update_irq(rtc->rtc_dev, 1, RTC_AF);\n>  \n> diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c\n> index 3a5c3d7..66fc7ba 100644\n> --- a/drivers/rtc/rtc-stm32.c\n> +++ b/drivers/rtc/rtc-stm32.c\n> @@ -169,7 +169,7 @@ static int stm32_rtc_wait_sync(struct stm32_rtc *rtc)\n>  \n>  static irqreturn_t stm32_rtc_alarm_irq(int irq, void *dev_id)\n>  {\n> -\tstruct stm32_rtc *rtc = (struct stm32_rtc *)dev_id;\n> +\tstruct stm32_rtc *rtc = dev_id;\n>  \tunsigned int isr, cr;\n>  \n>  \tmutex_lock(&rtc->rtc_dev->ops_lock);\n> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c\n> index 305c4d0..496a8dd 100644\n> --- a/drivers/rtc/rtc-sun6i.c\n> +++ b/drivers/rtc/rtc-sun6i.c\n> @@ -256,7 +256,7 @@ CLK_OF_DECLARE_DRIVER(sun6i_rtc_clk, \"allwinner,sun6i-a31-rtc\",\n>  \n>  static irqreturn_t sun6i_rtc_alarmirq(int irq, void *id)\n>  {\n> -\tstruct sun6i_rtc_dev *chip = (struct sun6i_rtc_dev *) id;\n> +\tstruct sun6i_rtc_dev *chip = id;\n>  \tirqreturn_t ret = IRQ_NONE;\n>  \tu32 val;\n>  \n> diff --git a/drivers/rtc/rtc-sunxi.c b/drivers/rtc/rtc-sunxi.c\n> index abada60..f1f7fd7 100644\n> --- a/drivers/rtc/rtc-sunxi.c\n> +++ b/drivers/rtc/rtc-sunxi.c\n> @@ -158,7 +158,7 @@ struct sunxi_rtc_dev {\n>  \n>  static irqreturn_t sunxi_rtc_alarmirq(int irq, void *id)\n>  {\n> -\tstruct sunxi_rtc_dev *chip = (struct sunxi_rtc_dev *) id;\n> +\tstruct sunxi_rtc_dev *chip = id;\n>  \tu32 val;\n>  \n>  \tval = readl(chip->base + SUNXI_ALRM_IRQ_STA);\n> diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c\n> index 7ce2296..a0aa377 100644\n> --- a/drivers/rtc/rtc-vr41xx.c\n> +++ b/drivers/rtc/rtc-vr41xx.c\n> @@ -228,7 +228,7 @@ static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)\n>  \n>  static irqreturn_t elapsedtime_interrupt(int irq, void *dev_id)\n>  {\n> -\tstruct platform_device *pdev = (struct platform_device *)dev_id;\n> +\tstruct platform_device *pdev = dev_id;\n>  \tstruct rtc_device *rtc = platform_get_drvdata(pdev);\n>  \n>  \trtc2_write(RTCINTREG, ELAPSEDTIME_INT);\n> @@ -240,7 +240,7 @@ static irqreturn_t elapsedtime_interrupt(int irq, void *dev_id)\n>  \n>  static irqreturn_t rtclong1_interrupt(int irq, void *dev_id)\n>  {\n> -\tstruct platform_device *pdev = (struct platform_device *)dev_id;\n> +\tstruct platform_device *pdev = dev_id;\n>  \tstruct rtc_device *rtc = platform_get_drvdata(pdev);\n>  \tunsigned long count = periodic_count;\n>  \n> diff --git a/drivers/rtc/rtc-xgene.c b/drivers/rtc/rtc-xgene.c\n> index 65b432a..2b8247d 100644\n> --- a/drivers/rtc/rtc-xgene.c\n> +++ b/drivers/rtc/rtc-xgene.c\n> @@ -131,7 +131,7 @@ static const struct rtc_class_ops xgene_rtc_ops = {\n>  \n>  static irqreturn_t xgene_rtc_interrupt(int irq, void *id)\n>  {\n> -\tstruct xgene_rtc_dev *pdata = (struct xgene_rtc_dev *) id;\n> +\tstruct xgene_rtc_dev *pdata = id;\n>  \n>  \t/* Check if interrupt asserted */\n>  \tif (!(readl(pdata->csr_base + RTC_STAT) & RTC_STAT_BIT))\n> diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c\n> index da18a8a..f2f8a2d 100644\n> --- a/drivers/rtc/rtc-zynqmp.c\n> +++ b/drivers/rtc/rtc-zynqmp.c\n> @@ -193,7 +193,7 @@ static const struct rtc_class_ops xlnx_rtc_ops = {\n>  \n>  static irqreturn_t xlnx_rtc_interrupt(int irq, void *id)\n>  {\n> -\tstruct xlnx_rtc_dev *xrtcdev = (struct xlnx_rtc_dev *)id;\n> +\tstruct xlnx_rtc_dev *xrtcdev = id;\n>  \tunsigned int status;\n>  \n>  \tstatus = readl(xrtcdev->reg_base + RTC_INT_STS);\n> -- \n> 2.7.4\n>","headers":{"Return-Path":"<linux-rtc-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"gHg6eo81\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlXqz3nGcz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 22:49:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751934AbdICMtu (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tSun, 3 Sep 2017 08:49:50 -0400","from mail-pf0-f195.google.com ([209.85.192.195]:38904 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751765AbdICMtt (ORCPT\n\t<rfc822;linux-rtc@vger.kernel.org>); Sun, 3 Sep 2017 08:49:49 -0400","by mail-pf0-f195.google.com with SMTP id r187so2822277pfr.5;\n\tSun, 03 Sep 2017 05:49:49 -0700 (PDT)","from himanshu-Vostro-3559 ([103.254.204.108])\n\tby smtp.gmail.com with ESMTPSA id\n\tq186sm6670820pga.62.2017.09.03.05.49.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 03 Sep 2017 05:49:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=WfmPC3QEHz+nhNEWCL3mfbEMEQ+oAAaorAUsCPAvGJ8=;\n\tb=gHg6eo81UiphNBOENXZvdRwadeye6pT8Fj8i38rAQXvWF8yZI8GSavVV580X6UDHjz\n\thaMjybEq+NXP2TIbV6k89sbXkMtCAcdT3LQXiFy1kBAlCnvw1M3SMY3Ko0/2JTEHRKHk\n\tKJeJWravCfVjk9vGC/p5hnbRttB391DUuSi8LiZBhCwYsdvCM2AjtGfx4ZytuJE2apow\n\t+SIpzbxA6vyxgDBgOhlCF96wvmDaDIH7trEvmpyuWthRafLj24huZ2Yeh1H7b2hGn3Qv\n\t17KUo2QSWyts/p7zFOdLJMOin6gQgUj+MK6HZhrnYyo5Hhpb0j4tZWeoa3n6m8yVPWF0\n\tBknQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=WfmPC3QEHz+nhNEWCL3mfbEMEQ+oAAaorAUsCPAvGJ8=;\n\tb=Xu6U6tdzbhqR/WfklpHQ3IuxFMS1tgNbeQkIORCfZt2PUJVJfks7FEWW5HvZzwkSYV\n\t1wWN2o2ItlIyVSgPMH9Y60omtwTK8BYFWPIjINyYLSgK/4xdy9z7wk/8GNI/o2Y0kgOJ\n\tMN2eyjx80BdQlHWxRUw2PdzhpMACFkeI00QFNNhuJfbl2g5nb1mUAzAom/S0II47Y65g\n\t1xNu/JM8K+4b3Zykj2zNO3/b135uWhgaT4Z4X7kik0nVeBThOl1yxzAk0QvpfziE1p1r\n\tSmGoDiWT0ysbtecJj/Wkr8xZZdZWyb0e1on9Bs9zpEpGgLZWNuCIYZ+gAYncxmLRpu8B\n\t8M8w==","X-Gm-Message-State":"AHPjjUiXNR+MbTAfvE6Vn4Duy3g+miHVoYkQlQgy4mBrF0V+4XI47OnD\n\t0SVP1TtomysJAg==","X-Google-Smtp-Source":"ADKCNb7GJzmcYZwwAsXKcsYMzpUEwm5JizOT7P+73HMq/9m63g5mCjcG//mTPxcLLYNN6fbH/9adqA==","X-Received":"by 10.84.210.165 with SMTP id a34mr11683pli.59.1504442988645;\n\tSun, 03 Sep 2017 05:49:48 -0700 (PDT)","Date":"Sun, 3 Sep 2017 18:19:34 +0530","From":"Himanshu Jha <himanshujha199640@gmail.com>","To":"alexandre.belloni@free-electrons.com","Cc":"a.zummo@towertech.it, patrice.chotard@st.com,\n\tmcoquelin.stm32@gmail.com, maxime.ripard@free-electrons.com,\n\tmichal.simek@xilinx.com, linux-rtc@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH] rtc: remove cast to void pointer","Message-ID":"<20170903124934.GA5972@himanshu-Vostro-3559>","References":"<1504017543-19720-1-git-send-email-himanshujha199640@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504017543-19720-1-git-send-email-himanshujha199640@gmail.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-rtc.vger.kernel.org>","X-Mailing-List":"linux-rtc@vger.kernel.org"}}]