[{"id":1759547,"web_url":"http://patchwork.ozlabs.org/comment/1759547/","msgid":"<20170829170551.5uws25py4fcpem73@ast-mbp>","list_archive_url":null,"date":"2017-08-29T17:05:52","subject":"Re: [PATCH net-next 7/7] samples/bpf: xdp_monitor tool based on\n\ttracepoints","submitter":{"id":42586,"url":"http://patchwork.ozlabs.org/api/people/42586/","name":"Alexei Starovoitov","email":"alexei.starovoitov@gmail.com"},"content":"On Tue, Aug 29, 2017 at 04:38:11PM +0200, Jesper Dangaard Brouer wrote:\n> This tool xdp_monitor demonstrate how to use the different xdp_redirect\n> tracepoints xdp_redirect{,_map}{,_err} from a BPF program.\n> \n> The default mode is to only monitor the error counters, to avoid\n> affecting the per packet performance. Tracepoints comes with a base\n> overhead of 25 nanosec for an attached bpf_prog, and 48 nanosec for\n> using a full perf record (with non-matching filter). Thus, default\n> loading the --stats mode could affect the maximum performance.\n> \n> This version of the tool is very simple and count all types of errors\n> as one. It will be natural to extend this later with the different\n> types of errors that can occur, which should help users quickly\n> identify common mistakes.\n> \n> Because the TP_STRUCT was kept in sync all the tracepoints loads the\n> same BPF code. It would also be natural to extend the map version to\n> demonstrate how the map information could be used.\n> \n> Signed-off-by: Jesper Dangaard Brouer \n\nNice. Did you consider using libbbpf (instead of old bpf_load.c hack)\nand make full standalone tool out of it? Looks very useful.\nAcked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BXZBC8ES\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhZlq2rSkz9s76\n\tfor ;\n\tWed, 30 Aug 2017 03:05:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751231AbdH2RF5 (ORCPT );\n\tTue, 29 Aug 2017 13:05:57 -0400","from mail-pg0-f49.google.com ([74.125.83.49]:35874 \"EHLO\n\tmail-pg0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750779AbdH2RFz (ORCPT\n\t); Tue, 29 Aug 2017 13:05:55 -0400","by mail-pg0-f49.google.com with SMTP id r133so12478647pgr.3\n\tfor ; Tue, 29 Aug 2017 10:05:55 -0700 (PDT)","from ast-mbp ([2620:10d:c090:180::1:18ee])\n\tby smtp.gmail.com with ESMTPSA id\n\te82sm5474180pfh.51.2017.08.29.10.05.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 10:05:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=P9SsIC+tVbYkiJi90U53TejGMrIDmtQbmwaGMmgaZFI=;\n\tb=BXZBC8ES1sYv/rqIA4r7+2n2exypjwTKCw82uicrml5mvFW8JIXcP6pZIwOFVeq+F8\n\t4YNxuJRt1o74Sp0oDHBwufgO2GWOzinsgFWwVONKhsJC7XJ36ZLurHeV8/I6lF29QqN+\n\tTXjYDKaumVCfwhlFqKj73B6tYW/IgHlWxLy4SEQwffVuZP71JstUeiSJGggNjKjXcdjh\n\tg89pGrt0Y+wCGl49Zcvj6K7Z+Jp3X2rFizKJURJDPaXYFP+ItVC4LICw+GqGmUReqvWR\n\tdctZlQfqyVU5+sjH7ghrDvsOR4Bk/smLurgY6n7Z0OOD+a6LIrDOSzcqzl21rviFqUjV\n\t7Xsw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=P9SsIC+tVbYkiJi90U53TejGMrIDmtQbmwaGMmgaZFI=;\n\tb=eQYgKYmg9W1K4EoNbkB8Fsh1BVPZI84zmZqTI5ZRatyLBEVcdl6P54SHI/SQaimsU+\n\tLZOvkICLcf7bL72s9YZ4SV2JwBVc/aXrvsaAZYs6VjlB3oZAxGqzCu6gIgvgjs6nnjQr\n\tU3jJn1vndIDFGFegzkbj21fYc9ECyhtYery6NO0jtgc2oWeuofmDXfN2WpyyErndMxr5\n\t/0F1dXZY1FLEdUXsEPRwBGQrB1HlYK3e3KJZVrH/EoZrBywna7E+2/59A8oBVgJOi/oo\n\tZGBqaYJKOBPWdsTLNzkUCNsJGQFNBB8jVYbQ41FiV4RlBcP4WydTeagw9OusMR/Vh8yA\n\tBVOg==","X-Gm-Message-State":"AHYfb5i3LgtNATMiyMFvIG2BxypW65FWJ+Xc1GFFPVdg16qweuXx2Opx\n\tKO93dWGHa1+eq5p89W4=","X-Received":"by 10.98.192.20 with SMTP id x20mr994281pff.146.1504026355108;\n\tTue, 29 Aug 2017 10:05:55 -0700 (PDT)","Date":"Tue, 29 Aug 2017 10:05:52 -0700","From":"Alexei Starovoitov ","To":"Jesper Dangaard Brouer ","Cc":"netdev@vger.kernel.org, John Fastabend ","Subject":"Re: [PATCH net-next 7/7] samples/bpf: xdp_monitor tool based on\n\ttracepoints","Message-ID":"<20170829170551.5uws25py4fcpem73@ast-mbp>","References":"<150401743083.16384.15778781741742858567.stgit@firesoul>\n\t<150401749138.16384.17129327124102881342.stgit@firesoul>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<150401749138.16384.17129327124102881342.stgit@firesoul>","User-Agent":"NeoMutt/20170421 (1.8.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759564,"web_url":"http://patchwork.ozlabs.org/comment/1759564/","msgid":"<59A5A356.108@iogearbox.net>","list_archive_url":null,"date":"2017-08-29T17:24:38","subject":"Re: [PATCH net-next 7/7] samples/bpf: xdp_monitor tool based on\n\ttracepoints","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 08/29/2017 07:05 PM, Alexei Starovoitov wrote:\n> On Tue, Aug 29, 2017 at 04:38:11PM +0200, Jesper Dangaard Brouer wrote:\n>> This tool xdp_monitor demonstrate how to use the different xdp_redirect\n>> tracepoints xdp_redirect{,_map}{,_err} from a BPF program.\n>>\n>> The default mode is to only monitor the error counters, to avoid\n>> affecting the per packet performance. Tracepoints comes with a base\n>> overhead of 25 nanosec for an attached bpf_prog, and 48 nanosec for\n>> using a full perf record (with non-matching filter). Thus, default\n>> loading the --stats mode could affect the maximum performance.\n>>\n>> This version of the tool is very simple and count all types of errors\n>> as one. It will be natural to extend this later with the different\n>> types of errors that can occur, which should help users quickly\n>> identify common mistakes.\n>>\n>> Because the TP_STRUCT was kept in sync all the tracepoints loads the\n>> same BPF code. It would also be natural to extend the map version to\n>> demonstrate how the map information could be used.\n>>\n>> Signed-off-by: Jesper Dangaard Brouer \n>\n> Nice. Did you consider using libbbpf (instead of old bpf_load.c hack)\n> and make full standalone tool out of it? Looks very useful.\n\n+1 also my suggestion. ;)\n\n> Acked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhb9T18rZz9t2v\n\tfor ;\n\tWed, 30 Aug 2017 03:24:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751295AbdH2RYn (ORCPT );\n\tTue, 29 Aug 2017 13:24:43 -0400","from www62.your-server.de ([213.133.104.62]:44458 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751283AbdH2RYl (ORCPT\n\t); Tue, 29 Aug 2017 13:24:41 -0400","from [92.105.166.74] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dmkFi-00009G-NZ; Tue, 29 Aug 2017 19:24:38 +0200"],"Message-ID":"<59A5A356.108@iogearbox.net>","Date":"Tue, 29 Aug 2017 19:24:38 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Alexei Starovoitov ,\n\tJesper Dangaard Brouer ","CC":"netdev@vger.kernel.org, John Fastabend ","Subject":"Re: [PATCH net-next 7/7] samples/bpf: xdp_monitor tool based on\n\ttracepoints","References":"<150401743083.16384.15778781741742858567.stgit@firesoul>\n\t<150401749138.16384.17129327124102881342.stgit@firesoul>\n\t<20170829170551.5uws25py4fcpem73@ast-mbp>","In-Reply-To":"<20170829170551.5uws25py4fcpem73@ast-mbp>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23734/Tue Aug 29 14:38:29 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]