[{"id":1760259,"web_url":"http://patchwork.ozlabs.org/comment/1760259/","msgid":"<20170830150357.GD5920@quack2.suse.cz>","list_archive_url":null,"date":"2017-08-30T15:03:57","subject":"Re: [PATCH 2/4] iomap: Add IOMAP_F_DATA_INLINE flag","submitter":{"id":363,"url":"http://patchwork.ozlabs.org/api/people/363/","name":"Jan Kara","email":"jack@suse.cz"},"content":"On Tue 29-08-17 16:29:40, Andreas Gruenbacher wrote:\n> Add a new IOMAP_F_DATA_INLINE flag to indicate that a mapping is in a\n> disk area that contains data as well as metadata. In iomap_fiemap, map\n> this flag to FIEMAP_EXTENT_DATA_INLINE.\n> \n> Signed-off-by: Andreas Gruenbacher \n\nLooks good to me. You can add:\n\nReviewed-by: Jan Kara \n\n\t\t\t\t\t\t\t\tHonza\n\n> ---\n> fs/iomap.c | 2 ++\n> include/linux/iomap.h | 5 +++--\n> 2 files changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/fs/iomap.c b/fs/iomap.c\n> index 7bc1797c2292..f0a263482a0e 100644\n> --- a/fs/iomap.c\n> +++ b/fs/iomap.c\n> @@ -510,6 +510,8 @@ static int iomap_to_fiemap(struct fiemap_extent_info *fi,\n> \t\tflags |= FIEMAP_EXTENT_MERGED;\n> \tif (iomap->flags & IOMAP_F_SHARED)\n> \t\tflags |= FIEMAP_EXTENT_SHARED;\n> +\tif (iomap->flags & IOMAP_F_DATA_INLINE)\n> +\t\tflags |= FIEMAP_EXTENT_DATA_INLINE;\n> \n> \treturn fiemap_fill_next_extent(fi, iomap->offset,\n> \t\t\tiomap->addr != IOMAP_NULL_ADDR ? iomap->addr : 0,\n> diff --git a/include/linux/iomap.h b/include/linux/iomap.h\n> index 7b8a615fa021..2b0790dbd6ea 100644\n> --- a/include/linux/iomap.h\n> +++ b/include/linux/iomap.h\n> @@ -26,8 +26,9 @@ struct vm_fault;\n> /*\n> * Flags that only need to be reported for IOMAP_REPORT requests:\n> */\n> -#define IOMAP_F_MERGED\t0x10\t/* contains multiple blocks/extents */\n> -#define IOMAP_F_SHARED\t0x20\t/* block shared with another file */\n> +#define IOMAP_F_MERGED\t\t0x10\t/* contains multiple blocks/extents */\n> +#define IOMAP_F_SHARED\t\t0x20\t/* block shared with another file */\n> +#define IOMAP_F_DATA_INLINE\t0x40\t/* data inline in the inode */\n> \n> /*\n> * Magic value for addr:\n> -- \n> 2.13.3\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj80g0MxHz9sN7\n\tfor ;\n\tThu, 31 Aug 2017 01:04:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751662AbdH3PEB (ORCPT );\n\tWed, 30 Aug 2017 11:04:01 -0400","from mx2.suse.de ([195.135.220.15]:38104 \"EHLO mx1.suse.de\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751455AbdH3PEA (ORCPT );\n\tWed, 30 Aug 2017 11:04:00 -0400","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id CE30AAC0B;\n\tWed, 30 Aug 2017 15:03:58 +0000 (UTC)","by quack2.suse.cz (Postfix, from userid 1000)\n\tid 55AC21E3414; Wed, 30 Aug 2017 17:03:57 +0200 (CEST)"],"X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","Date":"Wed, 30 Aug 2017 17:03:57 +0200","From":"Jan Kara ","To":"Andreas Gruenbacher ","Cc":"linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,\n\tlinux-xfs@vger.kernel.org, Jan Kara ,\n\tChristoph Hellwig ","Subject":"Re: [PATCH 2/4] iomap: Add IOMAP_F_DATA_INLINE flag","Message-ID":"<20170830150357.GD5920@quack2.suse.cz>","References":"<20170829142942.21594-1-agruenba@redhat.com>\n\t<20170829142942.21594-3-agruenba@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829142942.21594-3-agruenba@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}}]