[{"id":1759998,"web_url":"http://patchwork.ozlabs.org/comment/1759998/","msgid":"","list_archive_url":null,"date":"2017-08-30T09:38:43","subject":"Re: [Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Tue 29 Aug 2017 04:23:06 PM CEST, Pradeep Jagadeesh wrote:\n\n> +static void print_fsdev_throttle_config(Monitor *mon, IOThrottle *fscfg,\n> + Error *err)\n> +{\n> + monitor_printf(mon, \"%s\", fscfg->id);\n> + monitor_printf(mon, \" I/O throttling:\"\n> + \" bps=%\" PRId64\n> + \" bps_rd=%\" PRId64 \" bps_wr=%\" PRId64\n> + \" bps_max=%\" PRId64\n> + \" bps_rd_max=%\" PRId64\n> + \" bps_wr_max=%\" PRId64\n> + \" iops=%\" PRId64 \" iops_rd=%\" PRId64\n> + \" iops_wr=%\" PRId64\n> + \" iops_max=%\" PRId64\n> + \" iops_rd_max=%\" PRId64\n> + \" iops_wr_max=%\" PRId64\n> + \" iops_size=%\" PRId64\n> + \"\\n\",\n> + fscfg->bps,\n> + fscfg->bps_rd,\n> + fscfg->bps_wr,\n> + fscfg->bps_max,\n> + fscfg->bps_rd_max,\n> + fscfg->bps_wr_max,\n> + fscfg->iops,\n> + fscfg->iops_rd,\n> + fscfg->iops_wr,\n> + fscfg->iops_max,\n> + fscfg->iops_rd_max,\n> + fscfg->iops_wr_max,\n> + fscfg->iops_size);\n> + hmp_handle_error(mon, &err);\n> +}\n> +\n> +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict)\n> +{\n> + Error *err = NULL;\n> + IOThrottleList *fsdev_list, *info;\n> + fsdev_list = qmp_query_fsdev_io_throttle(&err);\n> +\n> + for (info = fsdev_list; info; info = info->next) {\n> + print_fsdev_throttle_config(mon, info->value, err);\n> + }\n> + qapi_free_IOThrottleList(fsdev_list);\n> +}\n\nI don't think what you're doing with the Error here is right:\n\n - You store the error returned by qmp_query_fsdev_io_throttle().\n - You report the error for _every_ fsdev in the list. That doesn't\n make much sense.\n - Furthermore, if there's an error then fsdev_list should be empty,\n so you're not reporting anything (and you're leaking the error).\n - Even if the list was not empty, hmp_handle_error() frees the error\n after reporting it. Therefore the second item in the list would\n try to report an error that has already been freed.\n\nBerto","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"Jw3+UWxz\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj0pr00tWz9sN7\n\tfor ;\n\tWed, 30 Aug 2017 19:40:02 +1000 (AEST)","from localhost ([::1]:49339 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmzTc-0002kz-1s\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 05:40:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52209)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmzTF-0002kp-Vj\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 05:39:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmzTC-0006bF-O8\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 05:39:38 -0400","from fanzine.igalia.com ([91.117.99.155]:54388)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dmzTC-0006WD-C7\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 05:39:34 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dmzSN-0006au-6g; Wed, 30 Aug 2017 11:38:43 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dmzSN-0007Tn-4A; Wed, 30 Aug 2017 11:38:43 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=S8Zk5yxYtkOlcH0yCG7NTtKyUlId4Qw6MtAQrRrUW0U=; \n\tb=Jw3+UWxz2xut4aWxOkOHVTdC3yEJtYueFfuKKP5eqep9pmHqXjVIPJ2FOcZe9PUd5TUvSFmIsh4B9h2B5nlynrzV1t38dkYbuzMXA+Ot7pgh50xmjUaZNyx5tMS0c9USXElzMX4BRk2t4lF2ueemBxDEs/8lryVvWG+dR2Qo+pF9ag1tT4WlbP9zzBAyad+c3eBtgGhOcHAiwtuq8opyjOY+FaEPzwB7j+3h9Tw3ce292AFzTA/gYY8XwjGthOkFiEvm/JRXvhQnen3+rXUgtMgBHI+XkV8Ng3qVjXgSzyqZhFmbrdA+dG0+610rJZnazbgXjdLW402W1ofkmesRnQ==;","From":"Alberto Garcia ","To":"Pradeep Jagadeesh ,\n\teric blake , greg kurz ","In-Reply-To":"<1504016587-39779-6-git-send-email-pradeep.jagadeesh@huawei.com>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1504016587-39779-6-git-send-email-pradeep.jagadeesh@huawei.com>","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Wed, 30 Aug 2017 11:38:43 +0200","Message-ID":"","MIME-Version":"1.0","Content-Type":"text/plain","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, jani kokkonen ,\n\tPradeep Jagadeesh ,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762600,"web_url":"http://patchwork.ozlabs.org/comment/1762600/","msgid":"<4b22589d-8299-e4e6-c2f0-9860ea1d0788@huawei.com>","list_archive_url":null,"date":"2017-09-04T12:22:40","subject":"Re: [Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 8/30/2017 11:38 AM, Alberto Garcia wrote:\n> On Tue 29 Aug 2017 04:23:06 PM CEST, Pradeep Jagadeesh wrote:\n>\n>> +static void print_fsdev_throttle_config(Monitor *mon, IOThrottle *fscfg,\n>> + Error *err)\n>> +{\n>> + monitor_printf(mon, \"%s\", fscfg->id);\n>> + monitor_printf(mon, \" I/O throttling:\"\n>> + \" bps=%\" PRId64\n>> + \" bps_rd=%\" PRId64 \" bps_wr=%\" PRId64\n>> + \" bps_max=%\" PRId64\n>> + \" bps_rd_max=%\" PRId64\n>> + \" bps_wr_max=%\" PRId64\n>> + \" iops=%\" PRId64 \" iops_rd=%\" PRId64\n>> + \" iops_wr=%\" PRId64\n>> + \" iops_max=%\" PRId64\n>> + \" iops_rd_max=%\" PRId64\n>> + \" iops_wr_max=%\" PRId64\n>> + \" iops_size=%\" PRId64\n>> + \"\\n\",\n>> + fscfg->bps,\n>> + fscfg->bps_rd,\n>> + fscfg->bps_wr,\n>> + fscfg->bps_max,\n>> + fscfg->bps_rd_max,\n>> + fscfg->bps_wr_max,\n>> + fscfg->iops,\n>> + fscfg->iops_rd,\n>> + fscfg->iops_wr,\n>> + fscfg->iops_max,\n>> + fscfg->iops_rd_max,\n>> + fscfg->iops_wr_max,\n>> + fscfg->iops_size);\n>> + hmp_handle_error(mon, &err);\n>> +}\n>> +\n>> +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict)\n>> +{\n>> + Error *err = NULL;\n>> + IOThrottleList *fsdev_list, *info;\n>> + fsdev_list = qmp_query_fsdev_io_throttle(&err);\n>> +\n>> + for (info = fsdev_list; info; info = info->next) {\n>> + print_fsdev_throttle_config(mon, info->value, err);\n>> + }\n>> + qapi_free_IOThrottleList(fsdev_list);\n>> +}\n>\n> I don't think what you're doing with the Error here is right:\n>\n> - You store the error returned by qmp_query_fsdev_io_throttle().\n> - You report the error for _every_ fsdev in the list. That doesn't\n> make much sense.\n> - Furthermore, if there's an error then fsdev_list should be empty,\n> so you're not reporting anything (and you're leaking the error).\n> - Even if the list was not empty, hmp_handle_error() frees the error\n> after reporting it. Therefore the second item in the list would\n> try to report an error that has already been freed.\nYou mean something like below?\n\nfsdev_list = qmp_query_fsdev_io_throttle(&err);\nif (err) {\n error_report_err(err);\n return;\n}\n\nRegards,\nPradeep\n>\n> Berto\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm8Dn3rMHz9t1G\n\tfor ;\n\tMon, 4 Sep 2017 22:24:53 +1000 (AEST)","from localhost ([::1]:59376 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doqQr-0003U7-G3\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 08:24:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50843)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doqQB-0003Sa-Jj\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:24:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doqQ6-0003KC-QP\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:24:07 -0400","from lhrrgout.huawei.com ([194.213.3.17]:22864)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from ) id 1doqQ6-0003EF-7X\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:24:02 -0400","from 172.18.7.190 (EHLO lhreml704-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DNW51119; Mon, 04 Sep 2017 12:23:10 +0000 (GMT)","from [127.0.0.1] (10.210.165.55) by lhreml704-cah.china.huawei.com\n\t(10.201.108.45) with Microsoft SMTP Server id 14.3.301.0;\n\tMon, 4 Sep 2017 13:22:50 +0100"],"To":"Alberto Garcia , Pradeep Jagadeesh\n\t, eric blake , greg kurz\n\t","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1504016587-39779-6-git-send-email-pradeep.jagadeesh@huawei.com>\n\t","From":"Pradeep Jagadeesh ","Message-ID":"<4b22589d-8299-e4e6-c2f0-9860ea1d0788@huawei.com>","Date":"Mon, 4 Sep 2017 14:22:40 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.165.55]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020203.59AD45AF.0101, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"53fc3d9f8b99cadab5bb5e6ee1c5ac31","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jani kokkonen ,\n\t\"Dr. David Alan Gilbert\" , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762638,"web_url":"http://patchwork.ozlabs.org/comment/1762638/","msgid":"","list_archive_url":null,"date":"2017-09-04T13:05:19","subject":"Re: [Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Mon 04 Sep 2017 02:22:40 PM CEST, Pradeep Jagadeesh wrote:\n>>> +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict)\n>>> +{\n>>> + Error *err = NULL;\n>>> + IOThrottleList *fsdev_list, *info;\n>>> + fsdev_list = qmp_query_fsdev_io_throttle(&err);\n>>> +\n>>> + for (info = fsdev_list; info; info = info->next) {\n>>> + print_fsdev_throttle_config(mon, info->value, err);\n>>> + }\n>>> + qapi_free_IOThrottleList(fsdev_list);\n>>> +}\n>>\n>> I don't think what you're doing with the Error here is right:\n>>\n>> - You store the error returned by qmp_query_fsdev_io_throttle().\n>> - You report the error for _every_ fsdev in the list. That doesn't\n>> make much sense.\n>> - Furthermore, if there's an error then fsdev_list should be empty,\n>> so you're not reporting anything (and you're leaking the error).\n>> - Even if the list was not empty, hmp_handle_error() frees the error\n>> after reporting it. Therefore the second item in the list would\n>> try to report an error that has already been freed.\n> You mean something like below?\n>\n> fsdev_list = qmp_query_fsdev_io_throttle(&err);\n> if (err) {\n> error_report_err(err);\n> return;\n> }\n\nMore or less, but there's hmp_handle_error() already, so you should use\nit:\n\n void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict)\n {\n Error *err = NULL;\n IOThrottleList *fsdev_list, *info;\n fsdev_list = qmp_query_fsdev_io_throttle(&err);\n\n for (info = fsdev_list; info; info = info->next) {\n print_fsdev_throttle_config(mon, info->value);\n }\n qapi_free_IOThrottleList(fsdev_list);\n\n hmp_handle_error(mon, &err);\n }\n\nAnyway I just checked that fsdev_get_io_throttle() can never return an\nError, so why don't you remove the Error parameter from there\naltogether?\n\nYou still need it in qmp_query_fsdev_io_throttle() because that's part\nof the API, and hmp_info_fsdev_iothrottle() should have the code to\nhandle it like the one I just pasted, but fsdev_get_io_throttle() does\nnot need it, or does it?\n\nBerto","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"Bh32c8vp\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm9mr67Vtz9t2c\n\tfor ;\n\tMon, 4 Sep 2017 23:34:20 +1000 (AEST)","from localhost ([::1]:41841 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dorW6-0005pI-T1\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 09:34:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50921)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dor7Q-00068w-M6\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 09:10:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dor4w-0004Sb-8O\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 09:08:48 -0400","from fanzine.igalia.com ([91.117.99.155]:47389)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dor4v-0003jz-Rn\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 09:06:14 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dor43-0007nG-5Y; Mon, 04 Sep 2017 15:05:19 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dor43-0003ja-2z; Mon, 04 Sep 2017 15:05:19 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=PRwEHSg74Q2KWOwnFrW7FLd31ccqjorf36GhboaMkKQ=; \n\tb=Bh32c8vphIYUg4JUFulaGpbaNbhtfTHoR+45uscwpeZ1i1qPASXG6Im60o+8dvN/Ku5+RMg+B9EEBPrOACn8T/Nhd263HtYskZnGUTUATnO0mvzJD2SPWjcvaKPL7JhN55YJ0NoZyQZpUMumrLBaeIyx37wpS9nepAbbUwvz6AJwvcbQ5TGAUwH1qrkiWq3oz9JyvxEb8fftjpZsJGCMFyI+FLd5IoI1TuzN1hzHAHPu17+bSURP5CHXcfy20em744L4VCPX9hklL0TL0cuEjPRMr1GtIyZkU98oT3adFLhcx/5dXzBBxFavHjQPB6/QuMPlK0VS+E4fhTjTLFLiIQ==;","From":"Alberto Garcia ","To":"Pradeep Jagadeesh ,\n\tPradeep Jagadeesh ,\n\teric blake , greg kurz ","In-Reply-To":"<4b22589d-8299-e4e6-c2f0-9860ea1d0788@huawei.com>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1504016587-39779-6-git-send-email-pradeep.jagadeesh@huawei.com>\n\t\n\t<4b22589d-8299-e4e6-c2f0-9860ea1d0788@huawei.com>","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Mon, 04 Sep 2017 15:05:19 +0200","Message-ID":"","MIME-Version":"1.0","Content-Type":"text/plain","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jani kokkonen ,\n\t\"Dr. David Alan Gilbert\" , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]