[{"id":1759381,"web_url":"http://patchwork.ozlabs.org/comment/1759381/","msgid":"<20170829142011.76w67w64a7lheef4@piout.net>","list_archive_url":null,"date":"2017-08-29T14:20:11","subject":"Re: [PATCH] rtc: Use PTR_ERR_OR_ZERO","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"Hi,\n\nOn 29/08/2017 at 19:16:59 +0530, Himanshu Jha wrote:\n> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n> \n\nI'm not taking that kind of useless changes (especially since it make\nthe code less readable) unless you have other significant improvement in\nthose drivers.\n\n> Signed-off-by: Himanshu Jha \n> ---\n> drivers/rtc/rtc-digicolor.c | 5 +----\n> drivers/rtc/rtc-ds1347.c | 5 +----\n> 2 files changed, 2 insertions(+), 8 deletions(-)\n> \n> diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c\n> index b253bf1..1e200a0 100644\n> --- a/drivers/rtc/rtc-digicolor.c\n> +++ b/drivers/rtc/rtc-digicolor.c\n> @@ -202,10 +202,7 @@ static int __init dc_rtc_probe(struct platform_device *pdev)\n> \tplatform_set_drvdata(pdev, rtc);\n> \trtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name,\n> \t\t\t\t\t\t&dc_rtc_ops, THIS_MODULE);\n> -\tif (IS_ERR(rtc->rtc_dev))\n> -\t\treturn PTR_ERR(rtc->rtc_dev);\n> -\n> -\treturn 0;\n> +\treturn PTR_ERR_OR_ZERO(rtc->rtc_dev);\n> }\n> \n> static const struct of_device_id dc_dt_ids[] = {\n> diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c\n> index ccfc9d4..9a02ca7 100644\n> --- a/drivers/rtc/rtc-ds1347.c\n> +++ b/drivers/rtc/rtc-ds1347.c\n> @@ -155,10 +155,7 @@ static int ds1347_probe(struct spi_device *spi)\n> \trtc = devm_rtc_device_register(&spi->dev, \"ds1347\",\n> \t\t\t\t&ds1347_rtc_ops, THIS_MODULE);\n> \n> -\tif (IS_ERR(rtc))\n> -\t\treturn PTR_ERR(rtc);\n> -\n> -\treturn 0;\n> +\treturn PTR_ERR_OR_ZERO(rtc);\n> }\n> \n> static struct spi_driver ds1347_driver = {\n> -- \n> 2.7.4\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhW4Z1Sl6z9t3J\n\tfor ;\n\tWed, 30 Aug 2017 00:20:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751945AbdH2OUN (ORCPT );\n\tTue, 29 Aug 2017 10:20:13 -0400","from mail.free-electrons.com ([62.4.15.54]:60064 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751804AbdH2OUM (ORCPT\n\t); Tue, 29 Aug 2017 10:20:12 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 750EB21F46; Tue, 29 Aug 2017 16:20:10 +0200 (CEST)","from localhost (unknown [88.191.26.124])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 4C78E21F42;\n\tTue, 29 Aug 2017 16:20:10 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 29 Aug 2017 16:20:11 +0200","From":"Alexandre Belloni ","To":"Himanshu Jha ","Cc":"a.zummo@towertech.it, baruch@tkos.co.il, linux-rtc@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] rtc: Use PTR_ERR_OR_ZERO","Message-ID":"<20170829142011.76w67w64a7lheef4@piout.net>","References":"<1504014419-16894-1-git-send-email-himanshujha199640@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504014419-16894-1-git-send-email-himanshujha199640@gmail.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1759405,"web_url":"http://patchwork.ozlabs.org/comment/1759405/","msgid":"<20170829144404.GA19791@himanshu-Vostro-3559>","list_archive_url":null,"date":"2017-08-29T14:44:04","subject":"Re: [PATCH] rtc: Use PTR_ERR_OR_ZERO","submitter":{"id":72201,"url":"http://patchwork.ozlabs.org/api/people/72201/","name":"Himanshu Jha","email":"himanshujha199640@gmail.com"},"content":"On Tue, Aug 29, 2017 at 04:20:11PM +0200, Alexandre Belloni wrote:\n> Hi,\n> \n> On 29/08/2017 at 19:16:59 +0530, Himanshu Jha wrote:\n> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n> > \n> \n> I'm not taking that kind of useless changes (especially since it make\n> the code less readable) unless you have other significant improvement in\n> those drivers.\n\nApologies!! I got this change accepted in staging, and didn't think\nabout it's readability.\n\n\nThanks\n\n\n> \n> > Signed-off-by: Himanshu Jha \n> > ---\n> > drivers/rtc/rtc-digicolor.c | 5 +----\n> > drivers/rtc/rtc-ds1347.c | 5 +----\n> > 2 files changed, 2 insertions(+), 8 deletions(-)\n> > \n> > diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c\n> > index b253bf1..1e200a0 100644\n> > --- a/drivers/rtc/rtc-digicolor.c\n> > +++ b/drivers/rtc/rtc-digicolor.c\n> > @@ -202,10 +202,7 @@ static int __init dc_rtc_probe(struct platform_device *pdev)\n> > \tplatform_set_drvdata(pdev, rtc);\n> > \trtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name,\n> > \t\t\t\t\t\t&dc_rtc_ops, THIS_MODULE);\n> > -\tif (IS_ERR(rtc->rtc_dev))\n> > -\t\treturn PTR_ERR(rtc->rtc_dev);\n> > -\n> > -\treturn 0;\n> > +\treturn PTR_ERR_OR_ZERO(rtc->rtc_dev);\n> > }\n> > \n> > static const struct of_device_id dc_dt_ids[] = {\n> > diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c\n> > index ccfc9d4..9a02ca7 100644\n> > --- a/drivers/rtc/rtc-ds1347.c\n> > +++ b/drivers/rtc/rtc-ds1347.c\n> > @@ -155,10 +155,7 @@ static int ds1347_probe(struct spi_device *spi)\n> > \trtc = devm_rtc_device_register(&spi->dev, \"ds1347\",\n> > \t\t\t\t&ds1347_rtc_ops, THIS_MODULE);\n> > \n> > -\tif (IS_ERR(rtc))\n> > -\t\treturn PTR_ERR(rtc);\n> > -\n> > -\treturn 0;\n> > +\treturn PTR_ERR_OR_ZERO(rtc);\n> > }\n> > \n> > static struct spi_driver ds1347_driver = {\n> > -- \n> > 2.7.4\n> > \n> \n> -- \n> Alexandre Belloni, Free Electrons\n> Embedded Linux and Kernel engineering\n> http://free-electrons.com","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fB2dzgHg\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhWcM0p3Kz9s7f\n\tfor ;\n\tWed, 30 Aug 2017 00:44:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754526AbdH2OoS (ORCPT );\n\tTue, 29 Aug 2017 10:44:18 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:35575 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753582AbdH2OoR (ORCPT\n\t); Tue, 29 Aug 2017 10:44:17 -0400","by mail-pg0-f67.google.com with SMTP id r133so2884089pgr.2;\n\tTue, 29 Aug 2017 07:44:17 -0700 (PDT)","from himanshu-Vostro-3559 ([103.254.204.108])\n\tby smtp.gmail.com with ESMTPSA id\n\ts23sm7572655pgn.56.2017.08.29.07.44.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 07:44:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=o2KDr0CrW1ShjFtq9LpgMQypTmB2XOeDMYJOKTd0HaA=;\n\tb=fB2dzgHgM9IMJrzkVLUKpZzfk1ICKut2vbccSBNPZ7jWw+sryfv/449LQCeaFFH7f3\n\td8by00pHFenC4sZMCIkVw4spgfkB7couIcH/PWmK3fzsO6pnQji+/x2vIr71Q44Y6L4V\n\tgMu2/rbf/MFatOWSJ6AKJo/LDYtvYqo5wXwfIbPwKACp9Fop1mEbL+n8OVlXVl5djFOP\n\t8Y4m1hUzfGMUwWt3VGAMQyq9bWvQuEdkuXlPi8DF9vQChBJiolZdo04+dV7A7ZMFWTxV\n\tZPazcteLhSwELtsiWyfcXc+e/b1PMY6mzI7TmHWNKtqNtPbqvb5wBh3PydvqYryd6t8n\n\thHTw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=o2KDr0CrW1ShjFtq9LpgMQypTmB2XOeDMYJOKTd0HaA=;\n\tb=RCZgceA1oAPU3r9CvBe7zkHC8SAB7roD7kh0MonuusiOLDH1/UDmgCZjtmMKf9Dzxt\n\tlr1HKpfk3UANA8R1BLnCDXh+LLNd39cN7npPT8PqCQqML3OkuUlbJF1jwqTe0HYTenj4\n\tjo5p2UdD1kVTN9SokXMPDFXLLG+2jIwONHkaU6fpJkPm1YW/SrkpxBBl/FJjZrXBzaUk\n\t2VhQd1EmxV44wnlHDvGQIM5tjErGG/JXxm3wdB4ExCmpEpT6H3+cd4zN9efPZKNjNNo0\n\tyAIcRoNKAzPxCbwCYMd3+AT/NehUtvk8njG8/ZpJ5EUgxsrfh/7cjWj7BwPP0l6mQQ+v\n\tlZIw==","X-Gm-Message-State":"AHYfb5gTH3gExV97O6+DWZPTVA8U02a6jizQViAdRSsTeVFTTaAIETMT\n\tYJNBPuz7HZecjZWZQ8kwGQ==","X-Google-Smtp-Source":"ADKCNb6a2ohN/VwriSf/ngTl2EDrLT87NKiZaTiroZRJcqQrbVmEqQG/NNX1W8YS8lKV0s8pRQp18g==","X-Received":"by 10.101.77.6 with SMTP id i6mr529040pgt.129.1504017857087;\n\tTue, 29 Aug 2017 07:44:17 -0700 (PDT)","Date":"Tue, 29 Aug 2017 20:14:04 +0530","From":"Himanshu Jha ","To":"Alexandre Belloni ","Cc":"a.zummo@towertech.it, baruch@tkos.co.il, linux-rtc@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] rtc: Use PTR_ERR_OR_ZERO","Message-ID":"<20170829144404.GA19791@himanshu-Vostro-3559>","References":"<1504014419-16894-1-git-send-email-himanshujha199640@gmail.com>\n\t<20170829142011.76w67w64a7lheef4@piout.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829142011.76w67w64a7lheef4@piout.net>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}}]