[{"id":1759364,"web_url":"http://patchwork.ozlabs.org/comment/1759364/","msgid":"","list_archive_url":null,"date":"2017-08-29T14:00:26","subject":"Re: [PATCH 1/2 v4] openpty: close slave pty fd on error","submitter":{"id":37,"url":"http://patchwork.ozlabs.org/api/people/37/","name":"Andreas Schwab","email":"schwab@suse.de"},"content":"On Aug 29 2017, Christian Brauner wrote:\n\n> @@ -129,12 +124,17 @@ openpty (int *amaster, int *aslave, char *name,\n> if (name != NULL)\n> strcpy (name, buf);\n> \n> + ret = 0;\n> +\n> + on_error:\n> + close (master);\n> +\n> + if (slave != -1)\n> + close(slave);\n> +\n\nYou don't want to close the fds on success.\n\nAndreas.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83820-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"U2oepx3F\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhVfT4XXGz9t33\n\tfor ;\n\tWed, 30 Aug 2017 00:01:05 +1000 (AEST)","(qmail 70054 invoked by alias); 29 Aug 2017 14:00:55 -0000","(qmail 57447 invoked by uid 89); 29 Aug 2017 14:00:43 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; q=dns; s=default; b=hnj+O\n\t1dbrxkrHjdszRjmTWMmb4kI0AiH5v9zXh6de+WyTnkhSkSp4nuhrGclAvEIBDkuB\n\tPSi/pGwpPT7sa5hlQenmcjBL4y+58QBj59S4ToSEQh4TcxPbrKwubHfByQVlKe+s\n\thpkzOJ6Uj4AMcJtAZvgXrEILDiqMam+qdAVSks=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; s=default; bh=QQ/hjM1LBgY\n\tZ8I8Imr6tdfkqrcQ=; b=U2oepx3FKRoLzR0GjSHt6KRGMMZWVtogB+aiu2CkzTU\n\tQQOGgJNRoGBL13/kAoytdu+DDGwheZkaSt0t7OAGG7Mb0SAy+qVJ0+n139Kdn4Kd\n\tiKNCLcrfiWWn1w+Ux6Hhfo1wqP/7emIpAkkz/1PukCQLFuut8fHRLMZKl4U21+y0\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","From":"Andreas Schwab ","To":"Christian Brauner ","Cc":"libc-alpha@sourceware.org, stgraber@stgraber.org, serge@hallyn.com,\n\tfweimer@redhat.com, joseph@codesourcery.com","Subject":"Re: [PATCH 1/2 v4] openpty: close slave pty fd on error","References":"\n\t<20170829134515.9345-1-christian.brauner@ubuntu.com>","X-Yow":"YOW!! Up ahead! It's a DONUT HUT!!","Date":"Tue, 29 Aug 2017 16:00:26 +0200","In-Reply-To":"<20170829134515.9345-1-christian.brauner@ubuntu.com> (Christian\n\tBrauner's message of \"Tue, 29 Aug 2017 15:45:14 +0200\")","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain"}},{"id":1759372,"web_url":"http://patchwork.ozlabs.org/comment/1759372/","msgid":"<20170829141207.fuhxzfqihtw6ixb7@gmail.com>","list_archive_url":null,"date":"2017-08-29T14:12:07","subject":"Re: [PATCH 1/2 v4] openpty: close slave pty fd on error","submitter":{"id":70356,"url":"http://patchwork.ozlabs.org/api/people/70356/","name":"Christian Brauner","email":"christian.brauner@canonical.com"},"content":"On Tue, Aug 29, 2017 at 04:00:26PM +0200, Andreas Schwab wrote:\n> On Aug 29 2017, Christian Brauner wrote:\n> \n> > @@ -129,12 +124,17 @@ openpty (int *amaster, int *aslave, char *name,\n> > if (name != NULL)\n> > strcpy (name, buf);\n> > \n> > + ret = 0;\n> > +\n> > + on_error:\n> > + close (master);\n> > +\n> > + if (slave != -1)\n> > + close(slave);\n> > +\n> \n> You don't want to close the fds on success.\n\nSorry, I was inatentive.\n\n> \n> Andreas.\n> \n> -- \n> Andreas Schwab, SUSE Labs, schwab@suse.de\n> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7\n> \"And now for something completely different.\"","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83821-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"muVlRpN3\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhVvd4sMBz9t38\n\tfor ;\n\tWed, 30 Aug 2017 00:12:29 +1000 (AEST)","(qmail 78099 invoked by alias); 29 Aug 2017 14:12:23 -0000","(qmail 78085 invoked by uid 89); 29 Aug 2017 14:12:22 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; q=dns; s=default; b=Pfdj\n\tuNqegP1GWsfhDsNcC5Yj4/adhEnPa6k0QPfAAW5s6roG88DdaGz43/8L3gEf1rZj\n\tTW0wokhiSUjx+G9Ad4yBFT6FW5abV6KedlQ5nyt9Hwx3EVREAsvvC7XAZF1s84Fm\n\tAiKuOcls+jxc3wfs3Yxhh+81GUl0VaOJfivnnZs=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:in-reply-to; s=default; bh=R22T/kMlQe\n\tvO64VJFJzd4ibXZKo=; b=muVlRpN3rk7T36ty8HcYoa2gdzvMRqzwFTuM1lekH9\n\tKCrtXYkxWbUUAYgqAengX5NGBx6z/yQB3bZdCKmf2zh03sQoQeJB4Mdv0C3JWRJr\n\tY+/9oH2tHP17BRx58useRqYOGjB8b2lbGHyRL6DKtHZl7jHNo5u6dSbKV/cqeRbK\n\t0=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*r:gmail.com,\n\tH*RU:gmail.com, Hx-spam-relays-external:gmail.com","X-HELO":"youngberry.canonical.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=iSoiEebFhmBH+oQGVfWXFwAqx//RbmEzO0QFf0gD2Ps=;\n\tb=f9s5JROIlKoem61wAx/4fPkq2grZ2Jy1QW2z5eWLd2q4JFgmJaOREVn/5aOakxsX1C\n\tYHEWCZZdIN8xOADBaRZvyo4DteFoXBqss/YUSpyVzFaXSratSnEABhR9cyqeN/UwKTzW\n\tNDT+DW+7LPZEqQQYJZBFfS5bpkDmGCQaJsT67B1ddQXR1dX6JzmgD6GijRdp8UlozhVr\n\tysuu/3twBkB7wWbaKI414iYZuDXFYYNdye+0Hf8q70FI0nJ5lAmkz8AD0DBseu+DYoYl\n\tOBbt821NtxLV8BdRrlMSyWN4irPxH+0GUCrZFNVxiVUETHB4MiKWG7T8zkJBsiaaWjPY\n\tJOiw==","X-Gm-Message-State":"AHYfb5gxiwVMejrhOz9jJ1lkm3jVg6ydK2N/4d5bgSOokNmXDlYMFZVH\n\tBILqhpiJ4pVKLVfC7KVI5VtV4eSBqTUvMsazVvgKxxzlCPf9GkMGpx+VpFBkZNmIpeTVNqWcxKM\n\tdj4z1xpXRgLMnY0YZbBron9knNKlT","X-Received":["by 10.28.15.6 with SMTP id 6mr2786550wmp.0.1504015929880;\n\tTue, 29 Aug 2017 07:12:09 -0700 (PDT)","by 10.28.15.6 with SMTP id 6mr2786512wmp.0.1504015928838;\n\tTue, 29 Aug 2017 07:12:08 -0700 (PDT)"],"Date":"Tue, 29 Aug 2017 16:12:07 +0200","From":"Christian Brauner ","To":"Andreas Schwab ","Cc":"Christian Brauner ,\n\tlibc-alpha@sourceware.org, stgraber@stgraber.org, serge@hallyn.com,\n\tfweimer@redhat.com, joseph@codesourcery.com","Subject":"Re: [PATCH 1/2 v4] openpty: close slave pty fd on error","Message-ID":"<20170829141207.fuhxzfqihtw6ixb7@gmail.com>","References":"\n\t<20170829134515.9345-1-christian.brauner@ubuntu.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170609 (1.8.3)"}}]