[{"id":1759360,"web_url":"http://patchwork.ozlabs.org/comment/1759360/","msgid":"<20170829135517.GA30733@ulmo>","list_archive_url":null,"date":"2017-08-29T13:55:17","subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"content":"On Tue, Aug 29, 2017 at 07:09:00PM +0530, Himanshu Jha wrote:\n> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n> \n> Signed-off-by: Himanshu Jha \n> ---\n> drivers/pci/host/pci-tegra.c | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c\n> index 9c40da5..90cda5b 100644\n> --- a/drivers/pci/host/pci-tegra.c\n> +++ b/drivers/pci/host/pci-tegra.c\n> @@ -1156,10 +1156,7 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)\n> \t\treturn PTR_ERR(pcie->afi_rst);\n> \n> \tpcie->pcie_xrst = devm_reset_control_get_exclusive(dev, \"pcie_x\");\n> -\tif (IS_ERR(pcie->pcie_xrst))\n> -\t\treturn PTR_ERR(pcie->pcie_xrst);\n> -\n> -\treturn 0;\n> +\treturn PTR_ERR_OR_ZERO(pcie->pcie_xrst);\n> }\n\nI'm not a big fan of this construct because it's a pain to undo this if\never we need to add code to this function. But since we do have scripts\nthat will flag this, I guess this would pop up every now and again. The\ndriver is unlikely to change in this part, too, so:\n\nAcked-by: Thierry Reding ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vLS4FGuy\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhVX82PV1z9t38\n\tfor ;\n\tTue, 29 Aug 2017 23:55:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752084AbdH2NzW (ORCPT );\n\tTue, 29 Aug 2017 09:55:22 -0400","from mail-wm0-f68.google.com ([74.125.82.68]:36075 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751180AbdH2NzV (ORCPT\n\t);\n\tTue, 29 Aug 2017 09:55:21 -0400","by mail-wm0-f68.google.com with SMTP id j72so3819617wmi.3;\n\tTue, 29 Aug 2017 06:55:20 -0700 (PDT)","from localhost\n\t(p200300E41BD6D60076D02BFFFE273F51.dip0.t-ipconnect.de.\n\t[2003:e4:1bd6:d600:76d0:2bff:fe27:3f51])\n\tby smtp.gmail.com with ESMTPSA id\n\t62sm2359806wrq.36.2017.08.29.06.55.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 29 Aug 2017 06:55:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=yBYOzRzVZw7XRIMKuPp2AKc73kzUUvjqXVG2a6hsALU=;\n\tb=vLS4FGuyS7mdxmRQWz70MCp0J3+J5bMrSih5MX6oOsqYG/Mu1GUT9V5kKHkh7Ac5Jx\n\tiVHZbhQmUMCzG/Bn9zoy4I2afBwE4WPS1WGlUNhEYV2xjyfphCas54YExenhkmHtaX0b\n\tVtmhzf8+JpFSh99h3FBPrj+5LJf2oDfAClHOqtdlhPALHz/1z8ta/vptKOd8C+0dZjz4\n\tKrTESRhrl1xvv5AjIUWpvqhN3rzL25Oekmb7Fwnfp+yR1sbmK/DX84YmjdlhHuApGAwG\n\tQF0kr9L0xsj2NKUy87xKucPn3tBDw1YXmQrKWULXFgoJZDYhMH3VCyX59nDCUzg5cRNT\n\t/AMw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=yBYOzRzVZw7XRIMKuPp2AKc73kzUUvjqXVG2a6hsALU=;\n\tb=S6PIrbDguEfRnBdVjvhidwnAkN10L1jNGBBX6TTDPJXyIS2u2n8wocdatY+m4Mvwo6\n\tPxa5xULBVRLx8fknfs6/MB2oidb1IDdVDdorGD+HwuRLWkK3EUaR3/kPTTiUU3sNA0M6\n\tqJewiGixbn/JYhwQAD0+apPtjBsKNDpIbL0B4ZE2u+UifSGqL6dwtuocn1K2/SnUJ96K\n\t+Fo23T7MB/iSQDVfK1KGei3ThYkoS3/XpmR0n5L2EzrRfmXsDFENsuCe8qahLugiMpnE\n\tzAjSFzvSXdUCx6r3+T7aAgLXK+zQkFY4ujZQKS2v/wieRTUK2U3wdmmj2fxuauJBwgup\n\tz9iw==","X-Gm-Message-State":"AHYfb5jHsciBltei6pJmWwJF3dYKKbiS+XAEQIEpuCCU9Mj4va/j7hjI\n\tfRNTgoLbpJZyIg==","X-Received":"by 10.28.62.203 with SMTP id l194mr2388540wma.110.1504014919615; \n\tTue, 29 Aug 2017 06:55:19 -0700 (PDT)","Date":"Tue, 29 Aug 2017 15:55:17 +0200","From":"Thierry Reding ","To":"Himanshu Jha ","Cc":"bhelgaas@google.com, jonathanh@nvidia.com,\n\tlinux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","Message-ID":"<20170829135517.GA30733@ulmo>","References":"<1504013940-16304-1-git-send-email-himanshujha199640@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"RnlQjJ0d97Da+TV1\"","Content-Disposition":"inline","In-Reply-To":"<1504013940-16304-1-git-send-email-himanshujha199640@gmail.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1759377,"web_url":"http://patchwork.ozlabs.org/comment/1759377/","msgid":"<20170829141401.GA18389@himanshu-Vostro-3559>","list_archive_url":null,"date":"2017-08-29T14:14:01","subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","submitter":{"id":72201,"url":"http://patchwork.ozlabs.org/api/people/72201/","name":"Himanshu Jha","email":"himanshujha199640@gmail.com"},"content":"On Tue, Aug 29, 2017 at 03:55:17PM +0200, Thierry Reding wrote:\n> On Tue, Aug 29, 2017 at 07:09:00PM +0530, Himanshu Jha wrote:\n> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n> > \n> > Signed-off-by: Himanshu Jha \n> > ---\n> > drivers/pci/host/pci-tegra.c | 5 +----\n> > 1 file changed, 1 insertion(+), 4 deletions(-)\n> > \n> > diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c\n> > index 9c40da5..90cda5b 100644\n> > --- a/drivers/pci/host/pci-tegra.c\n> > +++ b/drivers/pci/host/pci-tegra.c\n> > @@ -1156,10 +1156,7 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)\n> > \t\treturn PTR_ERR(pcie->afi_rst);\n> > \n> > \tpcie->pcie_xrst = devm_reset_control_get_exclusive(dev, \"pcie_x\");\n> > -\tif (IS_ERR(pcie->pcie_xrst))\n> > -\t\treturn PTR_ERR(pcie->pcie_xrst);\n> > -\n> > -\treturn 0;\n> > +\treturn PTR_ERR_OR_ZERO(pcie->pcie_xrst);\n> > }\n> \n> I'm not a big fan of this construct because it's a pain to undo this if\n> ever we need to add code to this function. But since we do have scripts\n> that will flag this, I guess this would pop up every now and again. The\n> driver is unlikely to change in this part, too, so:\n\nWhat do you suggest ? Shall I stop sending these patches ?\n\nThanks\n-Himanshu Jha\n\n> Acked-by: Thierry Reding \n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-tegra\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"k4wBuCVG\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhVxs6BqCz9t38\n\tfor ;\n\tWed, 30 Aug 2017 00:14:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752741AbdH2OOK (ORCPT );\n\tTue, 29 Aug 2017 10:14:10 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:33669 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752463AbdH2OOJ (ORCPT\n\t);\n\tTue, 29 Aug 2017 10:14:09 -0400","by mail-pf0-f194.google.com with SMTP id c28so2428075pfe.0;\n\tTue, 29 Aug 2017 07:14:09 -0700 (PDT)","from himanshu-Vostro-3559 ([103.254.204.108])\n\tby smtp.gmail.com with ESMTPSA id\n\tp1sm4533360pfe.129.2017.08.29.07.14.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 07:14:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=6Kywj/u2yoFqWUfz1JOCUJQ7cCC9II9I4Iu0bFDBmS8=;\n\tb=k4wBuCVGS5Fed84/sdp6ct3/4AaUT8kRPVxve3v5N/epb6CWVQzOEYUwe20HlqebjM\n\tSD/Jhtd/vcnHowyadSqUWAAmYUiawelASdxT/YV4CygENkyFRg7MnfMaz5hVXy8Z2Z8U\n\tG6oIAg04Fqug+7rpfZ3s4n/B9Nlksmx92B5uBKreuoZLOT5hARiUSvhLzt39n9hRe0z+\n\tqU9bwm+cqLMhZklQC7hiL3JLSp5Nlqdvn7BdyUATYixyKN2zj24TQ0vt2UlM/PdX/l4d\n\tGf6Wv2gfR4jVWr8E7HoMF/bSqvT4u0YATzSoDhYoRkQUhkhbofxUwLNJOsq+WURPdSvi\n\teSNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=6Kywj/u2yoFqWUfz1JOCUJQ7cCC9II9I4Iu0bFDBmS8=;\n\tb=cUusHJLE9IBToe5mXSRaVDp3wAIGHwGoz38BjttidVEAPErLl4HDiLtPnsAQyii7Jy\n\tggKwtDFkvqsEXUl6Muqux5Dp5p0S5ltA7anBHUEQElLCARkdqk7RbzN6pEY1OP91Sgfa\n\tIk3xaZ5Kt+MYrQ4rir8zOjhnfTqiajmCnuRW75wm+7488fxI6x+E+oPCDnWbOP+Adh3X\n\tSn3SWKrMYNT5njNEWYPxXUhr1qaFa5IadujlOKpbmw6gldJN+FlmpohcNLIuIEQReRxC\n\ttw8sDw/KGONAvEm9q1YYa0F0YbvZsuis9kTz0PsXhhqvVtgs5KcK7kR5789FaPxG7CwX\n\tu8XQ==","X-Gm-Message-State":"AHYfb5jtf0wmQmNfFWhtRV0JU7GL+PlUJI+AeJ+4ibW4Bto/H2J/FQ2A\n\tb97howleZSqb7Q==","X-Google-Smtp-Source":"ADKCNb44ElKM4wfxD9W6ngP7DYT9due9JfKbTvaqtr9Fb4WKisKdYCUzcpivFEpgRjhYBNiD5Gmp6Q==","X-Received":"by 10.98.79.146 with SMTP id f18mr491182pfj.216.1504016049114;\n\tTue, 29 Aug 2017 07:14:09 -0700 (PDT)","Date":"Tue, 29 Aug 2017 19:44:01 +0530","From":"Himanshu Jha ","To":"Thierry Reding ","Cc":"bhelgaas@google.com, jonathanh@nvidia.com,\n\tlinux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","Message-ID":"<20170829141401.GA18389@himanshu-Vostro-3559>","References":"<1504013940-16304-1-git-send-email-himanshujha199640@gmail.com>\n\t<20170829135517.GA30733@ulmo>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829135517.GA30733@ulmo>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1759433,"web_url":"http://patchwork.ozlabs.org/comment/1759433/","msgid":"<20170829150916.GA17659@ulmo>","list_archive_url":null,"date":"2017-08-29T15:09:16","subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"content":"On Tue, Aug 29, 2017 at 07:44:01PM +0530, Himanshu Jha wrote:\n> On Tue, Aug 29, 2017 at 03:55:17PM +0200, Thierry Reding wrote:\n> > On Tue, Aug 29, 2017 at 07:09:00PM +0530, Himanshu Jha wrote:\n> > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n> > > \n> > > Signed-off-by: Himanshu Jha \n> > > ---\n> > > drivers/pci/host/pci-tegra.c | 5 +----\n> > > 1 file changed, 1 insertion(+), 4 deletions(-)\n> > > \n> > > diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c\n> > > index 9c40da5..90cda5b 100644\n> > > --- a/drivers/pci/host/pci-tegra.c\n> > > +++ b/drivers/pci/host/pci-tegra.c\n> > > @@ -1156,10 +1156,7 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)\n> > > \t\treturn PTR_ERR(pcie->afi_rst);\n> > > \n> > > \tpcie->pcie_xrst = devm_reset_control_get_exclusive(dev, \"pcie_x\");\n> > > -\tif (IS_ERR(pcie->pcie_xrst))\n> > > -\t\treturn PTR_ERR(pcie->pcie_xrst);\n> > > -\n> > > -\treturn 0;\n> > > +\treturn PTR_ERR_OR_ZERO(pcie->pcie_xrst);\n> > > }\n> > \n> > I'm not a big fan of this construct because it's a pain to undo this if\n> > ever we need to add code to this function. But since we do have scripts\n> > that will flag this, I guess this would pop up every now and again. The\n> > driver is unlikely to change in this part, too, so:\n> \n> What do you suggest ? Shall I stop sending these patches ?\n\nNo, it's fine. I'm just saying that there are cases where this doesn't\nmake sense. In this case I think it's fine because the driver is fairly\nmature and unlikely to change, so there is not a lot of potential for\nchurn later on. In other cases, use your best judgement.\n\nUltimately it is up to maintainers whether or not they apply this kind\nof patch.\n\nThierry","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sNIDZjJk\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhX9G2Wh2z9t2Q\n\tfor ;\n\tWed, 30 Aug 2017 01:09:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752826AbdH2PJV (ORCPT );\n\tTue, 29 Aug 2017 11:09:21 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:33195 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751801AbdH2PJU (ORCPT\n\t);\n\tTue, 29 Aug 2017 11:09:20 -0400","by mail-wm0-f67.google.com with SMTP id e67so4061688wmd.0;\n\tTue, 29 Aug 2017 08:09:19 -0700 (PDT)","from localhost\n\t(p200300E41BD6D60076D02BFFFE273F51.dip0.t-ipconnect.de.\n\t[2003:e4:1bd6:d600:76d0:2bff:fe27:3f51])\n\tby smtp.gmail.com with ESMTPSA id\n\tm189sm1705419wmb.16.2017.08.29.08.09.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 29 Aug 2017 08:09:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=IZ1KYim0NgBvvxJ4fwOkPzL8fNbtFkBOrQBUu1J4VUw=;\n\tb=sNIDZjJkw0w8GUmSFPhXaa1DbDnmstuxeqEq22/8/fcVwl95hOtCOhyHndpF3FYEIc\n\tu8xUAv20Ti+Y235paBapHiUVW3GYrf/JzeDIvk384mbXy4Tdm4JMqJ3mG8VuaIyq0PUb\n\tyKIQceqd9tP6W9YLq8Jsiv2NiTrR8z45ht0Oi6zi4DEWkZhWcLhIbMBvVdi5KhwAjn1d\n\toUaDdpawOno9MVOs+Va8P9HLcdPAJi/yKs72sEl4xd51LDzy46IF95WKQij9uMKtaU15\n\tENwg3loRqEceKdYUJqJoxt0KXtURS2JTK1JnX3LwRBSdcMhCioiMQceoL2vDoj8NKMgt\n\tI/ng==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=IZ1KYim0NgBvvxJ4fwOkPzL8fNbtFkBOrQBUu1J4VUw=;\n\tb=f2H16dsl+Dfi4acXcqKGgrU2oY6gkze9QPa5RZwer0Dz7pzgrv4BbA00xWHJK8oY8B\n\tjaDnZzDa0yuC4htq72WgC4fs98A9M6lQvLm8Upy3KN9rDbSbVe28rc70rWgfvdOz8owk\n\taQ/jEWQtoajLb2hELV6cWutFS8hSLBlwMOYYZPF33qg/EKqkVLovFpRZCo53PyQyjV0H\n\tSFeZLRBoP+ycw6+vbt+bwATr0XAbjEqc3TIG4Kz3pNT/wUhy2zOKo8lprALZN6i0OkHF\n\t4uION1D2ruEvDRq30TmaGFKcBSYWVVlS0gm2WLHog/GKNWIZnLw2izl+0S1DaFdVBxam\n\ttv4Q==","X-Gm-Message-State":"AHYfb5gspvmv2layzxnetVReKrw8sD80UC0L88DZQWBA+Mt7mvCZy7us\n\t5HRxbUP1Itzp+cVy","X-Received":"by 10.28.49.215 with SMTP id x206mr28787wmx.65.1504019358750;\n\tTue, 29 Aug 2017 08:09:18 -0700 (PDT)","Date":"Tue, 29 Aug 2017 17:09:16 +0200","From":"Thierry Reding ","To":"Himanshu Jha ","Cc":"bhelgaas@google.com, jonathanh@nvidia.com,\n\tlinux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","Message-ID":"<20170829150916.GA17659@ulmo>","References":"<1504013940-16304-1-git-send-email-himanshujha199640@gmail.com>\n\t<20170829135517.GA30733@ulmo>\n\t<20170829141401.GA18389@himanshu-Vostro-3559>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"6TrnltStXW4iwmi0\"","Content-Disposition":"inline","In-Reply-To":"<20170829141401.GA18389@himanshu-Vostro-3559>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1760181,"web_url":"http://patchwork.ozlabs.org/comment/1760181/","msgid":"<20170830135931.GA18250@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-08-30T13:59:31","subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Tue, Aug 29, 2017 at 03:55:17PM +0200, Thierry Reding wrote:\n> On Tue, Aug 29, 2017 at 07:09:00PM +0530, Himanshu Jha wrote:\n> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n> > \n> > Signed-off-by: Himanshu Jha \n> > ---\n> > drivers/pci/host/pci-tegra.c | 5 +----\n> > 1 file changed, 1 insertion(+), 4 deletions(-)\n> > \n> > diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c\n> > index 9c40da5..90cda5b 100644\n> > --- a/drivers/pci/host/pci-tegra.c\n> > +++ b/drivers/pci/host/pci-tegra.c\n> > @@ -1156,10 +1156,7 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)\n> > \t\treturn PTR_ERR(pcie->afi_rst);\n> > \n> > \tpcie->pcie_xrst = devm_reset_control_get_exclusive(dev, \"pcie_x\");\n> > -\tif (IS_ERR(pcie->pcie_xrst))\n> > -\t\treturn PTR_ERR(pcie->pcie_xrst);\n> > -\n> > -\treturn 0;\n> > +\treturn PTR_ERR_OR_ZERO(pcie->pcie_xrst);\n> > }\n> \n> I'm not a big fan of this construct because it's a pain to undo this if\n> ever we need to add code to this function. But since we do have scripts\n> that will flag this, I guess this would pop up every now and again. The\n> driver is unlikely to change in this part, too, so:\n\nThanks for pointing this out. Do you know what the benefit of\nPTR_ERR_OR_ZERO() is? To me, it makes the following code harder\nto read because the error tests are no longer parallel:\n\n ...\n res->ahb_reset = devm_reset_control_get(dev, \"ahb\");\n if (IS_ERR(res->ahb_reset))\n return PTR_ERR(res->ahb_reset);\n\n res->por_reset = devm_reset_control_get(dev, \"por\");\n if (IS_ERR(res->por_reset))\n return PTR_ERR(res->por_reset);\n\n res->phy_reset = devm_reset_control_get(dev, \"phy\");\n return PTR_ERR_OR_ZERO(res->phy_reset);\n\nSo I'd be inclined to avoid it unless there's some significant benefit.\n\nBjorn\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-tegra\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj6Zg3lMBz9sNc\n\tfor ;\n\tWed, 30 Aug 2017 23:59:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751435AbdH3N7e (ORCPT );\n\tWed, 30 Aug 2017 09:59:34 -0400","from mail.kernel.org ([198.145.29.99]:57322 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751708AbdH3N7d (ORCPT );\n\tWed, 30 Aug 2017 09:59:33 -0400","from localhost (173-25-183-69.client.mchsi.com [173.25.183.69])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 933562199C;\n\tWed, 30 Aug 2017 13:59:32 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 933562199C","Date":"Wed, 30 Aug 2017 08:59:31 -0500","From":"Bjorn Helgaas ","To":"Thierry Reding ","Cc":"Himanshu Jha , bhelgaas@google.com,\n\tjonathanh@nvidia.com, linux-tegra@vger.kernel.org,\n\tlinux-pci@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","Message-ID":"<20170830135931.GA18250@bhelgaas-glaptop.roam.corp.google.com>","References":"<1504013940-16304-1-git-send-email-himanshujha199640@gmail.com>\n\t<20170829135517.GA30733@ulmo>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829135517.GA30733@ulmo>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1760204,"web_url":"http://patchwork.ozlabs.org/comment/1760204/","msgid":"<20170830142547.GC1361@ulmo>","list_archive_url":null,"date":"2017-08-30T14:25:47","subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"content":"On Wed, Aug 30, 2017 at 08:59:31AM -0500, Bjorn Helgaas wrote:\n> On Tue, Aug 29, 2017 at 03:55:17PM +0200, Thierry Reding wrote:\n> > On Tue, Aug 29, 2017 at 07:09:00PM +0530, Himanshu Jha wrote:\n> > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n> > > \n> > > Signed-off-by: Himanshu Jha \n> > > ---\n> > > drivers/pci/host/pci-tegra.c | 5 +----\n> > > 1 file changed, 1 insertion(+), 4 deletions(-)\n> > > \n> > > diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c\n> > > index 9c40da5..90cda5b 100644\n> > > --- a/drivers/pci/host/pci-tegra.c\n> > > +++ b/drivers/pci/host/pci-tegra.c\n> > > @@ -1156,10 +1156,7 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)\n> > > \t\treturn PTR_ERR(pcie->afi_rst);\n> > > \n> > > \tpcie->pcie_xrst = devm_reset_control_get_exclusive(dev, \"pcie_x\");\n> > > -\tif (IS_ERR(pcie->pcie_xrst))\n> > > -\t\treturn PTR_ERR(pcie->pcie_xrst);\n> > > -\n> > > -\treturn 0;\n> > > +\treturn PTR_ERR_OR_ZERO(pcie->pcie_xrst);\n> > > }\n> > \n> > I'm not a big fan of this construct because it's a pain to undo this if\n> > ever we need to add code to this function. But since we do have scripts\n> > that will flag this, I guess this would pop up every now and again. The\n> > driver is unlikely to change in this part, too, so:\n> \n> Thanks for pointing this out. Do you know what the benefit of\n> PTR_ERR_OR_ZERO() is? To me, it makes the following code harder\n> to read because the error tests are no longer parallel:\n> \n> ...\n> res->ahb_reset = devm_reset_control_get(dev, \"ahb\");\n> if (IS_ERR(res->ahb_reset))\n> return PTR_ERR(res->ahb_reset);\n> \n> res->por_reset = devm_reset_control_get(dev, \"por\");\n> if (IS_ERR(res->por_reset))\n> return PTR_ERR(res->por_reset);\n> \n> res->phy_reset = devm_reset_control_get(dev, \"phy\");\n> return PTR_ERR_OR_ZERO(res->phy_reset);\n> \n> So I'd be inclined to avoid it unless there's some significant benefit.\n\nYeah, I don't like the optics much either. Aside from the fact that it\nreduces the line count, I'm not aware of any benefits that this inline\nfunction has. It doesn't have any side-effects or anything, just wraps\nthe common pattern into a single line.\n\nLooking at the history of the semantic patch that is the basis for the\nconversions (scripts/coccinelle/api/ptr_ret.cocci), or the static inline\nfunction itself, no rationale is given for why people prefer this. I've\ncertainly seen such patches applied in some cases, but I've also seen\nother maintainers (including myself) reject them because of personal\npreference.\n\nThierry","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SgA+7N2l\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj78y4G40z9s7f\n\tfor ;\n\tThu, 31 Aug 2017 00:26:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751851AbdH3OZx (ORCPT );\n\tWed, 30 Aug 2017 10:25:53 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:37075 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751706AbdH3OZv (ORCPT\n\t);\n\tWed, 30 Aug 2017 10:25:51 -0400","by mail-wm0-f65.google.com with SMTP id x189so1970508wmg.4;\n\tWed, 30 Aug 2017 07:25:50 -0700 (PDT)","from localhost\n\t(p200300E41BD6D60076D02BFFFE273F51.dip0.t-ipconnect.de.\n\t[2003:e4:1bd6:d600:76d0:2bff:fe27:3f51])\n\tby smtp.gmail.com with ESMTPSA id\n\tu127sm3518393wmd.27.2017.08.30.07.25.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 30 Aug 2017 07:25:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=FMMiqXYKjgGg/Y61T7r94Zi+c4gFnEAcODRRok/J7PI=;\n\tb=SgA+7N2lYTCNgctTS1aFa8B4sOW1SDSqQQHHrHSH7dZqfy69VN8gPyTLoEPqwTjZfV\n\tuBHQTsGAcgnuXzA4SdclbU7a/fxPQAUzfcFZzn9lugH0y5V3lANYdo1K71JA/4hb2tbe\n\tBxVzOz3OL2dcMsX1E45qB0Kdmv2xIgoCq2B9rTUQ0vU+So4/TiSJIdeG0mNloj9eM2Ne\n\tSHoZyfUgjlGheteSbUzagWZV3hwlB042ezGrZCCCcHFuVg5xcRdQS/lGj4f2f5KwYMYj\n\tfqkOVZLTu4onl6QPZxxyuZO7IbnHm7aKsPubBLceonyxlw9QqcqLo9NxuaZIG6yTSRm8\n\tWODA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=FMMiqXYKjgGg/Y61T7r94Zi+c4gFnEAcODRRok/J7PI=;\n\tb=aAM+GaMVucgtVvCpxNwCadAlt+xxsF4QI6+qvMOuUxIjakx2ITUXu64qZEXR6wDpbA\n\to0qi0rXGFciVCN1TyTzWFhlf+4/k92Tqx0QbYYGex4wsBXuBRvNl+lMSK0pDLKhqaA7J\n\tjfV/XYokMn3ynGZIXrT85QO/y3vpoUG4u6mokcPOwikGknAKVZzPhi3k8n0h13/ILpBC\n\tyQ3K/1w38kuLZOEWHIAVg7oLIlgQddRN46T2KoSreX9QMx8XLF5jixdibvho+Nlt+ruU\n\t7ohwpd+7Tf6Qbc1/0WcQTPhgJHueH0C4rN+N9Hy2yqict0k+A+REU3nGxtaOwGKSI3s/\n\tK6ew==","X-Gm-Message-State":"AHYfb5iTC2HBnxmpmeQY+Rtzn/szZc+VZ95i5a6SaiRTc8lpBSxhc3v3\n\tQZBhESd0Oqs2Ew==","X-Received":"by 10.28.169.2 with SMTP id s2mr1392855wme.109.1504103150017;\n\tWed, 30 Aug 2017 07:25:50 -0700 (PDT)","Date":"Wed, 30 Aug 2017 16:25:47 +0200","From":"Thierry Reding ","To":"Bjorn Helgaas ","Cc":"Himanshu Jha , bhelgaas@google.com,\n\tjonathanh@nvidia.com, linux-tegra@vger.kernel.org,\n\tlinux-pci@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","Message-ID":"<20170830142547.GC1361@ulmo>","References":"<1504013940-16304-1-git-send-email-himanshujha199640@gmail.com>\n\t<20170829135517.GA30733@ulmo>\n\t<20170830135931.GA18250@bhelgaas-glaptop.roam.corp.google.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"w7PDEPdKQumQfZlR\"","Content-Disposition":"inline","In-Reply-To":"<20170830135931.GA18250@bhelgaas-glaptop.roam.corp.google.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1760313,"web_url":"http://patchwork.ozlabs.org/comment/1760313/","msgid":"<20170830162613.GB18250@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-08-30T16:26:13","subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Wed, Aug 30, 2017 at 04:25:47PM +0200, Thierry Reding wrote:\n> On Wed, Aug 30, 2017 at 08:59:31AM -0500, Bjorn Helgaas wrote:\n> > On Tue, Aug 29, 2017 at 03:55:17PM +0200, Thierry Reding wrote:\n> > > On Tue, Aug 29, 2017 at 07:09:00PM +0530, Himanshu Jha wrote:\n> > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n> > > > \n> > > > Signed-off-by: Himanshu Jha \n> > > > ---\n> > > > drivers/pci/host/pci-tegra.c | 5 +----\n> > > > 1 file changed, 1 insertion(+), 4 deletions(-)\n> > > > \n> > > > diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c\n> > > > index 9c40da5..90cda5b 100644\n> > > > --- a/drivers/pci/host/pci-tegra.c\n> > > > +++ b/drivers/pci/host/pci-tegra.c\n> > > > @@ -1156,10 +1156,7 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)\n> > > > \t\treturn PTR_ERR(pcie->afi_rst);\n> > > > \n> > > > \tpcie->pcie_xrst = devm_reset_control_get_exclusive(dev, \"pcie_x\");\n> > > > -\tif (IS_ERR(pcie->pcie_xrst))\n> > > > -\t\treturn PTR_ERR(pcie->pcie_xrst);\n> > > > -\n> > > > -\treturn 0;\n> > > > +\treturn PTR_ERR_OR_ZERO(pcie->pcie_xrst);\n> > > > }\n> > > \n> > > I'm not a big fan of this construct because it's a pain to undo this if\n> > > ever we need to add code to this function. But since we do have scripts\n> > > that will flag this, I guess this would pop up every now and again. The\n> > > driver is unlikely to change in this part, too, so:\n> > \n> > Thanks for pointing this out. Do you know what the benefit of\n> > PTR_ERR_OR_ZERO() is? To me, it makes the following code harder\n> > to read because the error tests are no longer parallel:\n> > \n> > ...\n> > res->ahb_reset = devm_reset_control_get(dev, \"ahb\");\n> > if (IS_ERR(res->ahb_reset))\n> > return PTR_ERR(res->ahb_reset);\n> > \n> > res->por_reset = devm_reset_control_get(dev, \"por\");\n> > if (IS_ERR(res->por_reset))\n> > return PTR_ERR(res->por_reset);\n> > \n> > res->phy_reset = devm_reset_control_get(dev, \"phy\");\n> > return PTR_ERR_OR_ZERO(res->phy_reset);\n> > \n> > So I'd be inclined to avoid it unless there's some significant benefit.\n> \n> Yeah, I don't like the optics much either. Aside from the fact that it\n> reduces the line count, I'm not aware of any benefits that this inline\n> function has. It doesn't have any side-effects or anything, just wraps\n> the common pattern into a single line.\n> \n> Looking at the history of the semantic patch that is the basis for the\n> conversions (scripts/coccinelle/api/ptr_ret.cocci), or the static inline\n> function itself, no rationale is given for why people prefer this. I've\n> certainly seen such patches applied in some cases, but I've also seen\n> other maintainers (including myself) reject them because of personal\n> preference.\n\nOK, I'm going to drop this then.\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-tegra\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj9qY3qL8z9sNn\n\tfor ;\n\tThu, 31 Aug 2017 02:26:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751416AbdH3Q0Q (ORCPT );\n\tWed, 30 Aug 2017 12:26:16 -0400","from mail.kernel.org ([198.145.29.99]:44312 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751405AbdH3Q0P (ORCPT );\n\tWed, 30 Aug 2017 12:26:15 -0400","from localhost (unknown [69.55.156.165])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 186592199E;\n\tWed, 30 Aug 2017 16:26:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 186592199E","Date":"Wed, 30 Aug 2017 11:26:13 -0500","From":"Bjorn Helgaas ","To":"Thierry Reding ","Cc":"Himanshu Jha , bhelgaas@google.com,\n\tjonathanh@nvidia.com, linux-tegra@vger.kernel.org,\n\tlinux-pci@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO","Message-ID":"<20170830162613.GB18250@bhelgaas-glaptop.roam.corp.google.com>","References":"<1504013940-16304-1-git-send-email-himanshujha199640@gmail.com>\n\t<20170829135517.GA30733@ulmo>\n\t<20170830135931.GA18250@bhelgaas-glaptop.roam.corp.google.com>\n\t<20170830142547.GC1361@ulmo>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830142547.GC1361@ulmo>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}}]