[{"id":1759286,"web_url":"http://patchwork.ozlabs.org/comment/1759286/","msgid":"<9c225c3c-e21c-48ad-ac36-e472c6dec84a@amsat.org>","list_archive_url":null,"date":"2017-08-29T12:31:35","subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Alberto,\n\nOn 08/29/2017 09:08 AM, Alberto Garcia wrote:\n> There's a few cases which we're passing an Error pointer to a function\n> only to discard it immediately afterwards without checking it. In\n> these cases we can simply remove the variable and pass NULL instead.\n\nHow did you notice?\n\n> \n> Signed-off-by: Alberto Garcia \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> ---\n> block/qcow.c | 12 +++---------\n> block/qcow2.c | 8 ++------\n> dump.c | 4 +---\n> 3 files changed, 6 insertions(+), 18 deletions(-)\n> \n> diff --git a/block/qcow.c b/block/qcow.c\n> index c08cdc4a7b..63904a26ee 100644\n> --- a/block/qcow.c\n> +++ b/block/qcow.c\n> @@ -454,13 +454,11 @@ static uint64_t get_cluster_offset(BlockDriverState *bs,\n> start_sect = (offset & ~(s->cluster_size - 1)) >> 9;\n> for(i = 0; i < s->cluster_sectors; i++) {\n> if (i < n_start || i >= n_end) {\n> - Error *err = NULL;\n> memset(s->cluster_data, 0x00, 512);\n> if (qcrypto_block_encrypt(s->crypto, start_sect + i,\n> s->cluster_data,\n> BDRV_SECTOR_SIZE,\n> - &err) < 0) {\n> - error_free(err);\n> + NULL) < 0) {\n> errno = EIO;\n> return -1;\n> }\n> @@ -572,7 +570,6 @@ static coroutine_fn int qcow_co_readv(BlockDriverState *bs, int64_t sector_num,\n> QEMUIOVector hd_qiov;\n> uint8_t *buf;\n> void *orig_buf;\n> - Error *err = NULL;\n> \n> if (qiov->niov > 1) {\n> buf = orig_buf = qemu_try_blockalign(bs, qiov->size);\n> @@ -637,7 +634,7 @@ static coroutine_fn int qcow_co_readv(BlockDriverState *bs, int64_t sector_num,\n> if (bs->encrypted) {\n> assert(s->crypto);\n> if (qcrypto_block_decrypt(s->crypto, sector_num, buf,\n> - n * BDRV_SECTOR_SIZE, &err) < 0) {\n> + n * BDRV_SECTOR_SIZE, NULL) < 0) {\n> goto fail;\n> }\n> }\n> @@ -660,7 +657,6 @@ done:\n> return ret;\n> \n> fail:\n> - error_free(err);\n> ret = -EIO;\n> goto done;\n> }\n> @@ -709,11 +705,9 @@ static coroutine_fn int qcow_co_writev(BlockDriverState *bs, int64_t sector_num,\n> break;\n> }\n> if (bs->encrypted) {\n> - Error *err = NULL;\n> assert(s->crypto);\n> if (qcrypto_block_encrypt(s->crypto, sector_num, buf,\n> - n * BDRV_SECTOR_SIZE, &err) < 0) {\n> - error_free(err);\n> + n * BDRV_SECTOR_SIZE, NULL) < 0) {\n> ret = -EIO;\n> break;\n> }\n> diff --git a/block/qcow2.c b/block/qcow2.c\n> index 40ba26c111..fbfffadc76 100644\n> --- a/block/qcow2.c\n> +++ b/block/qcow2.c\n> @@ -1820,15 +1820,13 @@ static coroutine_fn int qcow2_co_preadv(BlockDriverState *bs, uint64_t offset,\n> assert(s->crypto);\n> assert((offset & (BDRV_SECTOR_SIZE - 1)) == 0);\n> assert((cur_bytes & (BDRV_SECTOR_SIZE - 1)) == 0);\n> - Error *err = NULL;\n> if (qcrypto_block_decrypt(s->crypto,\n> (s->crypt_physical_offset ?\n> cluster_offset + offset_in_cluster :\n> offset) >> BDRV_SECTOR_BITS,\n> cluster_data,\n> cur_bytes,\n> - &err) < 0) {\n> - error_free(err);\n> + NULL) < 0) {\n> ret = -EIO;\n> goto fail;\n> }\n> @@ -1942,7 +1940,6 @@ static coroutine_fn int qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,\n> qemu_iovec_concat(&hd_qiov, qiov, bytes_done, cur_bytes);\n> \n> if (bs->encrypted) {\n> - Error *err = NULL;\n> assert(s->crypto);\n> if (!cluster_data) {\n> cluster_data = qemu_try_blockalign(bs->file->bs,\n> @@ -1963,8 +1960,7 @@ static coroutine_fn int qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,\n> cluster_offset + offset_in_cluster :\n> offset) >> BDRV_SECTOR_BITS,\n> cluster_data,\n> - cur_bytes, &err) < 0) {\n> - error_free(err);\n> + cur_bytes, NULL) < 0) {\n> ret = -EIO;\n> goto fail;\n> }\n> diff --git a/dump.c b/dump.c\n> index d9090a24cc..a79773d0f7 100644\n> --- a/dump.c\n> +++ b/dump.c\n> @@ -1695,10 +1695,8 @@ static void dump_process(DumpState *s, Error **errp)\n> \n> static void *dump_thread(void *data)\n> {\n> - Error *err = NULL;\n> DumpState *s = (DumpState *)data;\n> - dump_process(s, &err);\n> - error_free(err);\n> + dump_process(s, NULL);\n> return NULL;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"g0AAXyEe\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhSh612hQz9t1t\n\tfor ;\n\tTue, 29 Aug 2017 22:32:22 +1000 (AEST)","from localhost ([::1]:44730 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmfgp-00008y-Sy\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 08:32:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44092)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dmfgO-00006K-B8\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 08:31:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dmfgI-00049z-3M\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 08:31:52 -0400","from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:38707)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmfgC-00046c-Dk; Tue, 29 Aug 2017 08:31:40 -0400","by mail-qk0-x241.google.com with SMTP id o63so2690458qkb.5;\n\tTue, 29 Aug 2017 05:31:40 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tm83sm1820957qki.26.2017.08.29.05.31.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 05:31:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=gZV1BcTilI4DKiZJqwAyv6S4UPgKZ3foe67IQTiCoxs=;\n\tb=g0AAXyEex0sV9PaIs/E/dj3i8nP7dwpT5eLszbEKP1ben7pBDiBxLwypBu3WLuov8Y\n\trZo0dvo8ZfJEWx6NtZMBso8Vr6d8qZKjBfKk/8p7lBfx/arrk25RVncMvidqvcF3bDtf\n\t8vbrL5TueaEnZh/UdNBXQ/7ZH0g6kj7DSIPL4KPiXswaaQO/PXulw7JFTjR6U+o9mfA3\n\tJ2WmRUQu9D8lhkqvdVBGf0DG5jtHS0MuFZ2YUgRop0jcoazl82G1Y8+VyBIvdRp/KT0p\n\tpPRXaaK5rB/u2ZL4oT87atoFQh+vfL1zvhG20/PuMPALbvHTRPevRtP6BHU5V94eijtU\n\t/xzA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=gZV1BcTilI4DKiZJqwAyv6S4UPgKZ3foe67IQTiCoxs=;\n\tb=UZcbAQXF6+y9pVsqCG+41ZyWrIGaTcA9wArTUpIbNn17zQG7rdzEJ+NudAT7TJLdX+\n\t03q8E9yGrPgBqvjsLHj9O9dQ+Vl24NPrPMI1w3b8t7k6uFQAtnb27nMkQkN1QMCWlN2l\n\tth/BQFkhk9OxUp8UT4HkFhxLSSvK9a34/PCgSkGyQoMcy/2dkYTeg8CSQnQ0VRvTs3So\n\tbRuSdvTYtcfC53ZUXvavG4u3bdSvaFAP7HjPkLc6MSxOt6DQUjRNk/Pp66VgKUn/siIa\n\tFcIaJSDFxu9Ve/+bkKgxV8iLGwhRYNLjbMORyy+XSIuJu9+s+5rwmYMpxWiqXRfsSQ3h\n\tgsIA==","X-Gm-Message-State":"AHYfb5ivdyQb4WDxTaUnQVHGWNHAdABEq1txmDtCfJJYqGXfNBNTNn21\n\taY8xiHwQhlo5LQ==","X-Received":"by 10.55.5.133 with SMTP id 127mr5461149qkf.210.1504009899657;\n\tTue, 29 Aug 2017 05:31:39 -0700 (PDT)","To":"Alberto Garcia , qemu-devel@nongnu.org","References":"<20170829120836.16091-1-berto@igalia.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<9c225c3c-e21c-48ad-ac36-e472c6dec84a@amsat.org>","Date":"Tue, 29 Aug 2017 09:31:35 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170829120836.16091-1-berto@igalia.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::241","Subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759322,"web_url":"http://patchwork.ozlabs.org/comment/1759322/","msgid":"","list_archive_url":null,"date":"2017-08-29T13:12:24","subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Tue 29 Aug 2017 02:31:35 PM CEST, Philippe Mathieu-Daudé wrote:\n\n>> There's a few cases which we're passing an Error pointer to a function\n>> only to discard it immediately afterwards without checking it. In\n>> these cases we can simply remove the variable and pass NULL instead.\n>\n> How did you notice?\n\nI noticed it while I was working on something else. It's also not the\nfirst time I see something like this (see e.g. 026ac1586bdbd184e240).\n\nBerto","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"auGLB4IO\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhTcl12Qrz9t2v\n\tfor ;\n\tTue, 29 Aug 2017 23:14:31 +1000 (AEST)","from localhost ([::1]:44880 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmgLc-00074L-TG\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 09:14:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53911)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmgJi-00062q-Nw\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 09:12:36 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmgJf-0000LC-Fu\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 09:12:30 -0400","from fanzine.igalia.com ([91.117.99.155]:58319)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmgJf-0000KZ-6Q; Tue, 29 Aug 2017 09:12:27 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dmgJd-0001VG-6h; Tue, 29 Aug 2017 15:12:25 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dmgJd-0004jV-49; Tue, 29 Aug 2017 15:12:25 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=5Vrc1tytCKtXvHngk3kTH6guiY6VZFUUZRign+ES1i4=; \n\tb=auGLB4IOtHqLRjjAxLm/Tw//X8mlD5UDEEPBNuSonr2yXLcQp2u5p7eTI9iJLh5VbCxaInYK06pn+/PTHF+usaSjqQ2UNKkoM/e9icyqJx1y00sF3dI6cEdNRFEYd3XwMQCsaE9uStLwhDlrYdlknoBaNdSGpcZFvwQrj17k5shEh32lhvO/bONR73yRARptlp2xxLy6JwWw0rwLWmsnA+v+UNHPaP43tSUwVtPmetbuTPBi9qoVtcaQARicq8qJvLw3ulLeIjv/5sdjhzIdASpyZi2GeTDtj1q7xwvtZwXE5Bycg920cmFQYva7mA4YQCpVkG0sKU7dcx4R5JWD8w==;","From":"Alberto Garcia ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ,\n\tqemu-devel@nongnu.org","In-Reply-To":"<9c225c3c-e21c-48ad-ac36-e472c6dec84a@amsat.org>","References":"<20170829120836.16091-1-berto@igalia.com>\n\t<9c225c3c-e21c-48ad-ac36-e472c6dec84a@amsat.org>","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Tue, 29 Aug 2017 15:12:24 +0200","Message-ID":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759398,"web_url":"http://patchwork.ozlabs.org/comment/1759398/","msgid":"","list_archive_url":null,"date":"2017-08-29T14:40:35","subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/29/2017 07:08 AM, Alberto Garcia wrote:\n> There's a few cases which we're passing an Error pointer to a function\n> only to discard it immediately afterwards without checking it. In\n> these cases we can simply remove the variable and pass NULL instead.\n\nCould also go in via qemu-trivial or Markus' error tree (both added in\ncc) if the block maintainers don't take it quickly.\n\n> \n> Signed-off-by: Alberto Garcia \n> ---\n> block/qcow.c | 12 +++---------\n> block/qcow2.c | 8 ++------\n> dump.c | 4 +---\n> 3 files changed, 6 insertions(+), 18 deletions(-)\n> \n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhWXs1WJxz9s7f\n\tfor ;\n\tWed, 30 Aug 2017 00:41:17 +1000 (AEST)","from localhost ([::1]:45288 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmhha-00019P-LK\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 10:41:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59774)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmhhB-00019G-WF\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:40:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmhh8-0003sq-1o\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:40:49 -0400","from mx1.redhat.com ([209.132.183.28]:58304)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmhh1-0003jp-1S; Tue, 29 Aug 2017 10:40:39 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A8B147EA85;\n\tTue, 29 Aug 2017 14:40:37 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B6BDF4F6D8;\n\tTue, 29 Aug 2017 14:40:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A8B147EA85","To":"Alberto Garcia , qemu-devel@nongnu.org","References":"<20170829120836.16091-1-berto@igalia.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Tue, 29 Aug 2017 09:40:35 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170829120836.16091-1-berto@igalia.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"9gTI37VWVnWTTngGR74SUkEdMgWUerS07\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 29 Aug 2017 14:40:37 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , qemu-trivial ,\n\tMarkus Armbruster , qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759406,"web_url":"http://patchwork.ozlabs.org/comment/1759406/","msgid":"","list_archive_url":null,"date":"2017-08-29T14:45:14","subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Tue 29 Aug 2017 04:40:35 PM CEST, Eric Blake wrote:\n\n>> There's a few cases which we're passing an Error pointer to a\n\nHmmm... this was \"few cases in which\", but it seems that I accidentally\nremoved the \"in\". Not very important, but whoever commits this feel free\nto fix the message.\n\nBerto","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"TXIaT0Ti\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhWf13J1zz9s7f\n\tfor ;\n\tWed, 30 Aug 2017 00:45:44 +1000 (AEST)","from localhost ([::1]:45311 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmhlt-00032t-GF\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 10:45:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33200)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmhlZ-00032n-Oi\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:45:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmhlU-0007YV-TS\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:45:21 -0400","from fanzine.igalia.com ([91.117.99.155]:42846)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmhlU-0007XO-KC; Tue, 29 Aug 2017 10:45:16 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dmhlS-0002V2-7o; Tue, 29 Aug 2017 16:45:14 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dmhlS-0006tH-5F; Tue, 29 Aug 2017 16:45:14 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=LUzYb999xuZhu5j6m/LM4r5x23GqBdiLeyKV8gbvSVE=; \n\tb=TXIaT0TikN1x6XedQ2bQDj86yBtJRIzdKSdeAgmHZ8a+dmnwtNgvPNKaL/7j73YzGxfrc9EZToKhxAcBmqr64kf8ueOEfh7+EZOsvx9LKw9xvBSlZtk0Gn7bywsB/reUA3RNvPPU15ibvOvOk+24MhRfpo0uOcMElQrZrqztAwWuNVFqysRlLYFGYl81HrIFFV9qh6PPJZeowauoVuEva9ubbNT/FUARusf0heoI9Q8xTKLyg+onXTTVaEajGzo6F+4vtmxQ78urqRXuUKHHc0U9Xgk5noBWkTB3XQmz7eNlRY7Zj6lZvniRiLMc40Hw9H+7sY1XIv+5CxJokRxTCw==;","From":"Alberto Garcia ","To":"Eric Blake , qemu-devel@nongnu.org","In-Reply-To":"","References":"<20170829120836.16091-1-berto@igalia.com>\n\t","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Tue, 29 Aug 2017 16:45:14 +0200","Message-ID":"","MIME-Version":"1.0","Content-Type":"text/plain","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , qemu-trivial ,\n\tMarkus Armbruster , qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760057,"web_url":"http://patchwork.ozlabs.org/comment/1760057/","msgid":"<20170830105941.GK24565@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-08-30T10:59:41","subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Tue, Aug 29, 2017 at 03:08:36PM +0300, Alberto Garcia wrote:\n> There's a few cases which we're passing an Error pointer to a function\n> only to discard it immediately afterwards without checking it. In\n> these cases we can simply remove the variable and pass NULL instead.\n> \n> Signed-off-by: Alberto Garcia \n> ---\n> block/qcow.c | 12 +++---------\n> block/qcow2.c | 8 ++------\n> dump.c | 4 +---\n> 3 files changed, 6 insertions(+), 18 deletions(-)\n\nThanks, applied to my block-next tree:\nhttps://github.com/stefanha/qemu/commits/block-next\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"W13K4kVv\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj2bN2ZShz9s9Y\n\tfor ;\n\tWed, 30 Aug 2017 21:00:14 +1000 (AEST)","from localhost ([::1]:49630 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn0jD-0004T3-TD\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 07:00:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44785)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn0is-0004QP-OO\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 06:59:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn0io-0002Tg-HH\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 06:59:50 -0400","from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:36992)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn0io-0002T4-9l; Wed, 30 Aug 2017 06:59:46 -0400","by mail-wm0-x242.google.com with SMTP id x189so1375451wmg.4;\n\tWed, 30 Aug 2017 03:59:46 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tt4sm2167347edt.88.2017.08.30.03.59.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 30 Aug 2017 03:59:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=2jx5l6UirrTNQ6svycKDiTTR9UZbDotbNkvoywI+HcY=;\n\tb=W13K4kVvdw7VHY06e/VGwx4k3FtP8dEkuF3J139/dIZxxYNyR3Ps8jbeDVr5CFVsgX\n\tk/6Sy6o1B4UhWX4QGf8i1oaRJbYM4HqsLiar4Zrck78doejFkVTV3fL8RB3IX1dlkFP7\n\ta/ZjF8MAypOIEr957tjV0p5I/zift/O+onOH0SsdfIjS74Lu4N2XpJEKiYrIRHDFGvFo\n\t8tKfhNrXv+10bJ26l4oyt+2iXsM3/RWbl2fL7rfrwiYuRbbKLN28qb3tAYuXDZhbrzZg\n\t82iuhUO3AAVNgGh8WRT7QNAwrFZ/UBnhifluI8yY8I8RgBa79atd8DDpXtLx1TAT3uZq\n\tAzsA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=2jx5l6UirrTNQ6svycKDiTTR9UZbDotbNkvoywI+HcY=;\n\tb=AACyxW2Ady7l1WEZ74atHTZjEsQNV5gJnQxz72ufPHfdB+z9U9dNoRdw0Ofbei6+f9\n\tQksZxF9tb7/h+WHCDroala0HRrJBKaKFwvOMxR4MEkZiSP+lMM7NdLhqNkOIz7Uvbbxz\n\tHK15EP/vPl3ST4XvNy6CZj69E/B7gqzgu3zG9pozTKZpyqaZj10Zp70ICRw2GR1Zr8TB\n\t2GbnZWlIXn5xmy/I5sRs473/xQSZ4Lu6aX4KMXJUz4k+vivz0SoPWsEwQkahSxqm0PnA\n\tat7Efgs4gwq6kA3jLsTH8WjvF9CxtREPTohBhkPW7OogeCMt1i/i3fqmdJHAB9r63Yqz\n\tBB9g==","X-Gm-Message-State":"AHYfb5g8b0OBWWudfxhzXgcIbRhI+KM0lXR7cYgO2C8Cd8bl0mOkX3HQ\n\tOuiULqx5O1TBMA==","X-Received":"by 10.80.139.5 with SMTP id l5mr1388826edl.15.1504090783814;\n\tWed, 30 Aug 2017 03:59:43 -0700 (PDT)","Date":"Wed, 30 Aug 2017 11:59:41 +0100","From":"Stefan Hajnoczi ","To":"Alberto Garcia ","Message-ID":"<20170830105941.GK24565@stefanha-x1.localdomain>","References":"<20170829120836.16091-1-berto@igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829120836.16091-1-berto@igalia.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::242","Subject":"Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , qemu-devel@nongnu.org,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]