[{"id":1759187,"web_url":"http://patchwork.ozlabs.org/comment/1759187/","msgid":"<1a489dcc-e95c-bfe3-8e2a-fe2591fe86d8@cogentembedded.com>","list_archive_url":null,"date":"2017-08-29T10:08:09","subject":"Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic\n\tcompatible and rename file","submitter":{"id":22564,"url":"http://patchwork.ozlabs.org/api/people/22564/","name":"Sergei Shtylyov","email":"sergei.shtylyov@cogentembedded.com"},"content":"Hello!\n\nOn 8/29/2017 12:20 PM, Chunfeng Yun wrote:\n\n> The mt8173-mtu3.txt actually holds the bindings for all mediatek\n> SoCs with usb3 DRD IP, so add a generic compatible and change the\n> name to mediatek,mtu3.txt.\n> \n> Signed-off-by: Chunfeng Yun \n> Acked-by: Rob Herring \n> ---\n> .../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)\n> \n> diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt\n> similarity index 92%\n> rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt\n> rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt\n> index b8ea394..722a029 100644\n> --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt\n> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt\n> @@ -1,7 +1,11 @@\n> The device node for Mediatek USB3.0 DRD controller\n> \n> Required properties:\n> - - compatible : should be \"mediatek,mt8173-mtu3\"\n> + - compatible : should be \"mediatek,soc-model-mtu3\", \"mediatek,mtu3\",\n\n Worth enclosing soc-model in <>.\n\n> +\tsoc-model is the name of SoC, such as mt8173, mt2712 etc,\n> +\twhen using \"mediatek,mtu3\" compatible string, you need SoC specific\n> +\tones in addition, one of:\n> +\t- \"mediatek,mt8173-mtu3\"\n> - reg : specifies physical base address and size of the registers\n> - reg-names: should be \"mac\" for device IP and \"ippc\" for IP port control\n> - interrupts : interrupt used by the device IP\n\nMBR, Sergei\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=cogentembedded-com.20150623.gappssmtp.com\n\theader.i=@cogentembedded-com.20150623.gappssmtp.com\n\theader.b=\"Hv53hT4j\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhPV75HQTz9t1t\n\tfor ;\n\tTue, 29 Aug 2017 20:08:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751864AbdH2KIU (ORCPT\n\t);\n\tTue, 29 Aug 2017 06:08:20 -0400","from mail-lf0-f46.google.com ([209.85.215.46]:34888 \"EHLO\n\tmail-lf0-f46.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751773AbdH2KIT (ORCPT\n\t); Tue, 29 Aug 2017 06:08:19 -0400","by mail-lf0-f46.google.com with SMTP id k186so11483636lfe.2\n\tfor ;\n\tTue, 29 Aug 2017 03:08:18 -0700 (PDT)","from [192.168.4.126] ([31.173.80.175])\n\tby smtp.gmail.com with ESMTPSA id\n\tl30sm528200ljb.93.2017.08.29.03.08.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 03:08:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cogentembedded-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=BznARLmQDwe4iVcospHUNZN/OU+o9nLGf/ZUgXAOLPw=;\n\tb=Hv53hT4jrOLydYedKmqxeizJHx5ETtV0iEGZ/CF+S3I9kNS8kgLHDrZhnQu8/EdE67\n\teJpkT1ewAAaOaC3ZTkTFxOoLDdIWdP3zBtlu0osBRURQPfnS6tacOHJNVlmd4XLYyLQb\n\tcP5x6KHvcwMqtg3KWwEbsOXimMOKa7oE69kVhDRZ6ctAqQCxT3dmEVAZ8RPfwlcggEeH\n\tAqm5TC99TrzznsOfHqdYkripLT6GrRCUMobpOh3w2Nczvtcda9WLu4CDKPL+0mymelb1\n\tlwSu5Mq3YZQN/88I1PgVz0nQwsYIVY9gBdni5xieo/DlU23isoEg+n5CX/jrdRCEH293\n\tJ6ow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=BznARLmQDwe4iVcospHUNZN/OU+o9nLGf/ZUgXAOLPw=;\n\tb=PlqbAYYl3SC2Fd/b/NLqNGiLM5tuShzZQA0toiw0UKabSizjUa1UcZVc23WlZmDOoC\n\tlepiBFl+Ee7mYQzIA5t+clD22wlAQs3iOL2g0YALm2E5DHQ+eQaFFesg2WJMxwg14vcv\n\tGTOXiWga01aRlSlOIByB5AuL40YwHE9v2ZmwNoStZk0bXsv567fOYYFQwIfGOKxComEH\n\tfruWaOrsWgkEHUs6cTQUbXteodZTYDKmu/mPH2EKAv0v3mseJ3jBD3D4zUjbQ6FsqVbQ\n\t/e0j/Mzv1hX9723/Uw89wGjlT/qONHmhTzkMdn421L6Z8p8kbSlm7ta/rzIRP6gbDVmb\n\teB1g==","X-Gm-Message-State":"AHYfb5hSLVJkddgmD/rv/2vHX5UZRP+hV5xecDbmscDUKwcFeOEDylBX\n\t7oma4oU+BVNHt+4kQ/foeQ==","X-Received":"by 10.46.69.139 with SMTP id s133mr1528367lja.194.1504001297263; \n\tTue, 29 Aug 2017 03:08:17 -0700 (PDT)","Subject":"Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic\n\tcompatible and rename file","To":"Chunfeng Yun ,\n\tMathias Nyman ,\n\tGreg Kroah-Hartman ,\n\tFelipe Balbi ,\n\tRob Herring ","Cc":"Matthias Brugger ,\n\tMark Rutland ,\n\tIan Campbell ,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org,\n\tdevicetree@vger.kernel.org","References":"<33fa448238c0d95f0cfd6c2be3bd5c4e657a0cd4.1503998338.git.chunfeng.yun@mediatek.com>\n\t<61060035e057b13f43d383645c53c8726b7e67ab.1503998339.git.chunfeng.yun@mediatek.com>","From":"Sergei Shtylyov ","Message-ID":"<1a489dcc-e95c-bfe3-8e2a-fe2591fe86d8@cogentembedded.com>","Date":"Tue, 29 Aug 2017 13:08:09 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<61060035e057b13f43d383645c53c8726b7e67ab.1503998339.git.chunfeng.yun@mediatek.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1759837,"web_url":"http://patchwork.ozlabs.org/comment/1759837/","msgid":"<1504064333.17567.9.camel@mhfsdcap03>","list_archive_url":null,"date":"2017-08-30T03:38:53","subject":"Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic\n\tcompatible and rename file","submitter":{"id":66488,"url":"http://patchwork.ozlabs.org/api/people/66488/","name":"Chunfeng Yun","email":"chunfeng.yun@mediatek.com"},"content":"On Tue, 2017-08-29 at 13:08 +0300, Sergei Shtylyov wrote:\n> Hello!\n> \n> On 8/29/2017 12:20 PM, Chunfeng Yun wrote:\n> \n> > The mt8173-mtu3.txt actually holds the bindings for all mediatek\n> > SoCs with usb3 DRD IP, so add a generic compatible and change the\n> > name to mediatek,mtu3.txt.\n> > \n> > Signed-off-by: Chunfeng Yun \n> > Acked-by: Rob Herring \n> > ---\n> > .../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} | 6 +++++-\n> > 1 file changed, 5 insertions(+), 1 deletion(-)\n> > rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)\n> > \n> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt\n> > similarity index 92%\n> > rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt\n> > rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt\n> > index b8ea394..722a029 100644\n> > --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt\n> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt\n> > @@ -1,7 +1,11 @@\n> > The device node for Mediatek USB3.0 DRD controller\n> > \n> > Required properties:\n> > - - compatible : should be \"mediatek,mt8173-mtu3\"\n> > + - compatible : should be \"mediatek,soc-model-mtu3\", \"mediatek,mtu3\",\n> \n> Worth enclosing soc-model in <>.\nOk, I'll modify it, thanks\n> \n> > +\tsoc-model is the name of SoC, such as mt8173, mt2712 etc,\n> > +\twhen using \"mediatek,mtu3\" compatible string, you need SoC specific\n> > +\tones in addition, one of:\n> > +\t- \"mediatek,mt8173-mtu3\"\n> > - reg : specifies physical base address and size of the registers\n> > - reg-names: should be \"mac\" for device IP and \"ippc\" for IP port control\n> > - interrupts : interrupt used by the device IP\n> \n> MBR, Sergei\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhrpH4rssz9sP5\n\tfor ;\n\tWed, 30 Aug 2017 13:39:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752074AbdH3DjC (ORCPT\n\t);\n\tTue, 29 Aug 2017 23:39:02 -0400","from mailgw01.mediatek.com ([218.249.47.110]:44075 \"EHLO\n\tmailgw01.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by\n\tvger.kernel.org with ESMTP id S1751680AbdH3DjB (ORCPT\n\t); Tue, 29 Aug 2017 23:39:01 -0400","from mtkcas36.mediatek.inc [(172.27.4.250)] by\n\tmailgw01.mediatek.com (envelope-from )\n\t(mailgw01.mediatek.com ESMTP with TLS)\n\twith ESMTP id 1637222300; Wed, 30 Aug 2017 11:38:55 +0800","from MTKCAS32.mediatek.inc (172.27.4.184) by\n\tMTKMBS30N2.mediatek.inc\n\t(172.27.4.89) with Microsoft SMTP Server (TLS) id 15.0.1210.3;\n\tWed, 30 Aug 2017 11:38:54 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc\n\t(172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend\n\tTransport; Wed, 30 Aug 2017 11:38:53 +0800"],"Message-ID":"<1504064333.17567.9.camel@mhfsdcap03>","Subject":"Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic\n\tcompatible and rename file","From":"Chunfeng Yun ","To":"Sergei Shtylyov ","CC":"Mathias Nyman ,\n\tGreg Kroah-Hartman ,\n\tFelipe Balbi ,\n\tRob Herring ,\n\tMatthias Brugger ,\n\tMark Rutland ,\n\tIan Campbell ,\n\t, ,\n\t, ,\n\t","Date":"Wed, 30 Aug 2017 11:38:53 +0800","In-Reply-To":"<1a489dcc-e95c-bfe3-8e2a-fe2591fe86d8@cogentembedded.com>","References":"<33fa448238c0d95f0cfd6c2be3bd5c4e657a0cd4.1503998338.git.chunfeng.yun@mediatek.com>\n\t<61060035e057b13f43d383645c53c8726b7e67ab.1503998339.git.chunfeng.yun@mediatek.com>\n\t<1a489dcc-e95c-bfe3-8e2a-fe2591fe86d8@cogentembedded.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-MTK":"N","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]