[{"id":1759413,"web_url":"http://patchwork.ozlabs.org/comment/1759413/","msgid":"<0ad72a04-83d2-8db8-2375-0380642cbd66@linaro.org>","list_archive_url":null,"date":"2017-08-29T14:51:48","subject":"Re: [Qemu-devel] [RFC v3 PATCH 3/5] mttcg: Add tcg target default\n\tmemory ordering","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 08/28/2017 11:33 PM, Pranith Kumar wrote:\n> Signed-off-by: Pranith Kumar \n> ---\n> tcg/aarch64/tcg-target.h | 2 ++\n> tcg/arm/tcg-target.h | 2 ++\n> tcg/ia64/tcg-target.h | 2 ++\n> tcg/mips/tcg-target.h | 2 ++\n> tcg/ppc/tcg-target.h | 2 ++\n> tcg/s390/tcg-target.h | 2 ++\n> tcg/sparc/tcg-target.h | 2 ++\n> 7 files changed, 14 insertions(+)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"dBRbL7TR\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhWnq035sz9sR9\n\tfor ;\n\tWed, 30 Aug 2017 00:52:31 +1000 (AEST)","from localhost ([::1]:45343 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmhsS-0007cK-U8\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 10:52:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35402)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmhrx-0007bY-3E\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:51:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmhrt-0002kY-93\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:51:57 -0400","from mail-pg0-x22e.google.com ([2607:f8b0:400e:c05::22e]:36764)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmhrt-0002kK-0e\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:51:53 -0400","by mail-pg0-x22e.google.com with SMTP id r133so11453031pgr.3\n\tfor ; Tue, 29 Aug 2017 07:51:52 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\ts81sm5752498pfg.78.2017.08.29.07.51.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 07:51:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=thpuyTi89PF/MxBd8Kqwj95uNLxUhqR4tu6B8ByJmxU=;\n\tb=dBRbL7TR6FgrW2FZbdmwL30Hf3oHd+y7UIt0YMaFBSkPvlXF8hd23ZvNsI30ayDomb\n\t6OQg0gAP6o0aKx42f6X60yzcv/tGSIef4HabEp9ApxGs2CKy7TStQCtSiNBulFKYHTQd\n\tV9Kq7HLiyvvs3meoai5/Fc0+y9XeGmwDs/2BQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=thpuyTi89PF/MxBd8Kqwj95uNLxUhqR4tu6B8ByJmxU=;\n\tb=MAswpXOBL8Fjc+wYBkgI+YA4CaQ9SSdDjpT325vDo4MFHP9qREJUnrkfeovFEsyXr1\n\t2bs9EFGnZq6EsAe9W/uZkcUnPY5mxtDdXwWVIvd9sHpIRH0AWLzeS9SwotqxtHYiLeD6\n\tOmnZhEEU+OkheHUCNWkOAysaX1Xgw6oRseszlad12kXXIOmL6+TMq3uCSJRQpSYDl5/J\n\tJu/1vRLioNodONmoeGpYGnN4sFi6G8BZFRRiBw/enFfZd7IENRVPV4ioamvPQ8PDJb/+\n\t6/GBJ0PCX2xuCxYHzRitkWa+lYjXtyskc/CAISABbdLvrmHiydOjP8x4O2oK0CJOmhlH\n\tHCrg==","X-Gm-Message-State":"AHYfb5i6HBHLZkmtW9F0xtROvDWjkoTx6HzGushIUdi2RpK1GvuLLVU2\n\tQipsOiBmBiKoKU6k","X-Received":"by 10.99.67.130 with SMTP id q124mr555170pga.73.1504018311734;\n\tTue, 29 Aug 2017 07:51:51 -0700 (PDT)","To":"Pranith Kumar , alex.bennee@linaro.org,\n\tClaudio Fontana ,\n\tAndrzej Zaborowski , Aurelien Jarno\n\t, Alexander Graf ,\n\t\"open list:AArch64 target\" ,\n\t\"open list:All patches CC here\" ","References":"<20170829063313.10237-1-bobby.prani@gmail.com>\n\t<20170829063313.10237-3-bobby.prani@gmail.com>","From":"Richard Henderson ","Message-ID":"<0ad72a04-83d2-8db8-2375-0380642cbd66@linaro.org>","Date":"Tue, 29 Aug 2017 07:51:48 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170829063313.10237-3-bobby.prani@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::22e","Subject":"Re: [Qemu-devel] [RFC v3 PATCH 3/5] mttcg: Add tcg target default\n\tmemory ordering","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759426,"web_url":"http://patchwork.ozlabs.org/comment/1759426/","msgid":"<3148d084-9bff-2d8e-f1a7-fba94a1e7f87@linaro.org>","list_archive_url":null,"date":"2017-08-29T15:01:50","subject":"Re: [Qemu-devel] [RFC v3 PATCH 5/5] tcg/softmmu: Increase size of\n\tTLB caches","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 08/28/2017 11:33 PM, Pranith Kumar wrote:\n> + * TODO: rewrite this comment\n> */\n> -#define CPU_TLB_BITS \\\n> - MIN(8, \\\n> - TCG_TARGET_TLB_DISPLACEMENT_BITS - CPU_TLB_ENTRY_BITS - \\\n> - (NB_MMU_MODES <= 1 ? 0 : \\\n> - NB_MMU_MODES <= 2 ? 1 : \\\n> - NB_MMU_MODES <= 4 ? 2 : \\\n> - NB_MMU_MODES <= 8 ? 3 : 4))\n> +#define CPU_TLB_BITS MIN(12, TCG_TARGET_TLB_MAX_INDEX_BITS)\n> \n\nAh, no. This will cause several builds to fail.\nYou still need to restrict the *total* size of\nthe TLB to TCG_TARGET_TLB_DISPLACEMENT_BITS.\n\n(That's not a 100% accurate statement, but is close.\nSee the QEMU_BUILD_BUG_ON in tcg/*/*.c for specifics.)\n\nThe upshot is that if a target has 2 MMU modes,\nwe can allow them to be bigger. But if it has 8,\nwe have to make them smaller.\n\nI was expecting you to write\n\n MIN(MIN(12, TCG_TARGET_TLB_MAX_INDEX_BITS)\n TCG_TARGET_TLB_DISPLACEMENT_BITS - CPU_TLB_ENTRY_BITS -\n ...)\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"MH+azhuR\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhX2x39Prz9sRV\n\tfor ;\n\tWed, 30 Aug 2017 01:03:53 +1000 (AEST)","from localhost ([::1]:45398 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmi3T-0004St-Cd\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 11:03:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38767)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmi1g-0003em-D3\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:02:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmi1a-00072k-Tv\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:02:00 -0400","from mail-pf0-x22b.google.com ([2607:f8b0:400e:c00::22b]:33504)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmi1a-00072U-Og\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:01:54 -0400","by mail-pf0-x22b.google.com with SMTP id r62so11019593pfj.0\n\tfor ; Tue, 29 Aug 2017 08:01:54 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\ts186sm5849280pfb.110.2017.08.29.08.01.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 08:01:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=LKBU0WUKPMb/q3fXiJRYxg3Mc4KrXwkY+17UOZ/wFzI=;\n\tb=MH+azhuRaoUPIRw83JrRLvOujt3WzSkPjhFSZ3e6XJIHE8aAxreuSLCmf2akHBNtzl\n\tVyMysuIAEvg69MpcoYN4XYNPZ+81Y5fIDH9rc0zaTagzFF+a7tMJdolNF8Ii+trfNt1Q\n\tRelyxpAfsPkBJsmZnhSiqyqtcOPbN505bM8GI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=LKBU0WUKPMb/q3fXiJRYxg3Mc4KrXwkY+17UOZ/wFzI=;\n\tb=C64Hlrhgmix5XDfDXv7Kx2ndNi7L7AgjErD+w1wLoB0QKzeCYsrmStoVxpbZYxuN3o\n\t3Ml9RvzciElSeXKKf7ybqENjiT5wBFo+eErMIOzZeF5am/S4P1Glp+syNMd4MBzMcz9v\n\tSW+M4CRZiIJmL7o4dvjYgBYL9xdcpr5HcQRPDABpZ6rtGV2o6NQwCbBHWfuBO/bPW8+k\n\tSOTv/h3s29CMZFyg11wACGbvoi+P1C7Kg7nC4oej3Dim6oe1/PHAJ9+yH+FO38IpLBgg\n\tZyiAqJS5GwFsYDACBFp55cl9OoYncigeZ7XfaG2KRqZhCFUIQMIfmolFCc3zu2+Ps+RG\n\tq8tQ==","X-Gm-Message-State":"AHYfb5jZ+hwAL8nU+Et/4BYt/qjgQhyZkr4wQUV7vh79QY2Imc8UnAav\n\tN1L/xoAQfNDh1tYn","X-Received":"by 10.99.175.10 with SMTP id w10mr561692pge.373.1504018913503;\n\tTue, 29 Aug 2017 08:01:53 -0700 (PDT)","To":"Pranith Kumar , alex.bennee@linaro.org,\n\tPaolo Bonzini ,\n\tPeter Crosthwaite ,\n\tClaudio Fontana ,\n\tAndrzej Zaborowski , Aurelien Jarno\n\t, Alexander Graf ,\n\tStefan Weil ,\n\t\"open list:Overall\" , \n\t\"open list:AArch64 target\" ","References":"<20170829063313.10237-1-bobby.prani@gmail.com>\n\t<20170829063313.10237-5-bobby.prani@gmail.com>","From":"Richard Henderson ","Message-ID":"<3148d084-9bff-2d8e-f1a7-fba94a1e7f87@linaro.org>","Date":"Tue, 29 Aug 2017 08:01:50 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170829063313.10237-5-bobby.prani@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::22b","Subject":"Re: [Qemu-devel] [RFC v3 PATCH 5/5] tcg/softmmu: Increase size of\n\tTLB caches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759427,"web_url":"http://patchwork.ozlabs.org/comment/1759427/","msgid":"<125ae0ee-8104-5b52-6b4b-22622ba56191@linaro.org>","list_archive_url":null,"date":"2017-08-29T15:03:39","subject":"Re: [Qemu-devel] [RFC v3 PATCH 5/5] tcg/softmmu: Increase size of\n\tTLB caches","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 08/28/2017 11:33 PM, Pranith Kumar wrote:\n> +#if HOST_LONG_BITS == 32 && TARGET_LONG_BITS == 32\n> +#define TCG_TARGET_TLB_MAX_INDEX_BITS 28\n> +#else\n> +#define TCG_TARGET_TLB_MAX_INDEX_BITS 27\n> +#endif\n> +\n\nFor the record, did it not work to actually write (32 - CPU_TLB_BITS)? I'm not\nfond of repeating the conditions that go into computing CPU_TLB_BITS.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ePMpQ46H\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhX3g5d1qz9sRV\n\tfor ;\n\tWed, 30 Aug 2017 01:04:31 +1000 (AEST)","from localhost ([::1]:45399 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmi45-0004mU-Ix\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 11:04:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39365)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmi3P-0004ia-6S\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:03:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmi3L-0007kS-UE\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:03:47 -0400","from mail-pg0-x236.google.com ([2607:f8b0:400e:c05::236]:33951)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmi3L-0007k6-OC\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:03:43 -0400","by mail-pg0-x236.google.com with SMTP id y15so11633692pgc.1\n\tfor ; Tue, 29 Aug 2017 08:03:43 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\t23sm5187872pfh.183.2017.08.29.08.03.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 08:03:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=OtEDM/6KDcpI0YwzzJLiL5pla6GOa8b5egPWrLCFX4E=;\n\tb=ePMpQ46Htn1RsDKT0XbzqcC/QNSAx/B6g1f+OCG2dVDLyiOjxMFsBGqzl7AsIrvmTa\n\tKiViLIz37O6gKXkMJkqkEQe52Lt2qaePZyiLhmWXhgqhzj8h8xywSwYELl8dgx0p4a69\n\tx/i8nro/I9JPgsiP3qsTUvSJWLNBh9ktmu6P0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=OtEDM/6KDcpI0YwzzJLiL5pla6GOa8b5egPWrLCFX4E=;\n\tb=tp3RGfDEE1SCGU4SKb7vZmMMS2Rb9jS/FFDYsvq0U1C68DM6fjV8/izYgpHniuqTt/\n\t+MKKdAHgNExpGXeH65XichSnoosQDwuwJq/s5a3NStSDPOQKbJy7By2RiUj55+X4n2nJ\n\tVDG6IjH/wXdzhiv9rzuk46idGYhRiSxWTUEWSZno3I4I2VRi29lddXu10B+YTPts/dq2\n\tSKedQ4CiOrbaOxmHYUgil1rTwQN5J5cmMop1CkqSXN27q+2Mpj93XahoShyIHI5LBC83\n\txzh8tqpEwYToRrZ7HHr3+IUaPMvJZ3IBif6eE+mWVbLyPCaSXD0gw07fQaPfXCFNtltR\n\ttDaQ==","X-Gm-Message-State":"AHYfb5jYohiMlOsJj7e75LcokVMKvvFMNbgluvqnXj9mKYVCgnGZf6J5\n\tu0i950zZjE4CX7By","X-Received":"by 10.98.196.152 with SMTP id h24mr627534pfk.43.1504019022685;\n\tTue, 29 Aug 2017 08:03:42 -0700 (PDT)","To":"Pranith Kumar , alex.bennee@linaro.org,\n\tPaolo Bonzini ,\n\tPeter Crosthwaite ,\n\tClaudio Fontana ,\n\tAndrzej Zaborowski , Aurelien Jarno\n\t, Alexander Graf ,\n\tStefan Weil ,\n\t\"open list:Overall\" , \n\t\"open list:AArch64 target\" ","References":"<20170829063313.10237-1-bobby.prani@gmail.com>\n\t<20170829063313.10237-5-bobby.prani@gmail.com>","From":"Richard Henderson ","Message-ID":"<125ae0ee-8104-5b52-6b4b-22622ba56191@linaro.org>","Date":"Tue, 29 Aug 2017 08:03:39 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170829063313.10237-5-bobby.prani@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::236","Subject":"Re: [Qemu-devel] [RFC v3 PATCH 5/5] tcg/softmmu: Increase size of\n\tTLB caches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759511,"web_url":"http://patchwork.ozlabs.org/comment/1759511/","msgid":"","list_archive_url":null,"date":"2017-08-29T16:23:05","subject":"Re: [Qemu-devel] [RFC v3 PATCH 5/5] tcg/softmmu: Increase size of\n\tTLB caches","submitter":{"id":64653,"url":"http://patchwork.ozlabs.org/api/people/64653/","name":"Pranith Kumar","email":"bobby.prani@gmail.com"},"content":"On Tue, Aug 29, 2017 at 11:01 AM, Richard Henderson\n wrote:\n> On 08/28/2017 11:33 PM, Pranith Kumar wrote:\n>> + * TODO: rewrite this comment\n>> */\n>> -#define CPU_TLB_BITS \\\n>> - MIN(8, \\\n>> - TCG_TARGET_TLB_DISPLACEMENT_BITS - CPU_TLB_ENTRY_BITS - \\\n>> - (NB_MMU_MODES <= 1 ? 0 : \\\n>> - NB_MMU_MODES <= 2 ? 1 : \\\n>> - NB_MMU_MODES <= 4 ? 2 : \\\n>> - NB_MMU_MODES <= 8 ? 3 : 4))\n>> +#define CPU_TLB_BITS MIN(12, TCG_TARGET_TLB_MAX_INDEX_BITS)\n>>\n>\n> Ah, no. This will cause several builds to fail.\n> You still need to restrict the *total* size of\n> the TLB to TCG_TARGET_TLB_DISPLACEMENT_BITS.\n>\n> (That's not a 100% accurate statement, but is close.\n> See the QEMU_BUILD_BUG_ON in tcg/*/*.c for specifics.)\n>\n> The upshot is that if a target has 2 MMU modes,\n> we can allow them to be bigger. But if it has 8,\n> we have to make them smaller.\n>\n> I was expecting you to write\n>\n> MIN(MIN(12, TCG_TARGET_TLB_MAX_INDEX_BITS)\n> TCG_TARGET_TLB_DISPLACEMENT_BITS - CPU_TLB_ENTRY_BITS -\n> ...)\n\nI see what you mean. I will fix the blunder and send an updated patch.\n\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nraI+4jn\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhYqs1CQfz9t3F\n\tfor ;\n\tWed, 30 Aug 2017 02:24:24 +1000 (AEST)","from localhost ([::1]:45959 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmjJO-0004G1-Fe\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 12:24:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37995)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmjIk-0004Eu-OF\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 12:23:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmjIf-0004TS-6g\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 12:23:42 -0400","from mail-io0-x22e.google.com ([2607:f8b0:4001:c06::22e]:34526)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmjIf-0004TE-1V; Tue, 29 Aug 2017 12:23:37 -0400","by mail-io0-x22e.google.com with SMTP id n71so22721276iod.1;\n\tTue, 29 Aug 2017 09:23:36 -0700 (PDT)","by 10.79.166.2 with HTTP; Tue, 29 Aug 2017 09:23:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=HnEhVX+CaccwHelxmc9rI/oYb9aI6gtC5xOmbl5wEQI=;\n\tb=nraI+4jnHMFkVfhUTF4jIfx+pf0xoaVN9qFTIbBuw/QLM5NISof6zv33UR0hHbUVAx\n\tWjlesO7lf/YwlNQUuPui/BC2dbDQfI+woYroNqSsbqARY4dR3Z8IaQnxq32vrwkk4VcL\n\tQka5k0jhjgPOYPuO0CrrGQF7Z27K1SAJ+37viXyhxd1+M46FNbckG/cdgEdfKUD9TO1h\n\tcLkgvuULahS/TIzcnbKX2fZqyw5i046D9PZyPODRDi/9ok6l+dDDQnW+LbaJcTxKl+ml\n\thxWf1d//JY0jzqUq9C17MgLpJ/4S/ISGvX8yoaKdVpUTe7BBk2ONg6bOwL2c/MAzpgJR\n\tolIg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=HnEhVX+CaccwHelxmc9rI/oYb9aI6gtC5xOmbl5wEQI=;\n\tb=eZJlxFlmnBk8UgWspmMwaQqgjtCe9M13er0Yr5SHV3RRGWY03PqNl3N3+E34IAWPQS\n\tAQQy/4ugy2l8cpzJdr760jMEdOdCejA9bBbiOMSLMQtXZwyzH74tfMKgiNMkX7HGFnwC\n\tazJmPbvr+omo2NI8eX5+2KMqrY0ez5xZSKIdF/N6Jxrd5h/FrBVmVvtgwAd+U6pblJWK\n\tgxv0K4XnY1sglSCy6rNEVw/WZqH9eaWdgj92vx2KQ13ASCvidnj6CyVqU57x0XkAsDIA\n\tvxkrklBP4BxHbsZPJ1t+ScmjWoYwVkfee6ir5bSqZDulxBXPQdjJ6yguJ8efX9AWKfx4\n\thRpA==","X-Gm-Message-State":"AHYfb5gG605RWBZdQMvSWQOj8k9eNAqpVzIEtFVNfGRMFLxaqX49Xofl\n\t9eUZmQ4U7ylQ2TG7EvMF/sB3Ts6tNA==","X-Received":"by 10.107.129.11 with SMTP id c11mr4464867iod.17.1504023816354; \n\tTue, 29 Aug 2017 09:23:36 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<3148d084-9bff-2d8e-f1a7-fba94a1e7f87@linaro.org>","References":"<20170829063313.10237-1-bobby.prani@gmail.com>\n\t<20170829063313.10237-5-bobby.prani@gmail.com>\n\t<3148d084-9bff-2d8e-f1a7-fba94a1e7f87@linaro.org>","From":"Pranith Kumar ","Date":"Tue, 29 Aug 2017 12:23:05 -0400","Message-ID":"","To":"Richard Henderson ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::22e","Subject":"Re: [Qemu-devel] [RFC v3 PATCH 5/5] tcg/softmmu: Increase size of\n\tTLB caches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Crosthwaite , =?utf-8?q?Alex_Benn?=\n\t=?utf-8?b?w6ll?= ,\n\tClaudio Fontana , Alexander Graf\n\t, \t\"open list:Overall\" ,\n\t\"open list:AArch64 target\" , \n\tStefan Weil , Paolo Bonzini , \n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763275,"web_url":"http://patchwork.ozlabs.org/comment/1763275/","msgid":"<87lgltmjzl.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-05T12:02:22","subject":"Re: [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Pranith Kumar writes:\n\n> Update the comment which is not true since MTTCG.\n\nWhat happened to the cover letter? We seem to have a mix of patches but\nno summary of the overall outcome.\n\n>\n> Reviewed-by: Richard Henderson \n> Signed-off-by: Pranith Kumar \n> ---\n> target/arm/translate-a64.c | 4 ----\n> 1 file changed, 4 deletions(-)\n>\n> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c\n> index 2200e25be0..f42b155d7d 100644\n> --- a/target/arm/translate-a64.c\n> +++ b/target/arm/translate-a64.c\n> @@ -2012,10 +2012,6 @@ static void disas_ldst_excl(DisasContext *s, uint32_t insn)\n> }\n> tcg_addr = read_cpu_reg_sp(s, rn, 1);\n>\n> - /* Note that since TCG is single threaded load-acquire/store-release\n> - * semantics require no extra if (is_lasr) { ... } handling.\n> - */\n> -\n> if (is_excl) {\n> if (!is_store) {\n> s->is_ldex = true;\n\n\n--\nAlex Bennée","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"IRE7UfRd\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmljm1QRgz9sPt\n\tfor ;\n\tTue, 5 Sep 2017 22:03:40 +1000 (AEST)","from localhost ([::1]:58447 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpCZu-0005x1-6j\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:03:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36722)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpCYr-0005bA-K4\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:02:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpCYk-0007DB-4P\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:02:33 -0400","from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]:38886)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpCYj-0007Bx-Tt\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:02:26 -0400","by mail-wr0-x232.google.com with SMTP id 108so8192170wra.5\n\tfor ; Tue, 05 Sep 2017 05:02:25 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\tl91sm601798wrc.16.2017.09.05.05.02.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 05:02:23 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id 9402A3E00A0;\n\tTue, 5 Sep 2017 13:02:22 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=WBYbyegpwr3eT+o0pRnfNpZeGeMKJ2edRAs1uTjGeGQ=;\n\tb=IRE7UfRdQKuEPfylhGLb13NLpH+3pl917Ivo5d8Q7uhToKtX+hmQ0WwHGz6febVGrE\n\tcR3E9hWGhSo0peKZ265aFiBhMca3btUtle2Y4XguYzRdpsa/HXLXvJsJt8eB8bKwXtZz\n\tZV3FJqVGQ4BEUA9835zPdg3e3SUqd4iT/obHw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=WBYbyegpwr3eT+o0pRnfNpZeGeMKJ2edRAs1uTjGeGQ=;\n\tb=IGVXGN4lziI8WKOo3e1z5EM6PCF+Sh9rZpQGgeLFu89362veUqzTS3o+qv/j6uG2os\n\tG8k2pQRuVjo6QQ6REVot9b832NZM5Bwm/tzqXSnJTJxypYqJGPUuG3NCXGw3CnaDNB94\n\tyhgk3KMT/tnvmg729wQ72xPG5hzDlRgpDZDg4K6/ChVTB0Q9n0muXNuOZJkKxNPYMdCH\n\tRKpwb55izgUVaF9DCC1C0lcKY1AQTvVzIShaILSb7h4OKKOxNSxZBbkYelIbWFYgEB9Z\n\tkS4p35c84uiKpxwiCTL2+tgLToyeV7Qmnj6Wm/SoPinXnOiV3IqoikofuaR2z8BEI3ic\n\tIvuw==","X-Gm-Message-State":"AHPjjUhHxpf5V9G7spT8lV7Y+cUh2z9AVMtnzYqD4dbv/kf+bio5Nh5W\n\tcwN6wCSMuLSF/r4f","X-Google-Smtp-Source":"ADKCNb76wzr+kJGwhLTgfpaQTkDI08mMgJETx0w/wGRquZHEq8OhlDjvxaaXJDj026epWUU+Dsm/rw==","X-Received":"by 10.223.147.39 with SMTP id 36mr2206294wro.175.1504612944609; \n\tTue, 05 Sep 2017 05:02:24 -0700 (PDT)","References":"<20170829063313.10237-1-bobby.prani@gmail.com>","User-agent":"mu4e 0.9.19; emacs 25.2.50.3","From":"Alex =?utf-8?q?Benn=C3=A9e?= ","To":"Pranith Kumar ","In-reply-to":"<20170829063313.10237-1-bobby.prani@gmail.com>","Date":"Tue, 05 Sep 2017 13:02:22 +0100","Message-ID":"<87lgltmjzl.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::232","Subject":"Re: [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\t\"open list:ARM\" , qemu-devel@nongnu.org,\n\tpbonzini@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763294,"web_url":"http://patchwork.ozlabs.org/comment/1763294/","msgid":"<87k21dmiro.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-05T12:28:43","subject":"Re: [Qemu-devel] [RFC v3 PATCH 2/5] cpus-common: Cache allocated\n\twork items","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Pranith Kumar writes:\n\n> Using heaptrack, I found that quite a few of our temporary allocations\n> are coming from allocating work items. Instead of doing this\n> continously, we can cache the allocated items and reuse them instead\n> of freeing them.\n>\n> Stats from an ARM64 guest (boot+shutdown):\n>\n> heaptrack stats(before):\n> allocations: 1471317\n> leaked allocations: 73824\n> temporary allocations: 651293\n>\n> heaptrack stats(after):\n> allocations: 1143130\n> leaked allocations: 73693\n> temporary allocations: 487342\n>\n> The improvement in speedup is minor and within error margins, however I think the\n> patch is still worth. We can also explore atomics instead of taking a lock for\n> the work item pool.\n\nWhen we where doing the original MTTCG work I looked at using GArray for\nthe work queue, see:\n\n http://lists.gnu.org/archive/html/qemu-devel/2016-08/msg00367.html\n\nspecifically:\n\n Subject: [PATCH v5 13/13] cpu-exec: replace cpu->queued_work with GArray\n Date: Tue, 2 Aug 2016 18:27:44 +0100\n Message-Id: <1470158864-17651-14-git-send-email-alex.bennee@linaro.org>\n\nwhich I personally think might yield better results than messing around\nwith custom allocators and GSlice and the like. You still get the\ndynamic sizing of a malloc based array but for operations like insertion\nand iterating through the work queue should be cache friendly.\n\nOnce the array has (transparently) reached a reasonable size to service\nall allocations in the usual servicing period the same memory can be\nused over and over again ;-)\n\nMy fondness for arrays is informed by comments by Bjarne Stroustrup:\n\n https://www.youtube.com/watch?v=YQs6IC-vgmo\n\nObviously this patch would need to be re-worked given how much the code\nhas changes since it was merged.\n\n>\n> Signed-off-by: Pranith Kumar \n> ---\n> cpus-common.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++------------\n> 1 file changed, 60 insertions(+), 15 deletions(-)\n>\n> diff --git a/cpus-common.c b/cpus-common.c\n> index 59f751ecf9..ccf5f50e4e 100644\n> --- a/cpus-common.c\n> +++ b/cpus-common.c\n> @@ -24,6 +24,7 @@\n> #include \"sysemu/cpus.h\"\n>\n> static QemuMutex qemu_cpu_list_lock;\n> +static QemuMutex qemu_wi_pool_lock;\n> static QemuCond exclusive_cond;\n> static QemuCond exclusive_resume;\n> static QemuCond qemu_work_cond;\n> @@ -33,6 +34,49 @@ static QemuCond qemu_work_cond;\n> */\n> static int pending_cpus;\n>\n> +typedef struct qemu_work_item {\n> + struct qemu_work_item *next;\n> + run_on_cpu_func func;\n> + run_on_cpu_data data;\n> + bool free, exclusive, done;\n> +} qemu_work_item;\n> +\n> +typedef struct qemu_wi_pool {\n> + qemu_work_item *head;\n> + int num_items;\n> +} qemu_wi_pool;\n> +\n> +qemu_wi_pool *wi_free_pool;\n> +\n> +static void qemu_init_workitem_pool(void)\n> +{\n> + wi_free_pool = g_malloc0(sizeof(qemu_wi_pool));\n> +}\n> +\n> +static void qemu_wi_pool_insert(qemu_work_item *item)\n> +{\n> + qemu_mutex_lock(&qemu_wi_pool_lock);\n> + qemu_work_item *curr = atomic_read(&wi_free_pool->head);\n> + item->next = curr;\n> + wi_free_pool->head = item;\n> + qemu_mutex_unlock(&qemu_wi_pool_lock);\n> +}\n> +\n> +static qemu_work_item *qemu_wi_pool_remove(void)\n> +{\n> + qemu_mutex_lock(&qemu_wi_pool_lock);\n> + qemu_work_item *curr = atomic_read(&wi_free_pool->head);\n> + if (curr == NULL) {\n> + goto out;\n> + }\n> + wi_free_pool->head = curr->next;\n> + curr->next = NULL;\n> +\n> + out:\n> + qemu_mutex_unlock(&qemu_wi_pool_lock);\n> + return curr;\n> +}\n> +\n> void qemu_init_cpu_list(void)\n> {\n> /* This is needed because qemu_init_cpu_list is also called by the\n> @@ -43,6 +87,9 @@ void qemu_init_cpu_list(void)\n> qemu_cond_init(&exclusive_cond);\n> qemu_cond_init(&exclusive_resume);\n> qemu_cond_init(&qemu_work_cond);\n> +\n> + qemu_init_workitem_pool();\n> + qemu_mutex_init(&qemu_wi_pool_lock);\n> }\n>\n> void cpu_list_lock(void)\n> @@ -106,14 +153,7 @@ void cpu_list_remove(CPUState *cpu)\n> qemu_mutex_unlock(&qemu_cpu_list_lock);\n> }\n>\n> -struct qemu_work_item {\n> - struct qemu_work_item *next;\n> - run_on_cpu_func func;\n> - run_on_cpu_data data;\n> - bool free, exclusive, done;\n> -};\n> -\n> -static void queue_work_on_cpu(CPUState *cpu, struct qemu_work_item *wi)\n> +static void queue_work_on_cpu(CPUState *cpu, qemu_work_item *wi)\n> {\n> qemu_mutex_lock(&cpu->work_mutex);\n> if (cpu->queued_work_first == NULL) {\n> @@ -132,7 +172,7 @@ static void queue_work_on_cpu(CPUState *cpu, struct qemu_work_item *wi)\n> void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data,\n> QemuMutex *mutex)\n> {\n> - struct qemu_work_item wi;\n> + qemu_work_item wi;\n>\n> if (qemu_cpu_is_self(cpu)) {\n> func(cpu, data);\n> @@ -156,9 +196,11 @@ void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data,\n>\n> void async_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data)\n> {\n> - struct qemu_work_item *wi;\n> + qemu_work_item *wi = qemu_wi_pool_remove();\n>\n> - wi = g_malloc0(sizeof(struct qemu_work_item));\n> + if (!wi) {\n> + wi = g_malloc0(sizeof(qemu_work_item));\n> + }\n> wi->func = func;\n> wi->data = data;\n> wi->free = true;\n> @@ -299,9 +341,11 @@ void cpu_exec_end(CPUState *cpu)\n> void async_safe_run_on_cpu(CPUState *cpu, run_on_cpu_func func,\n> run_on_cpu_data data)\n> {\n> - struct qemu_work_item *wi;\n> + qemu_work_item *wi = qemu_wi_pool_remove();\n>\n> - wi = g_malloc0(sizeof(struct qemu_work_item));\n> + if (!wi) {\n> + wi = g_malloc0(sizeof(qemu_work_item));\n> + }\n> wi->func = func;\n> wi->data = data;\n> wi->free = true;\n> @@ -312,7 +356,7 @@ void async_safe_run_on_cpu(CPUState *cpu, run_on_cpu_func func,\n>\n> void process_queued_cpu_work(CPUState *cpu)\n> {\n> - struct qemu_work_item *wi;\n> + qemu_work_item *wi;\n>\n> if (cpu->queued_work_first == NULL) {\n> return;\n> @@ -343,7 +387,8 @@ void process_queued_cpu_work(CPUState *cpu)\n> }\n> qemu_mutex_lock(&cpu->work_mutex);\n> if (wi->free) {\n> - g_free(wi);\n> + memset(wi, 0, sizeof(qemu_work_item));\n> + qemu_wi_pool_insert(wi);\n> } else {\n> atomic_mb_set(&wi->done, true);\n> }\n\n\n--\nAlex Bennée","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"APNu1eVa\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmHc23x3z9sRV\n\tfor ;\n\tTue, 5 Sep 2017 22:29:32 +1000 (AEST)","from localhost ([::1]:58655 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpCyw-0006DJ-Cl\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:29:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48794)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpCyM-000689-Ij\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:28:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpCyE-0005W1-Fx\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:28:54 -0400","from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:37514)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpCyE-0005Vm-6u\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:28:46 -0400","by mail-wr0-x22b.google.com with SMTP id n33so8385259wrn.4\n\tfor ; Tue, 05 Sep 2017 05:28:46 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\to9sm443830wre.68.2017.09.05.05.28.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 05:28:44 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id A6CEF3E00FA;\n\tTue, 5 Sep 2017 13:28:43 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=5eBP81Hp6ZRMghyMcdzkvpWPfUhNEiTmQDLkN1yl0Sg=;\n\tb=APNu1eVa3bRavp9VwV0te7SmCmHfR+m1LvQ4biUHB86BFG1OkY1LDlW4Uznw6i9ixi\n\tZlZlzQdtrWxWjXmsHBf4HHLVmZqT0JLe9Ac+ij+nWGT/wamKqhW/f1UDmXc2QfhuRKrb\n\tJnoxrUrgPFiS6tuFPqiIV3T4KIEi/XLKAKi1Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=5eBP81Hp6ZRMghyMcdzkvpWPfUhNEiTmQDLkN1yl0Sg=;\n\tb=DtrvdDVys5HATF3uu9ZtJfJ6V3Go798Cws7aco9mXoQ0NZGGGAmmoEPhEod7f8LNt1\n\tuxnOzuAZY0TJatPrt4OlfbtgixXGxcqw/KvGq1Tx92b7YCLVSHZHkL9yvqWXrg7Jy2EO\n\tRkpKcQoOBE4+SQ80YOrpdJHib1X0cirq3mmRt27rtzoXYDlgf78ApxVeG2w2lSdnmPsW\n\ttUxdvvOM95LkZQcAgApfKvwNalHTG4VptchkP1+DHycab/YVmz6YrAoiAerEsQt9cJ8O\n\tdIMbgGhI8aKHSHaVo8ekKh/0oFlWQ8pdfQFWM7ji8+fPMq7Lnwv1Or7uRbMHAqTlDrYt\n\teucA==","X-Gm-Message-State":"AHPjjUjVSpro27Iy4ktU6GYY7hA4I+yzclTj3Yk1/IKv6Y8PjHwc1AS0\n\tD8T1SBc7++eNTa8s","X-Google-Smtp-Source":"ADKCNb5Rw16rr8yFyEu9XNnswQ53L4lLLpCD702ugkEwLVGQJ1fG60Rz/dNg9J96spMawFTYVwGWPw==","X-Received":"by 10.223.136.170 with SMTP id f39mr2207337wrf.164.1504614525047;\n\tTue, 05 Sep 2017 05:28:45 -0700 (PDT)","References":"<20170829063313.10237-1-bobby.prani@gmail.com>\n\t<20170829063313.10237-2-bobby.prani@gmail.com>","User-agent":"mu4e 0.9.19; emacs 25.2.50.3","From":"Alex =?utf-8?q?Benn=C3=A9e?= ","To":"Pranith Kumar ","In-reply-to":"<20170829063313.10237-2-bobby.prani@gmail.com>","Date":"Tue, 05 Sep 2017 13:28:43 +0100","Message-ID":"<87k21dmiro.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::22b","Subject":"Re: [Qemu-devel] [RFC v3 PATCH 2/5] cpus-common: Cache allocated\n\twork items","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tSergey Fedorov , \n\tqemu-devel@nongnu.org, Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763741,"web_url":"http://patchwork.ozlabs.org/comment/1763741/","msgid":"","list_archive_url":null,"date":"2017-09-06T00:35:14","subject":"Re: [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment","submitter":{"id":64653,"url":"http://patchwork.ozlabs.org/api/people/64653/","name":"Pranith Kumar","email":"bobby.prani@gmail.com"},"content":"Hi Alex,\n\nOn Tue, Sep 5, 2017 at 8:02 AM, Alex Bennée wrote:\n>\n> Pranith Kumar writes:\n>\n>> Update the comment which is not true since MTTCG.\n>\n> What happened to the cover letter? We seem to have a mix of patches but\n> no summary of the overall outcome.\n>\n\nThese are a bunch of unrelated patches, so there is no theme. I will\ninclude a cover letter saying so from now on.\n\nThanks,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HsFenR7c\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn4QC4pcjz9t2y\n\tfor ;\n\tWed, 6 Sep 2017 10:36:19 +1000 (AEST)","from localhost ([::1]:33649 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpOKH-00047M-Re\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 20:36:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53807)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpOJw-00045T-Bt\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 20:35:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpOJr-0001a7-Qe\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 20:35:56 -0400","from mail-it0-x22e.google.com ([2607:f8b0:4001:c0b::22e]:34382)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpOJl-0001XP-TX; Tue, 05 Sep 2017 20:35:45 -0400","by mail-it0-x22e.google.com with SMTP id f199so11400294ita.1;\n\tTue, 05 Sep 2017 17:35:45 -0700 (PDT)","by 10.79.166.2 with HTTP; Tue, 5 Sep 2017 17:35:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=eqZVKCKGdNFpU+xau+CuwVEHQs6ZaYn4/UYBSuLj/Q4=;\n\tb=HsFenR7cepIZW5FQyUT4a4I6RTBDaeToAIjJzRtK4g+7zS0pK7tV62ByQiAgheRQ2d\n\tIeUA4PBrK0k/8ZHvaLHYT9DNzErfQowdMVlfhArD1kdtnYbuso35ZOLzDYW8+AV9L0yt\n\tuAEmldayI3hAqgOb/RZkizp0yK1xNkQK9TtpWMYjI/O3+aNyv+aeX+XCbpprrxOTTizY\n\tyNrkvj+tyoKXOUDBXSRetiWUTPtPkbThisZv2ixYDwrnR2hYmAmHIgvYVWbMIK9BPAxQ\n\tPoI9tGOUuAivSa7VdaWDJ+/omOxBtFRwyHxMiUgdoJCEgOrYI5+kx361H+JKJP5YoYDy\n\t1UOg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=eqZVKCKGdNFpU+xau+CuwVEHQs6ZaYn4/UYBSuLj/Q4=;\n\tb=uBd7+tdaskpTxBy+WcI0dxyEoH72ugdqzfzlaAdP2PTOyyDtG3J37DoPiE/Y/S78fQ\n\t9EtEzeeFQVfTEYGW2yusd0+ngw9Lcv40Dyrdv6mcU6f8SDCWDvfqBg5tyfKXNyypql4L\n\tFRabZ444GMQjs4DaTxGBkRaroSZis/hMPLg70Yiyo8uN8BymQzvpF0SLVVX1IxYfYNIq\n\tV3dOpJgTfW8OC68fKU1XzFS6zyFNkmZ5OUFTOBIaPt+JJyeu/w/6vk4GmlPaCNa7e3ey\n\ti8F5IZRdGxU6LMuDn/0I9gczd+mSQ43SHyEGC18RajqlzrGkwqmBWdqO7zIQQbtGkXyC\n\tSfeA==","X-Gm-Message-State":"AHPjjUgcwDTdzTJqBOFhBMYVAMsoQj0CPmy3m0SO2G0lNLVDfjmYodkL\n\tnLjA5MYhfYsHg8Pirh9sk2D7pMMSog==","X-Google-Smtp-Source":"ADKCNb65ScQwKuC9n3RtU9LLp0GVWKUmsk43tDm85Jo8posTP8dX/HXtQKbb7Dn1A0WBy8W6VtoMGA21DX2dkrHjY4o=","X-Received":"by 10.36.239.134 with SMTP id i128mr1101501ith.68.1504658145249; \n\tTue, 05 Sep 2017 17:35:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<87lgltmjzl.fsf@linaro.org>","References":"<20170829063313.10237-1-bobby.prani@gmail.com>\n\t<87lgltmjzl.fsf@linaro.org>","From":"Pranith Kumar ","Date":"Tue, 5 Sep 2017 20:35:14 -0400","Message-ID":"","To":"=?utf-8?q?Alex_Benn=C3=A9e?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c0b::22e","Subject":"Re: [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\t\"open list:ARM\" ,\n\tqemu-devel , Paolo Bonzini ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]