[{"id":1759098,"web_url":"http://patchwork.ozlabs.org/comment/1759098/","msgid":"","list_archive_url":null,"date":"2017-08-29T07:49:03","subject":"Re: [U-Boot] [PATCH] x86: baytrail: acpi: Add full reset bit to the\n\treset register value in FADT","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"On 29.08.2017 07:09, Bin Meng wrote:\n> It was noticed a few times, that the reboot from Linux (reboot command)\n> is different from the reboot (reset command) under U-Boot. The U-Boot\n> version does seem to reset the board more deeply (PCI cards etc) than\n> the Linux reboot.\n> \n> This is actually caused by missing full reset bit in the reset register\n> value in the ACPI FADT table.\n> \n> Reported-by: Stefan Roese \n> Signed-off-by: Bin Meng \n> ---\n> \n> arch/x86/cpu/baytrail/acpi.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/arch/x86/cpu/baytrail/acpi.c b/arch/x86/cpu/baytrail/acpi.c\n> index cbefdf8..7aac634 100644\n> --- a/arch/x86/cpu/baytrail/acpi.c\n> +++ b/arch/x86/cpu/baytrail/acpi.c\n> @@ -73,7 +73,7 @@ void acpi_create_fadt(struct acpi_fadt *fadt, struct acpi_facs *facs,\n> \tfadt->reset_reg.access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS;\n> \tfadt->reset_reg.addrl = IO_PORT_RESET;\n> \tfadt->reset_reg.addrh = 0;\n> -\tfadt->reset_value = SYS_RST | RST_CPU;\n> +\tfadt->reset_value = SYS_RST | RST_CPU | FULL_RST;\n> \n> \tfadt->x_firmware_ctl_l = (u32)facs;\n> \tfadt->x_firmware_ctl_h = 0;\n> \n\nVery nice Bin, this does exactly what I was missing. :)\n\nTested-by: Stefan Roese \n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhLbL06p5z9t2x\n\tfor ;\n\tTue, 29 Aug 2017 17:57:48 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 135EBC2201A; Tue, 29 Aug 2017 07:52:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8D86FC21E49;\n\tTue, 29 Aug 2017 07:52:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 64091C21F8D; Tue, 29 Aug 2017 07:49:21 +0000 (UTC)","from mx1.mailbox.org (mx1.mailbox.org [80.241.60.212])\n\tby lists.denx.de (Postfix) with ESMTPS id 7B871C22023\n\tfor ; Tue, 29 Aug 2017 07:49:20 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.mailbox.org (Postfix) with ESMTPS id 483474325D;\n\tTue, 29 Aug 2017 09:49:20 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby gerste.heinlein-support.de (gerste.heinlein-support.de\n\t[91.198.250.173]) (amavisd-new, port 10030)\n\twith ESMTP id LqyYlzkTi9Kp; Tue, 29 Aug 2017 09:49:03 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","To":"Bin Meng , Simon Glass ,\n\tU-Boot Mailing List ","References":"<1503983351-27984-1-git-send-email-bmeng.cn@gmail.com>","From":"Stefan Roese ","Message-ID":"","Date":"Tue, 29 Aug 2017 09:49:03 +0200","MIME-Version":"1.0","In-Reply-To":"<1503983351-27984-1-git-send-email-bmeng.cn@gmail.com>","Content-Language":"en-US","Subject":"Re: [U-Boot] [PATCH] x86: baytrail: acpi: Add full reset bit to the\n\treset register value in FADT","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1761555,"web_url":"http://patchwork.ozlabs.org/comment/1761555/","msgid":"","list_archive_url":null,"date":"2017-09-01T09:44:59","subject":"Re: [U-Boot] [PATCH] x86: baytrail: acpi: Add full reset bit to the\n\treset register value in FADT","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Tue, Aug 29, 2017 at 3:49 PM, Stefan Roese wrote:\n> On 29.08.2017 07:09, Bin Meng wrote:\n>>\n>> It was noticed a few times, that the reboot from Linux (reboot command)\n>> is different from the reboot (reset command) under U-Boot. The U-Boot\n>> version does seem to reset the board more deeply (PCI cards etc) than\n>> the Linux reboot.\n>>\n>> This is actually caused by missing full reset bit in the reset register\n>> value in the ACPI FADT table.\n>>\n>> Reported-by: Stefan Roese \n>> Signed-off-by: Bin Meng \n>> ---\n>>\n>> arch/x86/cpu/baytrail/acpi.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/arch/x86/cpu/baytrail/acpi.c b/arch/x86/cpu/baytrail/acpi.c\n>> index cbefdf8..7aac634 100644\n>> --- a/arch/x86/cpu/baytrail/acpi.c\n>> +++ b/arch/x86/cpu/baytrail/acpi.c\n>> @@ -73,7 +73,7 @@ void acpi_create_fadt(struct acpi_fadt *fadt, struct\n>> acpi_facs *facs,\n>> fadt->reset_reg.access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS;\n>> fadt->reset_reg.addrl = IO_PORT_RESET;\n>> fadt->reset_reg.addrh = 0;\n>> - fadt->reset_value = SYS_RST | RST_CPU;\n>> + fadt->reset_value = SYS_RST | RST_CPU | FULL_RST;\n>> fadt->x_firmware_ctl_l = (u32)facs;\n>> fadt->x_firmware_ctl_h = 0;\n>>\n>\n> Very nice Bin, this does exactly what I was missing. :)\n>\n> Tested-by: Stefan Roese \n>\n\napplied to u-boot-x86, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ILW8j5lZ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkDrY5Fpxz9sPk\n\tfor ;\n\tFri, 1 Sep 2017 19:45:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 74B38C21EE6; Fri, 1 Sep 2017 09:45:37 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id DF483C21F20;\n\tFri, 1 Sep 2017 09:45:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E1956C21EBB; Fri, 1 Sep 2017 09:45:03 +0000 (UTC)","from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66])\n\tby lists.denx.de (Postfix) with ESMTPS id 25FBDC21ED5\n\tfor ; Fri, 1 Sep 2017 09:45:00 +0000 (UTC)","by mail-wm0-f66.google.com with SMTP id p17so1954737wmd.3\n\tfor ; Fri, 01 Sep 2017 02:45:00 -0700 (PDT)","by 10.223.135.121 with HTTP; Fri, 1 Sep 2017 02:44:59 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=zl07PkuP+tMeMxK0+9aVTWFQkOIa9z9nxQLCtVYO39Y=;\n\tb=ILW8j5lZM5fYaW7r7LxFo8pxk9PEs9VsJTtTksShIkSUCUedouEaJr45qQ/T32fVpN\n\t9mawV+nSYWV6BySNHg7fGzwZqBwc3uKwyqzQM2Ln0ZRQOjVnJZgjg2X3DaAPJiuJklwz\n\tiN4UTS+U5Lau0+eU7xfXTfY+ZHooRumexKEYMtlLIXGZIWfCJRmBV/9E0x6s/nrDzC3o\n\tj6QpO75E121AByXVllhAgiQE3nEXZDE95x3buOdXK4A3S4FStLoi7IKQWPq8Eu/MwuAo\n\tsBJkjunwD4YhECHxRyzF62sfsxNgIXsaK5EMB60qpCqvIH/60FFFnuueJRHNA3UObZXP\n\tDDyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=zl07PkuP+tMeMxK0+9aVTWFQkOIa9z9nxQLCtVYO39Y=;\n\tb=qsetqQdfSX6c1VSI6UnvxK/uQ3twUq1OmwUc8G/j9H4pM2/9+SYeki9sDAYbPdmVXu\n\tzjXVXqKf8e9HxTvhYrl6o9FDIdIRV5vBgp+WONlWB4wHEYQ4FmzAlmQkOB/fzKSA8rLI\n\tpgwkN+354vnKce7cENAdyqTOylmXN3cEPyvVNEFcv9YFRoglHOIsD7zMY1slN70sSp/R\n\tudStsCBHxLck8Xe/NkoUHuOSVVGWHxco72z5gl80CAQ8Tnd9DsQcl4ovoHhfqERao3UU\n\tGHCMvnxOvW1xtTfu5pUkctuTv6rhuPf6ay4O2TJs4hfgGEA7quzlh+CEJTUPhWfT/184\n\tL1lQ==","X-Gm-Message-State":"AHPjjUim9nPQlcWRbHuUc/4uWTN8p5Y3sA/V+zdVaGPh2C5IhdQZSAHY\n\tJ+Y3ynnKDxbN64cKLK56i52sEl29rg==","X-Google-Smtp-Source":"ADKCNb6tFQjTm55H5ptYV7aFLEiFnfSpAzu1AtPwL2YxEPKSfzNKdtArj27JY1II1+qlr/TQNhMZ9sEDkGzG04AYEcU=","X-Received":"by 10.28.228.195 with SMTP id b186mr37220wmh.137.1504259099863; \n\tFri, 01 Sep 2017 02:44:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503983351-27984-1-git-send-email-bmeng.cn@gmail.com>\n\t","From":"Bin Meng ","Date":"Fri, 1 Sep 2017 17:44:59 +0800","Message-ID":"","To":"Stefan Roese ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH] x86: baytrail: acpi: Add full reset bit to the\n\treset register value in FADT","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]