[{"id":1759190,"web_url":"http://patchwork.ozlabs.org/comment/1759190/","msgid":"<4163d291-6aec-327d-8708-5a3d32078d3b@cumulusnetworks.com>","list_archive_url":null,"date":"2017-08-29T10:13:44","subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 29/08/17 07:22, Roopa Prabhu wrote:\n> From: Roopa Prabhu <roopa@cumulusnetworks.com>\n> \n> A few useful tracepoints to trace bridge forwarding\n> database updates.\n> \n> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>\n> ---\n> v2 - address comments from Florian\n> \n>  include/trace/events/bridge.h |   98 +++++++++++++++++++++++++++++++++++++++++\n>  net/bridge/br_fdb.c           |    7 +++\n>  net/core/net-traces.c         |    6 +++\n>  3 files changed, 111 insertions(+)\n>  create mode 100644 include/trace/events/bridge.h\n> \n\nVery nice and useful, thanks!\n\nAcked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"Y1Pom0tp\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhPcG2J7fz9rxm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 20:13:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751997AbdH2KNs (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 06:13:48 -0400","from mail-wr0-f177.google.com ([209.85.128.177]:34194 \"EHLO\n\tmail-wr0-f177.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751843AbdH2KNr (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 29 Aug 2017 06:13:47 -0400","by mail-wr0-f177.google.com with SMTP id z91so8729884wrc.1\n\tfor <netdev@vger.kernel.org>; Tue, 29 Aug 2017 03:13:46 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\tv17sm2131662wrg.23.2017.08.29.03.13.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 03:13:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=Ds2wvtECzu5G+sbe/PTZH4BozCBYZnLrvBj4fntGmCU=;\n\tb=Y1Pom0tphXgtWMZT2uPph0QuYs8dF5AF+32WobRDMOYEREAzlDgSxQyM+/rNjOI4hE\n\tswX/zXSRXePq6xxJCltP7cQJf10+NhlZ3w0HHQr2txMx26I1DHNSXUtw5xT3xpuC6ZEu\n\t/SSui82cQMU7ee6+ACZQNCMGLvJUjQFuhNWWA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=Ds2wvtECzu5G+sbe/PTZH4BozCBYZnLrvBj4fntGmCU=;\n\tb=aSHLTXxKfDgz924mKCmIT3f1J5RWtWpTAbGPtDc1QRaHtISucG/rcJRJNgP3BcpzG1\n\tMtIGimckkb+8xge6Itn5WW1VIN2pbChPsCLfhCmX5AUcOPhVf0NVHxu2ngNTsP2m3Bvc\n\tCAUhTYhwV5WLQOhX0kyanfplB9Cq98bBj90gH2yuYQW38EmcIi4fofdJle+o62NaM2iY\n\t5wUJEYvCZesNDyZoSUg7vRCX0J+YkeDeba/blSDSi0lJJF4O0LHW9rGZbf/HJ7nnXPlQ\n\tKiAX618W+YUIVxTwtcJ3F/AVYirpx+AWW6K2waCe/iu96fOPALIN/JCX+/HIVxpqr2eV\n\tbKmw==","X-Gm-Message-State":"AHYfb5hBbu5MKr7Rze4Tm+C3/CwSvYQmEdkIY3f7Sy1w1RhBlZ2pSBFU\n\tVPUiifMr9CNOdt4D","X-Received":"by 10.223.176.206 with SMTP id j14mr2065015wra.303.1504001626122;\n\tTue, 29 Aug 2017 03:13:46 -0700 (PDT)","Subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","To":"Roopa Prabhu <roopa@cumulusnetworks.com>, davem@davemloft.net","References":"<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>","Cc":"netdev@vger.kernel.org, f.fainelli@gmail.com,\n\tbridge@lists.linux-foundation.org","From":"Nikolay Aleksandrov <nikolay@cumulusnetworks.com>","Message-ID":"<4163d291-6aec-327d-8708-5a3d32078d3b@cumulusnetworks.com>","Date":"Tue, 29 Aug 2017 13:13:44 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759344,"web_url":"http://patchwork.ozlabs.org/comment/1759344/","msgid":"<20170829133648.GF22093@lunn.ch>","list_archive_url":null,"date":"2017-08-29T13:36:48","subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Mon, Aug 28, 2017 at 09:22:48PM -0700, Roopa Prabhu wrote:\n> From: Roopa Prabhu <roopa@cumulusnetworks.com>\n> \n> A few useful tracepoints to trace bridge forwarding\n> database updates.\n\nHi Roopa\n\nOnce accepted, it would be nice to add mdb tracepoints as well. I\nexpect the implementation would be very similar.\n\n       Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhV6c2Pyjz9t2v\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 23:36:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753569AbdH2Ngy (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 09:36:54 -0400","from vps0.lunn.ch ([178.209.37.122]:43106 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752060AbdH2Ngx (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 29 Aug 2017 09:36:53 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dmghE-0001qQ-Rq; Tue, 29 Aug 2017 15:36:48 +0200"],"Date":"Tue, 29 Aug 2017 15:36:48 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Roopa Prabhu <roopa@cumulusnetworks.com>","Cc":"davem@davemloft.net, netdev@vger.kernel.org,\n\tnikolay@cumulusnetworks.com, f.fainelli@gmail.com,\n\tbridge@lists.linux-foundation.org","Subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","Message-ID":"<20170829133648.GF22093@lunn.ch>","References":"<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759355,"web_url":"http://patchwork.ozlabs.org/comment/1759355/","msgid":"<CAJieiUgGU8h5On7NT=bp4AVJn_txP0UBXBHaSF=8SL1yjkA=7Q@mail.gmail.com>","list_archive_url":null,"date":"2017-08-29T13:49:50","subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","submitter":{"id":23500,"url":"http://patchwork.ozlabs.org/api/people/23500/","name":"Roopa Prabhu","email":"roopa@cumulusnetworks.com"},"content":"On Tue, Aug 29, 2017 at 6:36 AM, Andrew Lunn <andrew@lunn.ch> wrote:\n> On Mon, Aug 28, 2017 at 09:22:48PM -0700, Roopa Prabhu wrote:\n>> From: Roopa Prabhu <roopa@cumulusnetworks.com>\n>>\n>> A few useful tracepoints to trace bridge forwarding\n>> database updates.\n>\n> Hi Roopa\n>\n> Once accepted, it would be nice to add mdb tracepoints as well. I\n> expect the implementation would be very similar.\n>\n\nyes, sounds great. will do.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"IA6s+u35\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhVPZ0lfwz9t33\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 23:49:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752622AbdH2Ntw (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 09:49:52 -0400","from mail-vk0-f49.google.com ([209.85.213.49]:33783 \"EHLO\n\tmail-vk0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752218AbdH2Ntv (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 29 Aug 2017 09:49:51 -0400","by mail-vk0-f49.google.com with SMTP id j7so9653557vke.0\n\tfor <netdev@vger.kernel.org>; Tue, 29 Aug 2017 06:49:51 -0700 (PDT)","by 10.176.73.66 with HTTP; Tue, 29 Aug 2017 06:49:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=PXETU6rFQnSRpo/TbTMzAOoT6gHxRgAxWy1Q+CzFKNo=;\n\tb=IA6s+u35wKniEeA6TjF7Ce2OJ8uZh4587TG42wpudg7oznhSz37GvTcbz7x9FPeLIK\n\tPafLvyeUigNkZxpXgS3s1SxZzBc3b2T1bu+Nt8TEv9nqD+CA7n/9Ov7NTxz6MeehcWeh\n\tpd2ifM9k51GoDVWn8OXbQDCLbbic7BC1mcwmQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=PXETU6rFQnSRpo/TbTMzAOoT6gHxRgAxWy1Q+CzFKNo=;\n\tb=IOBHfyfQ/M0UYX9oOr0+WCZ1CMZoWevZQK5xu0k2LInX+s3Xldg8e6/E3p6E3NpKuk\n\tVRjw1SFSfXeaaxPAT3s2Z3hjw3XD1pycoBc3YX4WNqHBHm2g0U58o/EimtNw7HV8Neod\n\tJv3dSVvvQfLENMFi6N8VIMOHV3IGVmemSh2SZQPt7/OvE0rWMU5wq66HA5zGqGfXWzXr\n\tvM20h2FFD+TNgQybkMDdDdzVlJdQOQ0gnK1MsSBeK9foj7WDpPtqGB+UWf5eooLrFWVn\n\ttyxBjPhvguZVoNVPSgO/A/nWxRjw2I3nZPcy/22mm7a0CsJnOHU8/FcR4vNg5beCapQP\n\tIBuQ==","X-Gm-Message-State":"AHYfb5hs4+7oSxDXsTjkdhn4/KdN4WrzAADyDe9WdIWTx/+aAsTqaqpZ\n\thwzc2e1iarUBnoog17YA7ET1Q/2//I9B","X-Received":"by 10.31.185.15 with SMTP id j15mr230516vkf.180.1504014590497;\n\tTue, 29 Aug 2017 06:49:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170829133648.GF22093@lunn.ch>","References":"<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>\n\t<20170829133648.GF22093@lunn.ch>","From":"Roopa Prabhu <roopa@cumulusnetworks.com>","Date":"Tue, 29 Aug 2017 06:49:50 -0700","Message-ID":"<CAJieiUgGU8h5On7NT=bp4AVJn_txP0UBXBHaSF=8SL1yjkA=7Q@mail.gmail.com>","Subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","To":"Andrew Lunn <andrew@lunn.ch>","Cc":"\"davem@davemloft.net\" <davem@davemloft.net>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\tNikolay Aleksandrov <nikolay@cumulusnetworks.com>,\n\tFlorian Fainelli <f.fainelli@gmail.com>,\n\tbridge@lists.linux-foundation.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759533,"web_url":"http://patchwork.ozlabs.org/comment/1759533/","msgid":"<8737eb73-3437-5529-6f4d-7aa52c770357@gmail.com>","list_archive_url":null,"date":"2017-08-29T16:46:05","subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 08/28/2017 09:22 PM, Roopa Prabhu wrote:\n> From: Roopa Prabhu <roopa@cumulusnetworks.com>\n> \n> A few useful tracepoints to trace bridge forwarding\n> database updates.\n> \n> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>\n\nReviewed-by: Florian Fainelli <f.fainelli@gmail.com>\n\nSmall nit below, but probably not a candidate for a v3\n\n> ---\n\n> +\n> +\tTP_printk(\"dev %s addr %02x:%02x:%02x:%02x:%02x:%02x vid %u nlh_flags %04x ndm_flags = %02x\",\n\nSmall nit, any particular reason why ndm_flags got a special treatment\nwith an equal character and not the other?\n\n> +\t\t  __get_str(dev), __entry->addr[0], __entry->addr[1],\n> +\t\t  __entry->addr[2], __entry->addr[3], __entry->addr[4],\n> +\t\t  __entry->addr[5], __entry->vid,\n> +\t\t  __entry->nlh_flags, __entry->ndm_flags)","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"AtphGnR1\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhZK60sDVz9t38\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 02:46:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751485AbdH2QqP (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 12:46:15 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:34444 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751180AbdH2QqO (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 29 Aug 2017 12:46:14 -0400","by mail-wr0-f194.google.com with SMTP id z91so2660620wrc.1\n\tfor <netdev@vger.kernel.org>; Tue, 29 Aug 2017 09:46:13 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tz39sm4186408wrz.61.2017.08.29.09.46.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 09:46:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=QQ3b1ph9QN/ecfSJ1D7VcTLKbwEjNhLzVVyYsvCG7to=;\n\tb=AtphGnR1FxmnO7qRjrqr/xIrhmdunIvUIXzPzLWnHAE37ymkzpOy5CAttoW6O0osnW\n\ttHjMdi+LHrdfK2J1m4+wmll3qhR7zBAwZZUBBtoWGhvjfZxWOy3FAi5EKnt2BRE15GdY\n\twoh5tXf8pm4M8aG+3Mpow0VOezjsvHgtiAw0s92slKn4oZxZw/cEvOJv+rB3YVCiBuvb\n\tCQsM61gBpoDQfrPH24ri91jvb2kxiuRcDkPfJh3tFfdfQfAQesHLlcP3qD1q7EMU0eoJ\n\tp3AqPcdr4oSsJiXDoghGckL8rkHSvWOQJh5oYY6I1osJyymjuFiT7XtEoRW5CUlaCeWu\n\th5og==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=QQ3b1ph9QN/ecfSJ1D7VcTLKbwEjNhLzVVyYsvCG7to=;\n\tb=KYD1Fh7twWoAs/uTwsyZuyR+Qv6//K69/lbTtOzEwndhbmkH0UJFMETWDq+ERhEBWn\n\toNKrLJ5tKgC51k3nhSU2fgEjFJhBl9nwW/TEzTdXvuvjeQ7StRKv9IA8fTqi6AIZYq3Z\n\tkCiM3GZPxWYRS+Xer0W8ZSWUOgym43vrz5pIZOkCI5JUqR4oqWKMmmggQE/lkpkqELiM\n\tU9Bt3AX7y2TicFZDEajSbG7kxpPJcCy7WGlnjenVujozCu3Mt7GBvB91J3k3Iuij5CLP\n\tkH0UvzgTKbYcRZtAMYwY4tJwl6At/ApQ+TvxRky1j24lLmN+M7lzB8gZvpU2XooDbJ1Q\n\tojCQ==","X-Gm-Message-State":"AHYfb5j0h4szK13EimFOOlJrrKHtupQV87RGfYpO43VaccdHsmuUKVnh\n\tpRXCSrihIkNeZg==","X-Received":"by 10.223.133.130 with SMTP id 2mr669825wrt.177.1504025172992;\n\tTue, 29 Aug 2017 09:46:12 -0700 (PDT)","Subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","To":"Roopa Prabhu <roopa@cumulusnetworks.com>, davem@davemloft.net","Cc":"netdev@vger.kernel.org, nikolay@cumulusnetworks.com,\n\tbridge@lists.linux-foundation.org","References":"<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>","From":"Florian Fainelli <f.fainelli@gmail.com>","Message-ID":"<8737eb73-3437-5529-6f4d-7aa52c770357@gmail.com>","Date":"Tue, 29 Aug 2017 09:46:05 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759569,"web_url":"http://patchwork.ozlabs.org/comment/1759569/","msgid":"<CAJieiUh6D5iUBBq1owL-=Sja9bEYYLOT6P7NTgKZYOMDwyLr_Q@mail.gmail.com>","list_archive_url":null,"date":"2017-08-29T17:36:50","subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","submitter":{"id":23500,"url":"http://patchwork.ozlabs.org/api/people/23500/","name":"Roopa Prabhu","email":"roopa@cumulusnetworks.com"},"content":"On Tue, Aug 29, 2017 at 9:46 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:\n> On 08/28/2017 09:22 PM, Roopa Prabhu wrote:\n>> From: Roopa Prabhu <roopa@cumulusnetworks.com>\n>>\n>> A few useful tracepoints to trace bridge forwarding\n>> database updates.\n>>\n>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>\n>\n> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>\n>\n> Small nit below, but probably not a candidate for a v3\n>\n>> ---\n>\n>> +\n>> +     TP_printk(\"dev %s addr %02x:%02x:%02x:%02x:%02x:%02x vid %u nlh_flags %04x ndm_flags = %02x\",\n>\n> Small nit, any particular reason why ndm_flags got a special treatment\n> with an equal character and not the other?\n>\n\n\ngood eyes, thats a typo. I did scan them once and removed the '=' and\nmissed a spot.\ni will send v3.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"NdlbwNSM\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhbRV3J1Fz9t3J\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 03:36:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751280AbdH2Rgw (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 13:36:52 -0400","from mail-ua0-f178.google.com ([209.85.217.178]:33549 \"EHLO\n\tmail-ua0-f178.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750815AbdH2Rgv (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 29 Aug 2017 13:36:51 -0400","by mail-ua0-f178.google.com with SMTP id 37so12369547ual.0\n\tfor <netdev@vger.kernel.org>; Tue, 29 Aug 2017 10:36:51 -0700 (PDT)","by 10.176.73.66 with HTTP; Tue, 29 Aug 2017 10:36:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=l0OQSVEmfCX/6WvBLZKl0bFYaFrdaT5X5d2qM7ANddA=;\n\tb=NdlbwNSMUOoMV2q0bibchvSfkUqAomjYA2HKMSjsWt0OHnjcRAZNeChGkUb2OSPTxP\n\tKlguxn6H1ipfLk0CwSW84KEydP5y3B6OPz1NURqE4IhCZl1NBEsEk6MQ4Hr9C0SJ9m7Z\n\tZtFpqoz3+fIwCPJIIftmrkekaTtFKnck0BuzI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=l0OQSVEmfCX/6WvBLZKl0bFYaFrdaT5X5d2qM7ANddA=;\n\tb=QIEse67P+E3IdERRyDxTUOqraTUqcgRsdYPBt6kD6WBp2MRLkxi9Wvh3sp0ZLuW0P4\n\t1mnWtuyy5Szb/wdSICIOLRA6O3c6oU18dPHaIvwSbLU0q5GqIwq6PVX+bxA03J9FLKpR\n\tM/VFdUYM2oQzC+wxd5Zdne3bFsL3uyCNf6dYDOwn5XYSKS3Z58Gdi3+k8O3+XhqGjbRv\n\to2AZSu2onMSLWpnh8zqXwXeStvKe4oDz4+JTxWE1aEHxYLh5hxCi1XwL0511ds7+GqK8\n\t33E9qyPcgvlEo9PPenMOiM+WySR3UFBpJplANtdVimIPJkpGDr7gLylyyWUY6kKmN6Rw\n\tiXzQ==","X-Gm-Message-State":"AHYfb5h43Unea7vU3VtowFAKlvc3Wk3go41R1GVepcUIY+F/HeZDF6VC\n\tM7HlWg4Sy9iCGifyEhj9yEstdubZX7ux","X-Received":"by 10.159.59.68 with SMTP id j4mr716051uah.60.1504028210476; Tue,\n\t29 Aug 2017 10:36:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<8737eb73-3437-5529-6f4d-7aa52c770357@gmail.com>","References":"<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>\n\t<8737eb73-3437-5529-6f4d-7aa52c770357@gmail.com>","From":"Roopa Prabhu <roopa@cumulusnetworks.com>","Date":"Tue, 29 Aug 2017 10:36:50 -0700","Message-ID":"<CAJieiUh6D5iUBBq1owL-=Sja9bEYYLOT6P7NTgKZYOMDwyLr_Q@mail.gmail.com>","Subject":"Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints","To":"Florian Fainelli <f.fainelli@gmail.com>","Cc":"\"davem@davemloft.net\" <davem@davemloft.net>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\tNikolay Aleksandrov <nikolay@cumulusnetworks.com>,\n\tbridge@lists.linux-foundation.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]