[{"id":1760502,"web_url":"http://patchwork.ozlabs.org/comment/1760502/","msgid":"<20170830232537.46d32939@windsurf.lan>","list_archive_url":null,"date":"2017-08-30T21:25:37","subject":"Re: [Buildroot] [PATCH v3] add package for pdmenu","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Mon, 28 Aug 2017 16:22:29 -0600, Brock Williams wrote:\n> Signed-off-by: Brock Williams \n\nSo, I applied your patch, but after fixing a number of issues. Some\neasy, some more complicated. See below.\n\n> diff --git a/package/pdmenu/pdmenu.hash b/package/pdmenu/pdmenu.hash\n> new file mode 100644\n> index 0000000..be6d27a\n> --- /dev/null\n> +++ b/package/pdmenu/pdmenu.hash\n> @@ -0,0 +1 @@\n\nMissing comment above the hash that says where it comes from.\n\n> +md5\t0623b992572511d5fd90d481c426fa40\tpdmenu_1.3.4.tar.gz\n\nWe use sha256 hashes when locally calculated, so I've added that.\n\nI've also added the hash for the license file.\n\n> diff --git a/package/pdmenu/pdmenu.mk b/package/pdmenu/pdmenu.mk\n> new file mode 100644\n> index 0000000..f3d9fba\n> --- /dev/null\n> +++ b/package/pdmenu/pdmenu.mk\n> @@ -0,0 +1,15 @@\n> +################################################################################\n> +#\n> +# pdmenu\n> +#\n> +################################################################################\n> +\n> +PDMENU_VERSION = 1.3.4\n> +PDMENU_SOURCE = pdmenu_$(PDMENU_VERSION).tar.gz\n> +PDMENU_SITE = http://snapshot.debian.org/archive/debian/20170828T160058Z/pool/main/p/pdmenu\n> +PDMENU_LICENSE = GPL-2.0+\n\nNowhere they say it's GPLv2 or later. They only include the license\ntext of the GPLv2, with no further information. So the license is\nGPL-2.0 only.\n\n> +PDMENU_LICENSE_FILES = COPYING.GPLv2\n\nThis file does not exist, it's doc/COPYING.\n\n> +PDMENU_DEPENDENCIES = slang\n\nNow the more complicated part is that the NLS handling was broken, in\ntwo situations:\n\n * If NLS support is enabled with uClibc/musl, the gettext functions are\n located in an external library (not in the C library) called\n libintl, and pdmenu was not linking with it. I've added a first\n patch to fix this. I also had to add $(TARGET_NLS_DEPENDENCIES) to\n PDMENU_DEPENDENCIES to make sure host-gettext/gettext get defined as\n necessary.\n\n * On the other hand, even if NLS support was disabled, pdmenu Makefile\n was trying to use the msgfmt tool on the build machine to\n generate .mo files from .po files, causing a build failure. I fixed\n that by adding another patch that only builds/installs .mo files if\n msgfmt is available.\n\nThanks for your contribution!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjJTG2fKsz9s8P\n\tfor ;\n\tThu, 31 Aug 2017 07:25:54 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 52A938749B;\n\tWed, 30 Aug 2017 21:25:52 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NjlqbID31qqg; Wed, 30 Aug 2017 21:25:51 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1D26987464;\n\tWed, 30 Aug 2017 21:25:51 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 33F251C09DE\n\tfor ;\n\tWed, 30 Aug 2017 21:25:50 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2BA9F8761E\n\tfor ;\n\tWed, 30 Aug 2017 21:25:50 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Zhb4SII7bUpd for ;\n\tWed, 30 Aug 2017 21:25:49 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 57D09874B5\n\tfor ; Wed, 30 Aug 2017 21:25:49 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 02C6C21F64; Wed, 30 Aug 2017 23:25:47 +0200 (CEST)","from windsurf.lan (LFbn-1-15133-129.w86-206.abo.wanadoo.fr\n\t[86.206.239.129])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id C183521F5F;\n\tWed, 30 Aug 2017 23:25:36 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 30 Aug 2017 23:25:37 +0200","From":"Thomas Petazzoni ","To":"Brock Williams ","Message-ID":"<20170830232537.46d32939@windsurf.lan>","In-Reply-To":"<1503958949-17690-1-git-send-email-brock@cottonwoodcomputer.com>","References":"<1503958949-17690-1-git-send-email-brock@cottonwoodcomputer.com>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v3] add package for pdmenu","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]