[{"id":1759289,"web_url":"http://patchwork.ozlabs.org/comment/1759289/","msgid":"<1768059.eopKmxhyQx@avalon>","list_archive_url":null,"date":"2017-08-29T12:37:18","subject":"Re: [PATCH 09/17] ARM: dts: Add missing iss node and binding for\n\tomap4","submitter":{"id":11034,"url":"http://patchwork.ozlabs.org/api/people/11034/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tony,\n\nThank you for the patch.\n\nOn Tuesday, 29 August 2017 00:19:10 EEST Tony Lindgren wrote:\n> On omap4 we're missing the iss node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Cc: Laurent Pinchart \n> Cc: Mauro Carvalho Chehab \n> Cc: Sakari Ailus \n> Signed-off-by: Tony Lindgren \n> ---\n> Documentation/devicetree/bindings/media/ti-iss.txt | 32 +++++++++++++++++++\n> arch/arm/boot/dts/omap4.dtsi | 7 +++++\n> 2 files changed, 39 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/media/ti-iss.txt\n> \n> diff --git a/Documentation/devicetree/bindings/media/ti-iss.txt\n> b/Documentation/devicetree/bindings/media/ti-iss.txt new file mode 100644\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/media/ti-iss.txt\n> @@ -0,0 +1,32 @@\n> +Texas Instruments Imaging Subsystem (ISS) binding\n> +\n> +ISS is used for cameras on Texas Instruments SoCs.\n> +\n> +\n> +Required properties:\n> +\n> +compatible: Shall be one of the following:\n> +\t \"ti,omap4-iss\"\n> +\n> +reg: Shall contain the device instance IO range\n> +\n> +interrupts: Shall contain the device instance interrupt\n> +\n> +\n> +Optional properties:\n> +\n> +reg-names: Shall contain the IO range names if multiple IO\n> +\t ranges are used by the SoC\n> +\n> +ti,hwmods: Shall contain the TI interconnect module name if needed\n> +\t by the SoC\n\nThis isn't enough. The ISS isn't a stand-alone IP core, it is connected to \nexternal devices and those connections must be modelled in DT similarly to the \nOMAP3 ISP.\n\n> +Example:\n> +\n> +\tiss: iss@52000000 {\n> +\t\tcompatible = \"ti,omap4-iss\";\n> +\t\treg = <0x52000000 0x1000000>;\n> +\t\tinterrupts = ;\n> +\t\tti,hwmods = \"iss\";\n> +\t};\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -649,6 +649,13 @@\n> \t\t\t#iommu-cells = <0>;\n> \t\t};\n> \n> +\t\tiss: iss@52000000 {\n> +\t\t\tcompatible = \"ti,omap4-iss\";\n> +\t\t\treg = <0x52000000 0x1000000>;\n> +\t\t\tinterrupts = ;\n> +\t\t\tti,hwmods = \"iss\";\n> +\t\t};\n> +\n> \t\tmmu_ipu: mmu@55082000 {\n> \t\t\tcompatible = \"ti,omap4-iommu\";\n> \t\t\treg = <0x55082000 0x100>;","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Vjdk94Yb\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhSnB5w4cz9sNc\n\tfor ;\n\tTue, 29 Aug 2017 22:36:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751317AbdH2Mgp (ORCPT\n\t);\n\tTue, 29 Aug 2017 08:36:45 -0400","from galahad.ideasonboard.com ([185.26.127.97]:57150 \"EHLO\n\tgalahad.ideasonboard.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751243AbdH2Mgo (ORCPT\n\t); Tue, 29 Aug 2017 08:36:44 -0400","from avalon.localnet (unknown [145.15.244.38])\n\tby galahad.ideasonboard.com (Postfix) with ESMTPSA id 04BC5201C5;\n\tTue, 29 Aug 2017 14:35:00 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1504010100;\n\tbh=dX2GSg878Szo8CUTtVSjiqv/V6TpwgKcJ0ErHzlB9Fs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Vjdk94YbcwOYIr8+uX1Gh1T5pTb8onbwUS3A5ZocV794E8fN0Er3RY33G1d99GfaW\n\tEiEEq7bruipogCrKqt1mhjkUy63d+AnsLqUKGHucaoj76dI37yF3AYttXiav4UjX08\n\t1CS/APJlGoX9CjwLr+VrMuZq1qO0Xd128Yy0Wb7c=","From":"Laurent Pinchart ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMauro Carvalho Chehab , \n\tSakari Ailus ","Subject":"Re: [PATCH 09/17] ARM: dts: Add missing iss node and binding for\n\tomap4","Date":"Tue, 29 Aug 2017 15:37:18 +0300","Message-ID":"<1768059.eopKmxhyQx@avalon>","In-Reply-To":"<20170828211918.11573-10-tony@atomide.com>","References":"<20170828211918.11573-1-tony@atomide.com>\n\t<20170828211918.11573-10-tony@atomide.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1759385,"web_url":"http://patchwork.ozlabs.org/comment/1759385/","msgid":"<20170829142253.GT6008@atomide.com>","list_archive_url":null,"date":"2017-08-29T14:22:53","subject":"Re: [PATCH 09/17] ARM: dts: Add missing iss node and binding for\n\tomap4","submitter":{"id":365,"url":"http://patchwork.ozlabs.org/api/people/365/","name":"Tony Lindgren","email":"tony@atomide.com"},"content":"* Laurent Pinchart [170829 05:37]:\n> On Tuesday, 29 August 2017 00:19:10 EEST Tony Lindgren wrote:\n> > On omap4 we're missing the iss node with it's related \"ti,hwmods\"\n> > property that the SoC interconnect code needs.\n> > \n> > Note that this will only show up as a bug with \"doesn't have\n> > mpu register target base\" boot errors when the legacy platform\n> > data is removed.\n...\n\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/media/ti-iss.txt\n> > @@ -0,0 +1,32 @@\n> > +Texas Instruments Imaging Subsystem (ISS) binding\n> > +\n> > +ISS is used for cameras on Texas Instruments SoCs.\n> > +\n> > +\n> > +Required properties:\n> > +\n> > +compatible: Shall be one of the following:\n> > +\t \"ti,omap4-iss\"\n> > +\n> > +reg: Shall contain the device instance IO range\n> > +\n> > +interrupts: Shall contain the device instance interrupt\n> > +\n> > +\n> > +Optional properties:\n> > +\n> > +reg-names: Shall contain the IO range names if multiple IO\n> > +\t ranges are used by the SoC\n> > +\n> > +ti,hwmods: Shall contain the TI interconnect module name if needed\n> > +\t by the SoC\n> \n> This isn't enough. The ISS isn't a stand-alone IP core, it is connected to \n> external devices and those connections must be modelled in DT similarly to the \n> OMAP3 ISP.\n\nOK I'll add a note about those so the driver can add those later\nwith a separate patch.\n\nRegards,\n\nTony\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhW7k4nJsz9t16\n\tfor ;\n\tWed, 30 Aug 2017 00:22:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752745AbdH2OW5 (ORCPT\n\t);\n\tTue, 29 Aug 2017 10:22:57 -0400","from muru.com ([72.249.23.125]:38372 \"EHLO muru.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752683AbdH2OW4 (ORCPT );\n\tTue, 29 Aug 2017 10:22:56 -0400","from atomide.com (localhost [127.0.0.1])\n\tby muru.com (Postfix) with ESMTPS id 2B07C813A;\n\tTue, 29 Aug 2017 14:23:17 +0000 (UTC)"],"Date":"Tue, 29 Aug 2017 07:22:53 -0700","From":"Tony Lindgren ","To":"Laurent Pinchart ","Cc":"linux-omap@vger.kernel.org, =?utf-8?q?Beno=C3=AEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMauro Carvalho Chehab , \n\tSakari Ailus ","Subject":"Re: [PATCH 09/17] ARM: dts: Add missing iss node and binding for\n\tomap4","Message-ID":"<20170829142253.GT6008@atomide.com>","References":"<20170828211918.11573-1-tony@atomide.com>\n\t<20170828211918.11573-10-tony@atomide.com>\n\t<1768059.eopKmxhyQx@avalon>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1768059.eopKmxhyQx@avalon>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]