[{"id":1762456,"web_url":"http://patchwork.ozlabs.org/comment/1762456/","msgid":"<6e1f8163-d457-22f1-4d96-9f278c22144c@ti.com>","list_archive_url":null,"date":"2017-09-04T06:55:48","subject":"Re: [PATCH 11/17] ARM: dts: Add missing mcasp node for omap4","submitter":{"id":9142,"url":"http://patchwork.ozlabs.org/api/people/9142/","name":"Peter Ujfalusi","email":"peter.ujfalusi@ti.com"},"content":"\n\n\nTexas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki\n\nOn 2017-08-29 00:19, Tony Lindgren wrote:\n> On omap4 we're missing the mcasp node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Cc: Liam Girdwood \n> Cc: Mark Brown \n> Cc: Peter Ujfalusi \n> Signed-off-by: Tony Lindgren \n> ---\n> Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt | 1 +\n> arch/arm/boot/dts/omap4.dtsi | 9 +++++++++\n> 2 files changed, 10 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt\n> --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt\n> +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt\n> @@ -6,6 +6,7 @@ Required properties:\n> \t\"ti,da830-mcasp-audio\"\t: for both DA830 & DA850 platforms\n> \t\"ti,am33xx-mcasp-audio\"\t: for AM33xx platforms (AM33xx, AM43xx, TI81xx)\n> \t\"ti,dra7-mcasp-audio\"\t: for DRA7xx platforms\n> +\t\"ti,omap4-mcasp-audio\"\t: for OMAP4 platforms\n> \n> - reg : Should contain reg specifiers for the entries in the reg-names property.\n> - reg-names : Should contain:\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -750,6 +750,15 @@\n> \t\t\tstatus = \"disabled\";\n> \t\t};\n> \n> +\t\tmcasp: mcasp@40128000 {\n> +\t\t\tcompatible = \"ti,omap4-mcasp-audio\";\n> +\t\t\treg = <0x40128000 0x400>, /* MPU private access */\n> +\t\t\t <0x49028000 0x400>; /* L3 Interconnect */\n> +\t\t\treg-names = \"mpu\", \"dma\";\n> +\t\t\tinterrupts = ;\n\ninterrupt-names = \"tx\";\n\nCan you add the DMA as well:\ndmas = <&sdma 8>;\ndma-names = \"tx\";\n\nThe RX of McASP is disabled, no RX DMA request.\n\n> +\t\t\tti,hwmods = \"mcasp\";\n> +\t\t};\n> +\n> \t\tslimbus1: slimbus@4012c000 {\n> \t\t\tcompatible = \"ti,omap4-slimbus\";\n> \t\t\treg = <0x4012c000 0x400>, /* MPU private access */\n> \n\n- Péter\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"TZmKXExy\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm0wj1jkbz9s7h\n\tfor ;\n\tMon, 4 Sep 2017 16:55:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752536AbdIDGzb (ORCPT\n\t);\n\tMon, 4 Sep 2017 02:55:31 -0400","from lelnx194.ext.ti.com ([198.47.27.80]:14707 \"EHLO\n\tlelnx194.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751620AbdIDGzb (ORCPT\n\t); Mon, 4 Sep 2017 02:55:31 -0400","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v846tPug022326; \n\tMon, 4 Sep 2017 01:55:25 -0500","from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v846tOfx029870;\n\tMon, 4 Sep 2017 01:55:24 -0500","from DLEE106.ent.ti.com (157.170.170.36) by DLEE115.ent.ti.com\n\t(157.170.170.26) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tMon, 4 Sep 2017 01:55:24 -0500","from dflp33.itg.ti.com (10.64.6.16) by DLEE106.ent.ti.com\n\t(157.170.170.36) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Mon, 4 Sep 2017 01:55:24 -0500","from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v846tMLq029373;\n\tMon, 4 Sep 2017 01:55:23 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1504508125;\n\tbh=IL1970x3F7s7n7miV8v+f9eAgMH4r/KBo10wkjvVyEg=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=TZmKXExyAc+fWZ/kyEJ7ZdQ351F8Qm2UWmJjnajAROb5P//PBglPYcs0HdG4i9ZdE\n\t2rNjxSvHowGQsDB6IBlSC9S4SpwVHGiegAG1xkg8YPYKy3ubFOfEMsdcHxTfSZkHFP\n\tLUuH+AaOkxm40i1UmeESTEGz3fH7W6Gzl6eedPRM=","Subject":"Re: [PATCH 11/17] ARM: dts: Add missing mcasp node for omap4","To":"Tony Lindgren , ","References":"<20170828211918.11573-1-tony@atomide.com>\n\t<20170828211918.11573-12-tony@atomide.com>","CC":"=?utf-8?q?Beno=C3=AEt_Cousson?= ,\n\t, Liam Girdwood , \n\tMark Brown ","From":"Peter Ujfalusi ","Message-ID":"<6e1f8163-d457-22f1-4d96-9f278c22144c@ti.com>","Date":"Mon, 4 Sep 2017 09:55:48 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170828211918.11573-12-tony@atomide.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]