[{"id":1759306,"web_url":"http://patchwork.ozlabs.org/comment/1759306/","msgid":"<20170829125822.GJ13471@gate.crashing.org>","list_archive_url":null,"date":"2017-08-29T12:58:23","subject":"Re: [PATCH,\n\trs6000] Stop non-volatile CR usage from killing shrink-wrap","submitter":{"id":134,"url":"http://patchwork.ozlabs.org/api/people/134/","name":"Segher Boessenkool","email":"segher@kernel.crashing.org"},"content":"Hi Pat,\n\nOn Mon, Aug 28, 2017 at 04:34:16PM -0500, Pat Haugen wrote:\n> The following patch allows shrink-wrapping to succeed in the presence of\n> non-volatile CR save/restore. The movesi_from_cr define_insn used to\n> list all CRs as used, even though it's only the non-volatile values that\n> we are interested in saving/restoring. This prevented the prolog from\n> being moved past the early exit test because that compare was defining a\n> register used in the prolog (a volatile CR). The patch removes the\n> mentions of the volatile CRs and renames the functions involved so that\n> it's hopefully clear they are for prolog generation only.\n\nIt is spelled \"prologue\" (prolog is a computer language).\n\n> --- gcc/config/rs6000/rs6000.c\t(revision 251389)\n> +++ gcc/config/rs6000/rs6000.c\t(working copy)\n> @@ -26083,10 +26083,14 @@ rs6000_emit_savres_rtx (rs6000_stack_t *\n> return insn;\n> }\n> \n> -/* Emit code to store CR fields that need to be saved into REG. */\n> +/* Emit prolog code to store CR fields that need to be saved into REG. This\n\nSuper nit: two spaces after a full stop.\n\nOkay for trunk with those fixed. Thanks!\n\n\nSegher","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461083-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"RwjTZ6g9\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhTGq1klPz9t38\n\tfor ;\n\tTue, 29 Aug 2017 22:58:56 +1000 (AEST)","(qmail 82490 invoked by alias); 29 Aug 2017 12:58:47 -0000","(qmail 82408 invoked by uid 89); 29 Aug 2017 12:58:42 -0000","from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tTue, 29 Aug 2017 12:58:32 +0000","from gate.crashing.org (localhost.localdomain [127.0.0.1])\tby\n\tgate.crashing.org (8.14.1/8.13.8) with ESMTP id\n\tv7TCwPJa016792; Tue, 29 Aug 2017 07:58:25 -0500","(from segher@localhost)\tby gate.crashing.org\n\t(8.14.1/8.14.1/Submit) id v7TCwNIT016787;\n\tTue, 29 Aug 2017 07:58:23 -0500"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=j8RWMWIWzcz9RsgvD\n\tBRkarPTO0mKOGz1EHCSqwu+IUkVq/d/PytQt9pk6itndVDPhQCtBFoJaOJOxaBSt\n\tC1Tu8jSzy4f/ESNSqTWN38KrWMo10MUiTE4MLDEGwON5X5+UkNs97vgKLEEflAJ5\n\t3x1Raj+CuCzTg7cO+MnT/48Z4A=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=f37Nfm7sfBmcpFd/3/o2Xgr\n\t8Qn0=; b=RwjTZ6g9BqN1WMoo1rxi6ZHHgh3C3kHOGvEfaKMeamIfTKshAN4gYnO\n\tV3jToYoYhSt8SGHmbRiFLVn9tr6hmxxFFkm9yOiX4rHbdadqQCnWcPZUuClu7a8m\n\tb7MDCBX9c1BMuK/dB1QieTEDprSEVxOZ5d/V7aNXdJKShjxFFrj8=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.1 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_2, GIT_PATCH_3,\n\tRP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=super","X-HELO":"gate.crashing.org","Date":"Tue, 29 Aug 2017 07:58:23 -0500","From":"Segher Boessenkool ","To":"Pat Haugen ","Cc":"GCC Patches , David Edelsohn ","Subject":"Re: [PATCH,\n\trs6000] Stop non-volatile CR usage from killing shrink-wrap","Message-ID":"<20170829125822.GJ13471@gate.crashing.org>","References":"","Mime-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.4.2.3i","X-IsSubscribed":"yes"}}]