[{"id":1759748,"web_url":"http://patchwork.ozlabs.org/comment/1759748/","msgid":"<20170829.153316.1820450184399128262.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-29T22:33:16","subject":"Re: [PATCH net-next] ipv6: Use rt6i_idev index for echo replies to\n\ta local address","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: David Ahern \nDate: Mon, 28 Aug 2017 13:53:34 -0700\n\n> Tariq repored local pings to linklocal address is failing:\n> $ ifconfig ens8\n> ens8: flags=4163 mtu 1500\n> inet 11.141.16.6 netmask 255.255.0.0 broadcast 11.141.255.255\n> inet6 fe80::7efe:90ff:fecb:7502 prefixlen 64 scopeid 0x20\n> ether 7c:fe:90:cb:75:02 txqueuelen 1000 (Ethernet)\n> RX packets 12 bytes 1164 (1.1 KiB)\n> RX errors 0 dropped 0 overruns 0 frame 0\n> TX packets 30 bytes 2484 (2.4 KiB)\n> TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0\n> \n> $ /bin/ping6 -c 3 fe80::7efe:90ff:fecb:7502%ens8\n> PING fe80::7efe:90ff:fecb:7502%ens8(fe80::7efe:90ff:fecb:7502) 56 data bytes\n> \n> --- fe80::7efe:90ff:fecb:7502%ens8 ping statistics ---\n> 3 packets transmitted, 0 received, 100% packet loss, time 2043ms\n> \n> icmpv6_echo_reply needs to use the rt6i_idev dev index for local traffic\n> similar to how icmp6_send does. Convert the change for icmp6_send into a\n> helper that can be used in both places. Add the long over due\n> skb_rt6_info helper to convert dst on an skb to rt6_info similar to\n> skb_rtable for ipv4.\n> \n> Fixes: 4832c30d5458 (\"net: ipv6: put host and anycast routes on\n> device with address\")\n> Reported-by: Tariq Toukan \n> Signed-off-by: David Ahern \n\nApplied but please do not break up Fixes: tags even if the line is\nvery long.\n\nOtherwise it's a pain to grep the logs for specific multi-word string\nsequences in the Fixes tag.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhk1X3CzTz9s8J\n\tfor ;\n\tWed, 30 Aug 2017 08:33:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751329AbdH2WdS (ORCPT );\n\tTue, 29 Aug 2017 18:33:18 -0400","from shards.monkeyblade.net ([184.105.139.130]:40574 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751270AbdH2WdR (ORCPT\n\t); Tue, 29 Aug 2017 18:33:17 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id DC8F813D94074;\n\tTue, 29 Aug 2017 15:33:16 -0700 (PDT)"],"Date":"Tue, 29 Aug 2017 15:33:16 -0700 (PDT)","Message-Id":"<20170829.153316.1820450184399128262.davem@davemloft.net>","To":"dsahern@gmail.com","Cc":"netdev@vger.kernel.org, tariqt@mellanox.com","Subject":"Re: [PATCH net-next] ipv6: Use rt6i_idev index for echo replies to\n\ta local address","From":"David Miller ","In-Reply-To":"<1503953614-32395-1-git-send-email-dsahern@gmail.com>","References":"<1503953614-32395-1-git-send-email-dsahern@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 29 Aug 2017 15:33:17 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759829,"web_url":"http://patchwork.ozlabs.org/comment/1759829/","msgid":"<1504063094.11498.112.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-08-30T03:18:14","subject":"Re: [PATCH net-next] ipv6: Use rt6i_idev index for echo replies to\n\ta local address","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Mon, 2017-08-28 at 13:53 -0700, David Ahern wrote:\n> Tariq repored local pings to linklocal address is failing:\n> $ ifconfig ens8\n> ens8: flags=4163 mtu 1500\n> inet 11.141.16.6 netmask 255.255.0.0 broadcast 11.141.255.255\n> inet6 fe80::7efe:90ff:fecb:7502 prefixlen 64 scopeid 0x20\n> ether 7c:fe:90:cb:75:02 txqueuelen 1000 (Ethernet)\n> RX packets 12 bytes 1164 (1.1 KiB)\n> RX errors 0 dropped 0 overruns 0 frame 0\n> TX packets 30 bytes 2484 (2.4 KiB)\n> TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0\n> \n> $ /bin/ping6 -c 3 fe80::7efe:90ff:fecb:7502%ens8\n> PING fe80::7efe:90ff:fecb:7502%ens8(fe80::7efe:90ff:fecb:7502) 56 data bytes\n> \n> --- fe80::7efe:90ff:fecb:7502%ens8 ping statistics ---\n\nNote that the presence of this leading --- had the effect of truncating\nthe merged patch from this point. (all tags were ignored)\n\n> 3 packets transmitted, 0 received, 100% packet loss, time 2043ms\n> \n> icmpv6_echo_reply needs to use the rt6i_idev dev index for local traffic\n> similar to how icmp6_send does. Convert the change for icmp6_send into a\n> helper that can be used in both places. Add the long over due\n> skb_rt6_info helper to convert dst on an skb to rt6_info similar to\n> skb_rtable for ipv4.\n> \n> Fixes: 4832c30d5458 (\"net: ipv6: put host and anycast routes on\n> device with address\")\n> Reported-by: Tariq Toukan \n> Signed-off-by: David Ahern \n> ---","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"OkCbmeYZ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhrLM1xt7z9s7m\n\tfor ;\n\tWed, 30 Aug 2017 13:18:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751891AbdH3DSR (ORCPT );\n\tTue, 29 Aug 2017 23:18:17 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:32965 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751440AbdH3DSP (ORCPT\n\t); Tue, 29 Aug 2017 23:18:15 -0400","by mail-pf0-f196.google.com with SMTP id r62so742011pfj.0\n\tfor ; Tue, 29 Aug 2017 20:18:15 -0700 (PDT)","from [192.168.86.171] (c-67-180-167-114.hsd1.ca.comcast.net.\n\t[67.180.167.114]) by smtp.googlemail.com with ESMTPSA id\n\tw6sm1340713pfb.13.2017.08.29.20.18.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 20:18:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=sT3dmAwIVBZURAB5dk2Gqp8EUWVREgDEN3F4CQYSdsQ=;\n\tb=OkCbmeYZwdrEU9lmxza0O30i84EdhgtuiXkjQL+uG2P1iKZiyzzKTLC7IRLd6m1bdA\n\tmMWDLi0xE0+Agk23UKvFB5Z8zUOmQwTD26Fo6zZEo++0cSs1f+XLzL/dE6gg89CKZO5f\n\tiY7uUc1xlXAcmZEhxpcMKO+vBMTBvkCqSjD8WoHvBUb1urUqML+qhYBB11AJNm3Rlecc\n\tbmzrE/VxuoOfXO1MdO+dBYxTJtVQQcM738MBtJgj9nuL2wmP7QDXKHki1kbzsOeRwx7p\n\ta8URgRGTuoJk2R+OKaPe1KzUQbPhwTBfDYoFZDqcPXtoNFRVJJQm8OSGDr3RV9MQXXI7\n\tVXPQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=sT3dmAwIVBZURAB5dk2Gqp8EUWVREgDEN3F4CQYSdsQ=;\n\tb=L01OB+y2DaXxT3W47detHblu/6mOEWfenvNpoE0wIU8sTIuGY06dK/51i/PWpYSLtY\n\tmolpU5/+H9JBiIyWr1O8OfMtHyOJ4JnwkHp5sF0cOQYu3hI3+E3X0uiLOvoZQEcvveb2\n\tKZXLsOreK7M3l8z5VsiuE4FVgHn3jBSworY+aEskoRTRAxsScJiLLqVcdPbyGteaF6cm\n\tkdqH5SdMhBz5ZJiEVHfsS/7AJ6sjtgUgChGCWLkDhmIGo6odGtzwfyFBQwYQk9FkMYMv\n\t7wsQ+i8uUsFFPRdkTIKGA9FNpVQTuMuMcctK+H344K8Faqezd0SJVtPMfzfRt2CZjLqy\n\tU2WA==","X-Gm-Message-State":"AHYfb5h9FqLsFc1pl1KVrBuAJYAdAzKYSq4JPIU8Gu3oBDkFetE6uCrC\n\t+zDH0+fPanVv+Q==","X-Received":"by 10.98.212.21 with SMTP id a21mr146020pfh.13.1504063095492;\n\tTue, 29 Aug 2017 20:18:15 -0700 (PDT)","Message-ID":"<1504063094.11498.112.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH net-next] ipv6: Use rt6i_idev index for echo replies to\n\ta local address","From":"Eric Dumazet ","To":"David Ahern ","Cc":"netdev@vger.kernel.org, tariqt@mellanox.com","Date":"Tue, 29 Aug 2017 20:18:14 -0700","In-Reply-To":"<1503953614-32395-1-git-send-email-dsahern@gmail.com>","References":"<1503953614-32395-1-git-send-email-dsahern@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]