[{"id":1758844,"web_url":"http://patchwork.ozlabs.org/comment/1758844/","msgid":"<20170828.140133.2126200702424568912.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-28T21:01:33","subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: David Ahern \nDate: Mon, 28 Aug 2017 13:23:09 -0700\n\n> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4.\n...\n> I think this is the second time such a patch has been reverted.\n\nThen please add a comment, it will help prevent this from happening\nagain.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh4G011jbz9t8F\n\tfor ;\n\tTue, 29 Aug 2017 07:11:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751218AbdH1VBg (ORCPT );\n\tMon, 28 Aug 2017 17:01:36 -0400","from shards.monkeyblade.net ([184.105.139.130]:48216 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751182AbdH1VBf (ORCPT\n\t); Mon, 28 Aug 2017 17:01:35 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id E8A14133EE3E1;\n\tMon, 28 Aug 2017 14:01:34 -0700 (PDT)"],"Date":"Mon, 28 Aug 2017 14:01:33 -0700 (PDT)","Message-Id":"<20170828.140133.2126200702424568912.davem@davemloft.net>","To":"dsahern@gmail.com","Cc":"netdev@vger.kernel.org, bhumirks@gmail.com","Subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","From":"David Miller ","In-Reply-To":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>","References":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 28 Aug 2017 14:01:35 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758845,"web_url":"http://patchwork.ozlabs.org/comment/1758845/","msgid":"<80c558d4-dea8-3a60-3786-c70e55946ff2@gmail.com>","list_archive_url":null,"date":"2017-08-28T21:03:34","subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 8/28/17 3:01 PM, David Miller wrote:\n> From: David Ahern \n> Date: Mon, 28 Aug 2017 13:23:09 -0700\n> \n>> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4.\n> ...\n>> I think this is the second time such a patch has been reverted.\n> \n> Then please add a comment, it will help prevent this from happening\n> again.\n> \n\nWas going to do that in both places after the revert. You want it as\npart of this one?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KW/aVjmZ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh4LT713Tz9sNn\n\tfor ;\n\tTue, 29 Aug 2017 07:15:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751263AbdH1VDh (ORCPT );\n\tMon, 28 Aug 2017 17:03:37 -0400","from mail-pg0-f41.google.com ([74.125.83.41]:34309 \"EHLO\n\tmail-pg0-f41.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750735AbdH1VDg (ORCPT\n\t); Mon, 28 Aug 2017 17:03:36 -0400","by mail-pg0-f41.google.com with SMTP id y15so4811893pgc.1\n\tfor ; Mon, 28 Aug 2017 14:03:36 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:c1bc:2493:e932:bac3])\n\tby smtp.googlemail.com with ESMTPSA id\n\tv25sm2215619pfg.52.2017.08.28.14.03.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 14:03:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=R2LdTTEr69RmtBtHte5hCw75qJ32R6IBPQCMGxd2Y2o=;\n\tb=KW/aVjmZSa7waWns5zN24RFHaZ6jH4Qi4c5jsWfRtghI8sZIwcM0yOua4i+eUPJevX\n\tA0J4vo5zw9hNGBDnKng3eYE7FeXQYded0erS1e64K7RWZfyEYlJ6fzpHnoRbioD5ZrzU\n\tjmLfhuHMdqvWp+6iro4q/S0oc16vCtBEBX9FjxCJNgQm77yeh5tnffFJhHQXIl5zwDWz\n\tGdhBFzzHgxmpiMzic13VeivfDx4jr5daUWjN2bFg85JGRjy1waVFdIw+JsffSUL+d9jM\n\trem54o017wxMFaWf0et3CP5fpOmrbjtX0cND+BeUK6gME9n5Zby7/EblfUJAcWk+P694\n\tbqug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=R2LdTTEr69RmtBtHte5hCw75qJ32R6IBPQCMGxd2Y2o=;\n\tb=IsDv0uACO9wuLLsVxay3WzxWVs6mnHlJRtVbYXU4ZaiixSIM8HZjL4YfPDrmtT7CO8\n\tuzBT6SjjN5JEvvMYod52nlufQhpRXZSOQ1XbFvfZAppyE+eCMhpLcE4gRY9QvBEic1SV\n\tioljwmC9dprVdbdaKWpsGrv2DeTpVSbhCcTD9FRBrsRR+bMTqUumN3G26oxaoSHCOgs5\n\tFIqxwXwleFKox8uA6PFhzLAvZTLg2ZUQk/KfXw1cWTvKJLj0K3Zl0Cf3SBEJZ28YGfCP\n\tNwMZMPSBXRx/X0WS9/lDili3TJL0afiAf+BYWY8Y0wWf54DRYIuC9qS6SrSnD2vZtqOE\n\tUrlQ==","X-Gm-Message-State":"AHYfb5hB9YcbQVida3N7dSesQWUwUk8feQewAM/eazakOEH1PPwY8XyQ\n\tKJrDETw5m2NIDw==","X-Received":"by 10.99.181.4 with SMTP id y4mr1741402pge.327.1503954215992;\n\tMon, 28 Aug 2017 14:03:35 -0700 (PDT)","Subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","To":"David Miller ","Cc":"netdev@vger.kernel.org, bhumirks@gmail.com","References":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>\n\t<20170828.140133.2126200702424568912.davem@davemloft.net>","From":"David Ahern ","Message-ID":"<80c558d4-dea8-3a60-3786-c70e55946ff2@gmail.com>","Date":"Mon, 28 Aug 2017 15:03:34 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170828.140133.2126200702424568912.davem@davemloft.net>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758853,"web_url":"http://patchwork.ozlabs.org/comment/1758853/","msgid":"<20170828141813.74c007ac@xeon-e3>","list_archive_url":null,"date":"2017-08-28T21:18:13","subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Mon, 28 Aug 2017 13:23:09 -0700\nDavid Ahern wrote:\n\n> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4.\n> \n> Early demux structs can not be made const. Doing so results in:\n> [ 84.967355] BUG: unable to handle kernel paging request at ffffffff81684b10\n> [ 84.969272] IP: proc_configure_early_demux+0x1e/0x3d\n> [ 84.970544] PGD 1a0a067\n> [ 84.970546] P4D 1a0a067\n> [ 84.971212] PUD 1a0b063\n> [ 84.971733] PMD 80000000016001e1\n> \n> [ 84.972669] Oops: 0003 [#1] SMP\n> [ 84.973065] Modules linked in: ip6table_filter ip6_tables veth vrf\n> [ 84.973833] CPU: 0 PID: 955 Comm: sysctl Not tainted 4.13.0-rc6+ #22\n> [ 84.974612] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014\n> [ 84.975855] task: ffff88003854ce00 task.stack: ffffc900005a4000\n> [ 84.976580] RIP: 0010:proc_configure_early_demux+0x1e/0x3d\n> [ 84.977253] RSP: 0018:ffffc900005a7dd0 EFLAGS: 00010246\n> [ 84.977891] RAX: ffffffff81684b10 RBX: 0000000000000001 RCX: 0000000000000000\n> [ 84.978759] RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000000\n> [ 84.979628] RBP: ffffc900005a7dd0 R08: 0000000000000000 R09: 0000000000000000\n> [ 84.980501] R10: 0000000000000001 R11: 0000000000000008 R12: 0000000000000001\n> [ 84.981373] R13: ffffffffffffffea R14: ffffffff81a9b4c0 R15: 0000000000000002\n> [ 84.982249] FS: 00007feb237b7700(0000) GS:ffff88003fc00000(0000) knlGS:0000000000000000\n> [ 84.983231] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n> [ 84.983941] CR2: ffffffff81684b10 CR3: 0000000038492000 CR4: 00000000000406f0\n> [ 84.984817] Call Trace:\n> [ 84.985133] proc_tcp_early_demux+0x29/0x30\n> \n> I think this is the second time such a patch has been reverted.\n> \n> Cc: Bhumika Goyal \n> Signed-off-by: David Ahern \n\nThis would have been caught at compile time if you tried setting inet_protos to const.\nStart with that if you want to give it a try.\n\n\n\ndiff --git a/include/net/protocol.h b/include/net/protocol.h\nindex 65ba335b0e7e..373fa92d33ff 100644\n--- a/include/net/protocol.h\n+++ b/include/net/protocol.h\n@@ -93,7 +93,7 @@ struct inet_protosw {\n #define INET_PROTOSW_PERMANENT 0x02 /* Permanent protocols are unremovable. */\n #define INET_PROTOSW_ICSK 0x04 /* Is this an inet_connection_sock? */\n \n-extern struct net_protocol __rcu *inet_protos[MAX_INET_PROTOS];\n+extern const struct net_protocol __rcu *inet_protos[MAX_INET_PROTOS];\n extern const struct net_offload __rcu *inet_offloads[MAX_INET_PROTOS];\n extern const struct net_offload __rcu *inet6_offloads[MAX_INET_PROTOS];\n \ndiff --git a/net/ipv4/protocol.c b/net/ipv4/protocol.c\nindex 32a691b7ce2c..4b7c0ec65251 100644\n--- a/net/ipv4/protocol.c\n+++ b/net/ipv4/protocol.c\n@@ -28,7 +28,7 @@\n #include \n #include \n \n-struct net_protocol __rcu *inet_protos[MAX_INET_PROTOS] __read_mostly;\n+const struct net_protocol __rcu *inet_protos[MAX_INET_PROTOS] __read_mostly;\n const struct net_offload __rcu *inet_offloads[MAX_INET_PROTOS] __read_mostly;\n EXPORT_SYMBOL(inet_offloads);\n\n\nnet/ipv4/sysctl_net_ipv4.c: In function ‘proc_configure_early_demux’:\nnet/ipv4/sysctl_net_ipv4.c:310:9: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]\n ipprot = rcu_dereference(inet_protos[protocol]);","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"ri1oGOtE\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh4z31LmLz9t6C\n\tfor ;\n\tTue, 29 Aug 2017 07:43:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751236AbdH1VSQ (ORCPT );\n\tMon, 28 Aug 2017 17:18:16 -0400","from mail-pg0-f45.google.com ([74.125.83.45]:33922 \"EHLO\n\tmail-pg0-f45.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751190AbdH1VSP (ORCPT\n\t); Mon, 28 Aug 2017 17:18:15 -0400","by mail-pg0-f45.google.com with SMTP id y15so4904591pgc.1\n\tfor ; Mon, 28 Aug 2017 14:18:15 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\tu68sm2029768pgc.14.2017.08.28.14.18.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 28 Aug 2017 14:18:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=IuMMdNTHLXiz+EHIPz1c8t/neuKC+E9dfp+OL1DduZI=;\n\tb=ri1oGOtEtraMLB6ysNCch5n7q85jN3R3uYCPtuuE65NSvrKbzuWR4yr7+UFGFy1TOg\n\tybvYu7uBWtFyeGHz3NaEgxuCLufde4DG+uVu4oabzo9DzPuraPhWbd3vPg2Et0uDs6nw\n\tFYv/s1lyk4jAbWgYzLLIQq1/vz2HZyB0K2xMr++IAyp7ji2TcsSC+4/Kk7NbMrirn4PA\n\tsScsUfziJassB0GCVkmox7I7uys+vh3tqesce2EjYIVYqeinPThEQD3COsnYZfyWdVhf\n\t9KxcKOVD/+gzBY3mH+GCkpfNyGAQd7nlgUfdcoeGO6ZSuyq79Fv5C5MtHmER6bMjCvOA\n\tK1eg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=IuMMdNTHLXiz+EHIPz1c8t/neuKC+E9dfp+OL1DduZI=;\n\tb=jEZUVg1RJMWj6PHy6u/82u2JLy3RkKgC7eEYb3vGEz7jUd0+9+P31hxi2J3LZ8+NGl\n\tLIu9tpproRrVHsZDm0JsklJm1/pNT8vKuHOvu77v6+J1XktOjdGBuac9X9TT6c6XUSWi\n\tt1VF/c3wnNUoIDCzxwSvnHSgyLYyIa+I9PdRwJ+ZaQkdl+DyjiW6DQsA1D4nZ2a/oVaX\n\trZpucUpdBUwaawGsmQqfY1viw57akYGImDDr8b+PYQpGEW//nSlt8Uk+RcLQVz6Ux+uk\n\t1O2T5rJT01ZruFBKKo8RjYE1A64XTJO65NaS1Q+8HioGlOAVT8xcXg8+NXJrpm/CaJll\n\t7Ppw==","X-Gm-Message-State":"AHYfb5iH4cIqAwg95dDQcuD8G9XVocAWGx7YGKF1tFYb627nqZd3zEp8\n\tbIoJBe7Ps8C1k7sv","X-Received":"by 10.99.120.5 with SMTP id t5mr1755559pgc.438.1503955095375;\n\tMon, 28 Aug 2017 14:18:15 -0700 (PDT)","Date":"Mon, 28 Aug 2017 14:18:13 -0700","From":"Stephen Hemminger ","To":"David Ahern ","Cc":"netdev@vger.kernel.org, bhumirks@gmail.com, davem@davemloft.net","Subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","Message-ID":"<20170828141813.74c007ac@xeon-e3>","In-Reply-To":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>","References":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758863,"web_url":"http://patchwork.ozlabs.org/comment/1758863/","msgid":"<20170828.143057.1225113814212085629.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-28T21:30:57","subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: David Ahern \nDate: Mon, 28 Aug 2017 15:03:34 -0600\n\n> On 8/28/17 3:01 PM, David Miller wrote:\n>> From: David Ahern \n>> Date: Mon, 28 Aug 2017 13:23:09 -0700\n>> \n>>> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4.\n>> ...\n>>> I think this is the second time such a patch has been reverted.\n>> \n>> Then please add a comment, it will help prevent this from happening\n>> again.\n>> \n> \n> Was going to do that in both places after the revert. You want it as\n> part of this one?\n\nYou're right a clean revert first is better.\n\nI'll apply this now, thanks David.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh5503R8Vz9sD9\n\tfor ;\n\tTue, 29 Aug 2017 07:49:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751280AbdH1Va7 (ORCPT );\n\tMon, 28 Aug 2017 17:30:59 -0400","from shards.monkeyblade.net ([184.105.139.130]:48712 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751182AbdH1Va6 (ORCPT\n\t); Mon, 28 Aug 2017 17:30:58 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 0CE12133F6409;\n\tMon, 28 Aug 2017 14:30:58 -0700 (PDT)"],"Date":"Mon, 28 Aug 2017 14:30:57 -0700 (PDT)","Message-Id":"<20170828.143057.1225113814212085629.davem@davemloft.net>","To":"dsahern@gmail.com","Cc":"netdev@vger.kernel.org, bhumirks@gmail.com","Subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","From":"David Miller ","In-Reply-To":"<80c558d4-dea8-3a60-3786-c70e55946ff2@gmail.com>","References":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>\n\t<20170828.140133.2126200702424568912.davem@davemloft.net>\n\t<80c558d4-dea8-3a60-3786-c70e55946ff2@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 28 Aug 2017 14:30:58 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759061,"web_url":"http://patchwork.ozlabs.org/comment/1759061/","msgid":"","list_archive_url":null,"date":"2017-08-29T06:46:23","subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","submitter":{"id":69882,"url":"http://patchwork.ozlabs.org/api/people/69882/","name":"Bhumika Goyal","email":"bhumirks@gmail.com"},"content":"On Tue, Aug 29, 2017 at 1:53 AM, David Ahern wrote:\n> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4.\n>\n> Early demux structs can not be made const. Doing so results in:\n> [ 84.967355] BUG: unable to handle kernel paging request at ffffffff81684b10\n> [ 84.969272] IP: proc_configure_early_demux+0x1e/0x3d\n> [ 84.970544] PGD 1a0a067\n> [ 84.970546] P4D 1a0a067\n> [ 84.971212] PUD 1a0b063\n> [ 84.971733] PMD 80000000016001e1\n>\n> [ 84.972669] Oops: 0003 [#1] SMP\n> [ 84.973065] Modules linked in: ip6table_filter ip6_tables veth vrf\n> [ 84.973833] CPU: 0 PID: 955 Comm: sysctl Not tainted 4.13.0-rc6+ #22\n> [ 84.974612] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014\n> [ 84.975855] task: ffff88003854ce00 task.stack: ffffc900005a4000\n> [ 84.976580] RIP: 0010:proc_configure_early_demux+0x1e/0x3d\n> [ 84.977253] RSP: 0018:ffffc900005a7dd0 EFLAGS: 00010246\n> [ 84.977891] RAX: ffffffff81684b10 RBX: 0000000000000001 RCX: 0000000000000000\n> [ 84.978759] RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000000\n> [ 84.979628] RBP: ffffc900005a7dd0 R08: 0000000000000000 R09: 0000000000000000\n> [ 84.980501] R10: 0000000000000001 R11: 0000000000000008 R12: 0000000000000001\n> [ 84.981373] R13: ffffffffffffffea R14: ffffffff81a9b4c0 R15: 0000000000000002\n> [ 84.982249] FS: 00007feb237b7700(0000) GS:ffff88003fc00000(0000) knlGS:0000000000000000\n> [ 84.983231] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n> [ 84.983941] CR2: ffffffff81684b10 CR3: 0000000038492000 CR4: 00000000000406f0\n> [ 84.984817] Call Trace:\n> [ 84.985133] proc_tcp_early_demux+0x29/0x30\n>\n> I think this is the second time such a patch has been reverted.\n>\n> Cc: Bhumika Goyal \n> Signed-off-by: David Ahern \n> ---\n> Bhumika: How are you testing these constify changes? In this case a simple\n> sysctl -w net.ipv4.tcp_early_demux=1 would have shown the problem\n>\n\nI am compile testing them. In this case I did: make\nnet/ipv4/af_inet.o and it compiled. Is this error because of\ntypecasting net_protocol inside inet_add_protocol function?\n\nThanks,\nBhumika\n\n\n> net/ipv4/af_inet.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c\n> index 19aee073ba29..d678820e4306 100644\n> --- a/net/ipv4/af_inet.c\n> +++ b/net/ipv4/af_inet.c\n> @@ -1596,7 +1596,7 @@ static const struct net_protocol igmp_protocol = {\n> };\n> #endif\n>\n> -static const struct net_protocol tcp_protocol = {\n> +static struct net_protocol tcp_protocol = {\n> .early_demux = tcp_v4_early_demux,\n> .early_demux_handler = tcp_v4_early_demux,\n> .handler = tcp_v4_rcv,\n> @@ -1606,7 +1606,7 @@ static const struct net_protocol tcp_protocol = {\n> .icmp_strict_tag_validation = 1,\n> };\n>\n> -static const struct net_protocol udp_protocol = {\n> +static struct net_protocol udp_protocol = {\n> .early_demux = udp_v4_early_demux,\n> .early_demux_handler = udp_v4_early_demux,\n> .handler = udp_rcv,\n> --\n> 2.1.4\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hXuO8vuR\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhK114dX8z9ryr\n\tfor ;\n\tTue, 29 Aug 2017 16:46:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751282AbdH2Gq0 (ORCPT );\n\tTue, 29 Aug 2017 02:46:26 -0400","from mail-io0-f193.google.com ([209.85.223.193]:33185 \"EHLO\n\tmail-io0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751270AbdH2GqZ (ORCPT\n\t); Tue, 29 Aug 2017 02:46:25 -0400","by mail-io0-f193.google.com with SMTP id s101so2607266ioe.0\n\tfor ; Mon, 28 Aug 2017 23:46:25 -0700 (PDT)","by 10.107.142.133 with HTTP; Mon, 28 Aug 2017 23:46:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=EOogQ40Vz6auUQAX1cmu7x/FcB4wfmLX2de3r5bS90Q=;\n\tb=hXuO8vuRuBoZnLQl1leEYiLBnVhY7Ytq75TaR2oRkUxcKA9zfd35JTKVqjpbmlvHqi\n\tjjZEIIjeoSxEjD4UFmvFFkEJswLqjk7JIZbLZZNnvFSTKkJkVi2UHY/0t1LomGqgLwOS\n\tinsd3QYQ4UQG8xZuwjtmHIc0S+339zEq9wnCq8/Iib3UsFxNoLYolJOEdraAq+b7Xrjv\n\tUgZNfnE2plB9k8SbDFFqRioti/woeJ0ol75F6NJkMRcjMmuAJ0tkqagmdveRgdvqs4fU\n\tFQkbvIJVbaaI0UbPAp1QcHhA6+9kbDNXTo5n2shJcVdRXAdHEc1FhyKztkRxzusamtXr\n\t1zZQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=EOogQ40Vz6auUQAX1cmu7x/FcB4wfmLX2de3r5bS90Q=;\n\tb=bGjW0ApxTVEW6qrRMI4dNfL+V6oRbsbpDuBuC8xBG6v0vbZVcXkTa8JG3IYt5wcPaI\n\t3LiP9zWDNbiwOYD5di7y5/1m7JUpAjIfirZBqOdQIiSM/UZaCjUsCuNNbZb99rjMNOHb\n\tICLWnbSKSupDrXImL5cy8FDqJr0bZwp8eedQB0VMmYpTYtV/Rtk9dryGXlna7ODQ2GcX\n\tIlGG7G7Z0513xLnsdoWFAF2dwBz1C+EemN9ndsCIIwINvGu2bZkCCYupvP96mSAYWPDa\n\tWVNFT3qm4DHOzLm6eTZYTGFKB+ie/++kWNa6UsAExYbNxiQWk6ekZ+4GN4Xkk5xHgHNR\n\t/pBg==","X-Gm-Message-State":"AHYfb5izUqxHAksWVoYi0S+G1TLdKXhWaAmkLsPxy4fs0J8foJovNfv0\n\tspQ/0tjKF6U7r7vC7HLNIqOB6zbHVA==","X-Received":"by 10.36.92.79 with SMTP id q76mr2917171itb.149.1503989184666;\n\tMon, 28 Aug 2017 23:46:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>","References":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>","From":"Bhumika Goyal ","Date":"Tue, 29 Aug 2017 12:16:23 +0530","Message-ID":"","Subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","To":"David Ahern ","Cc":"netdev@vger.kernel.org, David Miller ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759438,"web_url":"http://patchwork.ozlabs.org/comment/1759438/","msgid":"<20170829081403.41db6bde@xeon-e3>","list_archive_url":null,"date":"2017-08-29T15:14:03","subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Tue, 29 Aug 2017 12:16:23 +0530\nBhumika Goyal wrote:\n\n> On Tue, Aug 29, 2017 at 1:53 AM, David Ahern wrote:\n> > This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4.\n> >\n> > Early demux structs can not be made const. Doing so results in:\n> > [ 84.967355] BUG: unable to handle kernel paging request at ffffffff81684b10\n> > [ 84.969272] IP: proc_configure_early_demux+0x1e/0x3d\n> > [ 84.970544] PGD 1a0a067\n> > [ 84.970546] P4D 1a0a067\n> > [ 84.971212] PUD 1a0b063\n> > [ 84.971733] PMD 80000000016001e1\n> >\n> > [ 84.972669] Oops: 0003 [#1] SMP\n> > [ 84.973065] Modules linked in: ip6table_filter ip6_tables veth vrf\n> > [ 84.973833] CPU: 0 PID: 955 Comm: sysctl Not tainted 4.13.0-rc6+ #22\n> > [ 84.974612] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014\n> > [ 84.975855] task: ffff88003854ce00 task.stack: ffffc900005a4000\n> > [ 84.976580] RIP: 0010:proc_configure_early_demux+0x1e/0x3d\n> > [ 84.977253] RSP: 0018:ffffc900005a7dd0 EFLAGS: 00010246\n> > [ 84.977891] RAX: ffffffff81684b10 RBX: 0000000000000001 RCX: 0000000000000000\n> > [ 84.978759] RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000000\n> > [ 84.979628] RBP: ffffc900005a7dd0 R08: 0000000000000000 R09: 0000000000000000\n> > [ 84.980501] R10: 0000000000000001 R11: 0000000000000008 R12: 0000000000000001\n> > [ 84.981373] R13: ffffffffffffffea R14: ffffffff81a9b4c0 R15: 0000000000000002\n> > [ 84.982249] FS: 00007feb237b7700(0000) GS:ffff88003fc00000(0000) knlGS:0000000000000000\n> > [ 84.983231] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n> > [ 84.983941] CR2: ffffffff81684b10 CR3: 0000000038492000 CR4: 00000000000406f0\n> > [ 84.984817] Call Trace:\n> > [ 84.985133] proc_tcp_early_demux+0x29/0x30\n> >\n> > I think this is the second time such a patch has been reverted.\n> >\n> > Cc: Bhumika Goyal \n> > Signed-off-by: David Ahern \n> > ---\n> > Bhumika: How are you testing these constify changes? In this case a simple\n> > sysctl -w net.ipv4.tcp_early_demux=1 would have shown the problem\n> > \n> \n> I am compile testing them. In this case I did: make\n> net/ipv4/af_inet.o and it compiled. Is this error because of\n> typecasting net_protocol inside inet_add_protocol function?\n> \n> Thanks,\n> Bhumika\n> \n> \n> > net/ipv4/af_inet.c | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c\n> > index 19aee073ba29..d678820e4306 100644\n> > --- a/net/ipv4/af_inet.c\n> > +++ b/net/ipv4/af_inet.c\n> > @@ -1596,7 +1596,7 @@ static const struct net_protocol igmp_protocol = {\n> > };\n> > #endif\n> >\n> > -static const struct net_protocol tcp_protocol = {\n> > +static struct net_protocol tcp_protocol = {\n> > .early_demux = tcp_v4_early_demux,\n> > .early_demux_handler = tcp_v4_early_demux,\n> > .handler = tcp_v4_rcv,\n> > @@ -1606,7 +1606,7 @@ static const struct net_protocol tcp_protocol = {\n> > .icmp_strict_tag_validation = 1,\n> > };\n> >\n> > -static const struct net_protocol udp_protocol = {\n> > +static struct net_protocol udp_protocol = {\n> > .early_demux = udp_v4_early_demux,\n> > .early_demux_handler = udp_v4_early_demux,\n> > .handler = udp_rcv,\n> > --\n> > 2.1.4\n> > \n\nYou need to change inet_proto datastructure first.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"n/hK+NNr\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhXGn4rzwz9t2Q\n\tfor ;\n\tWed, 30 Aug 2017 01:14:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752323AbdH2POH (ORCPT );\n\tTue, 29 Aug 2017 11:14:07 -0400","from mail-pg0-f51.google.com ([74.125.83.51]:35349 \"EHLO\n\tmail-pg0-f51.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751343AbdH2POG (ORCPT\n\t); Tue, 29 Aug 2017 11:14:06 -0400","by mail-pg0-f51.google.com with SMTP id 63so11631849pgc.2\n\tfor ; Tue, 29 Aug 2017 08:14:06 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\th28sm5851812pfd.142.2017.08.29.08.14.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 29 Aug 2017 08:14:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=FyOKzyjOIHMkzxW0vbNNoNkYxoSgbnxaAYBw7BlszEY=;\n\tb=n/hK+NNrvPObF3mVGhtketyRpxoXj8NAI1E/d3qHdxQdutYAw7Afnjgzs1D0EUPRQ6\n\tqlkZC1YgLIGD0986CUuqoFh49L/KFSMap2MCs6qiVuZRJIwRJaL20o06aRSeNAcJNPaZ\n\tcqg60mKEXM/g+yLnqetEXYqMIZYN4u9yFXYmSfYYfpbGUj5+aoU3vHmFdytVRLOrD2nV\n\t9fCCZ9GlTEg59kzGV884CHap8JBI1g6QGRdPuhm2byxotidEEFH4UZXpMJruLKUY7ipC\n\tLFuY6oTG3UdcM1tnDSwW4kyKsDQg4bsnUO9X6eAUP3JA1y6hXxXl8SV4EQOaOq3J4VYe\n\tfhqw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=FyOKzyjOIHMkzxW0vbNNoNkYxoSgbnxaAYBw7BlszEY=;\n\tb=epgqCg3sslqB2bzyUcz/cnN0vH0XbkkR6+HF8WfHehrupsSO+2+L6C/ShQLcjTj53n\n\t0KLqeXIWJ7uVBTYVpTL31f/VyBQbLlgKrCyRz3F8GLaUk9yrgKgfCyXQ/36CwNnJvmKW\n\tXUwxQ3G4RUwFymc2KMZ9QUgEZvcspbYsED45hP26/SBnRgy2UCyDvkHl+1LAySYZyBl/\n\tAe9Mj911vkmMGpB8pn0b5yGL5S9iN83ZxMl+tBWSDEIT6CFENrg7sGUNzplAqwHoyIAs\n\tk/CxxRG34AOzsiX4khZ7VBkoitt5isMlxY8pM3SgxeD9glNlZXKBNZF4Bp8UUkBJ1t+i\n\tod9Q==","X-Gm-Message-State":"AHYfb5gpxpPpM2CIymOKKS2WlAMM8XbQoZRexRpJGDUWZIldUqTPl+z1\n\tYWUjsitfuc7Aw9EA","X-Received":"by 10.99.176.14 with SMTP id h14mr650869pgf.214.1504019645691;\n\tTue, 29 Aug 2017 08:14:05 -0700 (PDT)","Date":"Tue, 29 Aug 2017 08:14:03 -0700","From":"Stephen Hemminger ","To":"Bhumika Goyal ","Cc":"David Ahern , netdev@vger.kernel.org,\n\tDavid Miller ","Subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","Message-ID":"<20170829081403.41db6bde@xeon-e3>","In-Reply-To":"","References":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759535,"web_url":"http://patchwork.ozlabs.org/comment/1759535/","msgid":"<55ee348e-3193-f384-b4a9-3f773052a154@gmail.com>","list_archive_url":null,"date":"2017-08-29T16:47:15","subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 8/29/17 12:46 AM, Bhumika Goyal wrote:\n> I am compile testing them. In this case I did: make\n> net/ipv4/af_inet.o and it compiled. Is this error because of\n> typecasting net_protocol inside inet_add_protocol function?\n\nCompile testing is not sufficient. Marking data structures read-only\nleaves potential land mines for others to trip over at run-time.\n\nYou are making these changes based on a code analysis. Extend the\nanalysis to elements of the structure. In this case early_demux is the\nfirst element. There are only 9 references to early_demux and cscope\nvery quickly tells you it can be changed:\n\n7 sysctl_net_ipv4.c proc_configure_early_demux 312 ipprot->early_demux\n= enabled ? ipprot->early_demux_handler :\n8 sysctl_net_ipv4.c proc_configure_early_demux 318 ip6prot->early_demux\n= enabled ? ip6prot->early_demux_handler :","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"JTR4GjBK\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhZLK4SRYz9t33\n\tfor ;\n\tWed, 30 Aug 2017 02:47:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751549AbdH2QrT (ORCPT );\n\tTue, 29 Aug 2017 12:47:19 -0400","from mail-pf0-f171.google.com ([209.85.192.171]:35256 \"EHLO\n\tmail-pf0-f171.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751241AbdH2QrR (ORCPT\n\t); Tue, 29 Aug 2017 12:47:17 -0400","by mail-pf0-f171.google.com with SMTP id g13so11802635pfm.2\n\tfor ; Tue, 29 Aug 2017 09:47:17 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:d89a:ab61:c4f1:b1cb])\n\tby smtp.googlemail.com with ESMTPSA id\n\tg7sm5240781pgr.52.2017.08.29.09.47.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 09:47:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=EdWc7gtNzdU2tRHccv2RdNqP5wm0GW8J0EYdc1jHSJw=;\n\tb=JTR4GjBKCH/0uOyWmFu6ustVrLv3Lp62xL+4E2gqQs9hvdru9azZ2F+cP3drQ4HRYD\n\tDk/yC87DYVGwiieXMPRT5DbvQfzNx1mjv9VM80HJ5YdQU9dKjGNdOcjKUrJGy3iD+38r\n\tz+CCfMz7tXwJJv6X4Ib13BCPRR3KO8s/v0TlaAzuljMkeQIf9srQEidy51a9TVC++2eX\n\tQci3oCSq4WhRBdMTilNH82eLGGqmn86cp1oxX8jTonsX9YICge0CSfh6sUo/6m3UGQVa\n\tDTyU2+BnZvx5rTpT2DSxDVy7AnrjKlnD/5aLpiMfdUfxB4pZEtshNcFj7m9B9lK06Esf\n\tCxqA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=EdWc7gtNzdU2tRHccv2RdNqP5wm0GW8J0EYdc1jHSJw=;\n\tb=d7G4OhjIRaOd6MPn5bWY67PHukSfescpb/IPNqmU/qJzGuNTKIHr0fFD8+O2t11Xyh\n\t89X14eUCKB1Xttbv3hLwYhyem27oMphKcmhVA7hdxi6e8BvyPGZ7uxw7QQ+Sb9384gsK\n\tb5Wm2yoLl1UcWcvaEztqZfDXRX/dTAdt5uGqK7o9GoKD89LMFbybTD9R7yLgnESBqT4Q\n\t6TouhrDPzenQRDn8fcLNT2GS0XOnbTUvtCSEjsmB28v0MmSFbUSDsbGeFshvcjSRx8sV\n\tEUQ9gKuiIiRYU0HbESOFzv/6KGICJWHdsT3re9dAjyxK2sqxRhcu5xXaiEplAUPwU8//\n\tRZaA==","X-Gm-Message-State":"AHYfb5gLMBQH1XOUZhQY8Hb/9jcEOgiEhlZctS6ii3Or5uGgpg6aQqvm\n\tbuEwcT+MpgxoRw==","X-Received":"by 10.101.73.78 with SMTP id q14mr901203pgs.174.1504025237329;\n\tTue, 29 Aug 2017 09:47:17 -0700 (PDT)","Subject":"Re: [PATCH net-next] Revert \"ipv4: make net_protocol const\"","To":"Bhumika Goyal ","Cc":"netdev@vger.kernel.org, David Miller ","References":"<1503951789-31836-1-git-send-email-dsahern@gmail.com>\n\t","From":"David Ahern ","Message-ID":"<55ee348e-3193-f384-b4a9-3f773052a154@gmail.com>","Date":"Tue, 29 Aug 2017 10:47:15 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]