[{"id":1758892,"web_url":"http://patchwork.ozlabs.org/comment/1758892/","msgid":"","list_archive_url":null,"date":"2017-08-28T22:18:27","subject":"Re: [PATCH iproute2 3/4] tc: m_ife: report about kernels default\n\ttype","submitter":{"id":9380,"url":"http://patchwork.ozlabs.org/api/people/9380/","name":"Jamal Hadi Salim","email":"jhs@mojatatu.com"},"content":"Same comment as previous patch.\n\ncheers,\njamal\n\nOn 17-08-28 03:07 PM, Alexander Aring wrote:\n> This patch will report about if the ethertype for IFE is not specified\n> that the default IFE type is used.\n> \n> Signed-off-by: Alexander Aring \n> ---\n> tc/m_ife.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/tc/m_ife.c b/tc/m_ife.c\n> index 7b57130e..5633ab90 100644\n> --- a/tc/m_ife.c\n> +++ b/tc/m_ife.c\n> @@ -189,6 +189,8 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n> \t\taddattr_l(n, MAX_MSG, TCA_IFE_DMAC, dbuf, ETH_ALEN);\n> \tif (user_type)\n> \t\taddattr_l(n, MAX_MSG, TCA_IFE_TYPE, &ife_type, 2);\n> +\telse\n> +\t\tfprintf(stderr, \"IFE type 0x%04X\\n\", ETH_P_IFE);\n> \tif (saddr)\n> \t\taddattr_l(n, MAX_MSG, TCA_IFE_SMAC, sbuf, ETH_ALEN);\n> \n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"RtPlqWP8\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh5kx0cBQz9s65\n\tfor ;\n\tTue, 29 Aug 2017 08:18:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751309AbdH1WSb (ORCPT );\n\tMon, 28 Aug 2017 18:18:31 -0400","from mail-io0-f193.google.com ([209.85.223.193]:37781 \"EHLO\n\tmail-io0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751215AbdH1WSa (ORCPT\n\t); Mon, 28 Aug 2017 18:18:30 -0400","by mail-io0-f193.google.com with SMTP id j99so1633827ioo.4\n\tfor ; Mon, 28 Aug 2017 15:18:29 -0700 (PDT)","from [10.0.0.209] ([64.26.149.125])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu196sm61472itc.12.2017.08.28.15.18.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 15:18:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=PyAc2Cd1RoEhXpqR1yQ2nHwELdkauvVmBEAvXcE70sM=;\n\tb=RtPlqWP8W8IfScwLvQ35GL+DxnfWhboV9UvjSdoEvz6sFWlwk0wvghmlqQ4tKiXfdw\n\t9BwbM0iaMwt784uifSHTZQZ7w0KJMraObZaJDg2nYD1ceJ9ce0ReLsvCWL554+Rrob2w\n\td0ulAR3IjHnDBublexhbbOVRp3YNxs0qCbZCaH/LY3z76K+BuNQwsyr4ITsD5ATfnckj\n\tyWcEnG+FGTcHgFJCiW1k4E5p7jqHfRU9v4RV/9qSvVDklSUZd/rJJ9Fc0anOV195+GKP\n\tr9G7JmDWOAnMEf0ACm7Z9BRjD7ULNgYUdGKeBqdX/jioP6YUkwUWVjfINrDPFjTwW6pj\n\tJHhw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=PyAc2Cd1RoEhXpqR1yQ2nHwELdkauvVmBEAvXcE70sM=;\n\tb=ikqYeQoDKApfmmqEOlMXBdfZf0kB7edt3UL0KwCdpKu+ntd9CEYPl+JCssCJ59kBlT\n\tqGvVtg21SPYfoA3Zi5jQZWtEP3HjY0PDEHN7lZpDQYUw/sWIDDg7WSCfdFGkioOlb7Q8\n\tcgvPC8/mt5MI5bdYlpCGFhLVESLJzjc3LeNMv4Ieyj/8LKluYD0T3atf6NWHS/E49Lay\n\taT7yS1/SdtKxNXaf1wiTFLcQi9zcLExqPLKBX2kAU3c5eZM4ZcorD1cGUrhL5ogeff3O\n\tBTkX36zTA/W66aIq735DmuO5jeoefnrHOe4viHDoEtHSC0ULyBPf0svSWz3rpQAVCU0y\n\tQ72Q==","X-Gm-Message-State":"AHYfb5ihZ7W9MMihzjbfsVbZ+byCOsXZ2oNYeY3sa2q3zkxfdUwiDORD\n\tLN5i+AabCzoZZhwm8J4=","X-Received":"by 10.107.149.129 with SMTP id x123mr2201989iod.82.1503958709348;\n\tMon, 28 Aug 2017 15:18:29 -0700 (PDT)","Subject":"Re: [PATCH iproute2 3/4] tc: m_ife: report about kernels default\n\ttype","To":"Alexander Aring ","Cc":"yotamg@mellanox.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,\n\tnetdev@vger.kernel.org","References":"<20170828190738.26829-1-aring@mojatatu.com>\n\t<20170828190738.26829-4-aring@mojatatu.com>","From":"Jamal Hadi Salim ","Message-ID":"","Date":"Mon, 28 Aug 2017 18:18:27 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170828190738.26829-4-aring@mojatatu.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]