[{"id":1758806,"web_url":"http://patchwork.ozlabs.org/comment/1758806/","msgid":"<20170828123413.2283b2e1@xeon-e3>","list_archive_url":null,"date":"2017-08-28T19:34:13","subject":"Re: [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Mon, 28 Aug 2017 15:07:35 -0400\nAlexander Aring wrote:\n\n> This patch allows to set an ethertype for IFE which is zero. There is no\n> kernel side validation which forbids a type to zero.\n> \n> Signed-off-by: Alexander Aring \n> ---\n> tc/m_ife.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/tc/m_ife.c b/tc/m_ife.c\n> index e3521e62..e05e2276 100644\n> --- a/tc/m_ife.c\n> +++ b/tc/m_ife.c\n> @@ -63,6 +63,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n> \tchar dbuf[ETH_ALEN];\n> \tchar sbuf[ETH_ALEN];\n> \t__u16 ife_type = 0;\n> +\tint user_type = 0;\n\nPlease use bool if it is a flag value","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"HPz2nbce\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh2621SVkz9sN7\n\tfor ;\n\tTue, 29 Aug 2017 05:34:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751241AbdH1TeQ (ORCPT );\n\tMon, 28 Aug 2017 15:34:16 -0400","from mail-pf0-f175.google.com ([209.85.192.175]:36731 \"EHLO\n\tmail-pf0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750735AbdH1TeP (ORCPT\n\t); Mon, 28 Aug 2017 15:34:15 -0400","by mail-pf0-f175.google.com with SMTP id z87so3907272pfi.3\n\tfor ; Mon, 28 Aug 2017 12:34:15 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\td63sm1941917pfc.40.2017.08.28.12.34.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 28 Aug 2017 12:34:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=FntpJL8xmJK8tA1jD4kqtQH8sUDRKVMex8aN0c0yWiw=;\n\tb=HPz2nbceVdaNj6q8JfdU2TBbqCYTtq+g8TPewEMWHuLFBCJVdNtspCCTt4xxRYDFFT\n\tIvNJntqdhZBYUGEWUSMAdFNYhS0Pvpm4GNU2pobiHPii82mpQgXJTOYUD1BvVhGpX3Tk\n\tmYq2bHR83UwCnf1SWv0KdpySASmVtRMCv6m1p44D043P6i8SKX2paoERF2K9NChFUPYE\n\tRrLxakiEd+ML3HKDR3HfFs5PzPcmo+Rc3ejGRxben12pRUSpcIgj9MzmFYKVJhEFp6aa\n\teFQW2vCzl3TwxJrVE3g9dgoxRzgICnqnvNmE8FDqG7acZv2+pdaUR/40J+XWN0oyrVkF\n\tsQXw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=FntpJL8xmJK8tA1jD4kqtQH8sUDRKVMex8aN0c0yWiw=;\n\tb=ojtNmwUG4TgZiesa15F79wMBTLpK3B8bOCCWlLMUsneL9JCJZVlfwve0HXbWTnNT2H\n\tkKWWsujofpWF/VnLedzw87U1RGbLMvDU1KjzmOoDzAMIi9EvT2QchwR3FUe/qXVm+QUr\n\tZjyx0CleRgZlRpnmlkzbt6kpEQGA9jw6bAHr9X3+NU6oM0EWFc6oMG9vwjqgCQ69ans6\n\t/WOPIsTbp8E+oZklS7joYFuOmpyGCYJS9BfSo4U41kWcOHkGOHSIzyoZgqtEnFEEjR/x\n\t4xn6JJHgRxVXmiyVtOtPO2sRfmAA7QI60Ee65Gh9Ni1c1guZ6FkylfZpXjFAxU1ehpwv\n\tSZHw==","X-Gm-Message-State":"AHYfb5gqgIIjmVRCieh7d9pbkzKkq4IFkIoJJqgBIKIAGw0u95GVpaLv\n\tHAm7nLrGZW2BzQcg","X-Received":"by 10.84.210.231 with SMTP id a94mr2040738pli.448.1503948855429; \n\tMon, 28 Aug 2017 12:34:15 -0700 (PDT)","Date":"Mon, 28 Aug 2017 12:34:13 -0700","From":"Stephen Hemminger ","To":"Alexander Aring ","Cc":"jhs@mojatatu.com, yotamg@mellanox.com, xiyou.wangcong@gmail.com,\n\tjiri@resnulli.us, netdev@vger.kernel.org","Subject":"Re: [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero","Message-ID":"<20170828123413.2283b2e1@xeon-e3>","In-Reply-To":"<20170828190738.26829-2-aring@mojatatu.com>","References":"<20170828190738.26829-1-aring@mojatatu.com>\n\t<20170828190738.26829-2-aring@mojatatu.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758888,"web_url":"http://patchwork.ozlabs.org/comment/1758888/","msgid":"<5523e732-07f5-ac4b-8c88-6914c0e32ff0@mojatatu.com>","list_archive_url":null,"date":"2017-08-28T22:16:55","subject":"Re: [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero","submitter":{"id":9380,"url":"http://patchwork.ozlabs.org/api/people/9380/","name":"Jamal Hadi Salim","email":"jhs@mojatatu.com"},"content":"On 17-08-28 03:07 PM, Alexander Aring wrote:\n> This patch allows to set an ethertype for IFE which is zero. There is no\n> kernel side validation which forbids a type to zero.\n> \n> Signed-off-by: Alexander Aring \n\nAcked-by: Jamal Hadi Salim \n\ncheers,\njamal","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"cjpvdrki\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh5j816FDz9s65\n\tfor ;\n\tTue, 29 Aug 2017 08:17:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751263AbdH1WQ6 (ORCPT );\n\tMon, 28 Aug 2017 18:16:58 -0400","from mail-io0-f196.google.com ([209.85.223.196]:32840 \"EHLO\n\tmail-io0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751190AbdH1WQ5 (ORCPT\n\t); Mon, 28 Aug 2017 18:16:57 -0400","by mail-io0-f196.google.com with SMTP id s101so1641977ioe.0\n\tfor ; Mon, 28 Aug 2017 15:16:57 -0700 (PDT)","from [10.0.0.209] ([64.26.149.125])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu11sm622609iou.39.2017.08.28.15.16.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 15:16:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=1kBCrHd65sAcubykT6mv8GXvGvGYC2Og7GTifbx3m5w=;\n\tb=cjpvdrkiPeRfrQeWFWiVPZM0Q6+I3hRif06V0xzGIPbcqv0qkibOc9WB4py2ZFERT2\n\th5m9PSKz4Rvblj4XZi04zlXEHIfKj4NIo+MdPa8QzSJEaBvEdyHIG8GzPF7wdjCvyt8C\n\t7YrEdsfPG1JP3phqdhOwCKcaCtQdOILaxJ+e5SiWMqeBlsL9B92jYxZsV8Ez2PvIfoF8\n\t5t8mw0MprTr8cu4hxgfSu1Kno8El8chFp0PfcXHdxCAzyLD7lfMAVvJ1LFmWCOYzCa0I\n\tVkwUs2u6BR8pnkQEdUXFpJLt3P7lAL9yJTQPpJjpNcKhrQa0Rn89ecmhYrHC6gxyVNfO\n\tKm+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=1kBCrHd65sAcubykT6mv8GXvGvGYC2Og7GTifbx3m5w=;\n\tb=P+evBCQohd3lJeRGvAOhv7aOSjKprpM6kQlBeIla5eqsmPz0uvYoyXXZld1PNALUR8\n\tZ+O3+CcMyNYvEE28Z5iTRXy13ufMlXK4LFGmPLYNiB96u2QuhGORSnwuObtsk/D/VU4v\n\tjhUE2+LoQGcUZzcKov51tgRoeLdAvwjZneMTUupVltKvBRPLowRA/lgrh+71xxsmToPK\n\t3U3U2Ap5mOE2mXlmbS//dRkdrZy2G+y0QwkDxWWd1ybuHq7ynF4pDqCC1ccqic7nX2fJ\n\t3iRKkSzxyp4kLXq1sG8XY+m3caNINfZBQIbCpWyxgnt8amBKwL5pODNyzupsi2JfrZBu\n\tgpSQ==","X-Gm-Message-State":"AHYfb5gGJzIcI9BxPD0F+Te++/4Eh8VnZEF/YTT45b4IfhTzwQdUlJeQ\n\trmNtr14Ye6JUeerXGow=","X-Received":"by 10.36.27.72 with SMTP id 69mr2212780its.120.1503958616518;\n\tMon, 28 Aug 2017 15:16:56 -0700 (PDT)","Subject":"Re: [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero","To":"Alexander Aring ","Cc":"yotamg@mellanox.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,\n\tnetdev@vger.kernel.org","References":"<20170828190738.26829-1-aring@mojatatu.com>\n\t<20170828190738.26829-2-aring@mojatatu.com>","From":"Jamal Hadi Salim ","Message-ID":"<5523e732-07f5-ac4b-8c88-6914c0e32ff0@mojatatu.com>","Date":"Mon, 28 Aug 2017 18:16:55 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170828190738.26829-2-aring@mojatatu.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]