[{"id":1758805,"web_url":"http://patchwork.ozlabs.org/comment/1758805/","msgid":"<20170828123331.64260385@xeon-e3>","list_archive_url":null,"date":"2017-08-28T19:33:31","subject":"Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Mon, 28 Aug 2017 15:07:36 -0400\nAlexander Aring wrote:\n\n> This patch uses the usually IEEE format to display an ethertype which is\n> 4-digits and every digit in upper case.\n> \n> Signed-off-by: Alexander Aring \n> ---\n> tc/m_ife.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/tc/m_ife.c b/tc/m_ife.c\n> index e05e2276..7b57130e 100644\n> --- a/tc/m_ife.c\n> +++ b/tc/m_ife.c\n> @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n> \t\t\tNEXT_ARG();\n> \t\t\tif (get_u16(&ife_type, *argv, 0))\n> \t\t\t\tinvarg(\"ife type is invalid\", *argv);\n> -\t\t\tfprintf(stderr, \"IFE type 0x%x\\n\", ife_type);\n> +\t\t\tfprintf(stderr, \"IFE type 0x%04X\\n\", ife_type);\n> \t\t\tuser_type = 1;\n> \t\t} else if (matches(*argv, \"dst\") == 0) {\n> \t\t\tNEXT_ARG();\n\nWhy upper case?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"Yla0mXQF\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh25z0wPbz9sNc\n\tfor ;\n\tTue, 29 Aug 2017 05:34:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751218AbdH1Tde (ORCPT );\n\tMon, 28 Aug 2017 15:33:34 -0400","from mail-pg0-f43.google.com ([74.125.83.43]:35893 \"EHLO\n\tmail-pg0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751190AbdH1Tdd (ORCPT\n\t); Mon, 28 Aug 2017 15:33:33 -0400","by mail-pg0-f43.google.com with SMTP id r133so4162879pgr.3\n\tfor ; Mon, 28 Aug 2017 12:33:33 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\t16sm2317148pge.33.2017.08.28.12.33.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 28 Aug 2017 12:33:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=C2aiW+0tOw5C71i2tr+6VrCsrIJTEdNq+BQ5VFxyMjA=;\n\tb=Yla0mXQFmPmCFbvRs3Wj6a/pCz7GHIC4y1OzRbfXwIp9JmjC8hZ0AEwBrhWSr6TtlC\n\taWIUOSHCj7R0QwvqG2yTeKg//ISO0qtUYDPBcRP4k4DracE3z+XHBxosn9hFo9Ct+NfW\n\tVfIlCRIymQifIkiBKY6pFOGW7jDhWlpFDMh/W4TRR5C3X5uo1Rc2sxrB/8bwHZoubJoz\n\tJssh7Rh+qX2NZ4CV34mPGFx4FAHqenuA/hPYsUqhiPm8xDYvgXUeC1FTF2MEQJ3zY9mA\n\tC+4HEUVeefxiy2y5rKVlVkXkPjRu4zWsCBqIXzKztR+MonkvZkas5X7kuJ+s8LsZaSzJ\n\tEQ6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=C2aiW+0tOw5C71i2tr+6VrCsrIJTEdNq+BQ5VFxyMjA=;\n\tb=jqhPQElmC6GCJWJBw6A/OIg1nd3zn3VjHy4OXncj/RNVFYnGGBaL/+Ika8PS/58TWY\n\tOoD5rBxHcYlHbrcXw/xa3XC9RBPeNKB/Fp7mS5gMjQPy3MHlGvgzEA+9yUagdLzbcPuO\n\tC7ADH4gdMxFUF5eajVMvx0O+3B4/BQI72EN3hE1yUuOI7NP/j0RvUpp5288AbMdxF3v7\n\tYnAdCBFn48HFU5QpC9pIpbnQonqDskEHEbDTIsByE13oLZkPh9EO0LSXxPiA2ZAG2w8X\n\t6AILy47MtsTUEvsUHTh+n2YppRWuUp9GEaLmKtJPBj3AVOYSIoIw/rDAm2GP1Qz4TncS\n\tuphA==","X-Gm-Message-State":"AHYfb5ivGqyqtD2Zc17zs7UNCHufHQffmfUCa2JtpoDtZ0gUXq3WzxM+\n\tfmze6iPjk7uL7XAn","X-Received":"by 10.84.217.148 with SMTP id p20mr1924825pli.293.1503948813161; \n\tMon, 28 Aug 2017 12:33:33 -0700 (PDT)","Date":"Mon, 28 Aug 2017 12:33:31 -0700","From":"Stephen Hemminger ","To":"Alexander Aring ","Cc":"jhs@mojatatu.com, yotamg@mellanox.com, xiyou.wangcong@gmail.com,\n\tjiri@resnulli.us, netdev@vger.kernel.org","Subject":"Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format","Message-ID":"<20170828123331.64260385@xeon-e3>","In-Reply-To":"<20170828190738.26829-3-aring@mojatatu.com>","References":"<20170828190738.26829-1-aring@mojatatu.com>\n\t<20170828190738.26829-3-aring@mojatatu.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758891,"web_url":"http://patchwork.ozlabs.org/comment/1758891/","msgid":"","list_archive_url":null,"date":"2017-08-28T22:18:04","subject":"Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format","submitter":{"id":9380,"url":"http://patchwork.ozlabs.org/api/people/9380/","name":"Jamal Hadi Salim","email":"jhs@mojatatu.com"},"content":"Alex,\n\nI think we should get rid of these fprintfs instead of fixing them.\nThey were originally intended to be debug outputs.\n\ncheers,\njamal\n\nOn 17-08-28 03:07 PM, Alexander Aring wrote:\n> This patch uses the usually IEEE format to display an ethertype which is\n> 4-digits and every digit in upper case.\n> \n> Signed-off-by: Alexander Aring \n> ---\n> tc/m_ife.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/tc/m_ife.c b/tc/m_ife.c\n> index e05e2276..7b57130e 100644\n> --- a/tc/m_ife.c\n> +++ b/tc/m_ife.c\n> @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n> \t\t\tNEXT_ARG();\n> \t\t\tif (get_u16(&ife_type, *argv, 0))\n> \t\t\t\tinvarg(\"ife type is invalid\", *argv);\n> -\t\t\tfprintf(stderr, \"IFE type 0x%x\\n\", ife_type);\n> +\t\t\tfprintf(stderr, \"IFE type 0x%04X\\n\", ife_type);\n> \t\t\tuser_type = 1;\n> \t\t} else if (matches(*argv, \"dst\") == 0) {\n> \t\t\tNEXT_ARG();\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"UbOJO8xi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh5kT38mNz9s65\n\tfor ;\n\tTue, 29 Aug 2017 08:18:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751301AbdH1WSH (ORCPT );\n\tMon, 28 Aug 2017 18:18:07 -0400","from mail-io0-f194.google.com ([209.85.223.194]:34648 \"EHLO\n\tmail-io0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751215AbdH1WSG (ORCPT\n\t); Mon, 28 Aug 2017 18:18:06 -0400","by mail-io0-f194.google.com with SMTP id d81so918295ioj.1\n\tfor ; Mon, 28 Aug 2017 15:18:06 -0700 (PDT)","from [10.0.0.209] ([64.26.149.125])\n\tby smtp.googlemail.com with ESMTPSA id\n\ts204sm617786iod.42.2017.08.28.15.18.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 15:18:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=D4shulN1oHq+vDRlA81d2FP+aYIzYjJsI4F2Z0u8T6A=;\n\tb=UbOJO8xittkMYl2+Ls33VgMC7Bjj1fhMJutWqakNgMtRucd/Sv+AAYHyqk8Chzf9tl\n\tmUyEMIjq/gncl0Ii1DIApxwLsGRkpwPNM4/mZFbHM78tVHQRH6p7EvZjMpfgG2YpwEX6\n\tDp4+Zt7X5eSYLpvkVqyMDQ+2kIp2sE1vAS1YCRGvy541nGB8/X33ZoK4S4HmeUDPW2E1\n\togWM0vigvKXYvJlZq3JLqjwLJGV1m6SDV+D+kGKq5LtW+6OS/JOIQxxU2apsio4B1SmI\n\tYc1Wqz+1G1no2OMU7ZvVk/hDA8TrewDfyQEz6xwLKxKgQbtTY6YWdZrpB2SbaskwnQ90\n\tgQCw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=D4shulN1oHq+vDRlA81d2FP+aYIzYjJsI4F2Z0u8T6A=;\n\tb=aQWKzgZdrt19qvD+8GaYzKyqN4nzzw62eHSXhloQ5isWFN7JiKpE7Xh7FKg0fgvjei\n\tswPAcClONKei8t8GN/V49e4WX/RNa7iGhs7849nJhPzqtJOHzgPHluodopBX9o2d10Cp\n\tQFOF0/P4dfG+E2Nam3k0XARgsHY3hpvylsoKo2vQQcPK4t7h0TILKqhsurSm0xPYP62W\n\tfqNRCun2y0OBO9h+eQ1nuLeDRbi/Qn/9wRoI9ou2zlkmgr8eYL7AB2DHuoCA44mFv8Ka\n\tDlLITutvaLdZQPPCYsLE+GG1mnyIou358nGg99CRhNPsZTJdhV4gdVfsZ+kkbKlnTB4V\n\tEsFA==","X-Gm-Message-State":"AHYfb5isAp/lk/Q3loqdSXN3lersDCS7itgtrlw0mJQcL0M7pbWnPc7y\n\tqB0I8Py6YYgCcEyQqcM=","X-Received":"by 10.107.164.67 with SMTP id n64mr2049761ioe.282.1503958685891; \n\tMon, 28 Aug 2017 15:18:05 -0700 (PDT)","Subject":"Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format","To":"Alexander Aring ","Cc":"yotamg@mellanox.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,\n\tnetdev@vger.kernel.org","References":"<20170828190738.26829-1-aring@mojatatu.com>\n\t<20170828190738.26829-3-aring@mojatatu.com>","From":"Jamal Hadi Salim ","Message-ID":"","Date":"Mon, 28 Aug 2017 18:18:04 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170828190738.26829-3-aring@mojatatu.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758903,"web_url":"http://patchwork.ozlabs.org/comment/1758903/","msgid":"<20170828153734.4b32fa02@xeon-e3>","list_archive_url":null,"date":"2017-08-28T22:37:34","subject":"Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Mon, 28 Aug 2017 18:18:04 -0400\nJamal Hadi Salim wrote:\n\n> Alex,\n> \n> I think we should get rid of these fprintfs instead of fixing them.\n> They were originally intended to be debug outputs.\n> \n> cheers,\n> jamal\n> \n> On 17-08-28 03:07 PM, Alexander Aring wrote:\n> > This patch uses the usually IEEE format to display an ethertype which is\n> > 4-digits and every digit in upper case.\n> > \n> > Signed-off-by: Alexander Aring \n> > ---\n> > tc/m_ife.c | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/tc/m_ife.c b/tc/m_ife.c\n> > index e05e2276..7b57130e 100644\n> > --- a/tc/m_ife.c\n> > +++ b/tc/m_ife.c\n> > @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n> > \t\t\tNEXT_ARG();\n> > \t\t\tif (get_u16(&ife_type, *argv, 0))\n> > \t\t\t\tinvarg(\"ife type is invalid\", *argv);\n> > -\t\t\tfprintf(stderr, \"IFE type 0x%x\\n\", ife_type);\n> > +\t\t\tfprintf(stderr, \"IFE type 0x%04X\\n\", ife_type);\n> > \t\t\tuser_type = 1;\n> > \t\t} else if (matches(*argv, \"dst\") == 0) {\n> > \t\t\tNEXT_ARG();\n> > \n> \n\n\nFor iproute commands the show output is supposed to match the corresponding set inputs.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"oOLDNMn2\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh6903bVnz9s7v\n\tfor ;\n\tTue, 29 Aug 2017 08:37:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751231AbdH1Whi (ORCPT );\n\tMon, 28 Aug 2017 18:37:38 -0400","from mail-pf0-f172.google.com ([209.85.192.172]:34249 \"EHLO\n\tmail-pf0-f172.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751190AbdH1Whh (ORCPT\n\t); Mon, 28 Aug 2017 18:37:37 -0400","by mail-pf0-f172.google.com with SMTP id h75so5047154pfh.1\n\tfor ; Mon, 28 Aug 2017 15:37:37 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\t141sm1910747pfa.126.2017.08.28.15.37.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 28 Aug 2017 15:37:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+Bvb6bxbDSagjM4o5UrK8b4psy88MV+U0WXXJz3eSHo=;\n\tb=oOLDNMn2/E7mQioK8oFeXPhTFTAuhmHEt/wZlrhx3UUmWR9yDayMHFqmYbgcNP3kZr\n\ttqjzV1RRMbQjD5xQMrUw8oTozo/46QwTqGcB/iD9EJyPxHsOnPqGnkCyHECoWnLsS91+\n\tKnW8Z3Bfzm4ftQj0a+f7DrBcEO0BOBTQyldoaD7nPNP3AqtbFVQVGyQc1mNRVRmne06F\n\tdOcUE8TUAV09l4Pi08bajZG3TfTNNlzwZ4BmjWVNaH4YeElPFbrNV+cbCIWoP+gT4ec4\n\tMrzowLdZIcNtimuqc7PDtXxmOMfT1rbgsC79S+sIqUuJsUz/6qCtpkC30eNUhV45H7FI\n\tj2xQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+Bvb6bxbDSagjM4o5UrK8b4psy88MV+U0WXXJz3eSHo=;\n\tb=XCfGfysoXwts7ATJ0YWCHq+4WMZYGhuEhSDDeC3N/ReNfnj1MZDCfZvR9KuE4TO67R\n\tZzJxTU91LgX3lZmIvViFXG9iYCZ8SOOJ12VDhoXjLP0d2BnH2KQ3bqSLP0DlO9AZedlV\n\tuCOBektQ4TUmdXloQrpSXZa+/i2tzDUjrFIzlH1E/Y5wBT20cLxrflgSUw1N3VAvtki2\n\t08r7UwLFIes0uosQbm3DPdcemU5efHORNhXP71Z1GBDshsOffj6vj0ZTqGYhsL3D3nP/\n\tNQpEj+1RZy0xrhdL6XPak6yFFpxQ7BGgELCbAdMI5jip+rCuyA2IZ7M7FdnzCSuuodVx\n\tCHOw==","X-Gm-Message-State":"AHYfb5hr8fk6Z6z1dIRftw4n5NTPafvXFKCA17SPwl/ERvjf3oBWApbP\n\tdESGb2UTeiD5QM3u","X-Received":"by 10.84.129.72 with SMTP id 66mr2565128plb.146.1503959857199;\n\tMon, 28 Aug 2017 15:37:37 -0700 (PDT)","Date":"Mon, 28 Aug 2017 15:37:34 -0700","From":"Stephen Hemminger ","To":"Jamal Hadi Salim ","Cc":"Alexander Aring , yotamg@mellanox.com,\n\txiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org","Subject":"Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format","Message-ID":"<20170828153734.4b32fa02@xeon-e3>","In-Reply-To":"","References":"<20170828190738.26829-1-aring@mojatatu.com>\n\t<20170828190738.26829-3-aring@mojatatu.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758922,"web_url":"http://patchwork.ozlabs.org/comment/1758922/","msgid":"<51175933-03ea-2419-b871-e5e9a5955528@mojatatu.com>","list_archive_url":null,"date":"2017-08-28T22:56:39","subject":"Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format","submitter":{"id":9380,"url":"http://patchwork.ozlabs.org/api/people/9380/","name":"Jamal Hadi Salim","email":"jhs@mojatatu.com"},"content":"On 17-08-28 06:37 PM, Stephen Hemminger wrote:\n> On Mon, 28 Aug 2017 18:18:04 -0400\n\n[..]\n>>> @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,\n>>> \t\t\tNEXT_ARG();\n>>> \t\t\tif (get_u16(&ife_type, *argv, 0))\n>>> \t\t\t\tinvarg(\"ife type is invalid\", *argv);\n>>> -\t\t\tfprintf(stderr, \"IFE type 0x%x\\n\", ife_type);\n>>> +\t\t\tfprintf(stderr, \"IFE type 0x%04X\\n\", ife_type);\n>>> \t\t\tuser_type = 1;\n>>> \t\t} else if (matches(*argv, \"dst\") == 0) {\n>>> \t\t\tNEXT_ARG();\n>>> \n>>\n> \n> \n> For iproute commands the show output is supposed to match the corresponding set inputs.\n> \n\nThese were being printed at parse time ...\n\ncheers,\njamal","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"FnviI1s3\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh6b11Qk3z9s7v\n\tfor ;\n\tTue, 29 Aug 2017 08:56:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751270AbdH1W4m (ORCPT );\n\tMon, 28 Aug 2017 18:56:42 -0400","from mail-io0-f180.google.com ([209.85.223.180]:32981 \"EHLO\n\tmail-io0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751190AbdH1W4l (ORCPT\n\t); Mon, 28 Aug 2017 18:56:41 -0400","by mail-io0-f180.google.com with SMTP id s101so9171123ioe.0\n\tfor ; Mon, 28 Aug 2017 15:56:41 -0700 (PDT)","from [10.0.0.209] ([64.26.149.125])\n\tby smtp.googlemail.com with ESMTPSA id\n\t189sm688802ioz.29.2017.08.28.15.56.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 15:56:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=zOalWqq3xzN32z5Ic10t40ZSyimRBasZ+/9jcf4rDps=;\n\tb=FnviI1s3/LFmsl8+NfWpKQ9Bo7F0YlL7+B4Jh4jg+r5mCjfZsl1rTFDqV9bTaar6+S\n\trMHDtKzNJJv5lN0GIc+vUOXpixQiIMnhDegdaKEbyt7V1Umsl5wcOPwBw0MBs5yHLDKN\n\tcbEg+WzmRrkqWgfdf21ur9hnSeamcIST9TwmcTbWAyWYfd/P4jSktMi1ncWobOAXe/L6\n\tbJHdULAsu3iNWBVeA8pLNq7dCffT1Cs9jxpnkxGm21Lv55D6AR009p52BXpCCcmRq55r\n\tBWV6vqvwXWOdw082CBGjgTU0afiAf08tHalhoBHbTVYB3F4D7Qye7YuJUdcdHL1S3d0K\n\tHd6Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=zOalWqq3xzN32z5Ic10t40ZSyimRBasZ+/9jcf4rDps=;\n\tb=sJvZ39cArrWLhfnWxdzEJTn92r7mv7rJqhzcKwRd9s3Nyz/WFGBR90hxDuCagIBnTb\n\tzRsqNL9tC9PQOMHYMc3KRZGf2L16VyrgmNgnKFJS9euYiwx6zMKNYYl6MvjrZwFpGgvr\n\telWlgBQ/A78m2BjMc9AEVbhzJPRN/xyw3+2z5ab6wd4dqq4c5JqJmS9JwO+GlVrQmM2G\n\tLUFrhHL53rR1JC9j/+fptQY77TaaCLGtpEKRCGcXl101Ayw4ubhLHP6OvVXn4vjn1NRi\n\txABaWlJIJQn1cFOJjKwWJqSy4f/eCpY6btNA+Z4XswUrvICbHCsAAjze0HCLMZSfm6eg\n\tt8kQ==","X-Gm-Message-State":"AHYfb5hCvFMs7WtkyarPi4LYC3ZOzJL4MJhy7Cy2C+kmzGZd4h/IjNO8\n\tppCIcZSK7MQBZzraXmw=","X-Received":"by 10.36.50.214 with SMTP id j205mr234708ita.41.1503961000717;\n\tMon, 28 Aug 2017 15:56:40 -0700 (PDT)","Subject":"Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format","To":"Stephen Hemminger ","Cc":"Alexander Aring , yotamg@mellanox.com,\n\txiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org","References":"<20170828190738.26829-1-aring@mojatatu.com>\n\t<20170828190738.26829-3-aring@mojatatu.com>\n\t\n\t<20170828153734.4b32fa02@xeon-e3>","From":"Jamal Hadi Salim ","Message-ID":"<51175933-03ea-2419-b871-e5e9a5955528@mojatatu.com>","Date":"Mon, 28 Aug 2017 18:56:39 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170828153734.4b32fa02@xeon-e3>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]