[{"id":1758793,"web_url":"http://patchwork.ozlabs.org/comment/1758793/","msgid":"<20170828120724.53904cbf@xeon-e3>","list_archive_url":null,"date":"2017-08-28T19:07:24","subject":"Re: [PATCH iproute2 net-next 1/2] iproute: add support for seg6\n\tl2encap mode","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Mon, 28 Aug 2017 20:05:24 +0100\nDavid Lebrun wrote:\n\n> \n> +static const char *format_seg6mode_type(int mode)\n> +{\n> +\tif (mode == SEG6_IPTUN_MODE_ENCAP)\n> +\t\treturn \"encap\";\n> +\telse if (mode == SEG6_IPTUN_MODE_INLINE)\n> +\t\treturn \"inline\";\n> +\telse if (mode == SEG6_IPTUN_MODE_L2ENCAP)\n> +\t\treturn \"l2encap\";\n> +\n> +\treturn \"\";\n> +}\n> +\n> +static int read_seg6mode_type(const char *mode)\n> +{\n> +\tif (strcmp(mode, \"encap\") == 0)\n> +\t\treturn SEG6_IPTUN_MODE_ENCAP;\n> +\telse if (strcmp(mode, \"inline\") == 0)\n> +\t\treturn SEG6_IPTUN_MODE_INLINE;\n> +\telse if (strcmp(mode, \"l2encap\") == 0)\n> +\t\treturn SEG6_IPTUN_MODE_L2ENCAP;\n> +\n> +\treturn -1;\n> +}\n\nSince these values probably will grow over time, it would make\nsense to have this a name/value table.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"uG46rRM5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh1VV59T3z9s9Y\n\tfor ;\n\tTue, 29 Aug 2017 05:07:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751286AbdH1TH2 (ORCPT );\n\tMon, 28 Aug 2017 15:07:28 -0400","from mail-pf0-f182.google.com ([209.85.192.182]:35470 \"EHLO\n\tmail-pf0-f182.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751203AbdH1TH1 (ORCPT\n\t); Mon, 28 Aug 2017 15:07:27 -0400","by mail-pf0-f182.google.com with SMTP id g13so3751624pfm.2\n\tfor ; Mon, 28 Aug 2017 12:07:27 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\tb3sm1701202pgc.6.2017.08.28.12.07.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 28 Aug 2017 12:07:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QMVtln3bHYU73JFcHAr8IpZ84XVFwxNFbBy9YKflEAU=;\n\tb=uG46rRM5TOGdpOB9ullqjL96qn7Rj93RpDi1iTMkkPhI6Ni8eQ9MTTzSqqZOZ8XbPU\n\trZmO392lNBefoU1PgUS3dI9+AppFuuWEnPVrISL6vuM+JSwhrXad0/hCeMezAy2u4Vj7\n\tV7qSU6e9en4IrBAACIZY7uuA6CSEoUz/euT5UzJGyxAKj3WQB8wEAfqtZsaoPRmDV7lk\n\tESt/OIbR8CC67sTM2OeNyBxBv0ox6ivzyz0pkVOr4J09qgzS8tVAKPB9UEWC2qP0OP4Y\n\t5JBXCNbJvAR1xJNnZ74Rk78xccK3N8bdKcf0c38FwxOMnEn7wD2T/NjvSPoxfJqksIRz\n\tmS2Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QMVtln3bHYU73JFcHAr8IpZ84XVFwxNFbBy9YKflEAU=;\n\tb=K50XmbxYlUZS0XZedASF5UYcVvK6/coRiPEJETYd0GGSe8FFLjk1VB8KwPx49ekIVE\n\tBNYP3P/6LcV484K2h1SfCqmxHaHWWZSdM+sPzVSrUMip4zZjWX6P3QM8LKHcWQstbt2J\n\tfiwYuLpMoMSyvHANzcKjjeByWSJkbTUjGDBKkykJVrQW3f3PBOUBuA0F89XgfZ0StpwM\n\t8XT1jrYpCXbvqPS3pOBMFe83uR5Ph+7kLMvBmLlcOJptQI6Vj4i8SvRq22X0/qH2Lv6g\n\tP7y5g8HCLBxO3Se2MXTuongVXu6yqVpCrv9Yt5Y49UWlJgir4x8K+M89kl7ek70SJsmP\n\tnw6Q==","X-Gm-Message-State":"AHYfb5gT9kVwkwwiy09V8sFPia7VtPDbC6DDwsCYdHJ99cKQ/lPwE3SM\n\t/mF0boR5A2YAq9XcO7TU4g==","X-Received":"by 10.98.62.65 with SMTP id l62mr1541428pfa.250.1503947246769;\n\tMon, 28 Aug 2017 12:07:26 -0700 (PDT)","Date":"Mon, 28 Aug 2017 12:07:24 -0700","From":"Stephen Hemminger ","To":"David Lebrun ","Cc":"","Subject":"Re: [PATCH iproute2 net-next 1/2] iproute: add support for seg6\n\tl2encap mode","Message-ID":"<20170828120724.53904cbf@xeon-e3>","In-Reply-To":"<20170828190525.15655-2-david.lebrun@uclouvain.be>","References":"<20170828190525.15655-1-david.lebrun@uclouvain.be>\n\t<20170828190525.15655-2-david.lebrun@uclouvain.be>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758797,"web_url":"http://patchwork.ozlabs.org/comment/1758797/","msgid":"<99974f81-90e8-c6ff-7068-2beb871cb84d@uclouvain.be>","list_archive_url":null,"date":"2017-08-28T19:11:59","subject":"Re: [PATCH iproute2 net-next 1/2] iproute: add support for seg6\n\tl2encap mode","submitter":{"id":69771,"url":"http://patchwork.ozlabs.org/api/people/69771/","name":"David Lebrun","email":"david.lebrun@uclouvain.be"},"content":"On 08/28/2017 08:07 PM, Stephen Hemminger wrote:\n> Since these values probably will grow over time, it would make\n> sense to have this a name/value table.\n\nI wasn't sure if it was worth it for 3 values. I do not foresee a large\ngrowth either, but I will send a v2 will a table anyway\n\nDavid","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=uclouvain.be header.i=@uclouvain.be\n\theader.b=\"ddAiHr/2\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh1bC01CYz9s9Y\n\tfor ;\n\tTue, 29 Aug 2017 05:11:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751346AbdH1TLc (ORCPT );\n\tMon, 28 Aug 2017 15:11:32 -0400","from smtp.sgsi.ucl.ac.be ([130.104.5.67]:41426 \"EHLO\n\tsmtp2.sgsi.ucl.ac.be\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751225AbdH1TLb (ORCPT\n\t); Mon, 28 Aug 2017 15:11:31 -0400","from mailboxes.uclouvain.be (mailboxes.uclouvain.be\n\t[130.104.6.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp2.sgsi.ucl.ac.be (Postfix) with ESMTPS id 27B1067D9E0;\n\tMon, 28 Aug 2017 21:11:21 +0200 (CEST)","from [192.168.192.36] (188.141.97.249) by\n\tucl-mbx04.OASIS.UCLOUVAIN.BE (10.10.10.24) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Mon, 28 Aug 2017 21:11:20 +0200"],"DKIM-Filter":"OpenDKIM Filter v2.9.2 smtp2.sgsi.ucl.ac.be 27B1067D9E0","DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple; d=uclouvain.be;\n\ts=selucl; t=1503947481;\n\tbh=7xXPA9WaEhTDjbJ9+zby6CPzOGdy1bGnHZattfylr9U=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=ddAiHr/284PxnZj59IZDpBZs7F7YudjmN5Kz1HfGcxe194KJ4HJ4eQVefAiv9CMUO\n\tslLIK9wWhnNEm1IiWGKdNLX0QUq4xDoa02xLF5p1rKmk2UyP/45mnsqyzHJ+LpO9dR\n\t6/JU7MgOSUcfXZgvOwwunbqem9KfXcmrXL+Yw8OQ=","X-Virus-Status":"Clean","X-Virus-Scanned":"clamav-milter 0.99.2 at smtp-2","Subject":"Re: [PATCH iproute2 net-next 1/2] iproute: add support for seg6\n\tl2encap mode","To":"Stephen Hemminger ","References":"<20170828190525.15655-1-david.lebrun@uclouvain.be>\n\t<20170828190525.15655-2-david.lebrun@uclouvain.be>\n\t<20170828120724.53904cbf@xeon-e3>","CC":"","From":"David Lebrun ","Message-ID":"<99974f81-90e8-c6ff-7068-2beb871cb84d@uclouvain.be>","Date":"Mon, 28 Aug 2017 20:11:59 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<20170828120724.53904cbf@xeon-e3>","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"1FhqUu9wvEGWuDkAoub0tUwsvAMqVcMdh\"","X-Originating-IP":"[188.141.97.249]","X-ClientProxiedBy":"UCL-CAS03.OASIS.UCLOUVAIN.BE (10.10.10.43) To\n\tucl-mbx04.OASIS.UCLOUVAIN.BE (10.10.10.24)","X-SGSI-Information":"","X-SGSI-MailScanner-ID":"27B1067D9E0.A1A7E","X-SGSI-MailScanner":"Found to be clean","X-SGSI-SpamCheck":"n'est pas un polluriel, SpamAssassin (not cached,\n\tscore=-1.75, requis 5, autolearn=not spam, BAYES_00 -1.90,\n\tDKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10,\n\tHELO_MISC_IP 0.25)","X-SGSI-From":"david.lebrun@uclouvain.be","X-SGSI-Spam-Status":"No","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758804,"web_url":"http://patchwork.ozlabs.org/comment/1758804/","msgid":"<20170828123243.22c91803@xeon-e3>","list_archive_url":null,"date":"2017-08-28T19:32:43","subject":"Re: [PATCH iproute2 net-next 1/2] iproute: add support for seg6\n\tl2encap mode","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Mon, 28 Aug 2017 20:11:59 +0100\nDavid Lebrun wrote:\n\n> On 08/28/2017 08:07 PM, Stephen Hemminger wrote:\n> > Since these values probably will grow over time, it would make\n> > sense to have this a name/value table. \n> \n> I wasn't sure if it was worth it for 3 values. I do not foresee a large\n> growth either, but I will send a v2 will a table anyway\n> \n> David\n\nEither way, not a big worry.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"A1zs9gd6\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh25x511Vz9t2V\n\tfor ;\n\tTue, 29 Aug 2017 05:34:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751240AbdH1Tcr (ORCPT );\n\tMon, 28 Aug 2017 15:32:47 -0400","from mail-pg0-f49.google.com ([74.125.83.49]:34405 \"EHLO\n\tmail-pg0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750735AbdH1Tcq (ORCPT\n\t); Mon, 28 Aug 2017 15:32:46 -0400","by mail-pg0-f49.google.com with SMTP id y15so4210036pgc.1\n\tfor ; Mon, 28 Aug 2017 12:32:46 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\tu25sm1768848pfk.122.2017.08.28.12.32.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 28 Aug 2017 12:32:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version;\n\tbh=egPlmiLBI04NVYY8U+q5oaKSPjW339D1EzChdwoYcyY=;\n\tb=A1zs9gd62kgL/3jV99Bhn5PDMPsLU0dNsFtzIJv0o0v+1T+pzRrQUKg9SaOWlceAh8\n\tpr+txJ7p06oqHZeR3HXCyWDR8cgczyIAFqvm24GrSX3rZcfFzzfLXmMZpUR8ZkUtZYlj\n\tfbCxpR0CWHoe6PsERXYyGpgWqvQtzdqPg73rOVWIHOwLNg2WWtRAlrnM0VdPpCC7A9TH\n\tzdFlAGPfpPtGvT1PyuJNOYhjk3RD/46ZWFPRQMsCFugaKujItcjWs8yn262ddbWejL06\n\tUZ3FkLgl5x0Nuu0HBF5vj+E9ZadtZ/IbZ0Be6cm8x+UBBkk5hCFYK2DAf43IiBershJa\n\tiMXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version;\n\tbh=egPlmiLBI04NVYY8U+q5oaKSPjW339D1EzChdwoYcyY=;\n\tb=Xw8O6ci27X4r5A+erRjdDk4UA3/M+8y3DNnNYPN4VJF+hlj7//70tx3JM5Sg3owGlG\n\tmnhbCE8AFEgl1rrS4Fbz1TnB1dnj75F93RskqAPg01pv+DtZ1CI0y1zZA+ReXABNUYoh\n\tIlGji3SRyzsNTjJJ9WA4G+tH8yPImB/RGAGPD1mXz18lBuY/3Md3u+x4JobmqvDva0E0\n\tLwbMQDlhc11vQ9lE6VHFIJZFBp4boLiNAuif1EUBiiIctH0v98BTfTinosat1aqxuzWt\n\tIlNtEr5XiQLY/AUu9ykn1xx5RJB+aq7H2ALg2y2sq+SgqCWmgPQwu7nEcR3jT2fodh3G\n\tYJRA==","X-Gm-Message-State":"AHYfb5gooySJ81QDXRx8dpc6lypnTctWJU35EvIEpgC0CpvC5STwO7RV\n\thKJ5RZ/fP+mE7yMnKryMxw==","X-Received":"by 10.84.224.10 with SMTP id r10mr2001454plj.149.1503948766414; \n\tMon, 28 Aug 2017 12:32:46 -0700 (PDT)","Date":"Mon, 28 Aug 2017 12:32:43 -0700","From":"Stephen Hemminger ","To":"David Lebrun ","Cc":"","Subject":"Re: [PATCH iproute2 net-next 1/2] iproute: add support for seg6\n\tl2encap mode","Message-ID":"<20170828123243.22c91803@xeon-e3>","In-Reply-To":"<99974f81-90e8-c6ff-7068-2beb871cb84d@uclouvain.be>","References":"<20170828190525.15655-1-david.lebrun@uclouvain.be>\n\t<20170828190525.15655-2-david.lebrun@uclouvain.be>\n\t<20170828120724.53904cbf@xeon-e3>\n\t<99974f81-90e8-c6ff-7068-2beb871cb84d@uclouvain.be>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tboundary=\"Sig_/r1G1_0/yjDLUPTWX84cR=Uw\";\n\tprotocol=\"application/pgp-signature\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]