[{"id":1758782,"web_url":"http://patchwork.ozlabs.org/comment/1758782/","msgid":"","list_archive_url":null,"date":"2017-08-28T18:39:55","subject":"Re: [PATCH] packet: Don't write vnet header beyond end of buffer","submitter":{"id":67615,"url":"http://patchwork.ozlabs.org/api/people/67615/","name":"Willem de Bruijn","email":"willemdebruijn.kernel@gmail.com"},"content":"On Mon, Aug 28, 2017 at 2:29 PM, Benjamin Poirier wrote:\n> ... which may happen with certain values of tp_reserve and maclen.\n>\n> Fixes: 58d19b19cd99 (\"packet: vnet_hdr support for tpacket_rcv\")\n> Signed-off-by: Benjamin Poirier \n> Cc: Willem de Bruijn \n\nAcked-by: Willem de Bruijn \n\nThanks for fixing this, Benjamin.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tr8DgkW0\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh0w211QFz9s9Y\n\tfor ;\n\tTue, 29 Aug 2017 04:41:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751493AbdH1Skh (ORCPT );\n\tMon, 28 Aug 2017 14:40:37 -0400","from mail-oi0-f41.google.com ([209.85.218.41]:36497 \"EHLO\n\tmail-oi0-f41.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751182AbdH1Skg (ORCPT\n\t); Mon, 28 Aug 2017 14:40:36 -0400","by mail-oi0-f41.google.com with SMTP id t75so10723035oie.3;\n\tMon, 28 Aug 2017 11:40:35 -0700 (PDT)","by 10.168.72.133 with HTTP; Mon, 28 Aug 2017 11:39:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ox3URrV9LyKTtALNm41BxGUY9+ldwRIxJ5ecqisteAM=;\n\tb=tr8DgkW0J/u7FR5R4bZ+dNwYujY5WXWGcXko/3FLv31gGPuJyRUkIKuvE1oLqKfeeb\n\tlQo/e1pm8sMfBJMd/CjDt6QspzDPtnGFoSye1NDZkg4mJap/ME4bwne/asT/RFNDlwD5\n\txcg65HvZOyZuhd67JKQD58otbrXvzERXHkjDdcdflbNlBwU9vLDMt1AUZ66V/0u9iTf6\n\tNyRqL0jSct7nmS8KMGXwAuPCDA8E88OZauxNlO58JOH9YaPLaZFKLaSsF5OORZwc4vvE\n\t9hqvvRwKAG0CVB6Qq1iVgCT5S9M+zT9MI7QfINlLLg3FZJyoo56XJ36ZzzTcr5IZZUYx\n\t+Teg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ox3URrV9LyKTtALNm41BxGUY9+ldwRIxJ5ecqisteAM=;\n\tb=Alwan45m6IXRHtXjUs77xJGSE/btBq9eqxNfuBG23Och62t8u23mzUXlTk53i3UArZ\n\tOk3f/o5rdimZszlb6eQA5XWC8mxxZJlMvaDRX5QLqjNGM+1aG7KxbOzwpS/7sMBstvn4\n\tN+GvqJwl/SS4UDEIe+Yilh73zjn6RGjeSU31Q3KkLhVZ3HR6JHsefndySwbmwL65GC3I\n\t124/BB1NLhuXAgzE/+Mrr/AJ73KiNu0JnL5Rc9QPcWXiaOVAGBzZ9mfCV4HJ00ozJf11\n\tAgHU+ATIrF950IwqSurmDtrRz/I7tBHyAf6t2h6a4/apVsxQ+VGp64jT9E5BHHPInfnR\n\tlsIQ==","X-Gm-Message-State":"AHYfb5iTT0tOqRrRovSCOAjajsXk0vQep+YvcHkn5/L8rWD3ani0jPIX\n\tGUQs4hNZnKw8iChTa3IRaLGM3rYdUg==","X-Received":"by 10.202.169.17 with SMTP id s17mr1251733oie.198.1503945635471; \n\tMon, 28 Aug 2017 11:40:35 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170828182941.10677-1-bpoirier@suse.com>","References":"<20170828182941.10677-1-bpoirier@suse.com>","From":"Willem de Bruijn ","Date":"Mon, 28 Aug 2017 14:39:55 -0400","Message-ID":"","Subject":"Re: [PATCH] packet: Don't write vnet header beyond end of buffer","To":"Benjamin Poirier ","Cc":"\"David S. Miller\" ,\n\tNetwork Development ,\n\tLKML ,\n\tWillem de Bruijn ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759734,"web_url":"http://patchwork.ozlabs.org/comment/1759734/","msgid":"<20170829.151021.699244485897285329.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-29T22:10:21","subject":"Re: [PATCH] packet: Don't write vnet header beyond end of buffer","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Benjamin Poirier \nDate: Mon, 28 Aug 2017 14:29:41 -0400\n\n> ... which may happen with certain values of tp_reserve and maclen.\n> \n> Fixes: 58d19b19cd99 (\"packet: vnet_hdr support for tpacket_rcv\")\n> Signed-off-by: Benjamin Poirier \n> Cc: Willem de Bruijn \n\nApplied and queued up for -stable.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhjWJ47kmz9sN5\n\tfor ;\n\tWed, 30 Aug 2017 08:10:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751774AbdH2WKX (ORCPT );\n\tTue, 29 Aug 2017 18:10:23 -0400","from shards.monkeyblade.net ([184.105.139.130]:40092 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751275AbdH2WKW (ORCPT\n\t); Tue, 29 Aug 2017 18:10:22 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id EBBE213D8ED64;\n\tTue, 29 Aug 2017 15:10:21 -0700 (PDT)"],"Date":"Tue, 29 Aug 2017 15:10:21 -0700 (PDT)","Message-Id":"<20170829.151021.699244485897285329.davem@davemloft.net>","To":"bpoirier@suse.com","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org, willemb@google.com","Subject":"Re: [PATCH] packet: Don't write vnet header beyond end of buffer","From":"David Miller ","In-Reply-To":"<20170828182941.10677-1-bpoirier@suse.com>","References":"<20170828182941.10677-1-bpoirier@suse.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 29 Aug 2017 15:10:22 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]