[{"id":1758827,"web_url":"http://patchwork.ozlabs.org/comment/1758827/","msgid":"<9113cbb5-f15d-7ce2-fdb0-3609ddb56837@amsat.org>","list_archive_url":null,"date":"2017-08-28T20:18:57","subject":"Re: [Qemu-devel] [PATCH v4 08/10] Makefile: Add rules to run vm\n\ttests","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 08/28/2017 02:47 PM, Fam Zheng wrote:\n> Signed-off-by: Fam Zheng \n> Reviewed-by: Stefan Hajnoczi \n> ---\n> Makefile | 2 ++\n> configure | 2 +-\n> tests/vm/Makefile.include | 40 ++++++++++++++++++++++++++++++++++++++++\n> 3 files changed, 43 insertions(+), 1 deletion(-)\n> create mode 100644 tests/vm/Makefile.include\n> \n> diff --git a/Makefile b/Makefile\n> index 81447b1f08..2798a5ca69 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -813,6 +813,7 @@ endif\n> -include $(wildcard *.d tests/*.d)\n> \n> include $(SRC_PATH)/tests/docker/Makefile.include\n> +include $(SRC_PATH)/tests/vm/Makefile.include\n> \n> .PHONY: help\n> help:\n> @@ -836,6 +837,7 @@ help:\n> \t@echo 'Test targets:'\n> \t@echo ' check - Run all tests (check-help for details)'\n> \t@echo ' docker - Help about targets running tests inside Docker containers'\n> +\t@echo ' vm-test - Help about targets running tests inside VM'\n> \t@echo ''\n> \t@echo 'Documentation targets:'\n> \t@echo ' html info pdf txt'\n> diff --git a/configure b/configure\n> index dd73cce62f..9a3052e9ad 100755\n> --- a/configure\n> +++ b/configure\n> @@ -6544,7 +6544,7 @@ if test \"$ccache_cpp2\" = \"yes\"; then\n> fi\n> \n> # build tree in object directory in case the source is not in the current directory\n> -DIRS=\"tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests\"\n> +DIRS=\"tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests tests/vm\"\n> DIRS=\"$DIRS docs docs/interop fsdev\"\n> DIRS=\"$DIRS pc-bios/optionrom pc-bios/spapr-rtas pc-bios/s390-ccw\"\n> DIRS=\"$DIRS roms/seabios roms/vgabios\"\n> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include\n> new file mode 100644\n> index 0000000000..6e133ae2a6\n> --- /dev/null\n> +++ b/tests/vm/Makefile.include\n> @@ -0,0 +1,40 @@\n> +# Makefile for VM tests\n> +\n> +.PHONY: vm-build-all\n> +\n> +IMAGES := ubuntu.i386 freebsd netbsd openbsd\n> +IMAGE_FILES := $(patsubst %, tests/vm/%.img, $(IMAGES))\n> +\n> +.PRECIOUS: $(IMAGE_FILES)\n> +\n> +vm-test:\n> +\t@echo \"vm-test: Test QEMU in preconfigured virtual machines\"\n> +\t@echo\n> +\t@echo \" vm-build-ubuntu.i386 - Build QEMU in ubuntu i386 VM\"\n> +\t@echo \" vm-build-freebsd - Build QEMU in FreeBSD VM\"\n> +\t@echo \" vm-build-netbsd - Build QEMU in NetBSD VM\"\n> +\t@echo \" vm-build-freebsd - Build QEMU in OpenBSD VM\"\n\nvm-build-openbsd ;)\n\nis it possible to specify OS version?\n\nlike \"vm-build-ubuntu:16.04@i386\" and having a default:\n\n\"vm-build-ubuntu@i386\" -> \"vm-build-ubuntu:16.04@i386\"\n\n> +\n> +vm-build-all: $(addprefix vm-build-, $(IMAGES))\n> +\n> +tests/vm/%.img: $(SRC_PATH)/tests/vm/%\n> +\t$(call quiet-command, \\\n> +\t\t$(SRC_PATH)/tests/vm/$* \\\n> +\t\t$(if $(V)$(DEBUG), --debug) \\\n> +\t\t--image \"$@\" \\\n> +\t\t--force \\\n> +\t\t--build-image $@, \\\n> +\t\t\" VM-IMAGE $*\")\n> +\n> +\n> +# Build in VM $(IMAGE)\n> +vm-build-%: tests/vm/%.img\n> +\t$(call quiet-command, \\\n> +\t\t$(SRC_PATH)/tests/vm/$* \\\n> +\t\t$(if $(V)$(DEBUG), --debug) \\\n> +\t\t$(if $(DEBUG), --interactive) \\\n> +\t\t$(if $(J),--jobs $(J)) \\\n> +\t\t--image \"$<\" \\\n> +\t\t--build-qemu $(SRC_PATH), \\\n> +\t\t\" VM-BUILD $*\")\n> +\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QRNzJN0u\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh35y1qr6z9s7c\n\tfor ;\n\tTue, 29 Aug 2017 06:19:48 +1000 (AEST)","from localhost ([::1]:41326 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmQVd-0001Di-92\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 16:19:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33960)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dmQV1-0001D8-L9\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 16:19:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dmQUw-0004Vn-Nr\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 16:19:07 -0400","from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:38874)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmQUw-0004Vb-In\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 16:19:02 -0400","by mail-qt0-x242.google.com with SMTP id d15so1356152qta.5\n\tfor ; Mon, 28 Aug 2017 13:19:02 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tq19sm873084qta.17.2017.08.28.13.18.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 13:19:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=mkIAScpDG9adIOzOxyXX8WGvG210P7KzVz7hPEWNSRQ=;\n\tb=QRNzJN0uwtsHQHwabc56aw8STFU+cWKm2gGxN3AfCyLo++jMnxHSl9ixuMoIHwGG3p\n\tAH9ixtxU3GNBEda829cWtaAnYijxV5f6yBp2PlpE/wsL4+G1yHRhPiExQU2JhGfGo7Mu\n\tGTb5FjMzq4cm7VtwApvtkESgZddeQfhP4XLwhApERAcRHxdlsx2KRpaELUXQ84B7HJG7\n\t+WMlbr8WcAOMfkoW/Y/NA5V956/XKKBIIue8umyggkl/vtxe93TujpDs4GDmAxRf2Hwg\n\tdl1UyOShrjL0JyKrOACRwhND7P4Xz1VYZYNSijkqUcXdxvDWvshGyHYpPcrJtTzgAKsm\n\tzmkg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=mkIAScpDG9adIOzOxyXX8WGvG210P7KzVz7hPEWNSRQ=;\n\tb=UiqJXzVMaxLeNSUasqqy6Faq6vfhvJTF098NSNKWLxshcHHu8Zab5iCQ0mmjSLlmXx\n\trG/Y/ff2M+l7XsHooRbWY2V6txQ+gFp2rCHGzT8c76GKgV61lAN6OurbKbkBWd9X+ZCP\n\t0Mk64DpqSJMhEnekgy687BLBS55t0SHXasUfhVw44DCFy/l+W29x05WDtjzd/GxWBCNP\n\tyuJU8S/AKVDOT/2G8gGNclsvx71JQ2INI6DCBu6VEbX5UAu1Ht4dsaMjEo/I0i92OOtR\n\tVWdw7aexJDNmM1XtRlC2SkACVXO9wmQ/5RKeIoxKaqTDyl6PlMYXkFHbsE+/G9qR3ZTb\n\tYP8Q==","X-Gm-Message-State":"AHYfb5hJiSANTg2g26uSeCrDQ4obSoGZ8AoQh8BMn34JuYa+qxtjqE1D\n\txX/RFgL1Ng8lew==","X-Received":"by 10.200.22.205 with SMTP id y13mr2893922qtk.37.1503951541944; \n\tMon, 28 Aug 2017 13:19:01 -0700 (PDT)","To":"Fam Zheng , qemu-devel@nongnu.org","References":"<20170828174707.20786-1-famz@redhat.com>\n\t<20170828174707.20786-9-famz@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<9113cbb5-f15d-7ce2-fdb0-3609ddb56837@amsat.org>","Date":"Mon, 28 Aug 2017 17:18:57 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170828174707.20786-9-famz@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::242","Subject":"Re: [Qemu-devel] [PATCH v4 08/10] Makefile: Add rules to run vm\n\ttests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Kamil Rytarowski\n\t, stefanha@redhat.com, Cleber Rosa ,\n\tpbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759211,"web_url":"http://patchwork.ozlabs.org/comment/1759211/","msgid":"<20170829105007.GC8146@lemon>","list_archive_url":null,"date":"2017-08-29T10:50:07","subject":"Re: [Qemu-devel] [PATCH v4 08/10] Makefile: Add rules to run vm\n\ttests","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Mon, 08/28 17:18, Philippe Mathieu-Daudé wrote:\n> On 08/28/2017 02:47 PM, Fam Zheng wrote:\n> > Signed-off-by: Fam Zheng \n> > Reviewed-by: Stefan Hajnoczi \n> > ---\n> > Makefile | 2 ++\n> > configure | 2 +-\n> > tests/vm/Makefile.include | 40 ++++++++++++++++++++++++++++++++++++++++\n> > 3 files changed, 43 insertions(+), 1 deletion(-)\n> > create mode 100644 tests/vm/Makefile.include\n> > \n> > diff --git a/Makefile b/Makefile\n> > index 81447b1f08..2798a5ca69 100644\n> > --- a/Makefile\n> > +++ b/Makefile\n> > @@ -813,6 +813,7 @@ endif\n> > -include $(wildcard *.d tests/*.d)\n> > include $(SRC_PATH)/tests/docker/Makefile.include\n> > +include $(SRC_PATH)/tests/vm/Makefile.include\n> > .PHONY: help\n> > help:\n> > @@ -836,6 +837,7 @@ help:\n> > \t@echo 'Test targets:'\n> > \t@echo ' check - Run all tests (check-help for details)'\n> > \t@echo ' docker - Help about targets running tests inside Docker containers'\n> > +\t@echo ' vm-test - Help about targets running tests inside VM'\n> > \t@echo ''\n> > \t@echo 'Documentation targets:'\n> > \t@echo ' html info pdf txt'\n> > diff --git a/configure b/configure\n> > index dd73cce62f..9a3052e9ad 100755\n> > --- a/configure\n> > +++ b/configure\n> > @@ -6544,7 +6544,7 @@ if test \"$ccache_cpp2\" = \"yes\"; then\n> > fi\n> > # build tree in object directory in case the source is not in the current directory\n> > -DIRS=\"tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests\"\n> > +DIRS=\"tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests tests/vm\"\n> > DIRS=\"$DIRS docs docs/interop fsdev\"\n> > DIRS=\"$DIRS pc-bios/optionrom pc-bios/spapr-rtas pc-bios/s390-ccw\"\n> > DIRS=\"$DIRS roms/seabios roms/vgabios\"\n> > diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include\n> > new file mode 100644\n> > index 0000000000..6e133ae2a6\n> > --- /dev/null\n> > +++ b/tests/vm/Makefile.include\n> > @@ -0,0 +1,40 @@\n> > +# Makefile for VM tests\n> > +\n> > +.PHONY: vm-build-all\n> > +\n> > +IMAGES := ubuntu.i386 freebsd netbsd openbsd\n> > +IMAGE_FILES := $(patsubst %, tests/vm/%.img, $(IMAGES))\n> > +\n> > +.PRECIOUS: $(IMAGE_FILES)\n> > +\n> > +vm-test:\n> > +\t@echo \"vm-test: Test QEMU in preconfigured virtual machines\"\n> > +\t@echo\n> > +\t@echo \" vm-build-ubuntu.i386 - Build QEMU in ubuntu i386 VM\"\n> > +\t@echo \" vm-build-freebsd - Build QEMU in FreeBSD VM\"\n> > +\t@echo \" vm-build-netbsd - Build QEMU in NetBSD VM\"\n> > +\t@echo \" vm-build-freebsd - Build QEMU in OpenBSD VM\"\n> \n> vm-build-openbsd ;)\n\nYes, thanks!\n\n> \n> is it possible to specify OS version?\n> \n> like \"vm-build-ubuntu:16.04@i386\" and having a default:\n> \n> \"vm-build-ubuntu@i386\" -> \"vm-build-ubuntu:16.04@i386\"\n\nMaybe, when we do have more than one options. :)\n\nFam\n\n> \n> > +\n> > +vm-build-all: $(addprefix vm-build-, $(IMAGES))\n> > +\n> > +tests/vm/%.img: $(SRC_PATH)/tests/vm/%\n> > +\t$(call quiet-command, \\\n> > +\t\t$(SRC_PATH)/tests/vm/$* \\\n> > +\t\t$(if $(V)$(DEBUG), --debug) \\\n> > +\t\t--image \"$@\" \\\n> > +\t\t--force \\\n> > +\t\t--build-image $@, \\\n> > +\t\t\" VM-IMAGE $*\")\n> > +\n> > +\n> > +# Build in VM $(IMAGE)\n> > +vm-build-%: tests/vm/%.img\n> > +\t$(call quiet-command, \\\n> > +\t\t$(SRC_PATH)/tests/vm/$* \\\n> > +\t\t$(if $(V)$(DEBUG), --debug) \\\n> > +\t\t$(if $(DEBUG), --interactive) \\\n> > +\t\t$(if $(J),--jobs $(J)) \\\n> > +\t\t--image \"$<\" \\\n> > +\t\t--build-qemu $(SRC_PATH), \\\n> > +\t\t\" VM-BUILD $*\")\n> > +\n> > \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhQRl07q0z9s7c\n\tfor ;\n\tTue, 29 Aug 2017 20:51:30 +1000 (AEST)","from localhost ([::1]:43985 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dme6U-000321-Uo\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 06:50:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46319)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dme66-00030J-DQ\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 06:50:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dme62-0004BS-7W\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 06:50:18 -0400","from mx1.redhat.com ([209.132.183.28]:44558)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dme61-0004A7-Tm\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 06:50:14 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9DEA8356CD;\n\tTue, 29 Aug 2017 10:50:12 +0000 (UTC)","from localhost (ovpn-12-24.pek2.redhat.com [10.72.12.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2FE965C269;\n\tTue, 29 Aug 2017 10:50:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9DEA8356CD","Date":"Tue, 29 Aug 2017 18:50:07 +0800","From":"Fam Zheng ","To":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ","Message-ID":"<20170829105007.GC8146@lemon>","References":"<20170828174707.20786-1-famz@redhat.com>\n\t<20170828174707.20786-9-famz@redhat.com>\n\t<9113cbb5-f15d-7ce2-fdb0-3609ddb56837@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<9113cbb5-f15d-7ce2-fdb0-3609ddb56837@amsat.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 29 Aug 2017 10:50:12 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 08/10] Makefile: Add rules to run vm\n\ttests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Kamil\n\tRytarowski , stefanha@redhat.com, Cleber Rosa\n\t, pbonzini@redhat.com, Alex =?iso-8859-1?q?Benn=E9e?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]