[{"id":1759844,"web_url":"http://patchwork.ozlabs.org/comment/1759844/","msgid":"<d57d4bab-51ec-901c-7474-20dc5156f795@amsat.org>","list_archive_url":null,"date":"2017-08-30T01:48:59","subject":"Re: [Qemu-devel] [Qemu devel v7 PATCH 5/5] msf2: Add Emcraft's\n\tSmartfusion2 SOM kit","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Subbaraya,\n\nOn 08/28/2017 01:38 PM, Subbaraya Sundeep wrote:\n> Emulated Emcraft's Smartfusion2 System On Module starter\n> kit.\n> \n> Signed-off-by: Subbaraya Sundeep <sundeep.lkml@gmail.com>\n> ---\n>   hw/arm/Makefile.objs |  2 +-\n>   hw/arm/msf2-som.c    | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++++\n>   2 files changed, 95 insertions(+), 1 deletion(-)\n>   create mode 100644 hw/arm/msf2-som.c\n> \n> diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs\n> index df36a03..e81a7dc 100644\n> --- a/hw/arm/Makefile.objs\n> +++ b/hw/arm/Makefile.objs\n> @@ -19,4 +19,4 @@ obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o\n>   obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o\n>   obj-$(CONFIG_ASPEED_SOC) += aspeed_soc.o aspeed.o\n>   obj-$(CONFIG_MPS2) += mps2.o\n> -obj-$(CONFIG_MSF2) += msf2-soc.o\n> +obj-$(CONFIG_MSF2) += msf2-soc.o msf2-som.o\n> diff --git a/hw/arm/msf2-som.c b/hw/arm/msf2-som.c\n> new file mode 100644\n> index 0000000..fd89ba9\n> --- /dev/null\n> +++ b/hw/arm/msf2-som.c\n> @@ -0,0 +1,94 @@\n> +/*\n> + * SmartFusion2 SOM starter kit(from Emcraft) emulation.\n> + *\n> + * Copyright (c) 2017 Subbaraya Sundeep <sundeep.lkml@gmail.com>\n> + *\n> + * Permission is hereby granted, free of charge, to any person obtaining a copy\n> + * of this software and associated documentation files (the \"Software\"), to deal\n> + * in the Software without restriction, including without limitation the rights\n> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n> + * copies of the Software, and to permit persons to whom the Software is\n> + * furnished to do so, subject to the following conditions:\n> + *\n> + * The above copyright notice and this permission notice shall be included in\n> + * all copies or substantial portions of the Software.\n> + *\n> + * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL\n> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n> + * THE SOFTWARE.\n> + */\n> +\n> +#include \"qemu/osdep.h\"\n> +#include \"qapi/error.h\"\n> +#include \"hw/boards.h\"\n> +#include \"hw/arm/arm.h\"\n> +#include \"exec/address-spaces.h\"\n> +#include \"qemu/cutils.h\"\n> +#include \"hw/arm/msf2-soc.h\"\n> +\n> +#define DDR_BASE_ADDRESS      0xA0000000\n> +#define DDR_SIZE              (64 * M_BYTE)\n> +\n> +#define M2S010_ENVM_SIZE      (256 * K_BYTE)\n> +#define M2S010_ESRAM_SIZE     (64 * K_BYTE)\n> +\n> +static void emcraft_sf2_init(MachineState *machine)\n\nSince Emcraft can produce an upgraded SF2 SoC based on a different MCU, \nI prefer you rename it:\n\nstatic void emcraft_sf2_s2s010_init(MachineState *machine)\n\n> +{\n> +    DeviceState *dev;\n> +    DeviceState *spi_flash;\n> +    MSF2State *soc;\n> +    DriveInfo *dinfo = drive_get_next(IF_MTD);\n> +    qemu_irq cs_line;\n> +    SSIBus *spi_bus;\n> +    MemoryRegion *sysmem = get_system_memory();\n> +    MemoryRegion *ddr = g_new(MemoryRegion, 1);\n> +\n> +    memory_region_init_ram(ddr, NULL, \"ddr-ram\", DDR_SIZE,\n> +                           &error_fatal);\n> +    memory_region_add_subregion(sysmem, DDR_BASE_ADDRESS, ddr);\n> +\n> +    dev = qdev_create(NULL, TYPE_MSF2_SOC);\n> +    qdev_prop_set_string(dev, \"part-name\", \"M2S010\");\n> +    qdev_prop_set_uint64(dev, \"eNVM-size\", M2S010_ENVM_SIZE);\n> +    qdev_prop_set_uint64(dev, \"eSRAM-size\", M2S010_ESRAM_SIZE);\n> +\n> +    /*\n> +     * CPU clock and peripheral clocks(APB0, APB1)are configurable\n> +     * in Libero. CPU clock is divided by APB0 and APB1 divisors for\n> +     * peripherals. Emcraft's SoM kit comes with these settings by default.\n> +     */\n> +    qdev_prop_set_uint32(dev, \"m3clk\", 142 * 1000000);\n> +    qdev_prop_set_uint32(dev, \"apb0div\", 2);\n> +    qdev_prop_set_uint32(dev, \"apb1div\", 2);\n> +\n> +    object_property_set_bool(OBJECT(dev), true, \"realized\", &error_fatal);\n> +\n> +    soc = MSF2_SOC(dev);\n> +\n> +    /* Attach SPI flash to SPI0 controller */\n> +    spi_bus = (SSIBus *)qdev_get_child_bus(dev, \"spi0\");\n> +    spi_flash = ssi_create_slave_no_init(spi_bus, \"s25sl12801\");\n> +    qdev_prop_set_uint8(spi_flash, \"spansion-cr2nv\", 1);\n> +    if (dinfo) {\n> +        qdev_prop_set_drive(spi_flash, \"drive\", blk_by_legacy_dinfo(dinfo),\n> +                                    &error_fatal);\n> +    }\n> +    qdev_init_nofail(spi_flash);\n> +    cs_line = qdev_get_gpio_in_named(spi_flash, SSI_GPIO_CS, 0);\n> +    sysbus_connect_irq(SYS_BUS_DEVICE(&soc->spi[0]), 1, cs_line);\n> +\n> +    armv7m_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename,\n> +                       soc->envm_size);\n> +}\n> +\n> +static void emcraft_sf2_machine_init(MachineClass *mc)\n> +{\n> +    mc->desc = \"SmartFusion2 SOM kit from Emcraft\";\n\n     mc->desc = \"SmartFusion2 SOM kit from Emcraft (M2S010)\";\n\n> +    mc->init = emcraft_sf2_init;\n\n     mc->init = emcraft_sf2_s2s010_init;\n\n> +}\n> +\n> +DEFINE_MACHINE(\"emcraft-sf2\", emcraft_sf2_machine_init)\n\nGood work :)\n\nWith the changes:\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PsNhI05O\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhs460w4nz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 13:51:02 +1000 (AEST)","from localhost ([::1]:47977 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmu1s-0004Iy-0u\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 23:51:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40737)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dmu0w-0003zF-0p\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 23:50:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dmu0u-0001eb-MF\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 23:50:02 -0400","from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:32991)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dmu0k-0001Yj-B2; Tue, 29 Aug 2017 23:49:50 -0400","by mail-qt0-x243.google.com with SMTP id q53so4363983qtq.0;\n\tTue, 29 Aug 2017 20:49:50 -0700 (PDT)","from [192.168.43.33] ([170.51.33.248])\n\tby smtp.gmail.com with ESMTPSA id\n\te67sm2990018qkb.67.2017.08.29.20.49.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 20:49:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=ULGkTRG04Xj0pQe6afiUOVE9EwNdSsVrO7OyjfZuH7w=;\n\tb=PsNhI05OTaT2YUHAAWJMoDIvsupTSSWN/aMXf3zVcZM5IbFpIjhNuHQku2vwKDtE7i\n\tyKLZbHszgeIpY5CRud1ypp1d2wicPm0rPtbETDF5OsYs4T2xZgAOsKS2opLUnlkwXZCd\n\tQUjAhaREyhb0ezlo5HB4/iefYPlxyo/qm78pN25oNESpb2gmptIVQKZS4vkqZenSfyNP\n\t9JXmx1t2DeNw2IiRh4xCWMoIGQPjMoNGisqI3m2JSx+DWG5X8L03gETn/L+yh+hqKkuU\n\t3A3A11uxa1Bcz7NvyvlWCCurNwvrgrDlr+evIG4NK6oNKbCsYIogNzNBHUW5ztyavrCI\n\tQYVQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=ULGkTRG04Xj0pQe6afiUOVE9EwNdSsVrO7OyjfZuH7w=;\n\tb=AiGi/VBZ48ane8Y7yjdPpnm3Mcd5K5UYuAjhXhMzDEwYGO/PBqSWU5Vmsq1NhfQ2k3\n\t7wV45vTHTCRjyhvsI3HKxvHWc1aALMohqUodkblIgAZLgPJmAPOs3kVcj9KGnxCXstaw\n\taweG4HQ9eS0+pqAbNfox/3hFGf/yTOQjxEtNDQYSHhfiZS3J7N5+g9HwK+FR8pwDCqu9\n\tYDJSmngr40BbTMjnYd46tqZzJZjpFQWLDbeOlGxImBSyI4rUF1sjVv0028oIHmaIErxk\n\tgRXcLYbPll7GlIARrbyxlSeLID4JtFuVROiyuu8Y8KWNHWH8yDfuVHE6SBqkqgzkMDHG\n\tpMKQ==","X-Gm-Message-State":"AHYfb5jUaHMZ28PYda3YCRRUoyhFN9nfNZO12VGTHmY+MXel6BHj8/Xp\n\t2zMV+803T6EbMA==","X-Received":"by 10.237.62.173 with SMTP id n42mr265987qtf.72.1504064989706;\n\tTue, 29 Aug 2017 20:49:49 -0700 (PDT)","To":"Subbaraya Sundeep <sundeep.lkml@gmail.com>, qemu-devel@nongnu.org,\n\tqemu-arm@nongnu.org","References":"<1503938283-12404-1-git-send-email-sundeep.lkml@gmail.com>\n\t<1503938283-12404-6-git-send-email-sundeep.lkml@gmail.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","Message-ID":"<d57d4bab-51ec-901c-7474-20dc5156f795@amsat.org>","Date":"Tue, 29 Aug 2017 22:48:59 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1503938283-12404-6-git-send-email-sundeep.lkml@gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::243","Subject":"Re: [Qemu-devel] [Qemu devel v7 PATCH 5/5] msf2: Add Emcraft's\n\tSmartfusion2 SOM kit","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"peter.maydell@linaro.org, alistair23@gmail.com,\n\tcrosthwaite.peter@gmail.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760111,"web_url":"http://patchwork.ozlabs.org/comment/1760111/","msgid":"<CALHRZupSDn-a4oHqcZCjppj8NX=sZJ6Uk+xXhLfSs_W3zbJCHw@mail.gmail.com>","list_archive_url":null,"date":"2017-08-30T12:24:45","subject":"Re: [Qemu-devel] [Qemu devel v7 PATCH 5/5] msf2: Add Emcraft's\n\tSmartfusion2 SOM kit","submitter":{"id":64324,"url":"http://patchwork.ozlabs.org/api/people/64324/","name":"sundeep subbaraya","email":"sundeep.lkml@gmail.com"},"content":"Hi Philippe,\n\nOn Wed, Aug 30, 2017 at 7:18 AM, Philippe Mathieu-Daudé <f4bug@amsat.org>\nwrote:\n\n> Hi Subbaraya,\n>\n>\n> On 08/28/2017 01:38 PM, Subbaraya Sundeep wrote:\n>\n>> Emulated Emcraft's Smartfusion2 System On Module starter\n>> kit.\n>>\n>> Signed-off-by: Subbaraya Sundeep <sundeep.lkml@gmail.com>\n>> ---\n>>   hw/arm/Makefile.objs |  2 +-\n>>   hw/arm/msf2-som.c    | 94 ++++++++++++++++++++++++++++++\n>> ++++++++++++++++++++++\n>>   2 files changed, 95 insertions(+), 1 deletion(-)\n>>   create mode 100644 hw/arm/msf2-som.c\n>>\n>> diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs\n>> index df36a03..e81a7dc 100644\n>> --- a/hw/arm/Makefile.objs\n>> +++ b/hw/arm/Makefile.objs\n>> @@ -19,4 +19,4 @@ obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o\n>>   obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o\n>>   obj-$(CONFIG_ASPEED_SOC) += aspeed_soc.o aspeed.o\n>>   obj-$(CONFIG_MPS2) += mps2.o\n>> -obj-$(CONFIG_MSF2) += msf2-soc.o\n>> +obj-$(CONFIG_MSF2) += msf2-soc.o msf2-som.o\n>> diff --git a/hw/arm/msf2-som.c b/hw/arm/msf2-som.c\n>> new file mode 100644\n>> index 0000000..fd89ba9\n>> --- /dev/null\n>> +++ b/hw/arm/msf2-som.c\n>> @@ -0,0 +1,94 @@\n>> +/*\n>> + * SmartFusion2 SOM starter kit(from Emcraft) emulation.\n>> + *\n>> + * Copyright (c) 2017 Subbaraya Sundeep <sundeep.lkml@gmail.com>\n>> + *\n>> + * Permission is hereby granted, free of charge, to any person obtaining\n>> a copy\n>> + * of this software and associated documentation files (the \"Software\"),\n>> to deal\n>> + * in the Software without restriction, including without limitation the\n>> rights\n>> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or\n>> sell\n>> + * copies of the Software, and to permit persons to whom the Software is\n>> + * furnished to do so, subject to the following conditions:\n>> + *\n>> + * The above copyright notice and this permission notice shall be\n>> included in\n>> + * all copies or substantial portions of the Software.\n>> + *\n>> + * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n>> EXPRESS OR\n>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n>> MERCHANTABILITY,\n>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT\n>> SHALL\n>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR\n>> OTHER\n>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,\n>> ARISING FROM,\n>> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER\n>> DEALINGS IN\n>> + * THE SOFTWARE.\n>> + */\n>> +\n>> +#include \"qemu/osdep.h\"\n>> +#include \"qapi/error.h\"\n>> +#include \"hw/boards.h\"\n>> +#include \"hw/arm/arm.h\"\n>> +#include \"exec/address-spaces.h\"\n>> +#include \"qemu/cutils.h\"\n>> +#include \"hw/arm/msf2-soc.h\"\n>> +\n>> +#define DDR_BASE_ADDRESS      0xA0000000\n>> +#define DDR_SIZE              (64 * M_BYTE)\n>> +\n>> +#define M2S010_ENVM_SIZE      (256 * K_BYTE)\n>> +#define M2S010_ESRAM_SIZE     (64 * K_BYTE)\n>> +\n>> +static void emcraft_sf2_init(MachineState *machine)\n>>\n>\n> Since Emcraft can produce an upgraded SF2 SoC based on a different MCU, I\n> prefer you rename it:\n>\n> static void emcraft_sf2_s2s010_init(MachineState *machine)\n\n\nOk will change.\n\n>\n>\n> +{\n>> +    DeviceState *dev;\n>> +    DeviceState *spi_flash;\n>> +    MSF2State *soc;\n>> +    DriveInfo *dinfo = drive_get_next(IF_MTD);\n>> +    qemu_irq cs_line;\n>> +    SSIBus *spi_bus;\n>> +    MemoryRegion *sysmem = get_system_memory();\n>> +    MemoryRegion *ddr = g_new(MemoryRegion, 1);\n>> +\n>> +    memory_region_init_ram(ddr, NULL, \"ddr-ram\", DDR_SIZE,\n>> +                           &error_fatal);\n>> +    memory_region_add_subregion(sysmem, DDR_BASE_ADDRESS, ddr);\n>> +\n>> +    dev = qdev_create(NULL, TYPE_MSF2_SOC);\n>> +    qdev_prop_set_string(dev, \"part-name\", \"M2S010\");\n>> +    qdev_prop_set_uint64(dev, \"eNVM-size\", M2S010_ENVM_SIZE);\n>> +    qdev_prop_set_uint64(dev, \"eSRAM-size\", M2S010_ESRAM_SIZE);\n>> +\n>> +    /*\n>> +     * CPU clock and peripheral clocks(APB0, APB1)are configurable\n>> +     * in Libero. CPU clock is divided by APB0 and APB1 divisors for\n>> +     * peripherals. Emcraft's SoM kit comes with these settings by\n>> default.\n>> +     */\n>> +    qdev_prop_set_uint32(dev, \"m3clk\", 142 * 1000000);\n>> +    qdev_prop_set_uint32(dev, \"apb0div\", 2);\n>> +    qdev_prop_set_uint32(dev, \"apb1div\", 2);\n>> +\n>> +    object_property_set_bool(OBJECT(dev), true, \"realized\",\n>> &error_fatal);\n>> +\n>> +    soc = MSF2_SOC(dev);\n>> +\n>> +    /* Attach SPI flash to SPI0 controller */\n>> +    spi_bus = (SSIBus *)qdev_get_child_bus(dev, \"spi0\");\n>> +    spi_flash = ssi_create_slave_no_init(spi_bus, \"s25sl12801\");\n>> +    qdev_prop_set_uint8(spi_flash, \"spansion-cr2nv\", 1);\n>> +    if (dinfo) {\n>> +        qdev_prop_set_drive(spi_flash, \"drive\",\n>> blk_by_legacy_dinfo(dinfo),\n>> +                                    &error_fatal);\n>> +    }\n>> +    qdev_init_nofail(spi_flash);\n>> +    cs_line = qdev_get_gpio_in_named(spi_flash, SSI_GPIO_CS, 0);\n>> +    sysbus_connect_irq(SYS_BUS_DEVICE(&soc->spi[0]), 1, cs_line);\n>> +\n>> +    armv7m_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename,\n>> +                       soc->envm_size);\n>> +}\n>> +\n>> +static void emcraft_sf2_machine_init(MachineClass *mc)\n>> +{\n>> +    mc->desc = \"SmartFusion2 SOM kit from Emcraft\";\n>>\n>\n>     mc->desc = \"SmartFusion2 SOM kit from Emcraft (M2S010)\";\n>\n> +    mc->init = emcraft_sf2_init;\n>>\n>\n>     mc->init = emcraft_sf2_s2s010_init;\n>\n> +}\n>> +\n>> +DEFINE_MACHINE(\"emcraft-sf2\", emcraft_sf2_machine_init)\n>>\n>\n> Good work :)\n>\nWith the changes:\n> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n>\n\nThank you :)\nSundeep","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"NJxfMyJi\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj4Vg1ZMyz9sN5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 22:26:19 +1000 (AEST)","from localhost ([::1]:50305 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn24W-0001BQ-Vk\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 08:26:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36572)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <sundeep.lkml@gmail.com>) id 1dn236-00009J-C5\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:24:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <sundeep.lkml@gmail.com>) id 1dn234-0002lh-HZ\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:24:48 -0400","from mail-vk0-x22b.google.com ([2607:f8b0:400c:c05::22b]:34854)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <sundeep.lkml@gmail.com>)\n\tid 1dn234-0002lS-AV; Wed, 30 Aug 2017 08:24:46 -0400","by mail-vk0-x22b.google.com with SMTP id z187so17019617vkd.2;\n\tWed, 30 Aug 2017 05:24:46 -0700 (PDT)","by 10.176.75.196 with HTTP; Wed, 30 Aug 2017 05:24:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=nRPmrAoUz/kOGFdyV0l+r+3O1F7We0SgwqTq6eaJL5c=;\n\tb=NJxfMyJic+zV+aG2AISGmJSgMfBq2gsdQxOJBAuE3US9bx1ZuwPscv89Y63FgLSoGM\n\tA+ve7eREjjej058Q1MmnKM5KGIKFk3nj6zT6CE2458TT54aSHg4cmHep+LzH7MeacJJM\n\t40zqy+4ERbuy3BIo6IWWdHlWVrx3lJoYYC3xYDVA+FCdd5QYZJaWvIPAbsG+YdrnhB9+\n\tFDZ1cIKs2FohVddwQ3Bahn7S5vJaNM/M+QPylPyzH7NCmfwk6cSRYYoZY5RKhNcz9rr0\n\tLzhbKG3cLlNbQ4BksvcxEZT2VBNwP0WRFS9WCnuezQt/q1kxCORuzt6oue24EzFxuGTk\n\tgLMQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=nRPmrAoUz/kOGFdyV0l+r+3O1F7We0SgwqTq6eaJL5c=;\n\tb=pocIhCT4OWlOzAyMU+JrgDkLsg241mjr+f6fsrwW82JBmeZfJlMnDTKvAsgheNa8UO\n\tzhRp2jCkGaWjo3vVKt2lvJBXUV7nX3Bvrbk7AA6xCAE5dizVjV9TNxFrMC4jxs12TAtN\n\t18jbRw06E3at6f1fnopoVtat/SUOtHuzNPHBl4X5UZRO6Gfbk02LGHjp4zzrDF07cu+D\n\t+NkckTzytY7XpebM8O9dAQ0/Cq4JJZmeV4EpWV+tJESaAJx/BP2e+M8DWPY1bgEh99AF\n\tLcytB3SjdZlsv0PvLIR0nrzf1Z4tJ3SbFvmYKL5mjuM3kAbWMq8gH6uNuAko7p49Fb6j\n\t/zpA==","X-Gm-Message-State":"AHYfb5jZV8F86EOJnaKoZbwP7lmokRoIT1QaR4GLzjQ5bKt6Cg+ohWo0\n\t0u4XeuxskPT7vQ4Qsrvp5gNAMUO07A==","X-Google-Smtp-Source":"ADKCNb42mrVpRtxoud6t6POxoa/TzdQf4IQfPFIL3kqxZAztdqRnuyZWhXGP6Iz+UT7DDkUMCUiN8xPS9bzItZJ8pUk=","X-Received":"by 10.31.248.3 with SMTP id w3mr764782vkh.53.1504095885661; Wed,\n\t30 Aug 2017 05:24:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<d57d4bab-51ec-901c-7474-20dc5156f795@amsat.org>","References":"<1503938283-12404-1-git-send-email-sundeep.lkml@gmail.com>\n\t<1503938283-12404-6-git-send-email-sundeep.lkml@gmail.com>\n\t<d57d4bab-51ec-901c-7474-20dc5156f795@amsat.org>","From":"sundeep subbaraya <sundeep.lkml@gmail.com>","Date":"Wed, 30 Aug 2017 17:54:45 +0530","Message-ID":"<CALHRZupSDn-a4oHqcZCjppj8NX=sZJ6Uk+xXhLfSs_W3zbJCHw@mail.gmail.com>","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400c:c05::22b","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [Qemu devel v7 PATCH 5/5] msf2: Add Emcraft's\n\tSmartfusion2 SOM kit","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, qemu-arm <qemu-arm@nongnu.org>,\n\tQEMU Developers <qemu-devel@nongnu.org>,\n\tAlistair Francis <alistair23@gmail.com>,\n\tPeter Crosthwaite <crosthwaite.peter@gmail.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]