[{"id":1758830,"web_url":"http://patchwork.ozlabs.org/comment/1758830/","msgid":"<140e8e93-df14-fea5-ada5-4e1aa4636f94@mind.be>","list_archive_url":null,"date":"2017-08-28T20:28:08","subject":"Re: [Buildroot] [PATCH] pppd: Do not overwrite /etc/resolv.conf","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 28-08-17 17:56, Jeroen Roovers wrote:\n> With option usepeerdns, pppd by default writes to /etc/ppp/resolv.conf,\n> which is not very useful and might be impossible. However, when more\n> than one interface can be used for DNS resolution, pppd will overwrite\n> any existing entries when /etc/resolv.conf is used instead, which is\n> bad. \n\n I agree that this is bad.\n\n> Fix this by setting the path to a place we assume is always\n> writeable, /tmp/ppp-resolv.conf, and which does not interfere with other\n> mechanisms that write DNS resolver configurations.\n\n However, this is a regression. People who currently have ppp as their only\ninterface, or who never have ppp and ethernet running at the same time,\ncurrently have a fully working solution. With this change, DNS doesn't work\nanymore over ppp unless you add some script to merge /tmp/ppp-resolv.conf with\n/tmp/resolv.conf\n\n So I think this patch should be combined with a /etc/ppp/ip-up (and ip-down)\nscript that updates /etc/resolv.conf, similar like how udhcpc.script does it.\n\n I guess you must have something like that anyway, otherwise you would never\nhave DNS over ppp, right?\n\n Regards,\n Arnout\n\n> ---\n> package/pppd/pppd.mk | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/package/pppd/pppd.mk b/package/pppd/pppd.mk\n> index 6139c5b085..47937730d5 100644\n> --- a/package/pppd/pppd.mk\n> +++ b/package/pppd/pppd.mk\n> @@ -36,10 +36,10 @@ PPPD_POST_EXTRACT_HOOKS += PPPD_DROP_INTERNAL_IF_PPOL2TP_H\n> \n> # pppd defaults to /etc/ppp/resolv.conf, which not be writable and is\n> # definitely not useful since the C library only uses\n> -# /etc/resolv.conf. Therefore, we change pppd to use /etc/resolv.conf\n> +# /etc/resolv.conf. Therefore, we change pppd to use /tmp/ppp-resolv.conf\n> # instead.\n> define PPPD_SET_RESOLV_CONF\n> -\t$(SED) 's,ppp/resolv.conf,resolv.conf,' $(@D)/pppd/pathnames.h\n> +\t$(SED) 's,/etc/ppp/resolv.conf,/tmp/ppp-resolv.conf,' $(@D)/pppd/pathnames.h\n> endef\n> PPPD_POST_EXTRACT_HOOKS += PPPD_SET_RESOLV_CONF\n> \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh3Hr71RFz9s7p\n\tfor ;\n\tTue, 29 Aug 2017 06:28:23 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8DCA581CEC;\n\tMon, 28 Aug 2017 20:28:19 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FDpe3rt+Fsz4; Mon, 28 Aug 2017 20:28:17 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A491581B9B;\n\tMon, 28 Aug 2017 20:28:17 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9EE3B1BFE2E\n\tfor ;\n\tMon, 28 Aug 2017 20:28:16 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9606C81B9B\n\tfor ;\n\tMon, 28 Aug 2017 20:28:16 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Z83abX4vS1R5 for ;\n\tMon, 28 Aug 2017 20:28:15 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 02C1B8172D\n\tfor ; Mon, 28 Aug 2017 20:28:14 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tMon, 28 Aug 2017 22:28:11 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Jeroen Roovers , ","References":"<20170828155604.24229-1-jer@airfi.aero>","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"<140e8e93-df14-fea5-ada5-4e1aa4636f94@mind.be>","Date":"Mon, 28 Aug 2017 22:28:08 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170828155604.24229-1-jer@airfi.aero>","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Subject":"Re: [Buildroot] [PATCH] pppd: Do not overwrite /etc/resolv.conf","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1766119,"web_url":"http://patchwork.ozlabs.org/comment/1766119/","msgid":"","list_archive_url":null,"date":"2017-09-11T07:58:21","subject":"Re: [Buildroot] [PATCH] pppd: Do not overwrite /etc/resolv.conf","submitter":{"id":68300,"url":"http://patchwork.ozlabs.org/api/people/68300/","name":"Jeroen Roovers","email":"jer@airfi.aero"},"content":"On 28 August 2017 at 22:28, Arnout Vandecappelle wrote:\n\n>> pppd will overwrite any existing entries when /etc/resolv.conf is used instead, which is\n>> bad.\n>\n> I agree that this is bad.\n\nThanks.\n\n> However, this is a regression.\n\n1. dnsmasq(8) mentions using /etc/dhcp/resolv.conf as well as\n/etc/ppp/resolv.conf.\n2. On the greater Internet you can easily find plenty of examples of\npeople getting confused because /etc/resolv.conf does not reflect what\nusepeerdns has written to the wrong file in /etc/ppp/\n3. usepeerdns is not enable by default.\n\n> People who currently have ppp as their only\n> interface, or who never have ppp and ethernet running at the same time\n\nSo it's a regression for what I can only assume must be a tiny\nminority of system builders who don't configure their own systems and\nare powerless but to rely on a second-guessed set of defaults that you\nwould like to support.\n\nAdditionally, the current pppd.mk suggests /etc/ppp/resolv.conf is not\nwriteable (in some configurations) but you say adding an ip-up script\nwould solve the issue, when that ip-up script is then supposed to\nwrite to /etc/resolv.conf, which supposedly *is* writeable.\n\nPlease enlighten me.\n\n\nKind regards,\n jer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=airfi-aero.20150623.gappssmtp.com\n\theader.i=@airfi-aero.20150623.gappssmtp.com\n\theader.b=\"07kIVW5x\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrL7z57zLz9s81\n\tfor ;\n\tMon, 11 Sep 2017 18:05:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EAFAC2C2F9;\n\tMon, 11 Sep 2017 08:05:12 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aRUM6mN61cTh; Mon, 11 Sep 2017 08:05:11 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E8FD12C3A0;\n\tMon, 11 Sep 2017 08:05:10 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 321D41C0412\n\tfor ;\n\tMon, 11 Sep 2017 08:05:09 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2B4DF2C3A0\n\tfor ;\n\tMon, 11 Sep 2017 08:05:09 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 71x7Sk1vdcYb for ;\n\tMon, 11 Sep 2017 08:05:07 +0000 (UTC)","from mail-it0-f47.google.com (mail-it0-f47.google.com\n\t[209.85.214.47])\n\tby silver.osuosl.org (Postfix) with ESMTPS id B785D2C2F9\n\tfor ; Mon, 11 Sep 2017 08:05:07 +0000 (UTC)","by mail-it0-f47.google.com with SMTP id v19so12428874ite.0\n\tfor ; Mon, 11 Sep 2017 01:05:07 -0700 (PDT)","by 10.107.15.153 with HTTP; Mon, 11 Sep 2017 00:58:21 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"delayed 00:06:44 by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=airfi-aero.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=MxafnPJTvPedwYDVpJQC1eUb0t8n2NfPWeKoUmnZxXk=;\n\tb=07kIVW5xuKFQcAmXw0Il1c3dXdk0bNowGWrOUjg9cfKvgHflKBhj7LdFW82myde2VH\n\t7CaZse1JL14c6vG+t7ecVX5rmHYR2nlk3L/unfXdTItWB0YVwmQLNU0/TRkpUJr3RAqL\n\trCisx9Ygzkk/tJo2VGN2dYjF9cszRPBGWJGedhncNDU73YOodaoz9YGVZsmySuZrm2dC\n\tbZYuo2PJN1vrMFDhB42ks9h4UkWF70Byq8JmmHEMsEnohiqEb8kQcXSAnygtK08FLIig\n\tHqXePzuObq5LIrfSCkQOpOYpubTOxW8gty/m8ArxLTDS1WI9i6V0zyr6K2dmQwNcOKuz\n\tRj7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=MxafnPJTvPedwYDVpJQC1eUb0t8n2NfPWeKoUmnZxXk=;\n\tb=W2iiFVAl0il+Wk90jJHl50aiU7OW+4LuizK4S+CMfXFSJKvhIK15FJKarzgGB2HGX5\n\tNcXPifkiobnCr5eESogPbTbVX3H/RTplp8K6ikLN9xT90Y34VgK5VKavvdkKsWeMiwM4\n\tQ7kwxfmP43p/OlUoHp376ftE7fM6bcMFcJhp6nrVwTzvCW1qikxqfOF3JjUKRXTKpbPx\n\tckw3OdTRpulDft4F20vrNo81/Brh4El+8W0+OKt2Dn57iYs/wjIExF6t9V4xoEp4i2x3\n\tSQ6p5/p6ceGqivEBJ4aoajTa8uhlepstx5uhdqwSPbFnhDGDoUA9BYqGAhjS3AXNsW7G\n\t+vOg==","X-Gm-Message-State":"AHPjjUjyFLB50LReHAdbXiXLtKc746sTqk7IVt77gtMeo/hLuD7HVH8S\n\td4GsB9qAlvpOEVskNcQUwb3PIeFyu1M5","X-Google-Smtp-Source":"ADKCNb5Bggmho2qrR+7G3ShAIV+Yw6r5yF/MrDDGP8ifOygLd07I/N3b5EjaaqbnD9eu0EXgPsvigchgvpWsm2fpr0g=","X-Received":"by 10.36.127.146 with SMTP id r140mr11184339itc.79.1505116702398;\n\tMon, 11 Sep 2017 00:58:22 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<140e8e93-df14-fea5-ada5-4e1aa4636f94@mind.be>","References":"<20170828155604.24229-1-jer@airfi.aero>\n\t<140e8e93-df14-fea5-ada5-4e1aa4636f94@mind.be>","From":"Jeroen Roovers ","Date":"Mon, 11 Sep 2017 09:58:21 +0200","Message-ID":"","To":"Arnout Vandecappelle ","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] pppd: Do not overwrite /etc/resolv.conf","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1766619,"web_url":"http://patchwork.ozlabs.org/comment/1766619/","msgid":"<22237e85-c99b-1000-a339-c8e13e776443@mind.be>","list_archive_url":null,"date":"2017-09-11T23:04:44","subject":"Re: [Buildroot] [PATCH] pppd: Do not overwrite /etc/resolv.conf","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 11-09-17 09:58, Jeroen Roovers wrote:\n> On 28 August 2017 at 22:28, Arnout Vandecappelle wrote:\n> \n>>> pppd will overwrite any existing entries when /etc/resolv.conf is used instead, which is\n>>> bad.\n>>\n>> I agree that this is bad.\n> \n> Thanks.\n> \n>> However, this is a regression.\n> \n> 1. dnsmasq(8) mentions using /etc/dhcp/resolv.conf as well as\n> /etc/ppp/resolv.conf.\n> 2. On the greater Internet you can easily find plenty of examples of\n> people getting confused because /etc/resolv.conf does not reflect what\n> usepeerdns has written to the wrong file in /etc/ppp/\n> 3. usepeerdns is not enable by default.\n> \n>> People who currently have ppp as their only\n>> interface, or who never have ppp and ethernet running at the same time\n> \n> So it's a regression for what I can only assume must be a tiny\n> minority of system builders who don't configure their own systems and\n> are powerless but to rely on a second-guessed set of defaults that you\n> would like to support.\n\n My point is: people who currently use pppd and another network interface\nsimultaneously either have something that doesn't really work (unlikely) or have\nfixed it locally (more likely). However, people who currently have a working\nppp-only setup would no longer have a working setup after updating Buildroot.\nThat's something we prefer to avoid.\n\n If there is no way to avoid breaking existing configs, we probably indeed\nshould still accept this patch because as you say, it does fix things for a\n(probably) more common use case. Well, except it doesn't really fix things,\nbecause you still need an additional script to actually use the DNS information.\n\n Your point 1. is interesting. It suggests that a better solution would be to\nnot change pathnames.h at all, but instead symlink /etc/ppp/resolv.conf to\neither /etc/resolv.conf (keeping the current behaviour) or /tmp/ppp-resolv.conf\n(providing the behaviour you want).\n\n\n We recently added a \"Migrating\" section in the Buildroot manual. So what we\ncould do is:\n1. ln -s ../../tmp/ppp-resolv.conf $(TARGET_DIR)/etc/ppp/resolv.conf\n2. Add a paragraph to the Migrating section explaining that a configuration that\nwas using pppd with usepeerdns needs to either enable dnsmasq or to symlink\n$(TARGET_DIR)/etc/ppp/resolv.conf to /tmp/resolv.conf or to create a\n/etc/ppp/ip-up script.\n\n Does that sound reasonable?\n\n\n> \n> Additionally, the current pppd.mk suggests /etc/ppp/resolv.conf is not\n> writeable (in some configurations) but you say adding an ip-up script\n> would solve the issue, when that ip-up script is then supposed to\n> write to /etc/resolv.conf, which supposedly *is* writeable.\n\n Indeed, /etc/resolv.conf is a symlink to /tmp/resolv.conf.\n\n\n Regards,\n Arnout\n\n> \n> Please enlighten me.\n> \n> \n> Kind regards,\n> jer\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrk6j1Rjmz9s7B\n\tfor ;\n\tTue, 12 Sep 2017 09:05:32 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7090A86C5F;\n\tMon, 11 Sep 2017 23:05:29 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id r1SY2TgfNdnC; Mon, 11 Sep 2017 23:05:27 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F139686C18;\n\tMon, 11 Sep 2017 23:05:26 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3A50F1C25D4\n\tfor ;\n\tMon, 11 Sep 2017 23:05:25 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 34B6288B72\n\tfor ;\n\tMon, 11 Sep 2017 23:05:25 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YNBRVMjAgL-T for ;\n\tMon, 11 Sep 2017 23:05:24 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AFA7A88B22\n\tfor ; Mon, 11 Sep 2017 23:05:23 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tTue, 12 Sep 2017 01:04:46 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Jeroen Roovers ","References":"<20170828155604.24229-1-jer@airfi.aero>\n\t<140e8e93-df14-fea5-ada5-4e1aa4636f94@mind.be>\n\t","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"<22237e85-c99b-1000-a339-c8e13e776443@mind.be>","Date":"Tue, 12 Sep 2017 01:04:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] pppd: Do not overwrite /etc/resolv.conf","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1791940,"web_url":"http://patchwork.ozlabs.org/comment/1791940/","msgid":"<4c77149b-69f6-4301-4a25-1baf3a384c71@mind.be>","list_archive_url":null,"date":"2017-10-21T15:08:24","subject":"Re: [Buildroot] [PATCH] pppd: Do not overwrite /etc/resolv.conf","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"Hi Jeroen,\n\nOn 12-09-17 01:04, Arnout Vandecappelle wrote:\n> \n> \n> On 11-09-17 09:58, Jeroen Roovers wrote:\n>> On 28 August 2017 at 22:28, Arnout Vandecappelle wrote:\n> My point is: people who currently use pppd and another network interface\n> simultaneously either have something that doesn't really work (unlikely) or have\n> fixed it locally (more likely). However, people who currently have a working\n> ppp-only setup would no longer have a working setup after updating Buildroot.\n> That's something we prefer to avoid.\n> \n> If there is no way to avoid breaking existing configs, we probably indeed\n> should still accept this patch because as you say, it does fix things for a\n> (probably) more common use case. Well, except it doesn't really fix things,\n> because you still need an additional script to actually use the DNS information.\n> \n> Your point 1. is interesting. It suggests that a better solution would be to\n> not change pathnames.h at all, but instead symlink /etc/ppp/resolv.conf to\n> either /etc/resolv.conf (keeping the current behaviour) or /tmp/ppp-resolv.conf\n> (providing the behaviour you want).\n> \n> \n> We recently added a \"Migrating\" section in the Buildroot manual. So what we\n> could do is:\n> 1. ln -s ../../tmp/ppp-resolv.conf $(TARGET_DIR)/etc/ppp/resolv.conf\n> 2. Add a paragraph to the Migrating section explaining that a configuration that\n> was using pppd with usepeerdns needs to either enable dnsmasq or to symlink\n> $(TARGET_DIR)/etc/ppp/resolv.conf to /tmp/resolv.conf or to create a\n> /etc/ppp/ip-up script.\n> \n> Does that sound reasonable?\n\n I imagine that my proposed solution is way too complicated. So instead, I\napplied the patch from Maksim Salau [1]. It is also very simple, like yours, but\nin addition it keeps backward compatibility.\n\n A more extended solution can still be added in the future.\n\n Regards,\n Arnout\n\n\n[1] http://patchwork.ozlabs.org/patch/826889/","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yK5fC18gzz9sRn\n\tfor ;\n\tSun, 22 Oct 2017 02:08:50 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7059B89423;\n\tSat, 21 Oct 2017 15:08:45 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2iwIb1DAVoEj; Sat, 21 Oct 2017 15:08:43 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D00CB88F48;\n\tSat, 21 Oct 2017 15:08:42 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7F7A11C2D4B\n\tfor ;\n\tSat, 21 Oct 2017 15:08:41 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6AB9988847\n\tfor ;\n\tSat, 21 Oct 2017 15:08:41 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4LjCqhxOFPtR for ;\n\tSat, 21 Oct 2017 15:08:40 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C0D2789856\n\tfor ; Sat, 21 Oct 2017 15:08:39 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tSat, 21 Oct 2017 17:08:26 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Jeroen Roovers ","References":"<20170828155604.24229-1-jer@airfi.aero>\n\t<140e8e93-df14-fea5-ada5-4e1aa4636f94@mind.be>\n\t\n\t<22237e85-c99b-1000-a339-c8e13e776443@mind.be>","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"<4c77149b-69f6-4301-4a25-1baf3a384c71@mind.be>","Date":"Sat, 21 Oct 2017 17:08:24 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<22237e85-c99b-1000-a339-c8e13e776443@mind.be>","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] pppd: Do not overwrite /etc/resolv.conf","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]