[{"id":1768642,"web_url":"http://patchwork.ozlabs.org/comment/1768642/","msgid":"<20170914144744.GA1132@bill-the-cat>","list_archive_url":null,"date":"2017-09-14T14:47:44","subject":"Re: [U-Boot] lib: disable hashtable and display options code in SPL","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Mon, Aug 28, 2017 at 05:53:08PM +0200, Anatolij Gustschin wrote:\n\n> We do not need hashtable code in SPL when building\n> without environment support. Also display options\n> code is not used in current SPL configuration and\n> can be disabled.\n> \n> Signed-off-by: Anatolij Gustschin \n> ---\n> lib/Makefile | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n\nThis and https://patchwork.ozlabs.org/patch/806646/ don't give you what\nyou want I think. First, take a look at\nhttps://gist.github.com/trini/fb85b11f6337ea9d5d65736762c678ac as these\npatches break a number of platforms (there are SPL cases where we do\nneed these). And with gcc-6.x and later (which is being required with\nv2018.01, which is really soon now), we finally have strings discarded\nalong with functions, so there's no size savings being seen in almost\nevery case (it would be interesting to see what the savings is in\nCyprus* and those few arm cases where we do save a tiny bit of text).\n\nIn sum, I don't think we want either of these patches, even with the\nlink errors fixed unless you can show some size savings with gcc-6 or\nlater. But those cases in the above gist were size is reduced could\nhint at places to look for a different set of changes to make here,\nperhaps. Thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"dl4azW8r\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtLxJ33hTz9s0Z\n\tfor ;\n\tFri, 15 Sep 2017 00:48:03 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A4929C21D7A; Thu, 14 Sep 2017 14:47:54 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 08B97C21C5D;\n\tThu, 14 Sep 2017 14:47:50 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 514FAC21C5C; Thu, 14 Sep 2017 14:47:49 +0000 (UTC)","from mail-yw0-f180.google.com (mail-yw0-f180.google.com\n\t[209.85.161.180])\n\tby lists.denx.de (Postfix) with ESMTPS id C1DBFC21C57\n\tfor ; Thu, 14 Sep 2017 14:47:46 +0000 (UTC)","by mail-yw0-f180.google.com with SMTP id r85so6710026ywg.1\n\tfor ; Thu, 14 Sep 2017 07:47:46 -0700 (PDT)","from bill-the-cat ([2606:a000:140b:dc:d5bb:7ea9:8de7:8926])\n\tby smtp.gmail.com with ESMTPSA id\n\tg10sm5734336ywl.54.2017.09.14.07.47.44\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 14 Sep 2017 07:47:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=aI+6mOMhEmNdm+MBUpNDhEyTi1sV6KwdhkA1hEuImBE=;\n\tb=dl4azW8rL72mHTeXHXLubzwp1iDzm9ZiSm2g05qE+gCj446G3y1lJpsRWgP3DvmNxd\n\tlCshcxJoLHrTkErUKOIW1FfwNUeD99vpI1abinmJg0KEhN4jWt31FKoiz5i56Gs5Wx4O\n\tAQy246qmvHG9J4HbcuZQtbsAC1JRoKZfweSto=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=aI+6mOMhEmNdm+MBUpNDhEyTi1sV6KwdhkA1hEuImBE=;\n\tb=Cyjrx1hfwbXRhaeee8l0f7HTu7C9rUA7wc5RE54cMA/bfltYGcDNtdJeextpts3JrZ\n\tdYclGdHS98iyKaTQmsEDbEOWDGPmBJR57UlRGzrrB3j9E7/dbmlJZ7UpVhrZE0Yssbul\n\ttB7ZWIDK5dyzQyPts5oAeSGmKycqmSLkDbHeOz+gKqc3QqNRLzm7hkrk2z7gtfTldj2o\n\tHxe66a8hnNVK/oApTPNsbcVdeTbnB6NiyGT9kS/7XUsWQTqLLchbI9GNa8iC+0gIAAYo\n\tRgWguARCgSCrwBTj4GQaLTYgKiJWItF+d3InD03EMKkpqMmmagkiEwCvDQ0qQyHYg+rr\n\tvvbw==","X-Gm-Message-State":"AHPjjUgGkQHGcPybhVfhUegNtISTGSP0LVDAGA2Bewosm7SpykMbkjQx\n\twH9lH250Dj3WnUV2","X-Google-Smtp-Source":"ADKCNb44a0XwH9Rf54HEi0R5vW5WH0WMkUiR6aK0diFkpGixDq69ImcvTi65epBMdkqMwr7PvMXfHw==","X-Received":"by 10.13.216.80 with SMTP id a77mr18600488ywe.83.1505400465400; \n\tThu, 14 Sep 2017 07:47:45 -0700 (PDT)","Date":"Thu, 14 Sep 2017 10:47:44 -0400","From":"Tom Rini ","To":"Anatolij Gustschin ","Message-ID":"<20170914144744.GA1132@bill-the-cat>","References":"<1503935588-28721-1-git-send-email-agust@denx.de>","MIME-Version":"1.0","In-Reply-To":"<1503935588-28721-1-git-send-email-agust@denx.de>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] lib: disable hashtable and display options code in SPL","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============8046973475767980956==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]