[{"id":1828149,"web_url":"http://patchwork.ozlabs.org/comment/1828149/","msgid":"<436459cc-2430-d23d-ed85-7b8f1de67651@redhat.com>","list_archive_url":null,"date":"2017-12-22T19:30:00","subject":"Re: [RFC PATCH] Don't install libio.h or _G_config.h.","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 08/28/2017 04:06 PM, Zack Weinberg wrote:\n> It passes the testsuite on x86_64-linux, but it needs a great deal of\n> additional testing; in particular I'm almost certain I broke the\n> support for old-format (GLIBC_2.0) struct _IO_FILE, which is\n> configured out on this target. Testing this properly would require\n> someone to get their hands on_really_ old binaries, compiled against\n> glibc 2.0, possibly statically-linked-but-using-NSS. Unfortunately,\n> libc.so cannot be expected to be binary identical.\n\nelf/tst-audit1 and others break on i386. Usually, this is due to \ndlmopen/stdio sync issues, but in this case, it might be caused by a \n_IO_stdin_used mismatch. For some reason, I don't have debuginfo for \nthe inner libc, so this is rather difficult to diagnose. I won't be \nable to fix this before the freeze, I'm afraid.\n\nI think we should unify the libio locking first across glibc (aka get \nrid of _IO_MTSAFE_IO). This will reduce the size of the patch a bit.\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-88550-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Pzo+I04u\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z3JWh0FfNz9s7n\n\tfor ;\n\tSat, 23 Dec 2017 06:30:37 +1100 (AEDT)","(qmail 120395 invoked by alias); 22 Dec 2017 19:30:28 -0000","(qmail 120199 invoked by uid 89); 22 Dec 2017 19:30:15 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:cc:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=Kjioe7omXixCazB6\n\tuNPKdbI332DUKmdwK/TB9tnse625hJAY9dh2r5Ied2WdKzzGh1WRkB6KgdSQbdIe\n\tlvnV8816B9RRhK+E98Nc2Bio+Mu/p5MPUXiImQ2t+qog+ElKV5wuZXuGdRQEajF8\n\tBVx1C+fayPxS1esCotzXkkBwWPo=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:cc:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=Z2VUQUoQJNCeNlBNGjiHv4\n\tx0xME=; b=Pzo+I04ukC3blVlmqxFSGCvQ15j7aNdjD0F5Q7axzlXi7YVZChJONt\n\tIb3OCAjTEwsef2OQj0yqB3rc8wtC/TsUJ1KmMUmU75HoF7RxfmHvOYqc+ARJgedV\n\tmUNWMJmHVtof4/ANLlPcLCvjweC5Zl9TDHF+nCIlFSHtGZ7nqX1dM=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tSPF_HELO_PASS,\n\tT_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=glibc_20,\n\tglibc_2.0, hands","X-HELO":"mx1.redhat.com","Subject":"Re: [RFC PATCH] Don't install libio.h or _G_config.h.","To":"Zack Weinberg ","References":"<20170828140613.29221-1-zackw@panix.com>","From":"Florian Weimer ","Cc":"libc-alpha@sourceware.org","Message-ID":"<436459cc-2430-d23d-ed85-7b8f1de67651@redhat.com>","Date":"Fri, 22 Dec 2017 20:30:00 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.5.0","MIME-Version":"1.0","In-Reply-To":"<20170828140613.29221-1-zackw@panix.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}},{"id":1828256,"web_url":"http://patchwork.ozlabs.org/comment/1828256/","msgid":"","list_archive_url":null,"date":"2017-12-23T05:20:05","subject":"Re: [RFC PATCH] Don't install libio.h or _G_config.h.","submitter":{"id":65878,"url":"http://patchwork.ozlabs.org/api/people/65878/","name":"Zack Weinberg","email":"zackw@panix.com"},"content":"On Fri, Dec 22, 2017 at 11:30 AM, Florian Weimer wrote:\n> On 08/28/2017 04:06 PM, Zack Weinberg wrote:\n>>\n>> It passes the testsuite on x86_64-linux, but it needs a great deal of\n>> additional testing; in particular I'm almost certain I broke the\n>> support for old-format (GLIBC_2.0) struct _IO_FILE, which is\n>> configured out on this target. Testing this properly would require\n>> someone to get their hands on_really_ old binaries, compiled against\n>> glibc 2.0, possibly statically-linked-but-using-NSS. Unfortunately,\n>> libc.so cannot be expected to be binary identical.\n>\n>\n> elf/tst-audit1 and others break on i386. Usually, this is due to\n> dlmopen/stdio sync issues, but in this case, it might be caused by a\n> _IO_stdin_used mismatch. For some reason, I don't have debuginfo for the\n> inner libc, so this is rather difficult to diagnose. I won't be able to fix\n> this before the freeze, I'm afraid.\n\nUnderstood. Thanks for trying.\n\n> I think we should unify the libio locking first across glibc (aka get rid of\n> _IO_MTSAFE_IO). This will reduce the size of the patch a bit.\n\nThat makes sense. For 2.27, I suggest we make the installed libio.h\nand _G_config.h issue deprecation warnings. I'll send a patch for\nthat under separate cover.\n\nzw","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-88568-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"M2mG6zx8\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3z3YgV6dfvz9s0g\n\tfor ;\n\tSat, 23 Dec 2017 16:23:18 +1100 (AEDT)","(qmail 60590 invoked by alias); 23 Dec 2017 05:23:09 -0000","(qmail 43183 invoked by uid 89); 23 Dec 2017 05:22:18 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=P5BY\n\tUdlVttwIwYJz9tS/LyIuuXXDyWyV7B4tvmdgcI5WxxCDe0xhSUYTmGwmkR1fmbdZ\n\tfC3GC1gcfZPjGvBnW+xiVHF89tit9DSybnqs63cVuAJiS0tVQLG3NgAxFKjU8kph\n\tEow76vQzfxt2LiuEotdi2+ndaihbnroDmRbY1Ck=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=WkiwWGcNMq\n\tFMHBIwez3DTQnV5jo=; b=M2mG6zx84maTgLdc5IZWAbtBB51jJa8LTCZuMD/vpJ\n\thkZpw0dgDHUbGQQSxFbVEG2ffAQ8J/G8Rxm0+HO+QfN2llRgimefmNW4Pxh+Rnmb\n\tlVJMDkDdGtIlEltsbGG9nPoKWmqqSCh2AihGWCGf3oFpci7LJD9r/PJx3R/DQ+IX\n\tE=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=AWL, BAYES_00,\n\tSPF_PASS,\n\tT_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=hands","X-HELO":"mailbackend.panix.com","X-Gm-Message-State":"AKGB3mIKjKZvB6SAcrgSAFjY1RlKfW+uQ26+tGQBA4Sl1gcmmS44eTL2\n\thGhEdswTxT7ZZe+tKss36FTHAUYpCSJtzVr76fA=","X-Google-Smtp-Source":"ACJfBosKtK4VVcdukCNmq5EBm8EvNZVjga1b/Gr1xqidY1ZikyM9alXBko05T2bXSp+rSotHQqxmTd5obUkOzikZQHY=","X-Received":"by 10.202.190.139 with SMTP id o133mr489137oif.38.1514006406176; \n\tFri, 22 Dec 2017 21:20:06 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<436459cc-2430-d23d-ed85-7b8f1de67651@redhat.com>","References":"<20170828140613.29221-1-zackw@panix.com>\n\t<436459cc-2430-d23d-ed85-7b8f1de67651@redhat.com>","From":"Zack Weinberg ","Date":"Fri, 22 Dec 2017 21:20:05 -0800","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [RFC PATCH] Don't install libio.h or _G_config.h.","To":"Florian Weimer ","Cc":"GNU C Library ","Content-Type":"text/plain; charset=\"UTF-8\""}}]