[{"id":1788516,"web_url":"http://patchwork.ozlabs.org/comment/1788516/","msgid":"<099bf486-4830-4d19-eb88-bf05d4d6994f@baylibre.com>","list_archive_url":null,"date":"2017-10-17T15:03:48","subject":"Re: [PATCH] mtd: spi-nor: Add support for Winbond w25q16dw","submitter":{"id":67289,"url":"http://patchwork.ozlabs.org/api/people/67289/","name":"Neil Armstrong","email":"narmstrong@baylibre.com"},"content":"On 28/08/2017 15:11, Neil Armstrong wrote:\n> Add JEDEC entry for the Winbond w25q16fw/w25q16dw with similar\n> flags and format than the Winbond w25q32dw entry.\n> \n> Tested on a Khadas VIM2 SBC board with an Amlogic S912 SoC.\n> \n> Signed-off-by: Neil Armstrong \n> ---\n> drivers/mtd/spi-nor/spi-nor.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c\n> index cf1d4a1..2f74583 100644\n> --- a/drivers/mtd/spi-nor/spi-nor.c\n> +++ b/drivers/mtd/spi-nor/spi-nor.c\n> @@ -1137,6 +1137,11 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)\n> \t{ \"w25x40\", INFO(0xef3013, 0, 64 * 1024, 8, SECT_4K) },\n> \t{ \"w25x80\", INFO(0xef3014, 0, 64 * 1024, 16, SECT_4K) },\n> \t{ \"w25x16\", INFO(0xef3015, 0, 64 * 1024, 32, SECT_4K) },\n> +\t{\n> +\t\t\"w25q16dw\", INFO(0xef6015, 0, 64 * 1024, 32,\n> +\t\t\tSECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |\n> +\t\t\tSPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)\n> +\t},\n> \t{ \"w25x32\", INFO(0xef3016, 0, 64 * 1024, 64, SECT_4K) },\n> \t{ \"w25q20cl\", INFO(0xef4012, 0, 64 * 1024, 4, SECT_4K) },\n> \t{ \"w25q20bw\", INFO(0xef5012, 0, 64 * 1024, 4, SECT_4K) },\n> \n\nHi Cyrille,\n\nDid you had time to review this patch ?\n\nThanks,\nNeil","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"X0AW1BJ4\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=baylibre-com.20150623.gappssmtp.com\n\theader.i=@baylibre-com.20150623.gappssmtp.com\n\theader.b=\"SN/sAAD/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yGdlg3jklz9sP1\n\tfor ;\n\tWed, 18 Oct 2017 02:05:03 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e4TQ8-00057z-E7; Tue, 17 Oct 2017 15:04:40 +0000","from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e4TPg-0004sZ-7S\n\tfor linux-mtd@lists.infradead.org; Tue, 17 Oct 2017 15:04:16 +0000","by mail-wr0-x235.google.com with SMTP id q42so2027815wrb.7\n\tfor ;\n\tTue, 17 Oct 2017 08:03:51 -0700 (PDT)","from [192.168.1.29] ([90.63.244.31])\n\tby smtp.gmail.com with ESMTPSA id\n\te77sm15329633wmi.16.2017.10.17.08.03.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 17 Oct 2017 08:03:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=XRPO/IbXvuM+EbbwhoQ8sXakszUS5uY6oj65hq3Mrqg=;\n\tb=X0AW1BJ4C2dW6z\n\tYZXgH1q0w+zCrMM7hs6Aspbxqg4T1udQPlMWLS2kiMfq5KqKSfmkOwZckMU0trWqiU8OkA25tNlco\n\ti/qPNjj9RJPHlsoWUGl3n3IUHRP7QmFu8SuIb8c4ZAlUPSAqPPV6sH+RpQDLkzTcyIUHlfurWsF7V\n\tZQm67wwClCMVryNOeWpT5VsDJ4zpY9Z1Wpbv2sbT6GPpwz31TaNnR4XnScwqvcKI5zaDOtebpLGbz\n\tfY+P02ZTpGiQmgPqm66musNNHryscYNr/0jqBHmd7NuN2TMnsKHu25TKhuEKj7lxjWNaJ9l4wrq1G\n\tHS/JqKzUH7f5ba91cgpw==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:organization:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=M2rXfcC0Oj/dY7ApCcMbzUgucl+AHqa9z9C7J7FrAxE=;\n\tb=SN/sAAD/i3CROzkg55k0ABVzPkvO/4cSeMusgeqyIQ2nniM+webq7NZLqTF9vz36QI\n\tTudollMCeyqHjWwqtNiOI0FUHIz/A3+kLUiywGvvIsSgnqD6FS0C0+d0lu2fbNGgpvEX\n\tlnjVVPu72UXfm1nyQrBDDI20h8Iygsm+xNh9AaIzLNHhFjKF3RANkI+hlit2oi67I+gl\n\tGe0foQlPmf5JgsK6Hlg2KjXp2CHa/nb6+IuMHPelCwEnPMslNmGJCLcdnsQI3gSrwkzp\n\teseEJH6g2Fs/DzV7NRzP2grrgImQH7ufDE7L8jyutO53QU7c8pXpjTEMgdD2CIsDo/Dy\n\tqs/A=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=M2rXfcC0Oj/dY7ApCcMbzUgucl+AHqa9z9C7J7FrAxE=;\n\tb=YJUZZC4eYM5MKSEi0uh3iD2uq2QIsfGLm6uU1XYmbxwPKCznWwHq5+xSArhIugfJoT\n\tu3YZeghD+vL/hDAfaWomvdKBOrzho3FYEUggSzfnkliRr83HGpzqL5bW8DLJ3wj5wkX9\n\td30uRqEyOQZNTlWlkWcrjQuqX8kg3PyVn9bDPFdbAipuv65z7HFIQNY/WyJfR3U42uxr\n\tcxzsIcQNZE31o98z5a+EZjOYg7V/V2Hwg9kFnQeb167i3Ygep4pDomAv/GpobeqN3mS9\n\tmR52w8Cf9bzpsYHUcAUTQuTCHRPfMsiUXCC3qoBy6oMShV2UqaOzsEHCHoXuLyqvctE6\n\tOFcw==","X-Gm-Message-State":"AMCzsaUraNNZV/lKR2HkECJdUaMfOC1Ptu2m9ObYGh3z6+IBqJkp7qZU\n\tj+i6XPqlRyxu/RZ3deVHfGfe7w==","X-Google-Smtp-Source":"ABhQp+TbGBq0g+lUNYSlOSwJmG+T4nZ5oM+zS3rmDLHXA8H2LbVsSod67GqxhLbqIPoLBC3qpbq4qw==","X-Received":"by 10.223.136.170 with SMTP id f39mr3545668wrf.162.1508252630009;\n\tTue, 17 Oct 2017 08:03:50 -0700 (PDT)","Subject":"Re: [PATCH] mtd: spi-nor: Add support for Winbond w25q16dw","To":"cyrille.pitchen@wedev4u.fr, marek.vasut@gmail.com","References":"<1503925893-17116-1-git-send-email-narmstrong@baylibre.com>","From":"Neil Armstrong ","Organization":"Baylibre","Message-ID":"<099bf486-4830-4d19-eb88-bf05d4d6994f@baylibre.com>","Date":"Tue, 17 Oct 2017 17:03:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<1503925893-17116-1-git-send-email-narmstrong@baylibre.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171017_080412_523976_4FF6BB7B ","X-CRM114-Status":"GOOD ( 12.23 )","X-Spam-Score":"-1.2 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:235 listed in] [list.dnswl.org]\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1792390,"web_url":"http://patchwork.ozlabs.org/comment/1792390/","msgid":"<5bd1d86b-8b2c-a1ca-b5b5-9175569ffb36@wedev4u.fr>","list_archive_url":null,"date":"2017-10-23T07:54:34","subject":"Re: [PATCH] mtd: spi-nor: Add support for Winbond w25q16dw","submitter":{"id":70551,"url":"http://patchwork.ozlabs.org/api/people/70551/","name":"Cyrille Pitchen","email":"cyrille.pitchen@wedev4u.fr"},"content":"Le 28/08/2017 à 15:11, Neil Armstrong a écrit :\n> Add JEDEC entry for the Winbond w25q16fw/w25q16dw with similar\n> flags and format than the Winbond w25q32dw entry.\n> \n> Tested on a Khadas VIM2 SBC board with an Amlogic S912 SoC.\n> \n> Signed-off-by: Neil Armstrong \n\nApplied to the spi-nor/next branch of l2-mtd\n\nThanks!\n> ---\n> drivers/mtd/spi-nor/spi-nor.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c\n> index cf1d4a1..2f74583 100644\n> --- a/drivers/mtd/spi-nor/spi-nor.c\n> +++ b/drivers/mtd/spi-nor/spi-nor.c\n> @@ -1137,6 +1137,11 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)\n> \t{ \"w25x40\", INFO(0xef3013, 0, 64 * 1024, 8, SECT_4K) },\n> \t{ \"w25x80\", INFO(0xef3014, 0, 64 * 1024, 16, SECT_4K) },\n> \t{ \"w25x16\", INFO(0xef3015, 0, 64 * 1024, 32, SECT_4K) },\n> +\t{\n> +\t\t\"w25q16dw\", INFO(0xef6015, 0, 64 * 1024, 32,\n> +\t\t\tSECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |\n> +\t\t\tSPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)\n> +\t},\n> \t{ \"w25x32\", INFO(0xef3016, 0, 64 * 1024, 64, SECT_4K) },\n> \t{ \"w25q20cl\", INFO(0xef4012, 0, 64 * 1024, 4, SECT_4K) },\n> \t{ \"w25q20bw\", INFO(0xef5012, 0, 64 * 1024, 4, SECT_4K) },\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"XLg6iN/U\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yL7xr47Bbz9s7c\n\tfor ;\n\tMon, 23 Oct 2017 18:56:00 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e6Xa7-0006Qx-UN; Mon, 23 Oct 2017 07:55:31 +0000","from smtp3-g21.free.fr ([2a01:e0c:1:1599::12])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e6XZl-00050n-P4\n\tfor linux-mtd@lists.infradead.org; Mon, 23 Oct 2017 07:55:12 +0000","from mountainer.wedev4u.int (unknown [82.232.94.13])\n\tby smtp3-g21.free.fr (Postfix) with ESMTP id DCDC513F8B5;\n\tMon, 23 Oct 2017 09:54:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=aWoWEcbe+hMlReuinqKcRi/J7THdN2eVQMT3WI4VyYc=;\n\tb=XLg6iN/U1m7tmH\n\tR22PT1UnZZqyNzUV+jOnvPvvHBww0CESTl1pNERlpYdJs0RxAyo2kooWysj53CW2WP9vnD46GGSme\n\tE1kxrRc5ntcp7LBLd3OptlXx32jmG376CXgcUk4VdwOgG1LSajZVOZpGSmy9lIOpIBQ3dJEy83PMy\n\tT++xAxD16krMcUIrjdbiJuCkudZ89ouiKUF4t4hkNtVnr2nAL7uOMgjuPN5eJ/H0MckHDrwd8zzu/\n\taSQK8cT/zCvvyMnAjGHOWsShn7qm66Z7bVI0uFRKLy7JkSLznvY1mZbuYlXYD84fchzm/SzHM+Baf\n\t1Wx/vk0oM095+TKikraw==;","Subject":"Re: [PATCH] mtd: spi-nor: Add support for Winbond w25q16dw","To":"Neil Armstrong , marek.vasut@gmail.com","References":"<1503925893-17116-1-git-send-email-narmstrong@baylibre.com>","From":"Cyrille Pitchen ","Message-ID":"<5bd1d86b-8b2c-a1ca-b5b5-9175569ffb36@wedev4u.fr>","Date":"Mon, 23 Oct 2017 09:54:34 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<1503925893-17116-1-git-send-email-narmstrong@baylibre.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171023_005510_009194_4B7409FF ","X-CRM114-Status":"UNSURE ( 8.75 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2a01:e0c:1:1599:0:0:0:12 listed in] [list.dnswl.org]\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]