[{"id":1758578,"web_url":"http://patchwork.ozlabs.org/comment/1758578/","msgid":"<150392599255.51.8963072091091627194@2c699d6fd5aa>","list_archive_url":null,"date":"2017-08-28T13:13:13","subject":"Re: [Qemu-devel] [PATCH v2] qemu crashes when a negative number\n\tused for 'maxcpus'","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nType: series\nSubject: [Qemu-devel] [PATCH v2] qemu crashes when a negative number used for 'maxcpus'\nMessage-id: 1503924917-12687-1-git-send-email-s1seetee@linux.vnet.ibm.com\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n * [new tag] patchew/1503924917-12687-1-git-send-email-s1seetee@linux.vnet.ibm.com -> patchew/1503924917-12687-1-git-send-email-s1seetee@linux.vnet.ibm.com\nSwitched to a new branch 'test'\nbdc7670bb2 qemu crashes when a negative number used for 'maxcpus'\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/1: qemu crashes when a negative number used for 'maxcpus'...\nERROR: code indent should never use tabs\n#39: FILE: vl.c:1248:\n+^Iif (max_cpus < 0) {$\n\nERROR: code indent should never use tabs\n#40: FILE: vl.c:1249:\n+^I^Ierror_report(\"Invalid max_cpus : %d\", max_cpus);$\n\nERROR: code indent should never use tabs\n#41: FILE: vl.c:1250:\n+^I^Iexit(1);$\n\nERROR: code indent should never use tabs\n#42: FILE: vl.c:1251:\n+^I}$\n\ntotal: 4 errors, 0 warnings, 11 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgsg66pDkz9sN5\n\tfor ;\n\tMon, 28 Aug 2017 23:14:26 +1000 (AEST)","from localhost ([::1]:39821 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmJs0-00024G-P9\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 09:14:24 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52356)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmJrW-00022d-Fy\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 09:13:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmJrQ-0007Vt-Nd\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 09:13:54 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21440)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmJrQ-0007Vc-G5\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 09:13:48 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1503925993216393.8557978335019;\n\tMon, 28 Aug 2017 06:13:13 -0700 (PDT)"],"Resent-Date":"Mon, 28 Aug 2017 09:13:54 -0400","Resent-Message-Id":"","Message-ID":"<150392599255.51.8963072091091627194@2c699d6fd5aa>","In-Reply-To":"<1503924917-12687-1-git-send-email-s1seetee@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"s1seetee@linux.vnet.ibm.com","Date":"Mon, 28 Aug 2017 06:13:13 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH v2] qemu crashes when a negative number\n\tused for 'maxcpus'","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"pbonzini@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,\n\ts1seetee@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]