[{"id":1759489,"web_url":"http://patchwork.ozlabs.org/comment/1759489/","msgid":"","list_archive_url":null,"date":"2017-08-29T15:53:14","subject":"Re: [PATCH] ira-costs: avoid missing base registers in\n\trecord_address_regs","submitter":{"id":4455,"url":"http://patchwork.ozlabs.org/api/people/4455/","name":"Vladimir Makarov","email":"vmakarov@redhat.com"},"content":"On 08/28/2017 09:06 AM, Alexander Monakov wrote:\n> Hello,\n>\n> The code in record_address_regs shown in the following patch assumes that\n> if a given target cannot have two registers in a memory address, then the\n> sole register, if present, must be the leftmost operand in the PLUS chain.\n>\n> I think this is not true if the target uses unspecs to signify special\n> addressing modes such as TLS. In that case the unspec can be to the left\n> of the register, and this function won't see the register.\n>\n> The proposed fix is to always recurse into non-constant operands like in the\n> adjacent case of index registers being the same as base registers. OK to apply?\nYes. Thank you for the patch, Alexander.\n\nAs I remember this code was adopted from the old regclass.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461100-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"yH4VBYQz\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=vmakarov@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhY8J4j6Qz9t2v\n\tfor ;\n\tWed, 30 Aug 2017 01:53:36 +1000 (AEST)","(qmail 69114 invoked by alias); 29 Aug 2017 15:53:29 -0000","(qmail 69099 invoked by uid 89); 29 Aug 2017 15:53:28 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tTue, 29 Aug 2017 15:53:18 +0000","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.16])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 3129F5D697;\n\tTue, 29 Aug 2017 15:53:17 +0000 (UTC)","from [10.10.124.213] (ovpn-124-213.rdu2.redhat.com\n\t[10.10.124.213])\tby smtp.corp.redhat.com (Postfix) with ESMTP\n\tid 808E468885; Tue, 29 Aug 2017 15:53:15 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=l47Hc2OgaUXQo70M9m5iKQcq1pngC4HuF/aprQsKqKo1aoIuRrp3n\n\tExJJHxCIN8eFVjqfRO9OTKxgaIlqfM2rnnxFI+E5J6nLD3ToE/+/AKoFssJDb+L9\n\t1bQw90WNU2pkPC78CcoXUGRaDvRYdfjxjg4sQTEIGSLorBbZk6u1gY=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=7qTH+XFgANitDqxeh6WZMePK56g=; b=yH4VBYQzExmv+5ZrPDlpGGndA3/n\n\tJpHzTqInYvXAvg/L9Qm+EY/pxm9XuZMbY040IaMJC7bqu7fRb7eQBoDrerDzAKd6\n\tYocHzZ4hGoJxRANk23PqEBvUZgBw+tH1uTkYfM7Q3dEXnxbRCox25c2x4Fdf69pV\n\tve5XEb2EknP2unw=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-6.9 required=5.0 tests=BAYES_00, GIT_PATCH_1,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3129F5D697","Subject":"Re: [PATCH] ira-costs: avoid missing base registers in\n\trecord_address_regs","To":"Alexander Monakov , gcc-patches@gcc.gnu.org","References":"","From":"Vladimir Makarov ","Message-ID":"","Date":"Tue, 29 Aug 2017 11:53:14 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:45.0) Gecko/20100101 Thunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-IsSubscribed":"yes"}}]