[{"id":1759153,"web_url":"http://patchwork.ozlabs.org/comment/1759153/","msgid":"","list_archive_url":null,"date":"2017-08-29T09:09:33","subject":"Re: [U-Boot] [PATCH 1/2] i.MX6Q: spl: Fix falcon to use\n\tdram_init_banksize","submitter":{"id":20045,"url":"http://patchwork.ozlabs.org/api/people/20045/","name":"Jagan Teki","email":"jagannadh.teki@gmail.com"},"content":"Hi Stefano,\n\nOn Mon, Aug 28, 2017 at 4:45 PM, Jagan Teki wrote:\n> From: Jagan Teki \n>\n> Memory dt node update introduced by spl_fixup_fdt() in below\n> commit was making DDR configuration in-appropriate\n> to boot falcon mode. Hence added dram_init_banksize for\n> explicit assignment of proper base and size of DDR.\n>\n> \"boot: fdt: Perform arch_fixup_fdt() on the given device tree for falcon boot\"\n> (sha1: 6e7585bb64b12f632681c80c4b193349e1985d92)\n>\n> Signed-off-by: Jagan Teki \n> ---\n> arch/arm/mach-imx/spl.c | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n>\n> diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c\n> index 75698c4..0979458 100644\n> --- a/arch/arm/mach-imx/spl.c\n> +++ b/arch/arm/mach-imx/spl.c\n> @@ -15,6 +15,8 @@\n> #include \n> #include \n>\n> +DECLARE_GLOBAL_DATA_PTR;\n> +\n> #if defined(CONFIG_MX6)\n> /* determine boot device from SRC_SBMR1 (BOOT_CFG[4:1]) or SRC_GPR9 register */\n> u32 spl_boot_device(void)\n> @@ -126,3 +128,13 @@ __weak void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image)\n> }\n>\n> #endif\n> +\n> +#if defined(CONFIG_MX6) && defined(CONFIG_SPL_OS_BOOT)\n> +int dram_init_banksize(void)\n> +{\n> + gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;\n> + gd->bd->bi_dram[0].size = imx_ddr_size();\n> +\n> + return 0;\n> +}\n> +#endif\n\nI think these should be in-tree for the release? otherwise falcon broke.\n\nthanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ptyeHghC\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhNGK1fdcz9s7c\n\tfor ;\n\tTue, 29 Aug 2017 19:13:11 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 73C23C21E36; Tue, 29 Aug 2017 09:10:41 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 02762C22094;\n\tTue, 29 Aug 2017 09:10:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 721A9C22092; Tue, 29 Aug 2017 09:09:35 +0000 (UTC)","from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66])\n\tby lists.denx.de (Postfix) with ESMTPS id BD16CC22062\n\tfor ; Tue, 29 Aug 2017 09:09:34 +0000 (UTC)","by mail-lf0-f66.google.com with SMTP id o124so1755698lfo.1\n\tfor ; Tue, 29 Aug 2017 02:09:34 -0700 (PDT)","by 10.25.222.200 with HTTP; Tue, 29 Aug 2017 02:09:33 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=DIAyJu/ReDmBS7ooq0umLu1VsCphYrsr4cS8bq6IyUk=;\n\tb=ptyeHghC6ZxoHcpv3WeEMDRwJUvAap2ZoMIWITzALSXLuwUcXI8s/h8Vdhrk48Nr1j\n\tJ1uTnEbej0tHGIMSOjEU2WXdMgrZ60tAXIY/4W+YX8KllnUXKLmDgtQXQm1tEPoC2Q0r\n\tBpLhYiV4JrkZpo7q8Coh3oF+9bZbiqYoF7R/9B6tWtQkdito3NHIkQ5iVCUL+EeMPrw+\n\tepRm3l1rcwG/0wi88rL0rUYZlFLi++UU905t22tcHsWG7IeJVwNCEV6siH9npW9k3hkJ\n\ta9Qni8hJCSM9xJ3VolOawMs6iayoLLK31uRoVai6QGS6xRXTLLJD9NnXLKJJw54Lv696\n\tjEMw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=DIAyJu/ReDmBS7ooq0umLu1VsCphYrsr4cS8bq6IyUk=;\n\tb=SIcBZwkBjUPthSsck9q9wPn0AI1Ab0CkMepkhRx8iO9pwMQXXHYnzEYPG6yEfvCp8M\n\t36RKxX+7xL6w/QrNgDjvSYHQ5mIQCWwcBzt0iYgoibUka8rNmAW7JU9MC2d6Z4cgj8h9\n\taFNOUQhjEJmX/EJz6QWcMYG9v5hd/OWNHCP97gAFMqkdDl0AsBe1dc9XDvvnbL+PboDz\n\tzUtVuI2iRtVyrqU4h9Vqy8PoInyIkwrWejFFFtAWuJFsHBaVL8HwvNldHcCfJ5Fffw0J\n\tpwqtzvFRHFW9Hm5T4Ctc2bYUsBfUZc1l13yBLiiuZ8artNu8d8h1KH1KtBnbOFx9GThY\n\tUuZw==","X-Gm-Message-State":"AHYfb5huCRUJZ1Z+8kKd1qW50j0azc2x5/UcFw4/N9Vu1mJ84cbObGZG\n\tL7e7GevfQXtPLwYsogkZoXHRveuGQw==","X-Received":"by 10.25.16.151 with SMTP id 23mr1313484lfq.182.1503997773739;\n\tTue, 29 Aug 2017 02:09:33 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503918948-1436-1-git-send-email-jteki@openedev.com>","References":"<1503918948-1436-1-git-send-email-jteki@openedev.com>","From":"Jagan Teki ","Date":"Tue, 29 Aug 2017 14:39:33 +0530","Message-ID":"","To":"\"u-boot@lists.denx.de\" ","Cc":"Tom Rini , Fabio Estevam ","Subject":"Re: [U-Boot] [PATCH 1/2] i.MX6Q: spl: Fix falcon to use\n\tdram_init_banksize","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1760021,"web_url":"http://patchwork.ozlabs.org/comment/1760021/","msgid":"<36fbfec8-30a5-4e6e-cc86-65fd90a5fbbf@denx.de>","list_archive_url":null,"date":"2017-08-30T10:15:49","subject":"Re: [U-Boot] [PATCH 1/2] i.MX6Q: spl: Fix falcon to use\n\tdram_init_banksize","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"Hi Jagan,\n\nOn 29/08/2017 11:09, Jagan Teki wrote:\n> Hi Stefano,\n> \n> On Mon, Aug 28, 2017 at 4:45 PM, Jagan Teki wrote:\n>> From: Jagan Teki \n>>\n>> Memory dt node update introduced by spl_fixup_fdt() in below\n>> commit was making DDR configuration in-appropriate\n>> to boot falcon mode. Hence added dram_init_banksize for\n>> explicit assignment of proper base and size of DDR.\n>>\n>> \"boot: fdt: Perform arch_fixup_fdt() on the given device tree for falcon boot\"\n>> (sha1: 6e7585bb64b12f632681c80c4b193349e1985d92)\n>>\n>> Signed-off-by: Jagan Teki \n>> ---\n>> arch/arm/mach-imx/spl.c | 12 ++++++++++++\n>> 1 file changed, 12 insertions(+)\n>>\n>> diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c\n>> index 75698c4..0979458 100644\n>> --- a/arch/arm/mach-imx/spl.c\n>> +++ b/arch/arm/mach-imx/spl.c\n>> @@ -15,6 +15,8 @@\n>> #include \n>> #include \n>>\n>> +DECLARE_GLOBAL_DATA_PTR;\n>> +\n>> #if defined(CONFIG_MX6)\n>> /* determine boot device from SRC_SBMR1 (BOOT_CFG[4:1]) or SRC_GPR9 register */\n>> u32 spl_boot_device(void)\n>> @@ -126,3 +128,13 @@ __weak void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image)\n>> }\n>>\n>> #endif\n>> +\n>> +#if defined(CONFIG_MX6) && defined(CONFIG_SPL_OS_BOOT)\n>> +int dram_init_banksize(void)\n>> +{\n>> + gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;\n>> + gd->bd->bi_dram[0].size = imx_ddr_size();\n>> +\n>> + return 0;\n>> +}\n>> +#endif\n> \n> I think these should be in-tree for the release? otherwise falcon broke.\n> \n\nI pick it up.\n\nRegards,\nStefano","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj1cY2XD3z9t0F\n\tfor ;\n\tWed, 30 Aug 2017 20:16:13 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1F4DFC22828; Wed, 30 Aug 2017 10:16:01 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1196FC21E43;\n\tWed, 30 Aug 2017 10:15:59 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 990E1C21E39; Wed, 30 Aug 2017 10:15:57 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 7962BC21DC4\n\tfor ; Wed, 30 Aug 2017 10:15:56 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xj1cC5QY8z1qsGq;\n\tWed, 30 Aug 2017 12:15:55 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xj1cC2g0Nz3hjJt;\n\tWed, 30 Aug 2017 12:15:55 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 7HSLdQ8-f_H7; Wed, 30 Aug 2017 12:15:53 +0200 (CEST)","from babic.homelinux.org (host-88-217-136-221.customer.m-online.net\n\t[88.217.136.221])\n\t(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tWed, 30 Aug 2017 12:15:53 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 9E7644540595;\n\tWed, 30 Aug 2017 12:15:52 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id zNLwIHWasj6J; Wed, 30 Aug 2017 12:15:50 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 77D5A4540515;\n\tWed, 30 Aug 2017 12:15:49 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"To":"Jagan Teki ,\n\t\"u-boot@lists.denx.de\" ","References":"<1503918948-1436-1-git-send-email-jteki@openedev.com>\n\t","From":"Stefano Babic ","Message-ID":"<36fbfec8-30a5-4e6e-cc86-65fd90a5fbbf@denx.de>","Date":"Wed, 30 Aug 2017 12:15:49 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"de-DE","Cc":"Tom Rini , Fabio Estevam ","Subject":"Re: [U-Boot] [PATCH 1/2] i.MX6Q: spl: Fix falcon to use\n\tdram_init_banksize","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]