[{"id":1758423,"web_url":"http://patchwork.ozlabs.org/comment/1758423/","msgid":"<20170828080810.3pcu2jyjbiawjmd7@in.ibm.com>","list_archive_url":null,"date":"2017-08-28T08:08:10","subject":"Re: [Skiboot] [PATCH v2 1/5] hdata: Fix vpd parse","submitter":{"id":69686,"url":"http://patchwork.ozlabs.org/api/people/69686/","name":"Ananth N Mavinakayanahalli","email":"ananth@linux.vnet.ibm.com"},"content":"On Mon, Aug 28, 2017 at 12:47:59PM +0530, Vasant Hegde wrote:\n> We detect vpd data format in vpd_parse() and set \"op_platform\" variable.\n> dt_add_vpd_node() depends on op_platform to select parser type.\n> \n> There are places where we call dt_add_vpd_node() even before calling\n> vpd_parse(). And in such cases it will not parse vpd data properly.\n> \n> This patch fixes above issue.\n> \n> Fixes: 694546c1 (hdata/vpd: Parse the OpenPOWER OPFR record)\n> CC: Ananth N Mavinakayanahalli \n> Signed-off-by: Vasant Hegde \n\nAcked-by: Ananth N Mavinakayanahalli ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgktH5YSQz9sPt\n\tfor ;\n\tMon, 28 Aug 2017 18:08:39 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xgktG5TtrzDq8f\n\tfor ;\n\tMon, 28 Aug 2017 18:08:38 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xgkst05r5zDq5b\n\tfor ; Mon, 28 Aug 2017 18:08:17 +1000 (AEST)","from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7S83ecZ022725\n\tfor ; Mon, 28 Aug 2017 04:08:15 -0400","from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmefpjpbr-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 28 Aug 2017 04:08:14 -0400","from localhost\n\tby e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 28 Aug 2017 02:08:13 -0600","from b03cxnp08025.gho.boulder.ibm.com (9.17.130.17)\n\tby e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 02:08:12 -0600","from b03ledav004.gho.boulder.ibm.com\n\t(b03ledav004.gho.boulder.ibm.com [9.17.130.235])\n\tby b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7S88Bux1900804; Mon, 28 Aug 2017 01:08:11 -0700","from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id BD0ED78043;\n\tMon, 28 Aug 2017 02:08:11 -0600 (MDT)","from thinktux.localdomain (unknown [9.124.35.160])\n\tby b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 807057803F;\n\tMon, 28 Aug 2017 02:08:11 -0600 (MDT)","by thinktux.localdomain (Postfix, from userid 1000)\n\tid 64B1C103A45; Mon, 28 Aug 2017 13:38:10 +0530 (IST)"],"Date":"Mon, 28 Aug 2017 13:38:10 +0530","From":"Ananth N Mavinakayanahalli ","To":"Vasant Hegde ","References":"<20170828071803.9406-1-hegdevasant@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170828071803.9406-1-hegdevasant@linux.vnet.ibm.com>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-TM-AS-GCONF":"00","x-cbid":"17082808-0024-0000-0000-0000171BF560","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007625; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000225; SDB=6.00908716; UDB=6.00455655;\n\tIPR=6.00688956; \n\tBA=6.00005555; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016895;\n\tXFM=3.00000015; UTC=2017-08-28 08:08:13","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082808-0025-0000-0000-00004C7C98A9","Message-Id":"<20170828080810.3pcu2jyjbiawjmd7@in.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708280128","Subject":"Re: [Skiboot] [PATCH v2 1/5] hdata: Fix vpd parse","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"ananth@linux.vnet.ibm.com","Cc":"skiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1762956,"web_url":"http://patchwork.ozlabs.org/comment/1762956/","msgid":"<874lshhhri.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-05T04:49:21","subject":"Re: [Skiboot] [PATCH v2 1/5] hdata: Fix vpd parse","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Vasant Hegde writes:\n> We detect vpd data format in vpd_parse() and set \"op_platform\" variable.\n> dt_add_vpd_node() depends on op_platform to select parser type.\n>\n> There are places where we call dt_add_vpd_node() even before calling\n> vpd_parse(). And in such cases it will not parse vpd data properly.\n>\n> This patch fixes above issue.\n>\n> Fixes: 694546c1 (hdata/vpd: Parse the OpenPOWER OPFR record)\n> CC: Ananth N Mavinakayanahalli \n> Signed-off-by: Vasant Hegde \n\nI've taken patches 1-3 as of c6e9156379643afc45bef776b5a69b6e46b3dad1","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmZ4y6kXDz9s83\n\tfor ;\n\tTue, 5 Sep 2017 14:49:38 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xmZ4y5QgRzDrJj\n\tfor ;\n\tTue, 5 Sep 2017 14:49:38 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xmZ4q4sNjzDqXk\n\tfor ; Tue, 5 Sep 2017 14:49:31 +1000 (AEST)","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv854n3Ij018533\n\tfor ; Tue, 5 Sep 2017 00:49:29 -0400","from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cs7mhu6bm-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 05 Sep 2017 00:49:29 -0400","from localhost\n\tby e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 4 Sep 2017 22:49:29 -0600","from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 4 Sep 2017 22:49:24 -0600","from b03ledav004.gho.boulder.ibm.com\n\t(b03ledav004.gho.boulder.ibm.com [9.17.130.235])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v854nOth2687286; Mon, 4 Sep 2017 21:49:24 -0700","from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 16F3E78038;\n\tMon, 4 Sep 2017 22:49:24 -0600 (MDT)","from birb.localdomain (unknown [9.192.255.220])\n\tby b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 67A2278057;\n\tMon, 4 Sep 2017 22:49:23 -0600 (MDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid B541E4F0CA5; Tue, 5 Sep 2017 14:49:21 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=)","From":"Stewart Smith ","To":"Vasant Hegde , skiboot@lists.ozlabs.org","In-Reply-To":"<20170828071803.9406-1-hegdevasant@linux.vnet.ibm.com>","References":"<20170828071803.9406-1-hegdevasant@linux.vnet.ibm.com>","Date":"Tue, 05 Sep 2017 14:49:21 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17090504-0024-0000-0000-000017256E01","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007669; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00912434; UDB=6.00457851;\n\tIPR=6.00692697; \n\tBA=6.00005572; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017009;\n\tXFM=3.00000015; UTC=2017-09-05 04:49:27","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090504-0025-0000-0000-00004C964644","Message-Id":"<874lshhhri.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-05_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050073","Subject":"Re: [Skiboot] [PATCH v2 1/5] hdata: Fix vpd parse","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]