[{"id":1758223,"web_url":"http://patchwork.ozlabs.org/comment/1758223/","msgid":"","list_archive_url":null,"date":"2017-08-27T08:00:49","subject":"Re: [U-Boot] [PATCH 2/2] x86: ich-spi: Clear atomic preop only when\n\tSPI settings are not locked","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"On 27.08.2017 04:22, Bin Meng wrote:\n> The atomic preop register can only be written when SPI settings are\n> not locked, otherwise it's read-only.\n> \n> Signed-off-by: Bin Meng \n> ---\n> \n> drivers/spi/ich.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c\n> index 5a3d690..22fc83d 100644\n> --- a/drivers/spi/ich.c\n> +++ b/drivers/spi/ich.c\n> @@ -563,7 +563,8 @@ static int ich_spi_xfer(struct udevice *dev, unsigned int bitlen,\n> \t}\n> \n> \t/* Clear atomic preop now that xfer is done */\n> -\tich_writew(ctlr, 0, ctlr->preop);\n> +\tif (!lock)\n> +\t\tich_writew(ctlr, 0, ctlr->preop);\n> \n> \treturn 0;\n> }\n> \n\nReviewed-by: Stefan Roese \n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xg6mZ47QRz9sQl\n\tfor ;\n\tSun, 27 Aug 2017 18:01:34 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 064B8C220F9; Sun, 27 Aug 2017 08:01:09 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5DCAFC220FE;\n\tSun, 27 Aug 2017 08:01:07 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 045ACC220FE; Sun, 27 Aug 2017 08:00:54 +0000 (UTC)","from mx1.mailbox.org (mx1.mailbox.org [80.241.60.212])\n\tby lists.denx.de (Postfix) with ESMTPS id 74CA7C220DE\n\tfor ; Sun, 27 Aug 2017 08:00:54 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.mailbox.org (Postfix) with ESMTPS id 4FEF543203;\n\tSun, 27 Aug 2017 10:00:54 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby hefe.heinlein-support.de (hefe.heinlein-support.de\n\t[91.198.250.172]) (amavisd-new, port 10030)\n\twith ESMTP id N1dBrvIlN20n; Sun, 27 Aug 2017 10:00:50 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","To":"Bin Meng , Simon Glass ,\n\tU-Boot Mailing List ","References":"<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>\n\t<1503800579-19321-2-git-send-email-bmeng.cn@gmail.com>","From":"Stefan Roese ","Message-ID":"","Date":"Sun, 27 Aug 2017 10:00:49 +0200","MIME-Version":"1.0","In-Reply-To":"<1503800579-19321-2-git-send-email-bmeng.cn@gmail.com>","Content-Language":"en-US","Subject":"Re: [U-Boot] [PATCH 2/2] x86: ich-spi: Clear atomic preop only when\n\tSPI settings are not locked","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1761554,"web_url":"http://patchwork.ozlabs.org/comment/1761554/","msgid":"","list_archive_url":null,"date":"2017-09-01T09:44:54","subject":"Re: [U-Boot] [PATCH 2/2] x86: ich-spi: Clear atomic preop only when\n\tSPI settings are not locked","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Sun, Aug 27, 2017 at 4:00 PM, Stefan Roese wrote:\n> On 27.08.2017 04:22, Bin Meng wrote:\n>>\n>> The atomic preop register can only be written when SPI settings are\n>> not locked, otherwise it's read-only.\n>>\n>> Signed-off-by: Bin Meng \n>> ---\n>>\n>> drivers/spi/ich.c | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n\napplied to u-boot-x86, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"M+U6z6iy\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkDqt6KkLz9sPk\n\tfor ;\n\tFri, 1 Sep 2017 19:45:14 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 88F54C21F0F; Fri, 1 Sep 2017 09:45:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 0390EC21EE9;\n\tFri, 1 Sep 2017 09:45:07 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0076DC21EFA; Fri, 1 Sep 2017 09:44:59 +0000 (UTC)","from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby lists.denx.de (Postfix) with ESMTPS id 3D165C21ED3\n\tfor ; Fri, 1 Sep 2017 09:44:55 +0000 (UTC)","by mail-wm0-f67.google.com with SMTP id m85so1976330wma.0\n\tfor ; Fri, 01 Sep 2017 02:44:55 -0700 (PDT)","by 10.223.135.121 with HTTP; Fri, 1 Sep 2017 02:44:54 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Z2dSOXLIpRZQVoTt8DeCezQe7ZlGD/elY4EqwXyFXHk=;\n\tb=M+U6z6iyeA49iT21hTQ0UlIK2R5EKsVMnkkJjtGrqlqq0tiYh5rXiTgbUv25/p0JFr\n\tJucboiikdgBx8E2DiqXJNroul0DxvniO1cH52irCcwe1RHBHDpO6K/4I6MBnKtG/p+dB\n\ttKjeyTH9qPuGKIbFtIMALcWK6pHUDBWBbWc2kc49C8qFLUIyjZ+VfeaUavLRle7RZvTE\n\tmWF8Jv8NqDUodrHvIB2BAYcWhGmElB/Kz68jg73p+MNXrhFIuj8Dy6miUDHkfdxEqD35\n\t9Onhyx+UYKlwr13Hj6nwM452KldiATYxScKNzlQig5YgSDYyImY9g6/8vv7GO9+pFylW\n\tVWLw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Z2dSOXLIpRZQVoTt8DeCezQe7ZlGD/elY4EqwXyFXHk=;\n\tb=eXpA/0TjILsfx1IwqduCtdSAS0ctrFbsB38i6qtyLd5l6/pzc+WttYwpzJsP/N1WUG\n\tlwg6NvSM5w39c1fofGLXpq/Kr+A5fX8WPb3T0jOojd9qQzLrANsT5hk8QBZLn2Ou54V2\n\tmtfdosOWVJUorUWk5AD/GDPHB4OVS4FTv7d0SjU+UadhsTUDdkO1PyqBMRzqthX9q1oN\n\t2MAzYR7JFHOC2pmP5KiYqDrjWJBFzgsJDIBbLQzCbpydxkAa9wVlBbdj7AQDLKNemwB8\n\t9kAQVTFPEARGOjXlpzqJ8q0t/agZ4+jIOucC4dRqSXchbdU4uUTsgCcnisD75SRMfGX8\n\tONQw==","X-Gm-Message-State":"AHPjjUjQ4Bi4/FalsDrl2SjiBt4xkR5DamPr90FnA6RHL3i/fnDm8qMN\n\tzH4mZgEJLT1VacF2ZkAn8+Y04b8NJA==","X-Google-Smtp-Source":"ADKCNb44xLWVPcBVRxpzqlXdSrCYuxfKCGt/b80wEwvCzJbNu1xdr5bNh6t1/VrnMb3LNPs+f9pjkrz4qg6O7sHYWL0=","X-Received":"by 10.28.10.132 with SMTP id 126mr67897wmk.46.1504259095003; Fri,\n\t01 Sep 2017 02:44:55 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>\n\t<1503800579-19321-2-git-send-email-bmeng.cn@gmail.com>\n\t","From":"Bin Meng ","Date":"Fri, 1 Sep 2017 17:44:54 +0800","Message-ID":"","To":"Stefan Roese ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 2/2] x86: ich-spi: Clear atomic preop only when\n\tSPI settings are not locked","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]