[{"id":1758222,"web_url":"http://patchwork.ozlabs.org/comment/1758222/","msgid":"<562556c1-32f9-a2d2-7f82-abb75bcfb1c7@denx.de>","list_archive_url":null,"date":"2017-08-27T08:00:21","subject":"Re: [U-Boot] [PATCH 1/2] x86: ich-spi: Remove useless assignment in\n\tich_spi_xfer()","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"On 27.08.2017 04:22, Bin Meng wrote:\n> In ich_spi_xfer() when the driver presets control fields, control\n> variable gets assigned twice. Apparently only the last assignment\n> takes effect. Remove the other one.\n> \n> Signed-off-by: Bin Meng \n> ---\n> \n> drivers/spi/ich.c | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c\n> index 373bc26..5a3d690 100644\n> --- a/drivers/spi/ich.c\n> +++ b/drivers/spi/ich.c\n> @@ -468,8 +468,6 @@ static int ich_spi_xfer(struct udevice *dev, unsigned int bitlen,\n> \t}\n> \n> \t/* Preset control fields */\n> -\tcontrol = ich_readw(ctlr, ctlr->control);\n> -\tcontrol &= ~SSFC_RESERVED;\n> \tcontrol = SPIC_SCGO | ((opcode_index & 0x07) << 4);\n> \n> \t/* Issue atomic preop cycle if needed */\n> \n\nReviewed-by: Stefan Roese \n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xg6lX47d3z9sQl\n\tfor ;\n\tSun, 27 Aug 2017 18:00:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 8C096C220F0; Sun, 27 Aug 2017 08:00:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 0D0A3C220CD;\n\tSun, 27 Aug 2017 08:00:27 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 4E692C220CA; Sun, 27 Aug 2017 08:00:26 +0000 (UTC)","from mx1.mailbox.org (mx1.mailbox.org [80.241.60.212])\n\tby lists.denx.de (Postfix) with ESMTPS id 0116DC220CD\n\tfor ; Sun, 27 Aug 2017 08:00:26 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.mailbox.org (Postfix) with ESMTPS id 878CC431BA;\n\tSun, 27 Aug 2017 10:00:25 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby hefe.heinlein-support.de (hefe.heinlein-support.de\n\t[91.198.250.172]) (amavisd-new, port 10030)\n\twith ESMTP id zWArO60G6AIl; Sun, 27 Aug 2017 10:00:22 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","To":"Bin Meng , Simon Glass ,\n\tU-Boot Mailing List ","References":"<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>","From":"Stefan Roese ","Message-ID":"<562556c1-32f9-a2d2-7f82-abb75bcfb1c7@denx.de>","Date":"Sun, 27 Aug 2017 10:00:21 +0200","MIME-Version":"1.0","In-Reply-To":"<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>","Content-Language":"en-US","Subject":"Re: [U-Boot] [PATCH 1/2] x86: ich-spi: Remove useless assignment in\n\tich_spi_xfer()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1761553,"web_url":"http://patchwork.ozlabs.org/comment/1761553/","msgid":"","list_archive_url":null,"date":"2017-09-01T09:44:50","subject":"Re: [U-Boot] [PATCH 1/2] x86: ich-spi: Remove useless assignment in\n\tich_spi_xfer()","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Sun, Aug 27, 2017 at 4:00 PM, Stefan Roese wrote:\n> On 27.08.2017 04:22, Bin Meng wrote:\n>>\n>> In ich_spi_xfer() when the driver presets control fields, control\n>> variable gets assigned twice. Apparently only the last assignment\n>> takes effect. Remove the other one.\n>>\n>> Signed-off-by: Bin Meng \n>> ---\n>>\n>> drivers/spi/ich.c | 2 --\n>> 1 file changed, 2 deletions(-)\n>>\n\napplied to u-boot-x86, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d7RO9azT\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkDqj5C3nz9sPk\n\tfor ;\n\tFri, 1 Sep 2017 19:45:04 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid B0306C21F14; Fri, 1 Sep 2017 09:44:55 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1FE75C21D7D;\n\tFri, 1 Sep 2017 09:44:53 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7C7D6C21D7D; Fri, 1 Sep 2017 09:44:51 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby lists.denx.de (Postfix) with ESMTPS id 22701C21C51\n\tfor ; Fri, 1 Sep 2017 09:44:51 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id x189so1953919wmg.4\n\tfor ; Fri, 01 Sep 2017 02:44:51 -0700 (PDT)","by 10.223.135.121 with HTTP; Fri, 1 Sep 2017 02:44:50 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=QpXdHK2OniI7K5i5oEohaWyN2erz0Fbw97gFk1tpsHg=;\n\tb=d7RO9azTWImy8i2hn1UrPHOxPuBVuwzJoRX7jmL/VwzTR7tL1XuYMltkZnJKY2tAKM\n\tj2UrlBkhlaqMOsvqHi737rqLOBjV2O8mxMQopsFsGY0TFLwtU42X2D8+7Oa4oGoBB+Oy\n\tKTsgbm6xL9njrN9XjTpp4c7IQr4keg376yAc8c1lHEn7YERGjQQiCWIu/rmJsASS4i+E\n\tnEnQau7NSSsLRgcWLGCAGrvCn8B1jkpAbuX3cK3S+gj+VnyfEowU5Om+0M6mRQmjVd0/\n\tivcFaJIi80w4zGpn1WVe55pc7frB7V40bzx2nnpt3gTVlFEB71RhhGHvpx226mk5evHH\n\tAMIA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=QpXdHK2OniI7K5i5oEohaWyN2erz0Fbw97gFk1tpsHg=;\n\tb=hXQvEj/YIpz0SWdAMs1rhz1XtxyfokMwUh7JgHMFOBTbgF/KYA9q0lMcPAD6Hlyd+6\n\tqUPJQ3xJwd0xaircSR/DXZLYeFyik2IS3nlJS3iKowBSKoleuZ8XoysH9PvQWxyuk7FF\n\tf9X0MsuhvQ2wQes9aIDZfMMFCY2Esc9YlY6y2SXwHw6FHUE6y15G1A0NDyWWibXTwQkJ\n\t9+CLmwvFGwCiBg3c2gP3XPeqx91tVerCuHa+F9ZaYffQIl18cDHPv+u4WCFbuK5biIBI\n\toBxRvC0xmJnBxOttFlpuXC7WW6p6/BLc3/xpeImTsBp/FhwE4TZMSKzHzynthKBAjn5w\n\tOMig==","X-Gm-Message-State":"AHPjjUiqfBmHuJfI+J2rCrJ/LZXfsFtIh1VApfRwxIgngUA+ceHSrFc4\n\tQHNjKjd+mjoO0ZkYQML3lfCk7As1uQ==","X-Google-Smtp-Source":"ADKCNb60sDAMUbM+xFuOkq0XK29RinEYCsJjsOjGfgeBoi9U4nx0kpkcS1aVDn33GeNWQRWyptlh93cL9rYcWC5f6co=","X-Received":"by 10.28.20.18 with SMTP id 18mr71901wmu.34.1504259090845;\n\tFri, 01 Sep 2017 02:44:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<562556c1-32f9-a2d2-7f82-abb75bcfb1c7@denx.de>","References":"<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>\n\t<562556c1-32f9-a2d2-7f82-abb75bcfb1c7@denx.de>","From":"Bin Meng ","Date":"Fri, 1 Sep 2017 17:44:50 +0800","Message-ID":"","To":"Stefan Roese ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 1/2] x86: ich-spi: Remove useless assignment in\n\tich_spi_xfer()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]