[{"id":1760963,"web_url":"http://patchwork.ozlabs.org/comment/1760963/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:52:23","subject":"Re: [U-Boot] [PATCH 22/23] efi_loader: set parent handle in\n\tefi_load_image","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 27 August 2017 at 06:54, Heinrich Schuchardt wrote:\n> The parent_handle of the loaded image must be set.\n> Add the file path protocol from the provided parameter.\n> Set system table.\n> Add parameter checks.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> lib/efi_loader/efi_boottime.c | 31 +++++++++++++++++++++++++++++--\n> 1 file changed, 29 insertions(+), 2 deletions(-)\n>\n\nReviewed-by: Simon Glass \n\nA function comment on this would be nice","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"GqyfuehG\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Hg3RgBa0\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjLK3B9sz9sMN\n\tfor ;\n\tThu, 31 Aug 2017 23:06:17 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2A9CAC21E38; Thu, 31 Aug 2017 12:56:17 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 67F05C21E1D;\n\tThu, 31 Aug 2017 12:55:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2211DC21E1D; Thu, 31 Aug 2017 12:52:49 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 035B9C21DBA\n\tfor ; Thu, 31 Aug 2017 12:52:46 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id a21so2263105qkg.5\n\tfor ; Thu, 31 Aug 2017 05:52:45 -0700 (PDT)","by 10.200.28.106 with HTTP; Thu, 31 Aug 2017 05:52:23 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=B4JPjun4Er+godJ2TQOh2B2kYzyqfP5Vg1xue8/Kw7E=;\n\tb=GqyfuehG59WqArkydUYQ9z3c/qmPb0qPf0CFf3PmIiv1JDEcF6u79hJvB99BPMq1EM\n\tp8JoUv0l53+TnbmmDtjhqIjVsW1T60XdR8TBeG/M8NG1bDXcWM0b+2ja+dtMEwxunfRf\n\tffkVS9jf9V61IhfKv1VZw2lnS7n0XeyetBeJO7UsIcYQiTagRfv0x4UId+wGsCnAuA+g\n\tTHBkx+BkQ05lkuUGmhADAgnqsxuDP4SkEw5bsD/ah5n6TeEYMhbQelz5dJcT/XC7cw9+\n\tlvIRb0oD5V+g69LloUk9TlfeIalWgehCkIXbKnDY3fsl1mBLrfHxYjeieuowJx4NWkhK\n\tJZ3A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=B4JPjun4Er+godJ2TQOh2B2kYzyqfP5Vg1xue8/Kw7E=;\n\tb=Hg3RgBa0QgZ0qVclkGAdKcCa8q6Jgpo18zM8aMC9anBzz9MSxdabPwf9ufED6NlxXV\n\thor695UZ3NRCjxcT39ohqPhFvbu1r95Mn8WDdJcTwYHEzR5N8xcnkEErVy4ldkCz0Qm/\n\tIA7GyJ7vrKJ+IDXLDW1wBTSiEo+A0BpYit14A="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=B4JPjun4Er+godJ2TQOh2B2kYzyqfP5Vg1xue8/Kw7E=;\n\tb=EXCfDPaGe+fA65bcp1YN0WGywKJliJcTwTtvCQk6kDDcumgnvHWH3OxJ7ZmxiIzDae\n\t1U2r2YbuwaMJzyBLnEw7zpLWr5eG2WgZneJkZt8WXaxfdxWUZ2++x2dvDPbFoFmMaClx\n\tLC6BiaaUUXghjR8UXHUc/zsXdQydgtqwowYA9zrgoKxNVjYq73LXJDj2EKoH+BZrsjTx\n\tpAjCKMVkxEuKWCAUv0ZEjgWLHSoOYVSgGGiG7WCvltrCrmgSXnDdygSIFowIbBEse4/H\n\t9BIGM/mxJN3eBnWSxkl4DWnK432Ulz59ZQaVJI18V+GFBmw3DmNUHiwIH8082Ip7eJ0b\n\t/eWw==","X-Gm-Message-State":"AHYfb5jejdbnSri5odP+aMlGQR32lsNlgatNSA4vjd+x17TRutpNUruJ\n\t/e4FhKXJhFfNayogrKvr7juqFlDLXmCA","X-Google-Smtp-Source":"ADKCNb69bN94R5SfCrmc1NkWqF1Ofk4RZBQJKE0sRk6NKTpI5pcjZp+Rv2hICTZ5Lh62PJr8nX63gHD0ClhWw8L+jfY=","X-Received":"by 10.55.39.84 with SMTP id n81mr3377340qkn.236.1504183964541;\n\tThu, 31 Aug 2017 05:52:44 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170826225444.7608-3-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225444.7608-1-xypron.glpk@gmx.de>\n\t<20170826225444.7608-3-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Thu, 31 Aug 2017 20:52:23 +0800","X-Google-Sender-Auth":"1aT78Rj10noFJvRV4Hot-SIPmMo","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 22/23] efi_loader: set parent handle in\n\tefi_load_image","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]