[{"id":1760955,"web_url":"http://patchwork.ozlabs.org/comment/1760955/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:51:54","subject":"Re: [U-Boot] [PATCH 13/23] efi_loader: non-static efi_open_protocol,\n\tefi_close_protocol","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 27 August 2017 at 06:53, Heinrich Schuchardt wrote:\n> We need efi_open_protocol and efi_close_protocol for\n> implementing other functions. So they shouldn't be static.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> include/efi_loader.h | 9 +++++++++\n> lib/efi_loader/efi_boottime.c | 9 ++++-----\n> 2 files changed, 13 insertions(+), 5 deletions(-)\n\nReviewed-by: Simon Glass \n\nBut please document these two functions fully.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"aaKMMfrq\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"d1tVgxU8\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjDq5BnRz9sMN\n\tfor ;\n\tThu, 31 Aug 2017 23:01:31 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5E04BC21E3A; Thu, 31 Aug 2017 12:55:49 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EBC7CC21E1B;\n\tThu, 31 Aug 2017 12:55:01 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 52CFDC21CB6; Thu, 31 Aug 2017 12:52:21 +0000 (UTC)","from mail-qk0-f171.google.com (mail-qk0-f171.google.com\n\t[209.85.220.171])\n\tby lists.denx.de (Postfix) with ESMTPS id 79021C21E27\n\tfor ; Thu, 31 Aug 2017 12:52:17 +0000 (UTC)","by mail-qk0-f171.google.com with SMTP id a21so2257790qkg.5\n\tfor ; Thu, 31 Aug 2017 05:52:17 -0700 (PDT)","by 10.200.28.106 with HTTP; Thu, 31 Aug 2017 05:51:54 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=7bbgKy1fDhVDPfTynVuZRMrrIzAn7WvG787xXbASbLc=;\n\tb=aaKMMfrq+IIt+C4MbShItFz0NDO0uSJaa9ibt9n1UjAwMJdJGvXhs6gEM5Q94err3o\n\tAizY6E4BBUEBel8BI1hWsu+fjNn2aTyUvu9braN4aJO1MSv2Uza4DKAwizFfH/3NCA6k\n\tQuJOpyLHucPOxKslzEIHZo4fF/tozsbh56dVc1QlK8+7Za1yqx7/ddZIZwqZhIAV8VXf\n\tTk53ctQUf70TE0mtjQE6a5nztgARlNrgR5OX6k2fmUi5xG6BEI3g5TUR/54HXkRLjv7b\n\tvE9U0tP2ByeN8L/IA/ajOLByB/Es+W/UjW2Go7Qg0tb9+14GAUTm6k+sN3RgJp10HLC2\n\t4rfg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=7bbgKy1fDhVDPfTynVuZRMrrIzAn7WvG787xXbASbLc=;\n\tb=d1tVgxU8QEVS4QSP6bDFBJhRxcHQkbDWmTEkOoDw7yLAf9pg6GPfrQVHTR4xeQK6oW\n\tvL8kuYXtCXN7qCIJLKcvtrbKoVobkuxJBQQv9Ctn5eiN0zLV7VI5s4CGUe+od0dXUEfO\n\tWE0pLLPZGcWgkKGPG8qE3JBCAkd8lOTJSDeCU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=7bbgKy1fDhVDPfTynVuZRMrrIzAn7WvG787xXbASbLc=;\n\tb=ebCMnzSImpcpLo1qxuhzPFqNVuVrpYWi5Fow2ohovk1dVyBr/CBxZi1LynJcWDM1b8\n\tt08Yv2uX63K+PCMrbMN5lriftLLjwOYinxZ2UI2q2NjDRO3zEsj7wcx92CaeGU5GU5ys\n\tfJD6ir/PXuQ+uza3J2Nh9LMZm53n0dD10Ya2UHymMjqv4tCW3eNVuA/duPDZ5Bu/gQ4m\n\ttEG31lmUwtwj+sRuIAUr6c+7TzBBLkb7znCem5f+yJ7yWt6o4UlI+jBMrtjyRQ+DyXop\n\tNhj3U+wuK1QhydrmdYu6ByNC8/4N+XMMS8ofrvS7IgrB+jomSwiiAwK0bTYl8rQh+mg3\n\tyvIw==","X-Gm-Message-State":"AHPjjUiRmDD+PwGgOnuvCwAWyYAgw5gJijCQf++B20JE9ClSSndLrr2D\n\tVeb3KIRsKo3W8O9+kdJ9c+HoSoUYOrPv","X-Google-Smtp-Source":"ADKCNb6uPYHbricbn7WGuNI+/jgefwW5ZBqJIimWchT2Nzfg0J6tdbofzehm9WCVmOMStw/mAUJLnPZpZ7qMkY99g6c=","X-Received":"by 10.55.57.77 with SMTP id g74mr3717246qka.186.1504183936092;\n\tThu, 31 Aug 2017 05:52:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170826225328.7550-4-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-4-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Thu, 31 Aug 2017 20:51:54 +0800","X-Google-Sender-Auth":"WKwkRkxC946Dp9SQHxA-aNBmhM4","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 13/23] efi_loader: non-static efi_open_protocol,\n\tefi_close_protocol","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]