[{"id":1760975,"web_url":"http://patchwork.ozlabs.org/comment/1760975/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:52:07","subject":"Re: [U-Boot] [PATCH 17/23] efi_loader: efi_net: hwaddr_size = 6","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 27 August 2017 at 06:53, Heinrich Schuchardt wrote:\n> The length of a MAC address is 6.\n> We have to set this length in the EFI_SIMPLE_NETWORK_MODE\n> structure of the EFI_SIMPLE_NETWORK_PROTOCOL.\n>\n> Without this patch iPXE fails to initialize the network with\n> error message\n> SNP MAC(001e0633bcbf,0x0) has invalid hardware address length 0\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> lib/efi_loader/efi_net.c | 1 +\n> 1 file changed, 1 insertion(+)\n\nReviewed-by: Simon Glass \n\nCan you use ARP_HLEN?\n\n>\n> diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c\n> index 0b949d86e8..75d7974b0e 100644\n> --- a/lib/efi_loader/efi_net.c\n> +++ b/lib/efi_loader/efi_net.c\n> @@ -259,6 +259,7 @@ int efi_net_register(void **handle)\n> netobj->dp_end = dp_end;\n> memcpy(netobj->dp_mac.mac.addr, eth_get_ethaddr(), 6);\n> memcpy(netobj->net_mode.current_address.mac_addr, eth_get_ethaddr(), 6);\n> + netobj->net_mode.hwaddr_size = 6;\n> netobj->net_mode.max_packet_size = PKTSIZE;\n>\n> netobj->pxe.mode = &netobj->pxe_mode;\n> --\n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"NcIE7vTC\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"E9h6Y6Rr\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjTw61QPz9sPm\n\tfor ;\n\tThu, 31 Aug 2017 23:12:52 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 769A1C21E9B; Thu, 31 Aug 2017 13:03:42 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 37F60C21E72;\n\tThu, 31 Aug 2017 13:03:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8E0AEC21E0E; Thu, 31 Aug 2017 12:52:32 +0000 (UTC)","from mail-qt0-f172.google.com (mail-qt0-f172.google.com\n\t[209.85.216.172])\n\tby lists.denx.de (Postfix) with ESMTPS id AA135C21E05\n\tfor ; Thu, 31 Aug 2017 12:52:29 +0000 (UTC)","by mail-qt0-f172.google.com with SMTP id w42so2337739qtg.5\n\tfor ; Thu, 31 Aug 2017 05:52:29 -0700 (PDT)","by 10.200.28.106 with HTTP; Thu, 31 Aug 2017 05:52:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=YtvzehYetsEGTy/ETKv4mbQqS/NHQuqrO5CeKlfAEnQ=;\n\tb=NcIE7vTCyeoof+3+6BH58JH0zB0E6Za2scvsm2xjltAsI5ANV5L+hQjG+Cu8FkjGgy\n\t7FNWh40MZWLd5Hc1fniXBKS9kYbXPk7AzUHdAbZgRJVB6gHMOdRkxkgvk82V6BhLv0Ql\n\tvTcA/2nZs8L9PZ9dYyteRvuXj2YnKrhPyDrs38agxVjE06tgEKywiymYqkUy8zmts70H\n\tTw+l+wTtEdJJVHE4KqAIrWj/sQbEF0RbY7HnL/KZMRKJDbIIGYJ9ummo5PHnwLtwZYd0\n\tEAHk5I1YxMhUyOVErR/OLJwV38nOawExrwW0WVgBJjemD3zOREPy3gGT3edWdRiZxir6\n\tXOjA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=YtvzehYetsEGTy/ETKv4mbQqS/NHQuqrO5CeKlfAEnQ=;\n\tb=E9h6Y6RrkvzxQ9z/MoeetbqUz80oCEz9h5It+kt4m2wLhDkdUv0BJ84PEy5T/OZX3h\n\tcTyxjHUz1y6FeiznTN66j6AgGAsaOeoJNz6slWgYjpRNYTGnoAqbj0GaEW+hlpqDXvUY\n\tGc3NR0D+G7JusjtQVGuBukoIp6wqvDRSOeZRc="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=YtvzehYetsEGTy/ETKv4mbQqS/NHQuqrO5CeKlfAEnQ=;\n\tb=KlUubKLeHkNO/jZfFoG7iyeTR1cTNuqWSph/IjQuamtwcEcLz2RGwn5txCWUtr4b3r\n\taSX2BbRQ2D6Tp3wFIg+I+++amio6478Z9orbvWNrwkvoNMIaOnmFj59ClC6o4OUTSd2L\n\tYlZHRYCy0hTeBxJZYaezKw1bmN9pfBvsue3aqcpcPxrkEH7jI/EflWlXYHm8xIumRTn0\n\tA11JpI0x8XZcQrs/hC10Bgz4GP9LgwvQ4sC0T6F/U6AtPE57IwHOQDvHFdwQHpakUasf\n\th6rgfYwQ0eYvuBN4jGs4Sv56EBAESxt+QE8Xup8hYcXSHeNvLiKpY1coA0Jodc/WcIeI\n\t1RrQ==","X-Gm-Message-State":"AHYfb5hJkL854yhtpQSee5O8PamCb7JojxniUmUqY2nvXuXk3XDm1Ep8\n\txiIljpTCysVU0Ffzn+mPWrforofyxuqe","X-Google-Smtp-Source":"ADKCNb6ev+7YDGll2ZGN9wKra0i5rhR06VjMUSvwq9YPxLFs/GarLNjOcLeFfGjQkMULabQUUDrnaH+flbCR+T6NnvI=","X-Received":"by 10.237.33.176 with SMTP id l45mr7459563qtc.145.1504183948481; \n\tThu, 31 Aug 2017 05:52:28 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170826225328.7550-8-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-8-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Thu, 31 Aug 2017 20:52:07 +0800","X-Google-Sender-Auth":"OFhCS6sl1sWO50He73Yy1b0ldRQ","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 17/23] efi_loader: efi_net: hwaddr_size = 6","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]