[{"id":1760949,"web_url":"http://patchwork.ozlabs.org/comment/1760949/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:52:27","subject":"Re: [U-Boot] [PATCH 23/23] efi_loader: implement SetWatchdogTimer","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 27 August 2017 at 06:54, Heinrich Schuchardt wrote:\n> The watchdog is initialized with a 5 minute timeout period.\n> It can be reset by SetWatchdogTimer.\n> It is stopped by ExitBoottimeServices.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> cmd/bootefi.c | 1 +\n> include/efi_loader.h | 4 +++\n> lib/efi_loader/Makefile | 2 +-\n> lib/efi_loader/efi_boottime.c | 3 ++-\n> lib/efi_loader/efi_watchdog.c | 58 +++++++++++++++++++++++++++++++++++++++++++\n> 5 files changed, 66 insertions(+), 2 deletions(-)\n> create mode 100644 lib/efi_loader/efi_watchdog.c\n>\n\nReviewed-by: Simon Glass \n\nI'm wondering whether the efi_ prefix on all these files is\nsuperfluous. What is the purpose?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"nrXJyqxb\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Xok4jFWJ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjBx4cv1z9sPm\n\tfor ;\n\tThu, 31 Aug 2017 22:59:53 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 61E02C21E13; Thu, 31 Aug 2017 12:55:33 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5C469C21DE7;\n\tThu, 31 Aug 2017 12:54:24 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 59530C21DF3; Thu, 31 Aug 2017 12:52:52 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 2BD8AC21E0C\n\tfor ; Thu, 31 Aug 2017 12:52:49 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id k126so2270843qkb.4\n\tfor ; Thu, 31 Aug 2017 05:52:49 -0700 (PDT)","by 10.200.28.106 with HTTP; Thu, 31 Aug 2017 05:52:27 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=wu/AmXZcmRzrD94kamsiTv8nyjIrTfb43zK/1uDt/yI=;\n\tb=nrXJyqxbZ4MIN4T2bKEPsrFtu0VSmgYeFGZbzOe/rsCFgrUhKm3evzGWzxcUIxDd+3\n\tMC7jZlybIRCHtxtKKY0UvP0QMkDAk0IX7zBm1H5seUwWBAWK4J8yv9h5UZPWULvDlrKm\n\t6rWPVPAnCfk/Ri7qTm6W+7waAZWWSiETCtFsYRfTYpCiCWp0W7eDwNtr5N6z1uFsa9hn\n\tSsOLFugcGAiDOaQNngIMBsvXVBw1vVaXd5a9uXDl7j0/U2sbcQQwbnXIksZr6IiD2nrH\n\tPpf89VTPoArRC2udSRkIYTyn0ZA8Fa2fCfCVRlVMv8BPJj25K5NI3GtyJmf66nSp6lDu\n\tfYLQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=wu/AmXZcmRzrD94kamsiTv8nyjIrTfb43zK/1uDt/yI=;\n\tb=Xok4jFWJixSox4vVyklOC47fVLKPPTtZRDBORESFsK8nNwbja6XjqBj0998XsQ19NX\n\tkYVSwRLE2eoTMiKMrZ3PnqSFGUvK83evLu4gHecwjTWGuDovARArr7yEg4HrOjioXhDe\n\tpo6IWBX2PAox90O2S2AakBZ+4LLgNwSbhjERg="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=wu/AmXZcmRzrD94kamsiTv8nyjIrTfb43zK/1uDt/yI=;\n\tb=VAnCsbgRllGEBVBf/te/SkFF1OvEcaLyRCZZylTYDXzFOeme5Nc+wC1MG8VpWMah4Z\n\tohCP9jhfdrYVKZKeHdfUOVywKkeyUk4Zv69OVRQMJnNn/SBd92qwNuJSuWl/TPGQvHQE\n\t/WIkTlrPU9xZtuWl3ZUWCll2GJr9Wif50A0grx4r2iK/iLMHIPbiAk62ckNAbHEIhy2G\n\tct9vGkYrG3/SNqOEfoh3XwXLddH/Z1Oq1SmNVgCwGsED1BxxA9GhydRlyecpTV2J3O0k\n\t+B3a31hiQDzmW8uWUhGB+QeEBLLNjHHrwiC36sXK+txQQKOCL05Mscc+2Ff7hk0QMOcC\n\tfTiQ==","X-Gm-Message-State":"AHYfb5jV4UtphV1bpTzS7G9MaIfLn8MyC8h78C1jrRryGJF+Gf1oxxPd\n\t1pBghd7+KXi1y5gyjy/9wiRhFWm95uqQ","X-Google-Smtp-Source":"ADKCNb6X5HBkb6RRjHbysKLnQ/exBKqCKtivf7I5DJwZxj4VsZpf2avU+ULCOBK0X0ettmY8NP+n/lC77IpSArWaSTk=","X-Received":"by 10.55.74.88 with SMTP id x85mr3489242qka.294.1504183967730;\n\tThu, 31 Aug 2017 05:52:47 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170826225444.7608-4-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225444.7608-1-xypron.glpk@gmx.de>\n\t<20170826225444.7608-4-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Thu, 31 Aug 2017 20:52:27 +0800","X-Google-Sender-Auth":"aQHEV1NJHO459wkIvmEpCmA86ZQ","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 23/23] efi_loader: implement SetWatchdogTimer","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]