[{"id":1760970,"web_url":"http://patchwork.ozlabs.org/comment/1760970/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:52:01","subject":"Re: [U-Boot] [PATCH 15/23] efi_loader: implement ConnectController","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 27 August 2017 at 06:53, Heinrich Schuchardt wrote:\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> include/efi_api.h | 22 ++++++++\n> include/efi_loader.h | 1 +\n> lib/efi_loader/efi_boottime.c | 119 +++++++++++++++++++++++++++++++++++++++++-\n> 3 files changed, 141 insertions(+), 1 deletion(-)\n>\n\nReviewed-by: Simon Glass \n\nPlease see below.\n\n> diff --git a/include/efi_api.h b/include/efi_api.h\n> index 8efc8dfab8..b2838125d7 100644\n> --- a/include/efi_api.h\n> +++ b/include/efi_api.h\n> @@ -609,4 +609,26 @@ struct efi_pxe {\n> struct efi_pxe_mode *mode;\n> };\n>\n> +#define EFI_DRIVER_BINDING_PROTOCOL_GUID \\\n> + EFI_GUID(0x18a031ab, 0xb443, 0x4d1a,\\\n> + 0xa5, 0xc0, 0x0c, 0x09, 0x26, 0x1e, 0x9f, 0x71)\n> +struct efi_driver_binding_protocol {\n> + efi_status_t (EFIAPI * supported)(\n\nI think the * should be up against 'supported'. Similarly below.\n\n> + struct efi_driver_binding_protocol *this,\n> + efi_handle_t controller_handle,\n> + struct efi_device_path *remaining_device_path);\n> + efi_status_t (EFIAPI * start)(\n> + struct efi_driver_binding_protocol *this,\n> + efi_handle_t controller_handle,\n> + struct efi_device_path *remaining_device_path);\n> + efi_status_t (EFIAPI * stop)(\n> + struct efi_driver_binding_protocol *this,\n> + efi_handle_t controller_handle,\n> + UINTN number_of_children,\n> + efi_handle_t child_handle_buffer);\n\nThese should have function comments.\n\n> + u32 version;\n> + efi_handle_t image_handle;\n> + efi_handle_t driver_binding_handle;\n> +};\n> +\n> #endif\n> diff --git a/include/efi_loader.h b/include/efi_loader.h\n> index 9c68246c7c..f9f33e1d01 100644\n> --- a/include/efi_loader.h\n> +++ b/include/efi_loader.h\n> @@ -74,6 +74,7 @@ extern const struct efi_device_path_to_text_protocol efi_device_path_to_text;\n>\n> extern const efi_guid_t efi_guid_console_control;\n> extern const efi_guid_t efi_guid_device_path;\n> +extern const efi_guid_t efi_guid_driver_binding_protocol;\n\ncomment for this?\n\n> extern const efi_guid_t efi_guid_loaded_image;\n> extern const efi_guid_t efi_guid_device_path_to_text_protocol;\n>\n> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n> index 5a73ea5cd0..1069da7d79 100644\n> --- a/lib/efi_loader/efi_boottime.c\n> +++ b/lib/efi_loader/efi_boottime.c\n> @@ -18,6 +18,14 @@\n>\n> DECLARE_GLOBAL_DATA_PTR;\n>\n> +static efi_status_t EFIAPI efi_locate_protocol(const efi_guid_t *protocol,\n> + void *registration,\n> + void **protocol_interface);\n> +static efi_status_t EFIAPI efi_locate_handle_buffer(\n> + enum efi_locate_search_type search_type,\n> + const efi_guid_t *protocol, void *search_key,\n> + unsigned long *no_handles, efi_handle_t **buffer);\n> +\n\nIs this a forward decl? Can you reorder (in a separate patch) to avoid it?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"bJ5BNorc\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DDbCZRWo\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjQB0c8Jz9sPm\n\tfor ;\n\tThu, 31 Aug 2017 23:09:38 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C160AC21E3A; Thu, 31 Aug 2017 12:56:32 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7030FC21E38;\n\tThu, 31 Aug 2017 12:55:46 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5036FC21E0F; Thu, 31 Aug 2017 12:52:26 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 753C1C21E07\n\tfor ; Thu, 31 Aug 2017 12:52:23 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id o63so2281128qkb.3\n\tfor ; Thu, 31 Aug 2017 05:52:23 -0700 (PDT)","by 10.200.28.106 with HTTP; Thu, 31 Aug 2017 05:52:01 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Wcx1Zs/r8pVylMa/UERom7CM6jy0JpbA+WNLl/DPMV8=;\n\tb=bJ5BNorcXK8le6G4kj0rGe+pCXg4X0IvIh/miU4N+4bCY113Hl/tsWFQTMouCGQjOb\n\tpZsoei3OOz5cqv2lJbmEWuKLQJGXdyVxkjvLcmoOE+Fj5xl03Xeew1OdASJ4nhJyO8Tx\n\t2rXzSw/IokNrtMiNq27KDExHEiURaboetE5vIkPVOOr9ochLsk8I8uopJcOkMMFGqRC/\n\t+R06RwV/obMI65OL1EBCBj3sSOJQmkzpBenng8wtJnYfLxapfFcFRq322PsEU3Nu+7aE\n\tOB4BL4IAE0s1om77rRfighXGOd9dguxCv1az4vgzZplerPGO7QfWY20dANFosRhD7Yg+\n\tEEgg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Wcx1Zs/r8pVylMa/UERom7CM6jy0JpbA+WNLl/DPMV8=;\n\tb=DDbCZRWoNPBjC772OuvzvUp5fLD9bcLu5V4dX2WFFmz4A4UWM6w1f8at8/148TuMOs\n\tcIWp7LvE71ljrlQAhuYq9/MLCM46vbedMrAsdIAkriOv0lZ0w4zEvLwP23BJx5z2r2+W\n\tdkvzBWDaBYU3+f7D49kCK+RuPOLoPV8W9eGeU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=Wcx1Zs/r8pVylMa/UERom7CM6jy0JpbA+WNLl/DPMV8=;\n\tb=FUYOFzGUfgVJ+/vn2x0MhmiKHbTPBrbGHBW9MPAgEbPKACqxpRUGHjLDt6g+QkZ6r5\n\tmkFe2qImjzUgEnWsf8/cReDGY9iYJXWC5OQ9HGZrhlDVLX0j1Tax2rEBcNvXxaqdiR+M\n\tRGld63+DZwrwN8s3PI5Aj+wF9P+XXUMdWfvODZzAOnbRYyNdJ+xFemPdkwQPpgyCWA+D\n\tVInvy12TuRVCwvza+Atm2Z75FiZYYyc3Y0BQLSWwXequv8IbA+o62Tw4UCXOLVmuReFT\n\tZo4R8bLyuQ5vXQjdjxj5DKYkSnzk4IO1MVUgJGxzQ80jmznL+4DTri9DVkzWB39ZKZzY\n\tE9TA==","X-Gm-Message-State":"AHPjjUhP7mbgDsl9vsSyPYbJoXM2lDW0Do5ZCrMj6bufWRdMofJ2ie8g\n\tBoYiIEh+iRRYMWIq5eL7s9kh38cHKA6T","X-Google-Smtp-Source":"ADKCNb5geUgbOALCl2VYtmYth81kUuvqaX7SyYdZIVKGXZ3uMrhqIgm0sgXpCJjw7PMQsWHM0KX+fCA/j6W+ehecAB4=","X-Received":"by 10.55.156.147 with SMTP id f141mr3495023qke.84.1504183942183; \n\tThu, 31 Aug 2017 05:52:22 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170826225328.7550-6-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-6-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Thu, 31 Aug 2017 20:52:01 +0800","X-Google-Sender-Auth":"Vfb9o7e09FCiwzFkJd4-gwYmMqE","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 15/23] efi_loader: implement ConnectController","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1768962,"web_url":"http://patchwork.ozlabs.org/comment/1768962/","msgid":"<15a8b074-4287-e97a-d977-835b3da93445@gmx.de>","list_archive_url":null,"date":"2017-09-15T06:48:34","subject":"Re: [U-Boot] [PATCH 15/23] efi_loader: implement ConnectController","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 08/31/2017 02:52 PM, Simon Glass wrote:\n> On 27 August 2017 at 06:53, Heinrich Schuchardt wrote:\n>> Signed-off-by: Heinrich Schuchardt \n>> ---\n>> include/efi_api.h | 22 ++++++++\n>> include/efi_loader.h | 1 +\n>> lib/efi_loader/efi_boottime.c | 119 +++++++++++++++++++++++++++++++++++++++++-\n>> 3 files changed, 141 insertions(+), 1 deletion(-)\n>>\n> \n> Reviewed-by: Simon Glass \n> \n> Please see below.\n> \n>> diff --git a/include/efi_api.h b/include/efi_api.h\n>> index 8efc8dfab8..b2838125d7 100644\n>> --- a/include/efi_api.h\n>> +++ b/include/efi_api.h\n>> @@ -609,4 +609,26 @@ struct efi_pxe {\n>> struct efi_pxe_mode *mode;\n>> };\n>>\n>> +#define EFI_DRIVER_BINDING_PROTOCOL_GUID \\\n>> + EFI_GUID(0x18a031ab, 0xb443, 0x4d1a,\\\n>> + 0xa5, 0xc0, 0x0c, 0x09, 0x26, 0x1e, 0x9f, 0x71)\n>> +struct efi_driver_binding_protocol {\n>> + efi_status_t (EFIAPI * supported)(\n> \n> I think the * should be up against 'supported'. Similarly below.\n\nThis is what checkpatch wants to see. Your suggestion leads to\n\nERROR: need consistent spacing around '*' (ctx:WxV)\n#25: FILE: include/efi_api.h:616:\n+ efi_status_t (EFIAPI *supported)(\n\nSo I prefer not change this before checkpatch.pl is not giving a\ndifferent result.\n\n> \n>> + struct efi_driver_binding_protocol *this,\n>> + efi_handle_t controller_handle,\n>> + struct efi_device_path *remaining_device_path);\n>> + efi_status_t (EFIAPI * start)(\n>> + struct efi_driver_binding_protocol *this,\n>> + efi_handle_t controller_handle,\n>> + struct efi_device_path *remaining_device_path);\n>> + efi_status_t (EFIAPI * stop)(\n>> + struct efi_driver_binding_protocol *this,\n>> + efi_handle_t controller_handle,\n>> + UINTN number_of_children,\n>> + efi_handle_t child_handle_buffer);\n> \n> These should have function comments.\n> \n>> + u32 version;\n>> + efi_handle_t image_handle;\n>> + efi_handle_t driver_binding_handle;\n>> +};\n>> +\n>> #endif\n>> diff --git a/include/efi_loader.h b/include/efi_loader.h\n>> index 9c68246c7c..f9f33e1d01 100644\n>> --- a/include/efi_loader.h\n>> +++ b/include/efi_loader.h\n>> @@ -74,6 +74,7 @@ extern const struct efi_device_path_to_text_protocol efi_device_path_to_text;\n>>\n>> extern const efi_guid_t efi_guid_console_control;\n>> extern const efi_guid_t efi_guid_device_path;\n>> +extern const efi_guid_t efi_guid_driver_binding_protocol;\n> \n> comment for this?\n\nThe GUIDs are defined in the UEFI spec.\nSo maybe we should just put a comment above all of these.\n\nRegards\n\nHeinrich\n\n> \n>> extern const efi_guid_t efi_guid_loaded_image;\n>> extern const efi_guid_t efi_guid_device_path_to_text_protocol;\n>>\n>> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n>> index 5a73ea5cd0..1069da7d79 100644\n>> --- a/lib/efi_loader/efi_boottime.c\n>> +++ b/lib/efi_loader/efi_boottime.c\n>> @@ -18,6 +18,14 @@\n>>\n>> DECLARE_GLOBAL_DATA_PTR;\n>>\n>> +static efi_status_t EFIAPI efi_locate_protocol(const efi_guid_t *protocol,\n>> + void *registration,\n>> + void **protocol_interface);\n>> +static efi_status_t EFIAPI efi_locate_handle_buffer(\n>> + enum efi_locate_search_type search_type,\n>> + const efi_guid_t *protocol, void *search_key,\n>> + unsigned long *no_handles, efi_handle_t **buffer);\n>> +\n> \n> Is this a forward decl? Can you reorder (in a separate patch) to avoid it?\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtmGs4fC3z9t2V\n\tfor ;\n\tFri, 15 Sep 2017 16:49:41 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3FED2C21FBF; Fri, 15 Sep 2017 06:49:34 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6A890C21E31;\n\tFri, 15 Sep 2017 06:49:31 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9F513C21E31; Fri, 15 Sep 2017 06:49:29 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby lists.denx.de (Postfix) with ESMTPS id 3FB85C21DAA\n\tfor ; Fri, 15 Sep 2017 06:49:29 +0000 (UTC)","from [192.168.8.100] ([94.197.120.111]) by mail.gmx.com (mrgmx101\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0MEsXW-1dcko9044o-00G4Qz; Fri, 15 Sep 2017 08:48:39 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","To":"Simon Glass ","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-6-xypron.glpk@gmx.de>\n\t","From":"Heinrich Schuchardt ","Message-ID":"<15a8b074-4287-e97a-d977-835b3da93445@gmx.de>","Date":"Fri, 15 Sep 2017 08:48:34 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Provags-ID":"V03:K0:W1Da09piUWKwrJTgw23srJPs0Onb+olGFpJAUSbSyM12f5jFWIl\n\t9AXxt4kdRBFSp1Gr1ROiCEJiFDJb7snT9BPSrURHVOA+H4Ki/FkgQvKZBQLuL6XfhbyjVW8\n\tHpfkeMmwvUcEos/NB3ITpFzTzanZsSoLu4u7nzKnxWj3Fr3C9PVSMOrulx4okQwm0RwtAQ4\n\tzWETBYGDpG2/uyySoSJEg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:Id2/DXGKjnI=:tRHakhom6Ik7gW7E17+Ddo\n\thy23E7LRdLTeCDz7gcnvkW3qmayLXo7pQ0Tk56GmV4rvxsyMJjsmjQGm/quD3xCqyhsE4s/c1\n\tviFqkKhV4vKSc5vQ7DfZiy8aE0kt7sK38cixoHy9NC99h1FtdDDLtlgaWz1lADHEmW0KVGJ0Q\n\tTUgM2FYYyVSB+Z5Pfi9pSj6N6gkRPKeyUMcj02OguvKIHgDnG/vLvZcflf7xNFGM8kuuoNRiL\n\tEM2wkaEzYH5otUbd05C43JfvejHa+I+pAu1v71onAbTQ6oznb2hJc0t6X7VANHwSzi1CJo07B\n\tnWE8rz2c8BW5dXmRyTz2At57g947zJQ6N3igvmElQO2Oza/5EKLspdwB32AvkXgXhDP647AGD\n\tDmY+J1Id0EsBSZS1udmzgYZIu5Gmh01t0GlheQa9/KgCMp9qBtx2QKtWFWDtrtWMZfESREImm\n\t2wvjo4eW/hGp+mawgYJqBjc01QAMfY4koETNxWdPWIaRb+ctFkK+/aiIp46t/57ZLzWMEiDJi\n\tfWa1Ah9TpdsY44215QfJGeiwGRrnT4BN2qP20MBSgxpOUnZpjjQ76aYSbAv+BpKpE1XypfEda\n\t++4knqEpj8hdKgvVQQSGPM3s5skE/1JmdWDNRMoa27js4dZHFy6QGjhUbcNPmYNITIoQ7p2E4\n\t5w6AjeFuVWeT1dvYFf/EAz5BipE8QHauzP70WefRtdaskaMwg2QXoy1urd7bPy3OD/5Xl1YA9\n\tAFqUb3UnQ5kj0fznTaCrM/dp1tpjTUAA2yht7IJM4zHBNojgGsHsvCqt/L2vmLXjcKwZNQuJg\n\t2gLFCPmqbqZem9ySCtjvpI1P+9zhCY9SiAok5C+57/Ajscv+SY=","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 15/23] efi_loader: implement ConnectController","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1771872,"web_url":"http://patchwork.ozlabs.org/comment/1771872/","msgid":"","list_archive_url":null,"date":"2017-09-20T13:49:47","subject":"Re: [U-Boot] [PATCH 15/23] efi_loader: implement ConnectController","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Heinrich,\n\nOn 15 September 2017 at 00:48, Heinrich Schuchardt wrote:\n> On 08/31/2017 02:52 PM, Simon Glass wrote:\n>> On 27 August 2017 at 06:53, Heinrich Schuchardt wrote:\n>>> Signed-off-by: Heinrich Schuchardt \n>>> ---\n>>> include/efi_api.h | 22 ++++++++\n>>> include/efi_loader.h | 1 +\n>>> lib/efi_loader/efi_boottime.c | 119 +++++++++++++++++++++++++++++++++++++++++-\n>>> 3 files changed, 141 insertions(+), 1 deletion(-)\n>>>\n>>\n>> Reviewed-by: Simon Glass \n>>\n>> Please see below.\n>>\n>>> diff --git a/include/efi_api.h b/include/efi_api.h\n>>> index 8efc8dfab8..b2838125d7 100644\n>>> --- a/include/efi_api.h\n>>> +++ b/include/efi_api.h\n>>> @@ -609,4 +609,26 @@ struct efi_pxe {\n>>> struct efi_pxe_mode *mode;\n>>> };\n>>>\n>>> +#define EFI_DRIVER_BINDING_PROTOCOL_GUID \\\n>>> + EFI_GUID(0x18a031ab, 0xb443, 0x4d1a,\\\n>>> + 0xa5, 0xc0, 0x0c, 0x09, 0x26, 0x1e, 0x9f, 0x71)\n>>> +struct efi_driver_binding_protocol {\n>>> + efi_status_t (EFIAPI * supported)(\n>>\n>> I think the * should be up against 'supported'. Similarly below.\n>\n> This is what checkpatch wants to see. Your suggestion leads to\n>\n> ERROR: need consistent spacing around '*' (ctx:WxV)\n> #25: FILE: include/efi_api.h:616:\n> + efi_status_t (EFIAPI *supported)(\n>\n> So I prefer not change this before checkpatch.pl is not giving a\n> different result.\n\nOK I see. I suppose the EFIAPI is confusing it.\n\n>\n>>\n>>> + struct efi_driver_binding_protocol *this,\n>>> + efi_handle_t controller_handle,\n>>> + struct efi_device_path *remaining_device_path);\n>>> + efi_status_t (EFIAPI * start)(\n>>> + struct efi_driver_binding_protocol *this,\n>>> + efi_handle_t controller_handle,\n>>> + struct efi_device_path *remaining_device_path);\n>>> + efi_status_t (EFIAPI * stop)(\n>>> + struct efi_driver_binding_protocol *this,\n>>> + efi_handle_t controller_handle,\n>>> + UINTN number_of_children,\n>>> + efi_handle_t child_handle_buffer);\n>>\n>> These should have function comments.\n>>\n>>> + u32 version;\n>>> + efi_handle_t image_handle;\n>>> + efi_handle_t driver_binding_handle;\n>>> +};\n>>> +\n>>> #endif\n>>> diff --git a/include/efi_loader.h b/include/efi_loader.h\n>>> index 9c68246c7c..f9f33e1d01 100644\n>>> --- a/include/efi_loader.h\n>>> +++ b/include/efi_loader.h\n>>> @@ -74,6 +74,7 @@ extern const struct efi_device_path_to_text_protocol efi_device_path_to_text;\n>>>\n>>> extern const efi_guid_t efi_guid_console_control;\n>>> extern const efi_guid_t efi_guid_device_path;\n>>> +extern const efi_guid_t efi_guid_driver_binding_protocol;\n>>\n>> comment for this?\n>\n> The GUIDs are defined in the UEFI spec.\n> So maybe we should just put a comment above all of these.\n\nI know what a GUID is (or can look up efi_guid_t to find out) but not\nwhat these variables are for.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Np6R3eFU\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DigsGdQT\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy1PR1N3Qz9s7h\n\tfor ;\n\tWed, 20 Sep 2017 23:51:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E133BC21ECF; Wed, 20 Sep 2017 13:50:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 113EEC21F49;\n\tWed, 20 Sep 2017 13:50:14 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5A51FC21F5D; Wed, 20 Sep 2017 13:50:10 +0000 (UTC)","from mail-qt0-f175.google.com (mail-qt0-f175.google.com\n\t[209.85.216.175])\n\tby lists.denx.de (Postfix) with ESMTPS id 8D0B6C21F6A\n\tfor ; Wed, 20 Sep 2017 13:50:09 +0000 (UTC)","by mail-qt0-f175.google.com with SMTP id x54so2790767qth.12\n\tfor ; Wed, 20 Sep 2017 06:50:09 -0700 (PDT)","by 10.200.37.200 with HTTP; Wed, 20 Sep 2017 06:49:47 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=iDfrBnOZw+5mffzqYlsqDVh+3oXKH1OnfnZ5mb/NGm0=;\n\tb=Np6R3eFUL92Nn2n/IDlEiFcJoLIgAfcnTvYVwew1RJ8hAyRNcYGHJIZJx5hT1YU45P\n\t5yZUy7XHeozb3UqyULjAKPvulCeDuKpaOtRYL6gbtCZLANKB+IIB5T5MFbN58abVGKca\n\tjMvmUmEhLw4MUqWAJwXnJcwvkG4E0oFnzL5cCirmtRF0O6/iPWaSBALizXbawQqierQo\n\tuZGV3M9F9EwIM8ssx9tpkfxM4RlCgNJR2AlTb7hwSkHLO+xUL/8IFINGewpcgfdELAhf\n\tOFv375cKk9YdrXDtPTufuxA4iPIknZR4DqezL/JFuNd+9ig9frMUUYPb4w8XYek8SKjm\n\tH/Aw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=iDfrBnOZw+5mffzqYlsqDVh+3oXKH1OnfnZ5mb/NGm0=;\n\tb=DigsGdQTOi5x1oyAvdypXibQgJ8GtPfW5lgpg6EMbBqp5mOYELe25ZCTQO4bcqo5Ve\n\tB+VwOmJhSECOurHegCNyXCEMTa/dcVZ2jo9k1v+GRvTqc0E4Z09Zy70BMFUAOuKJY3bg\n\tyFQ48/TbJicT1InQcVjLSNXbXTmA+jhrykMCU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=iDfrBnOZw+5mffzqYlsqDVh+3oXKH1OnfnZ5mb/NGm0=;\n\tb=Vf//b0vcbqROyo5GgChHXz/ZiLnxnFXD5V4VTxpXahg4SKFfe19EfdneLT+J6Po50m\n\tXlrjDx50duPB40FLt2zFGGN6NpZZav7OBrqL6HLezvGtTqnFycAwFSOP7msHhxyAE8/z\n\tYZu9N4CB/8MogkD8NxxiWIvityQwDVPjOwQrxzHF/m0CL2KT9dnVRTdfF9k7eaxnl69B\n\tIr7Thc95xZAOH1pzi73mvV4cQ2i+TZqnmYq1fIrFtDdiXWJzAxJL3HWkRAaHebQs6cqu\n\tMWVk9Gi00KA9H1U5v4/XfYPRm6fzvFBL5FQamyJzTkNSGemzWqYFsbfwNqWvOU2LPFIm\n\tjRjA==","X-Gm-Message-State":"AHPjjUiZy29nzazXn8xXFEW7/Z+xflYIArFHGZI4X4HpLUC3S4cCYu85\n\te3mrsSUtxHNnQxaGCuQquQkdHmTou3PAdqR8n+mwSQ==","X-Google-Smtp-Source":"AOwi7QAJNArXdHcuJfd61m7AjO5jlVlHAaTID+JXrx0hMtX82HIg/b3Wl4wBfWvaAevvhDpb2P5Sa/VYQyH6Q+qmojs=","X-Received":"by 10.200.63.154 with SMTP id d26mr7720877qtk.212.1505915408226; \n\tWed, 20 Sep 2017 06:50:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<15a8b074-4287-e97a-d977-835b3da93445@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-6-xypron.glpk@gmx.de>\n\t\n\t<15a8b074-4287-e97a-d977-835b3da93445@gmx.de>","From":"Simon Glass ","Date":"Wed, 20 Sep 2017 07:49:47 -0600","X-Google-Sender-Auth":"cqT97INPPkJzKrUX7Rc3CIeHqKA","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 15/23] efi_loader: implement ConnectController","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]