[{"id":1760959,"web_url":"http://patchwork.ozlabs.org/comment/1760959/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:52:16","subject":"Re: [U-Boot] [PATCH 20/23] efi_loader: use events for\n\tefi_net_receive","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 27 August 2017 at 06:54, Heinrich Schuchardt wrote:\n> A timer event is defined. The timer handler cares for receiving new\n> packets.\n>\n> efi_timer_check is called both in efi_net_transmit and efi_net_receive\n> to enable events during network communication.\n>\n> Calling efi_timer_check in efi_net_get_status is implemented in a\n> separate patch.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> lib/efi_loader/efi_net.c | 35 ++++++++++++++++++++++++++++++++---\n> 1 file changed, 32 insertions(+), 3 deletions(-)\n>\n\nReviewed-by: Simon Glass \n\nBut this code should not support pre-DM networking. E.g. calling eth_rx()...\n\nIt should be adjusted to work only with boards that define\nCONFIG_DM_ETH. Otherwise we will never be able to move things over.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"NSb7gm2L\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"BqTid11y\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjGm3000z9sMN\n\tfor ;\n\tThu, 31 Aug 2017 23:03:12 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1E134C21E70; Thu, 31 Aug 2017 12:58:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8CBD8C21E0C;\n\tThu, 31 Aug 2017 12:58:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid EC743C21E0F; Thu, 31 Aug 2017 12:52:42 +0000 (UTC)","from mail-qt0-f173.google.com (mail-qt0-f173.google.com\n\t[209.85.216.173])\n\tby lists.denx.de (Postfix) with ESMTPS id B5D25C21E24\n\tfor ; Thu, 31 Aug 2017 12:52:38 +0000 (UTC)","by mail-qt0-f173.google.com with SMTP id u11so2389501qtu.1\n\tfor ; Thu, 31 Aug 2017 05:52:38 -0700 (PDT)","by 10.200.28.106 with HTTP; Thu, 31 Aug 2017 05:52:16 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=GSD547W687NM03OFtow8BYHotwdfSOkxs5qiv60cWVk=;\n\tb=NSb7gm2Ll/CyjZxOuQGPwULJPg3L9XYLwXB7JZmJswxXZ/mYWrBqtT119YNzLtGiC9\n\toGbl8xTwSEKwzF0Y/k9C0gbJ30+tGAbCxwK3YY5wv1KW+AA+RjH/TJkABowH/desRpJ7\n\t2zXfmk0BQT+KEPD29BFwcs4hdJhtjL88P2ovZ0hMVIze9IY3QLTi4F8kBeknpWVZWY7B\n\tDALf9HKS7/Y31XDxtGLXChyV9b8IkVJBmh6yS1EbFw5SlPQ5hgpKwfwWBt7yBDuPRyQf\n\tD/icJ6w7kaUr26qrH8n/YhTSru1auo+fUANFjsW7VjVB/rqEJet6Tt6wuKiYkKixv5DF\n\tqJiw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=GSD547W687NM03OFtow8BYHotwdfSOkxs5qiv60cWVk=;\n\tb=BqTid11yFPWr4ohVyd5AE4p9bnNs2Y6ULpXfLUjKHJaQIqkSHjknWpoySaGR0Sle83\n\tJ4ioBDDz4Kk4vdz81GZnOXVHkUx4GYlMH9JJHPLrZ5XqUHbQxohY4ooQTnm3bkdhIYiL\n\tKuJHnMTg3xxcOQHlKy+8po3mcRIoYQ782Hwvg="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=GSD547W687NM03OFtow8BYHotwdfSOkxs5qiv60cWVk=;\n\tb=cFsCbnibJ1L90mG5yyqp2TErd7pgg5OYHkQU/4Ht9bipnSE6ROwAyZym0/SNzcPdSW\n\tp0aJ61UfjxiuskgiYM9iwHnGosyVFVN6zRZRhKq5+5/NdHH1w0Kr/r215bX/efJLp2Oa\n\txNN27UGxUE14ncyVTvQc8bge6+A/8ap5C56cqiqlwpHLr6Uusye6N3wRNuJ6mfYu/uF7\n\tirBhRvIhfopLU5xxc0M7NB00p4LQ9Wc9lAFkJ2rM9rPjgydTFDz4NH92bJ7sIM5G9Jgi\n\t0PNfg/70E7VoOc5+SottkoPjPGodkVCItSRzskkj/jfxFvh+hwqVXS8TJ5Zcq+j+Ck2r\n\tFnzg==","X-Gm-Message-State":"AHYfb5hbqHOxlWrp1gzkMWoTgv8pKCcYByEeNd1xv1uqkRVuD4+FM7mV\n\tHwlwF/A/qGEgSB6ivYhKBdzZ2OqcTMnv","X-Google-Smtp-Source":"ADKCNb5kh5L7QSy33NIfUOpQifbEGNBZeGvgaq+QaLIGOa/QOElpc5h4GpQkvCWA1YdZIUY7dKvnQzMPzrIK0GddLJo=","X-Received":"by 10.200.34.195 with SMTP id g3mr6691722qta.0.1504183957555;\n\tThu, 31 Aug 2017 05:52:37 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170826225444.7608-1-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225444.7608-1-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Thu, 31 Aug 2017 20:52:16 +0800","X-Google-Sender-Auth":"fN64A74urFRf-YacFegA_CIfq6o","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 20/23] efi_loader: use events for\n\tefi_net_receive","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]