[{"id":1760940,"web_url":"http://patchwork.ozlabs.org/comment/1760940/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:51:14","subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 27 August 2017 at 06:51, Heinrich Schuchardt wrote:\n> 8 protocols per efi_object is insufficient for iPXE.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> include/efi_loader.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"oElOrFWP\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"fi5e86sU\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjj4h6W9jz9s7g\n\tfor ;\n\tThu, 31 Aug 2017 22:54:28 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9C621C21DD9; Thu, 31 Aug 2017 12:52:23 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 93E3FC21E0F;\n\tThu, 31 Aug 2017 12:51:56 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 323FEC21C62; Thu, 31 Aug 2017 12:51:41 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id BA5F7C21D93\n\tfor ; Thu, 31 Aug 2017 12:51:37 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id a21so2250505qkg.5\n\tfor ; Thu, 31 Aug 2017 05:51:37 -0700 (PDT)","by 10.200.28.106 with HTTP; Thu, 31 Aug 2017 05:51:14 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=oyJ5ffwlkO6IQ/I80YiNJN1tGK8hu4gnjgFpeTt0xT0=;\n\tb=oElOrFWPpuiyw3JkTZDAwvPfWzMKHthv1nzWmCFOaLSVpCz7A/j+f/uRnS760EmkJN\n\ttiRLKi/eOhUZjk21mtFFe8UHGxUfD+1AQYIveTrto15s+rOqFsAxc7VF+ocO83Lbb7VW\n\t7RlQeECHkhd57TTQrVQFca0Hpt5Ke352mDfxueYNgi9Vl2Dq2ezRgT7g4Py0pG7Wkiv0\n\tShaErUcEvqzzarK4DHDmpi2wyG2SHUtYLCemiHxYP5ldTmDgKNw60xPS8ZdWLuJ1eSoO\n\t0es5vMDv1EHkJ2y06qfhu15zt4JqLCXc0jjDADqjRpewlOAGKw4I6QTDvykPiOrlJWjO\n\taelw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=oyJ5ffwlkO6IQ/I80YiNJN1tGK8hu4gnjgFpeTt0xT0=;\n\tb=fi5e86sUe36+03behXs3NDo+hc4fD3Iurod7kbh/Kiyy5/JkBCsxIr2O8Bo6HalDWS\n\tNpDd+1MCceKzOh74xyvjunpXivfjoiQpzsE5YslUqnwdF8xJ5iM77zNLH4RUebhvN3jp\n\txRRAK9ZhohrDYQx5HBvaLn8nphiKFSnFAsVkI="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=oyJ5ffwlkO6IQ/I80YiNJN1tGK8hu4gnjgFpeTt0xT0=;\n\tb=rt7IWqeBFALDWBRTABxwPMux1VthMh5vX+yiAmyZJvUY1ewCG6xy2TjeofmFg2GikY\n\tIntuPm/OXA1Lh7RzQoB2O+FasGCUgTCItfJ68B2Vjbtj4GlhaoOL8Hkr3W/EXyacpZQe\n\twP8GJCNwKBsGVOtJsKcGp+1+9p/twH1zWY3i8WRtVDuuR3rZ6AlaX/YTrNTsvSCj8QSy\n\tlGSOVuodutWIPOWRrc0X/MXjzRNnUyXm2Iwmo3NfgVBl/IslXxPiNzKqespgFxhxo9Wl\n\t+EEH/6rgt2he5JbqGd/MPBc76trhEWreKhydSlwxwdo3W8246nDJP6SHCMT9SmK2f6Pp\n\tEe5g==","X-Gm-Message-State":"AHYfb5iGW75saNON28/9TtcYDLACquk+3aRLEmn648LDRE4o9UT+9RLA\n\tYC5DKJNf21u46QyJxrUz/D5bBS45eWqk","X-Google-Smtp-Source":"ADKCNb6DRkaMlZn0inCtWluhPc4d0Dt8TBSzdKNkKqsQ1o+5W8HvnUkCrXcoJNgECej899Agk0MdhHmILtw1gstl5WA=","X-Received":"by 10.55.76.8 with SMTP id z8mr3318939qka.54.1504183896549; Thu,\n\t31 Aug 2017 05:51:36 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170826225110.7381-4-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-4-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Thu, 31 Aug 2017 20:51:14 +0800","X-Google-Sender-Auth":"T3VwGbQI2VNBfMD_Rusfaskv2Qc","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1761341,"web_url":"http://patchwork.ozlabs.org/comment/1761341/","msgid":"","list_archive_url":null,"date":"2017-08-31T14:01:19","subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"On 08/27/2017 12:51 AM, Heinrich Schuchardt wrote:\n> 8 protocols per efi_object is insufficient for iPXE.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> include/efi_loader.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/efi_loader.h b/include/efi_loader.h\n> index 6f71a6202b..e8fb4fbb0a 100644\n> --- a/include/efi_loader.h\n> +++ b/include/efi_loader.h\n> @@ -99,8 +99,8 @@ struct efi_handler {\n> struct efi_object {\n> \t/* Every UEFI object is part of a global object list */\n> \tstruct list_head link;\n> -\t/* We support up to 8 \"protocols\" an object can be accessed through */\n> -\tstruct efi_handler protocols[8];\n> +\t/* We support up to 16 \"protocols\" an object can be accessed through */\n> +\tstruct efi_handler protocols[16];\n\nCan you try to convert it into a list instead? Leif tried to make the \nUEFI Shell work and stumbled over the same limitation, so I guess a \nstatic array won't cut it for long.\n\n\nAlex","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjwv03QLhz9s8J\n\tfor ;\n\tFri, 1 Sep 2017 07:46:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid AC588C21E29; Thu, 31 Aug 2017 21:46:46 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D6E93C21D7B;\n\tThu, 31 Aug 2017 21:46:43 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 49B74C21D7B; Thu, 31 Aug 2017 21:46:42 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id EFC04C21D7A\n\tfor ; Thu, 31 Aug 2017 21:46:41 +0000 (UTC)","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 81B67AF52;\n\tThu, 31 Aug 2017 21:46:41 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.2 required=5.0 tests=DATE_IN_PAST_06_12,\n\tRCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","To":"Heinrich Schuchardt ","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-4-xypron.glpk@gmx.de>","From":"Alexander Graf ","Message-ID":"","Date":"Thu, 31 Aug 2017 16:01:19 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.6.0","MIME-Version":"1.0","In-Reply-To":"<20170826225110.7381-4-xypron.glpk@gmx.de>","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1761432,"web_url":"http://patchwork.ozlabs.org/comment/1761432/","msgid":"<88af2425-863e-e071-4a33-7ea0533483b7@gmx.de>","list_archive_url":null,"date":"2017-09-01T01:45:23","subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 08/31/2017 04:01 PM, Alexander Graf wrote:\n> On 08/27/2017 12:51 AM, Heinrich Schuchardt wrote:\n>> 8 protocols per efi_object is insufficient for iPXE.\n>>\n>> Signed-off-by: Heinrich Schuchardt \n>> ---\n>> include/efi_loader.h | 4 ++--\n>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/include/efi_loader.h b/include/efi_loader.h\n>> index 6f71a6202b..e8fb4fbb0a 100644\n>> --- a/include/efi_loader.h\n>> +++ b/include/efi_loader.h\n>> @@ -99,8 +99,8 @@ struct efi_handler {\n>> struct efi_object {\n>> /* Every UEFI object is part of a global object list */\n>> struct list_head link;\n>> - /* We support up to 8 \"protocols\" an object can be accessed\n>> through */\n>> - struct efi_handler protocols[8];\n>> + /* We support up to 16 \"protocols\" an object can be accessed\n>> through */\n>> + struct efi_handler protocols[16];\n> \n> Can you try to convert it into a list instead? Leif tried to make the\n> UEFI Shell work and stumbled over the same limitation, so I guess a\n> static array won't cut it for long.\n> \n> \n> Alex\n> \n> \n\nHello Alex,\n\nis it safe to call malloc and free before efi_exit_boot_services?\n\nCurrently we do not check that boottime services are not called after\nefi_exit_boot_services. Shouldn't every call to boottime services fail\nthereafter? The spec says: \"After successfully calling\nExitBootServices(), all boot services in the system are terminated.\"\n\nWe definitively do not want to call malloc at runtime because all\navailable memory (except for EFI_MEMORY_RUNTIME) is managed by the\noperating system.\n\nBest regards\n\nHeinrich","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk2CZ0HpHz9ryr\n\tfor ;\n\tFri, 1 Sep 2017 11:46:32 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 631C4C21E65; Fri, 1 Sep 2017 01:46:22 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AB65FC21D93;\n\tFri, 1 Sep 2017 01:46:20 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9DC4FC21D93; Fri, 1 Sep 2017 01:46:18 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lists.denx.de (Postfix) with ESMTPS id 4D317C21C27\n\tfor ; Fri, 1 Sep 2017 01:46:18 +0000 (UTC)","from [192.168.123.58] ([84.118.154.110]) by mail.gmx.com (mrgmx101\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0MaF8e-1e33VX2Hw8-00JnWa; Fri, 01 Sep 2017 03:45:35 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable\n\tautolearn_force=no version=3.4.0","To":"Alexander Graf ","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-4-xypron.glpk@gmx.de>\n\t","From":"Heinrich Schuchardt ","Message-ID":"<88af2425-863e-e071-4a33-7ea0533483b7@gmx.de>","Date":"Fri, 1 Sep 2017 03:45:23 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Provags-ID":"V03:K0:vPG9oEHdVcHo2xOkEuMTFJoBwIrc4foKEJGKc+HcauewSKeL5N8\n\tgMRYHYCfF92IXLO18QQP+xfS28lQFoifOpc9iCtCJKuwn6zLXgT5j5c4omtDGccKMk6sXYT\n\t0QG+MwQesFkq3RsT4rEkmIZXD2EFl+XtnqjSyS9txRsH9F4ktwo+7TZRyn0aXogv2nZnfaM\n\tQ+TsmG4n5NB7NS3gmgWRg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:1pUCnWpSdhw=:X6c6rECfDKz+8NOoUKS6ut\n\t0EEDy8zYDiXd8PmiJwRom/kfgJOLCIhjwd+trHQSghthB4dDS1MnlDbieH3TZE2z6fwKZVmqp\n\tRDflwi6zkd1vW8sAa7sSdVrEuI5J0i72V+DfLVSELiou9gI7Oxs9A+gwM+88/LBrpDJG5gBtT\n\t1khrGNL0udmTbuzesdgcEMW3c6MjKLvyR2u9nc6V1PcfRz7bKDMGdj6wVM0mcSlNo1lEiLyO2\n\t2/UTXBBi3trBfkqKZCaCd0i7xPR5i4iE6MRn+aldaaccyDemofviXgurScSrUEf9CB6bBvbH7\n\tOeAPHz3p7AqSEdWjXCVMTSB3On+LdHjlJViFyMueL9K9RBX/kdEgZHvYCwCido/1dpR1r5761\n\tSCKnQ/KNbjSBK9AaZ50nRnRGK+B3MmgYhyQLFkEoOR7RcwWCK+iYJJDmZdRaunMRmtwL5BXdU\n\tdnK6HXjAP9kJtqbAbB/C6qnN6AXykmrCjXQBRwC6YfaSv/4IxuLQ+XNf6lUMMq3yKxQyDe+Yo\n\tEF3sf5Wjr65av4sHdvxkU/Qa7nrC0kGxhSBGW+2ZLXCtVVJbCKsigBTJGToHwRurl2rokJuA9\n\tA21jCGnAw+GdZD/5DIsgA+f7srj3B5IvopgoRyquZUF+Smv7JpONiPyGxBiPn2QVbFC9D7MXZ\n\tkGMEkfoDGm21L2901jGHjsnvvdBwkaLPreYzg3eZbcX3hY3JTI2Lj2r7v2f370lWqW3VsI3T6\n\t+DCZhqITqyWX8OOMK0YYj8Bqp5mPxp1NTXu8GRvJmHxV0Gb+AC27FFObngedrABpoJ4W7KVgu\n\tOD36fX9th0S26shJnVYMzxLl6BGEPp3UcWogmOFDtLdsOy1QcA=","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1761510,"web_url":"http://patchwork.ozlabs.org/comment/1761510/","msgid":"<9b02930a-79ac-2112-62d5-e94d9f1b9c43@suse.de>","list_archive_url":null,"date":"2017-09-01T08:15:22","subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"On 01.09.17 03:45, Heinrich Schuchardt wrote:\n> On 08/31/2017 04:01 PM, Alexander Graf wrote:\n>> On 08/27/2017 12:51 AM, Heinrich Schuchardt wrote:\n>>> 8 protocols per efi_object is insufficient for iPXE.\n>>>\n>>> Signed-off-by: Heinrich Schuchardt \n>>> ---\n>>> include/efi_loader.h | 4 ++--\n>>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/include/efi_loader.h b/include/efi_loader.h\n>>> index 6f71a6202b..e8fb4fbb0a 100644\n>>> --- a/include/efi_loader.h\n>>> +++ b/include/efi_loader.h\n>>> @@ -99,8 +99,8 @@ struct efi_handler {\n>>> struct efi_object {\n>>> /* Every UEFI object is part of a global object list */\n>>> struct list_head link;\n>>> - /* We support up to 8 \"protocols\" an object can be accessed\n>>> through */\n>>> - struct efi_handler protocols[8];\n>>> + /* We support up to 16 \"protocols\" an object can be accessed\n>>> through */\n>>> + struct efi_handler protocols[16];\n>>\n>> Can you try to convert it into a list instead? Leif tried to make the\n>> UEFI Shell work and stumbled over the same limitation, so I guess a\n>> static array won't cut it for long.\n>>\n>>\n>> Alex\n>>\n>>\n> \n> Hello Alex,\n> \n> is it safe to call malloc and free before efi_exit_boot_services?\n\nYes :). Before exiting boot services we're basically in normal U-Boot \nspace with a U-Boot owned malloc region that we can allocate from.\n\n> Currently we do not check that boottime services are not called after\n> efi_exit_boot_services. Shouldn't every call to boottime services fail\n\nYes, IIUC it's simply illegal to call them afterwards.\n\n> thereafter? The spec says: \"After successfully calling\n> ExitBootServices(), all boot services in the system are terminated.\"\n\nI'm not sure. I'd be very surprised to see a payload actually call any \nboot service after exiting boot services. Runtime services is a \ndifferent question, but those are very special anyway.\n\n> We definitively do not want to call malloc at runtime because all\n> available memory (except for EFI_MEMORY_RUNTIME) is managed by the\n> operating system.\n\nYes, but efi objects only exist during boot time. Runtime services don't \nexpose protocols or objects.\n\n\nAlex","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkBrS0xsQz9s3w\n\tfor ;\n\tFri, 1 Sep 2017 18:15:36 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CAB2EC21E0D; Fri, 1 Sep 2017 08:15:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 27371C21DC5;\n\tFri, 1 Sep 2017 08:15:26 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A7963C21DC5; Fri, 1 Sep 2017 08:15:24 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id 36EC2C21C27\n\tfor ; Fri, 1 Sep 2017 08:15:24 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id BC052AB9B;\n\tFri, 1 Sep 2017 08:15:23 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","To":"Heinrich Schuchardt ","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-4-xypron.glpk@gmx.de>\n\t\n\t<88af2425-863e-e071-4a33-7ea0533483b7@gmx.de>","From":"Alexander Graf ","Message-ID":"<9b02930a-79ac-2112-62d5-e94d9f1b9c43@suse.de>","Date":"Fri, 1 Sep 2017 10:15:22 +0200","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<88af2425-863e-e071-4a33-7ea0533483b7@gmx.de>","Content-Language":"en-US","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762174,"web_url":"http://patchwork.ozlabs.org/comment/1762174/","msgid":"","list_archive_url":null,"date":"2017-09-02T18:14:22","subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Thu, Aug 31, 2017 at 10:01 AM, Alexander Graf wrote:\n> On 08/27/2017 12:51 AM, Heinrich Schuchardt wrote:\n>>\n>> 8 protocols per efi_object is insufficient for iPXE.\n>>\n>> Signed-off-by: Heinrich Schuchardt \n>> ---\n>> include/efi_loader.h | 4 ++--\n>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/include/efi_loader.h b/include/efi_loader.h\n>> index 6f71a6202b..e8fb4fbb0a 100644\n>> --- a/include/efi_loader.h\n>> +++ b/include/efi_loader.h\n>> @@ -99,8 +99,8 @@ struct efi_handler {\n>> struct efi_object {\n>> /* Every UEFI object is part of a global object list */\n>> struct list_head link;\n>> - /* We support up to 8 \"protocols\" an object can be accessed\n>> through */\n>> - struct efi_handler protocols[8];\n>> + /* We support up to 16 \"protocols\" an object can be accessed\n>> through */\n>> + struct efi_handler protocols[16];\n>\n>\n> Can you try to convert it into a list instead? Leif tried to make the UEFI\n> Shell work and stumbled over the same limitation, so I guess a static array\n> won't cut it for long.\n>\n\nCan we go w/ fixed 16 protocols length for now? A list is a\ndefinitely a better option, and it will be easier after \"efi_loader:\nrefactor boot device and loaded_image handling\" (which gets rid of the\nstatically initialized efi_object's). After that we can drop the\nfixed length array and add an 'void append_protocol(efiobj, guid,\nhandle)' helper fairly easily.\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"o30HN+T1\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl45641nNz9s82\n\tfor ;\n\tSun, 3 Sep 2017 04:14:33 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 48C03C21EDF; Sat, 2 Sep 2017 18:14:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E297AC21C5C;\n\tSat, 2 Sep 2017 18:14:25 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D99B3C21C5C; Sat, 2 Sep 2017 18:14:23 +0000 (UTC)","from mail-lf0-f68.google.com (mail-lf0-f68.google.com\n\t[209.85.215.68])\n\tby lists.denx.de (Postfix) with ESMTPS id 571D4C21C59\n\tfor ; Sat, 2 Sep 2017 18:14:23 +0000 (UTC)","by mail-lf0-f68.google.com with SMTP id l140so1654420lfg.3\n\tfor ; Sat, 02 Sep 2017 11:14:23 -0700 (PDT)","by 10.46.82.11 with HTTP; Sat, 2 Sep 2017 11:14:22 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=dplrZr7Wxn0o9B5lNXwP49lYbn2etNwFZc+7Kw+Ggvw=;\n\tb=o30HN+T1SR9LuzNBAeqzHI544haYtlmlEexoKojujtQXq/73cFFiqq5vvDu3adyaA9\n\tStCwm8uB6IVJwXP4SdOmmpUFVPHXwzzfmBetfind/Ccvswvv8vLBzkKjfM2qMO5w4m2P\n\tv5s5sR05E9ai354KTTXm5LGxLQQdjQUB1KYIgLae/3Y5oBcHJ2dSpqR3iByJFC1Qv+5+\n\tZM+jvXG9JjzKSfSA40jx5d6SwHP5u65LwY3+DytmM7JFHtHHYbH3f+cAx0mrui3eQHtz\n\t15EawB1B2xs+ziIssvRBT+e7fbS+Bci+OVDG6yBjIqxFHwhdRPKvl53qnJCkjhggt0Im\n\tEezQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=dplrZr7Wxn0o9B5lNXwP49lYbn2etNwFZc+7Kw+Ggvw=;\n\tb=Wi5PTAhZfI6KTT+ICFpnlC+fbiTFXv/XIVUq1WfL87Sq9aAwf62KtMpC6tzwI7bJg7\n\ta6j88DMnnulU884huXxed/fJY0exataoy0TMfzovRp3rFUBBFOeDpjYvy6v05sHJZnKl\n\t6xbypQrxnUe7AyVc4RaHrLly+Js3WxQgWkp8YmqRte6h4/cUVjt2+yUMLlPHsVut+boF\n\tEHmwVm0HCzefBg2/ZxRSr4W87Kq/mJMfbVE44FTYGwaE4waoaICW7UUlMIoci/W8JGv1\n\tfndNCrJVXx4mELAhCoTdEnJ1+akE4Oexa7nSfN9W86QG7NjMdg3esgcLCmw6lVgbaNrf\n\tLWnA==","X-Gm-Message-State":"AHPjjUgPyL999kFH7mIldd8KqVmzqJIQqVn2MR2gt51aR4qhb6EaFUXe\n\tiEHsyriMsM6vy21KjCUku4akls7Cdw==","X-Google-Smtp-Source":"ADKCNb7ytdA5oQ80Qb/J8F/KLZnJI6R9Ja5Ed7+p1GGrCwrDlD5s8XFqV430+Uc2RKOXVQk6cMgCgklLMTbXXnFK560=","X-Received":"by 10.25.221.75 with SMTP id u72mr2246038lfg.252.1504376062792; \n\tSat, 02 Sep 2017 11:14:22 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-4-xypron.glpk@gmx.de>\n\t","From":"Rob Clark ","Date":"Sat, 2 Sep 2017 14:14:22 -0400","Message-ID":"","To":"Alexander Graf ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762202,"web_url":"http://patchwork.ozlabs.org/comment/1762202/","msgid":"<24824C40-F63D-40C7-B148-97F1039CFEB0@suse.de>","list_archive_url":null,"date":"2017-09-02T22:26:43","subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"> Am 02.09.2017 um 20:14 schrieb Rob Clark :\n> \n>> On Thu, Aug 31, 2017 at 10:01 AM, Alexander Graf wrote:\n>>> On 08/27/2017 12:51 AM, Heinrich Schuchardt wrote:\n>>> \n>>> 8 protocols per efi_object is insufficient for iPXE.\n>>> \n>>> Signed-off-by: Heinrich Schuchardt \n>>> ---\n>>> include/efi_loader.h | 4 ++--\n>>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>> \n>>> diff --git a/include/efi_loader.h b/include/efi_loader.h\n>>> index 6f71a6202b..e8fb4fbb0a 100644\n>>> --- a/include/efi_loader.h\n>>> +++ b/include/efi_loader.h\n>>> @@ -99,8 +99,8 @@ struct efi_handler {\n>>> struct efi_object {\n>>> /* Every UEFI object is part of a global object list */\n>>> struct list_head link;\n>>> - /* We support up to 8 \"protocols\" an object can be accessed\n>>> through */\n>>> - struct efi_handler protocols[8];\n>>> + /* We support up to 16 \"protocols\" an object can be accessed\n>>> through */\n>>> + struct efi_handler protocols[16];\n>> \n>> \n>> Can you try to convert it into a list instead? Leif tried to make the UEFI\n>> Shell work and stumbled over the same limitation, so I guess a static array\n>> won't cut it for long.\n>> \n> \n> Can we go w/ fixed 16 protocols length for now? A list is a\n> definitely a better option, and it will be easier after \"efi_loader:\n> refactor boot device and loaded_image handling\" (which gets rid of the\n> statically initialized efi_object's). After that we can drop the\n> fixed length array and add an 'void append_protocol(efiobj, guid,\n> handle)' helper fairly easily.\n\nSure, of course :)\n\nAlex\n\n> \n> BR,\n> -R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl9hS0bqZz9sPs\n\tfor ;\n\tSun, 3 Sep 2017 08:27:02 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A5855C21F32; Sat, 2 Sep 2017 22:26:53 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 685E2C21C5C;\n\tSat, 2 Sep 2017 22:26:51 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9BB7FC21C5C; Sat, 2 Sep 2017 22:26:49 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id 3BE20C21C59\n\tfor ; Sat, 2 Sep 2017 22:26:48 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 8B317AD8D;\n\tSat, 2 Sep 2017 22:26:47 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","Mime-Version":"1.0 (1.0)","From":"Alexander Graf ","X-Mailer":"iPhone Mail (14G60)","In-Reply-To":"","Date":"Sun, 3 Sep 2017 00:26:43 +0200","Message-Id":"<24824C40-F63D-40C7-B148-97F1039CFEB0@suse.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-4-xypron.glpk@gmx.de>\n\t\n\t","To":"Rob Clark ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 03/23] efi_loader: support 16 protocols per\n\tefi_object","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]